94669 2012-08-21 22:32:43 -0700 [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender 2012-08-21 23:47:19 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cgarcia pnormand webkit.review.bot oldest_to_newest 701572 0 naginenis 2012-08-21 22:32:43 -0700 Found new memory leaks in DRT's EventSender.cpp ==9709== 240 (24 direct, 216 indirect) bytes in 1 blocks are definitely lost in loss record 22,591 of 24,861 ==9709== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9709== by 0xA9EBA38: g_malloc (gmem.c:159) ==9709== by 0xA9FEC62: g_slice_alloc (gslice.c:1003) ==9709== by 0xA9E283D: g_list_prepend (glist.c:275) ==9709== by 0x975D40E: gtk_container_children_callback (gtkcontainer.c:2889) ==9709== by 0x9803E2C: gtk_menu_shell_forall (gtkmenushell.c:1218) ==9709== by 0x976182D: gtk_container_get_children (gtkcontainer.c:2105) ==9709== by 0x477A4A: contextClickCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) (EventSender.cpp:219) ==9709== 2,670 (1,080 direct, 1,590 indirect) bytes in 45 blocks are definitely lost in loss record 24,378 of 24,861 ==9709== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==9709== by 0x560E9E2: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==9709== by 0x52BCD5E: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==9709== by 0x52CE2D0: OpaqueJSString::create(unsigned short const*, unsigned int) (OpaqueJSString.h:46) ==9709== by 0x52CDFE5: JSStringCreateWithUTF8CString (JSStringRef.cpp:50) ==9709== by 0x477830: getMenuItemTitleCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSString*, OpaqueJSValue const**) (EventSender.cpp:160) ==9709== by 0x52B81F9: JSC::JSCallbackObject<JSC::JSNonFinalObject>::getStaticValue(JSC::ExecState*, JSC::PropertyName) (JSCallbackObjectFunctions.h:529) ==9709== by 0x52B4E86: JSC::JSCallbackObject<JSC::JSNonFinalObject>::getOwnPropertySlot(JSC::JSCell*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) (JSCallbackObjectFunctions.h:165) ==9709== by 0x49188E: JSC::JSCell::fastGetOwnPropertySlot(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) (JSObject.h:618) ==9709== by 0x53C15B3: JSC::JSValue::get(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const (JSObject.h:873) 701573 1 159862 naginenis 2012-08-21 22:42:55 -0700 Created attachment 159862 Patch 701588 2 159862 cgarcia 2012-08-21 23:03:59 -0700 Comment on attachment 159862 Patch Thanks! 701620 3 159862 webkit.review.bot 2012-08-21 23:47:15 -0700 Comment on attachment 159862 Patch Clearing flags on attachment: 159862 Committed r126267: <http://trac.webkit.org/changeset/126267> 701621 4 webkit.review.bot 2012-08-21 23:47:19 -0700 All reviewed patches have been landed. Closing bug. 159862 2012-08-21 22:42:55 -0700 2012-08-21 23:47:15 -0700 Patch 94669.patch text/plain 2470 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhM2Ni MDViLi43ODM0OTBmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDgtMjEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gY29u dGV4dENsaWNrIGFuZCBnZXRNZW51SXRlbVRpdGxlIGNhbGxiYWNrcyBhcmUgbGVha3kgaW4gRFJU J3MgRXZlbnRTZW5kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk0NjY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4IG1lbW9yeSBsZWFrcyBpbiBEUlQncyBFdmVudFNlbmRlciBjb2RlLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcDoKKyAgICAgICAgKGdldE1l bnVJdGVtVGl0bGVDYWxsYmFjayk6IFVzZSBKU1JldGFpblB0ciBhbmQgZG9uJ3QgbGVhay4KKyAg ICAgICAgKGNvbnRleHRDbGlja0NhbGxiYWNrKTogVXNlIEdPd25QdHIgdG8gbWFuYWdlIG1lbW9y eSBvZiBhCisgICAgICAgIG5ld2x5LWFsbG9jYXRlZCBsaXN0IGF1dG9tYXRpY2FsbHkuCisKIDIw MTItMDgtMjEgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBuZXdlciBRdCA1OiBUaGUgbWVhbmluZyBv ZiBwcml2YXRlX2luY2x1ZGVzIGNoYW5nZWQgdG8gYmUgZnVsbHkKZGlmZiAtLWdpdCBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJl ZS9ndGsvRXZlbnRTZW5kZXIuY3BwCmluZGV4IDRjYzJhYjMuLmQ3OGRiOTMgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FdmVudFNlbmRlci5jcHAKKysrIGIvVG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL0V2ZW50U2VuZGVyLmNwcApAQCAtMTU3LDcgKzE1Nyw4IEBAIHN0YXRp YyBKU1ZhbHVlUmVmIGdldE1lbnVJdGVtVGl0bGVDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4 dCwgSlNPYmplY3RSZWYgb2JqCiAgICAgZWxzZQogICAgICAgICBsYWJlbCA9IGd0a19tZW51X2l0 ZW1fZ2V0X2xhYmVsKEdUS19NRU5VX0lURU0od2lkZ2V0KSk7CiAKLSAgICByZXR1cm4gSlNWYWx1 ZU1ha2VTdHJpbmcoY29udGV4dCwgSlNTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcobGFiZWwu ZGF0YSgpKSk7CisgICAgSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IGl0ZW1UZXh0KEFkb3B0LCBK U1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhsYWJlbC5kYXRhKCkpKTsKKyAgICByZXR1cm4g SlNWYWx1ZU1ha2VTdHJpbmcoY29udGV4dCwgaXRlbVRleHQuZ2V0KCkpOwogfQogCiBzdGF0aWMg Ym9vbCBzZXRNZW51SXRlbVRpdGxlQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQsIEpTT2Jq ZWN0UmVmIG9iamVjdCwgSlNTdHJpbmdSZWYgcHJvcGVydHlOYW1lLCBKU1ZhbHVlUmVmIHZhbHVl LCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pCkBAIC0yMTYsMTAgKzIxNywxMCBAQCBzdGF0aWMgSlNW YWx1ZVJlZiBjb250ZXh0Q2xpY2tDYWxsYmFjayhKU0NvbnRleHRSZWYgY29udGV4dCwgSlNPYmpl Y3RSZWYgZnVuY3RpbwogICAgIFdlYktpdFdlYlZpZXcqIHZpZXcgPSB3ZWJraXRfd2ViX2ZyYW1l X2dldF93ZWJfdmlldyhtYWluRnJhbWUpOwogICAgIEd0a01lbnUqIGd0a01lbnUgPSB3ZWJraXRf d2ViX3ZpZXdfZ2V0X2NvbnRleHRfbWVudSh2aWV3KTsKICAgICBpZiAoZ3RrTWVudSkgewotICAg ICAgICBHTGlzdCogaXRlbXMgPSBndGtfY29udGFpbmVyX2dldF9jaGlsZHJlbihHVEtfQ09OVEFJ TkVSKGd0a01lbnUpKTsKLSAgICAgICAgSlNWYWx1ZVJlZiBhcnJheVZhbHVlc1tnX2xpc3RfbGVu Z3RoKGl0ZW1zKV07CisgICAgICAgIEdPd25QdHI8R0xpc3Q+IGl0ZW1zKGd0a19jb250YWluZXJf Z2V0X2NoaWxkcmVuKEdUS19DT05UQUlORVIoZ3RrTWVudSkpKTsKKyAgICAgICAgSlNWYWx1ZVJl ZiBhcnJheVZhbHVlc1tnX2xpc3RfbGVuZ3RoKGl0ZW1zLmdldCgpKV07CiAgICAgICAgIGludCBp bmRleCA9IDA7Ci0gICAgICAgIGZvciAoR0xpc3QqIGl0ZW0gPSBnX2xpc3RfZmlyc3QoaXRlbXMp OyBpdGVtOyBpdGVtID0gZ19saXN0X25leHQoaXRlbSkpIHsKKyAgICAgICAgZm9yIChHTGlzdCog aXRlbSA9IGdfbGlzdF9maXJzdChpdGVtcy5nZXQoKSk7IGl0ZW07IGl0ZW0gPSBnX2xpc3RfbmV4 dChpdGVtKSkgewogICAgICAgICAgICAgYXJyYXlWYWx1ZXNbaW5kZXhdID0gSlNPYmplY3RNYWtl KGNvbnRleHQsIGdldE1lbnVJdGVtQ2xhc3MoKSwgaXRlbS0+ZGF0YSk7CiAgICAgICAgICAgICBp bmRleCsrOwogICAgICAgICB9Cg==