94658 2012-08-21 18:07:32 -0700 [chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support those 2012-08-22 10:56:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth cc-bugs dpranke playmobil thakis tony webkit.review.bot oldest_to_newest 701413 0 jamesr 2012-08-21 18:07:32 -0700 [chromium/mac] Remove unnecessary checks for OS version <= 10.5. We don't support those 701416 1 159830 jamesr 2012-08-21 18:08:28 -0700 Created attachment 159830 Patch 701419 2 jamesr 2012-08-21 18:11:07 -0700 There's also a runtime OS X version check in FontMac.mm that we use, but it's checking for a bug only present in Snow Leopard and not in higher versions so we have to check that at runtime. The mac weenies report that it'd be better to use base::mac::IsOSSnowLeopard() since it just uses uname() instead of Gestalt, but we'd have to plumb that through WK API 701484 3 159830 thakis 2012-08-21 19:00:05 -0700 Comment on attachment 159830 Patch lgtm 701485 4 thakis 2012-08-21 19:00:24 -0700 Jeremy: FYI 702050 5 159830 jamesr 2012-08-22 10:44:36 -0700 Comment on attachment 159830 Patch Thanks Tony! 702062 6 159830 webkit.review.bot 2012-08-22 10:56:26 -0700 Comment on attachment 159830 Patch Clearing flags on attachment: 159830 Committed r126320: <http://trac.webkit.org/changeset/126320> 702063 7 webkit.review.bot 2012-08-22 10:56:30 -0700 All reviewed patches have been landed. Closing bug. 159830 2012-08-21 18:08:28 -0700 2012-08-22 10:56:26 -0700 Patch bug-94658-20120821180827.patch text/plain 3605 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTEyZGQ1ZWMxYTU1YmFh NDIwNGVjZjAwZjM3MzQzYzMzNGY0MGQ4MC4uMGRlMTliOGRiMDFhOTQ3NzNiN2Y0MjE4NjZlMzI3 ODE1NDQwYTBmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTIxICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtL21h Y10gUmVtb3ZlIHVubmVjZXNzYXJ5IGNoZWNrcyBmb3IgT1MgdmVyc2lvbiA8PSAxMC41LiBXZSBk b24ndCBzdXBwb3J0IHRob3NlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NDY1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBjaHJvbWl1bSBtYWMgcG9ydCBoYXNuJ3Qgc3VwcG9ydGVkIExlb3BhcmQg Zm9yIGEgd2hpbGUgbm93LCBzbyByZW1vdmUgY2hyb21pdW0tc3BlY2lmaWMgY29kZSB0aGF0IGNo ZWNrcworICAgICAgICBmb3IgT1MgWCB2ZXJzaW9uIDw9IExlb3BhcmQuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Dcm9zc1Byb2Nlc3NGb250TG9hZGluZy5tbToKKyAg ICAgICAgKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6OmxvYWRGb250KToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250UGxhdGZvcm1EYXRhQ29jb2EubW06CisgICAgICAg IChXZWJDb3JlOjpjYW5TZXRDYXNjYWRlTGlzdEZvckN1c3RvbUZvbnQpOgorCiAyMDEyLTA4LTIx ICBMaWFuZ2h1aSBDaGVuICA8bGlhY2hlbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5 XSBBZGQgUlNTIGNvbnRlbnQgaGFuZGxpbmcgc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ3Jvc3NQcm9jZXNzRm9udExvYWRpbmcu bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Dcm9zc1Byb2Nl c3NGb250TG9hZGluZy5tbQppbmRleCBhMjdhZjRjYmU2NWY5NTU2NjY3Y2JmZmM0NTc0ZGZlMzI3 NGJjYjI0Li5jMGYxMGRjNmJmYTkxM2ExZjU5MjZlYjE2MjUzMWNhYTBiMzRmMTI5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Dcm9zc1Byb2Nl c3NGb250TG9hZGluZy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9Dcm9zc1Byb2Nlc3NGb250TG9hZGluZy5tbQpAQCAtNDEsMjAgKzQxLDYgQEAgbmFt ZXNwYWNlIHsKIHR5cGVkZWYgSGFzaE1hcDx1aW50MzIsIE1lbW9yeUFjdGl2YXRlZEZvbnQqPiBG b250Q29udGFpbmVyUmVmTWVtb3J5Rm9udEhhc2g7CiB0eXBlZGVmIEhhc2hNYXA8V1RGOjpTdHJp bmcsIE1lbW9yeUFjdGl2YXRlZEZvbnQqPiBGb250TmFtZU1lbW9yeUZvbnRIYXNoOwogCi0vLyBP biAxMC41LCBmb250IGxvYWRpbmcgaXMgbm90IGJsb2NrZWQgYnkgdGhlIHNhbmRib3ggYW5kIHRo dXMgdGhlcmUgaXMgbm8KLS8vIG5lZWQgZm9yIHRoZSBjcm9zcy1wcm9jZXNzIGZvbnQgbG9hZGlu ZyBtZWNoYW5pbS4KLS8vIE9uIHN5c3RlbSB2ZXJzaW9ucyA+PTEwLjYgY3Jvc3MtcHJvY2VzcyBm b250IGxvYWRpbmcgaXMgcmVxdWlyZWQuCi1ib29sIE91dE9mUHJvY2Vzc0ZvbnRMb2FkaW5nRW5h YmxlZCgpCi17Ci0gICAgc3RhdGljIFNJbnQzMiBzeXN0ZW1WZXJzaW9uID0gMDsKLSAgICBpZiAo IXN5c3RlbVZlcnNpb24pIHsKLSAgICAgICAgaWYgKEdlc3RhbHQoZ2VzdGFsdFN5c3RlbVZlcnNp b24sICZzeXN0ZW1WZXJzaW9uKSAhPSBub0VycikKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsK LSAgICB9Ci0KLSAgICByZXR1cm4gc3lzdGVtVmVyc2lvbiA+PSAweDEwNjA7Ci19Ci0KIC8vIENh Y2hpbmc6CiAvLwogLy8gUmVxdWVzdGluZyBhIGZvbnQgZnJvbSB0aGUgYnJvd3NlciBwcm9jZXNz IGlzIGV4cGVuc2l2ZSBhbmQgc28gaXMKQEAgLTE5OSw3ICsxODUsNyBAQCB2b2lkIEZvbnRQbGF0 Zm9ybURhdGE6OmxvYWRGb250KE5TRm9udCogbnNGb250LCBmbG9hdCBmb250U2l6ZSwgTlNGb250 KiYgb3V0TlNGbwogewogICAgIG91dE5TRm9udCA9IG5zRm9udDsKICAgICBjZ0ZvbnQgPSBDVEZv bnRDb3B5R3JhcGhpY3NGb250KHRvQ1RGb250UmVmKG91dE5TRm9udCksIDApOwotICAgIGlmIChP dXRPZlByb2Nlc3NGb250TG9hZGluZ0VuYWJsZWQoKSAmJiBvdXROU0ZvbnQgJiYgY2dGb250ICYm IGlzTGFzdFJlc29ydEZvbnQoY2dGb250KSkgeworICAgIGlmIChvdXROU0ZvbnQgJiYgY2dGb250 ICYmIGlzTGFzdFJlc29ydEZvbnQoY2dGb250KSkgewogICAgICAgICAvLyBSZWxlYXNlIG9sZCBD R0ZvbnRSZWYgc2luY2UgaXQgcG9pbnRzIGF0IHRoZSBMYXN0UmVzb3J0IGZvbnQgd2hpY2ggd2Ug ZG9uJ3Qgd2FudC4KICAgICAgICAgQ0ZSZWxlYXNlKGNnRm9udCk7CiAgICAgICAgIGNnRm9udCA9 IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9G b250UGxhdGZvcm1EYXRhQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jb2NvYS9Gb250UGxhdGZvcm1EYXRhQ29jb2EubW0KaW5kZXggOGEwYzMyYzRmYzdhOTM4MDQz YTMwNGY1ZDkyNGYxNTJhZmU3OWJmMC4uOTYxMjg0ODc2M2QyMjBiYzAxZTMxZTA5NmVlMDE2YmIz ZmJkMDFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29j b2EvRm9udFBsYXRmb3JtRGF0YUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NvY29hL0ZvbnRQbGF0Zm9ybURhdGFDb2NvYS5tbQpAQCAtMjQ3LDE1ICsyNDcs NyBAQCBzdGF0aWMgQ1RGb250RGVzY3JpcHRvclJlZiBjYXNjYWRlVG9MYXN0UmVzb3J0QW5kRGlz YWJsZVN3YXNoZXNGb250RGVzY3JpcHRvcigpCiAvLyBBZGRpbmcgYSBjYXNjYWRlIGxpc3QgYnJl YWtzIHRoZSBmb250IG9uIExlb3BhcmQKIHN0YXRpYyBib29sIGNhblNldENhc2NhZGVMaXN0Rm9y Q3VzdG9tRm9udCgpCiB7Ci0jaWYgUExBVEZPUk0oQ0hST01JVU0pCi0gICAgc3RhdGljIFNJbnQz MiBzeXN0ZW1WZXJzaW9uOwotICAgIGlmICghc3lzdGVtVmVyc2lvbikgewotICAgICAgICBpZiAo R2VzdGFsdChnZXN0YWx0U3lzdGVtVmVyc2lvbiwgJnN5c3RlbVZlcnNpb24pICE9IG5vRXJyKQot ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLQotICAgIHJldHVybiBzeXN0ZW1WZXJz aW9uID49IDB4MTA2MDsKLSNlbGlmIFBMQVRGT1JNKElPUykgfHwgX19NQUNfT1NfWF9WRVJTSU9O X01JTl9SRVFVSVJFRCA+PSAxMDYwCisjaWYgUExBVEZPUk0oSU9TKSB8fCBfX01BQ19PU19YX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDEwNjAKICAgICByZXR1cm4gdHJ1ZTsKICNlbHNlCiAgICAg cmV0dXJuIGZhbHNlOwo=