<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>94648</bug_id>
          
          <creation_ts>2012-08-21 16:47:58 -0700</creation_ts>
          <short_desc>[Qt] Avoid using WebKit macros in qrawwebview_p.h</short_desc>
          <delta_ts>2012-08-22 01:44:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P3</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Luiz Agostini">luiz</reporter>
          <assigned_to name="Luiz Agostini">luiz</assigned_to>
          <cc>cmarcelo</cc>
    
    <cc>menard</cc>
    
    <cc>noam</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zoltan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>701299</commentid>
    <comment_count>0</comment_count>
    <who name="Luiz Agostini">luiz</who>
    <bug_when>2012-08-21 16:47:58 -0700</bug_when>
    <thetext>ENABLE(FEATURE) should not be used in qrawwebview_p.h because it is an API header file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>701319</commentid>
    <comment_count>1</comment_count>
      <attachid>159805</attachid>
    <who name="Luiz Agostini">luiz</who>
    <bug_when>2012-08-21 16:58:37 -0700</bug_when>
    <thetext>Created attachment 159805
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>701677</commentid>
    <comment_count>2</comment_count>
      <attachid>159805</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-22 01:43:59 -0700</bug_when>
    <thetext>Comment on attachment 159805
patch

Clearing flags on attachment: 159805

Committed r126277: &lt;http://trac.webkit.org/changeset/126277&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>701678</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-22 01:44:02 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>159805</attachid>
            <date>2012-08-21 16:58:37 -0700</date>
            <delta_ts>2012-08-22 01:43:59 -0700</delta_ts>
            <desc>patch</desc>
            <filename>0001-Qt-Avoid-using-WebKit-macros-in-qrawwebview_p.h.patch</filename>
            <type>text/plain</type>
            <size>2883</size>
            <attacher name="Luiz Agostini">luiz</attacher>
            
              <data encoding="base64">RnJvbSBlNmE3MDJjMTE1ZTA1YjM4YTViZGY5YjdlMDU3MTcwZGU3OTBhMzllIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG5va2lhLmNv
bT4KRGF0ZTogVHVlLCAyMSBBdWcgMjAxMiAxNjo1NjoxNyAtMDcwMApTdWJqZWN0OiBbUEFUQ0hd
IFtRdF0gQXZvaWQgdXNpbmcgV2ViS2l0IG1hY3JvcyBpbiBxcmF3d2Vidmlld19wLmgKIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDY0OAoKUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCgpFTkFCTEUoRkVBVFVSRSkgc2hvdWxkIG5vdCBiZSB1c2VkIGluIHFyYXd3
ZWJ2aWV3X3AuaCBiZWNhdXNlIGl0IGlzIGFuIEFQSSBoZWFkZXIgZmlsZS4KCiogVUlQcm9jZXNz
L0FQSS9xdC9yYXcvcXJhd3dlYnZpZXcuY3BwOgooUVJhd1dlYlZpZXc6OnNlbmRUb3VjaEV2ZW50
KToKKiBVSVByb2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vidmlld19wLmg6Ci0tLQogU291cmNlL1dl
YktpdDIvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEzICsrKysrKysr
KysrKysKIC4uLi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3LmNwcCAg
IHwgICAgNCArKy0tCiAuLi4vV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vidmll
d19wLmggICB8ICAgIDMgLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDUg
ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291
cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IGY4NmM0ZjkuLmNjY2FkMjYgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOC0yMSAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3Rp
bmlAbm9raWEuY29tPgorCisgICAgICAgIFtRdF0gQXZvaWQgdXNpbmcgV2ViS2l0IG1hY3JvcyBp
biBxcmF3d2Vidmlld19wLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTk0NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgRU5BQkxFKEZFQVRVUkUpIHNob3VsZCBub3QgYmUgdXNlZCBpbiBxcmF3d2Vidmll
d19wLmggYmVjYXVzZSBpdCBpcyBhbiBBUEkgaGVhZGVyIGZpbGUuCisKKyAgICAgICAgKiBVSVBy
b2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vidmlldy5jcHA6CisgICAgICAgIChRUmF3V2ViVmlldzo6
c2VuZFRvdWNoRXZlbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2
aWV3X3AuaDoKKwogMjAxMi0wOC0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNv
bT4KIAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTEyNDE4NTA+IEJsb2NrIGFjY2VzcyB0byB4
cGNkIGluIFdlYlByb2Nlc3Muc2IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B
UEkvcXQvcmF3L3FyYXd3ZWJ2aWV3LmNwcAppbmRleCAwYWVkNWQ5Li42MjUwMzQ4IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vidmlldy5jcHAK
KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXcuY3Bw
CkBAIC0zODAsOSArMzgwLDkgQEAgdm9pZCBRUmF3V2ViVmlldzo6c2VuZFdoZWVsRXZlbnQoUVdo
ZWVsRXZlbnQqIGV2ZW50KQogICAgIGQtPm1fd2ViUGFnZVByb3h5LT5oYW5kbGVXaGVlbEV2ZW50
KFdlYktpdDo6TmF0aXZlV2ViV2hlZWxFdmVudChldmVudCwgUVRyYW5zZm9ybSgpKSk7CiB9CiAK
LSNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogdm9pZCBRUmF3V2ViVmlldzo6c2VuZFRvdWNoRXZl
bnQoUVRvdWNoRXZlbnQqIGV2ZW50KQogeworI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAgICAg
ZC0+bV93ZWJQYWdlUHJveHktPmhhbmRsZVRvdWNoRXZlbnQoV2ViS2l0OjpOYXRpdmVXZWJUb3Vj
aEV2ZW50KGV2ZW50LCBRVHJhbnNmb3JtKCkpKTsKLX0KICNlbmRpZgorfQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXdfcC5oIGIvU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXdfcC5oCmluZGV4IDQ2
MDhmZjkuLmY4ZjE1YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv
cXQvcmF3L3FyYXd3ZWJ2aWV3X3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ
L3F0L3Jhdy9xcmF3d2Vidmlld19wLmgKQEAgLTMwLDcgKzMwLDYgQEAKICNpbmNsdWRlIDxXZWJL
aXQyL1dLQ29udGV4dC5oPgogI2luY2x1ZGUgPFdlYktpdDIvV0tQYWdlLmg+CiAjaW5jbHVkZSA8
V2ViS2l0Mi9XS1BhZ2VHcm91cC5oPgotI2luY2x1ZGUgPHd0Zi9QbGF0Zm9ybS5oPgogCiBRVF9C
RUdJTl9OQU1FU1BBQ0UKIGNsYXNzIFFSZWN0OwpAQCAtOTUsOSArOTQsNyBAQCBwdWJsaWM6CiAg
ICAgdm9pZCBzZW5kS2V5RXZlbnQoUUtleUV2ZW50Kik7CiAgICAgdm9pZCBzZW5kTW91c2VFdmVu
dChRTW91c2VFdmVudCosIGludCBjbGlja0NvdW50ID0gMCk7CiAgICAgdm9pZCBzZW5kV2hlZWxF
dmVudChRV2hlZWxFdmVudCopOwotI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAgICAgdm9pZCBz
ZW5kVG91Y2hFdmVudChRVG91Y2hFdmVudCopOwotI2VuZGlmCiAKIHByaXZhdGU6CiAgICAgUVJh
d1dlYlZpZXdQcml2YXRlKiBkOwotLSAKMS43LjkuNQoK
</data>

          </attachment>
      

    </bug>

</bugzilla>