94647 2012-08-21 16:39:16 -0700 Web Inspector: [regression] Settings panel fails to open 2012-08-21 19:39:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 johnjbarton pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 701289 0 johnjbarton 2012-08-21 16:39:16 -0700 After Bug 94416 - Web Inspector: load scripts panel lazily the Settings fails to open unless the user happens to open the Sources panel first. SettingScreen.js uses WebInspector.settings.searchInContentScripts p.appendChild(this._createCheckboxSetting(WebInspector.UIString("Search in content scripts"), WebInspector.settings.searchInContentScripts)); But the value is not define until ScriptsPanel.js imports ScriptsSearchScope.js Source/WebCore/inspector/front-end/ScriptsPanel.js:importScript("ScriptsSearchScope.js"); which creates the setting: WebInspector.settings.searchInContentScripts = WebInspector.settings.createSetting("searchInContentScripts", false); 701496 1 pfeldman 2012-08-21 19:20:10 -0700 I'l fix it right away. Now that it squeezed into the Canary, the workaround is to open Sources tab first. Then settings will open. 701499 2 159844 pfeldman 2012-08-21 19:37:49 -0700 Created attachment 159844 Patch 701501 3 pfeldman 2012-08-21 19:39:44 -0700 Committed r126253: <http://trac.webkit.org/changeset/126253> 159844 2012-08-21 19:37:49 -0700 2012-08-21 19:37:49 -0700 Patch bug-94647-20120822063746.patch text/plain 2267 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmJmMjU5OTUyN2MzOTE2 YjgzNGZhOWE3ZGIwNTFlYWQ4YzhiYmQ2ZS4uZDI1YzBlMDNlYzgwMzY4MjY1ZTk1NDcyNjY4ZGUy YTVlOGQ2Zjc2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTIxICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFtyZWdyZXNzaW9uXSBTZXR0aW5ncyBwYW5lbCBmYWlscyB0byBvcGVuLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ2NDcKKworICAgICAgICBV bnJldmlld2VkOiBvbmUgbGluZSBKUyBmcm9udC1lbmQgZml4LgorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9TY3JpcHRzU2VhcmNoU2NvcGUuanM6CisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9TZXR0aW5ncy5qczoKKwogMjAxMi0wOC0yMSAgSnVsaWVuIENoYWZmcmFpeCAg PGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBDcmFzaCBpbiBSZW5kZXJUYWJsZVNl Y3Rpb246OnNldENlbGxMb2dpY2FsV2lkdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNTZWFyY2hTY29wZS5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1NlYXJjaFNjb3BlLmpzCmluZGV4IGUzMDY1NWE2 YzkyYzFmY2FkNzIxNjkxZWIwMTFiMDRhODRjN2U4MDcuLmMxOWQxZWNmNWIyODMzYzU0NmE0M2Fj MWYxZTczYjhiZGM2NTI2ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU2NyaXB0c1NlYXJjaFNjb3BlLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvU2NyaXB0c1NlYXJjaFNjb3BlLmpzCkBAIC0xMjgsNSArMTI4LDMgQEAg V2ViSW5zcGVjdG9yLlNjcmlwdHNTZWFyY2hTY29wZS5wcm90b3R5cGUgPSB7CiB9CiAKIFdlYklu c3BlY3Rvci5TY3JpcHRzU2VhcmNoU2NvcGUucHJvdG90eXBlLl9fcHJvdG9fXyA9IFdlYkluc3Bl Y3Rvci5TZWFyY2hTY29wZS5wcm90b3R5cGU7Ci0KLVdlYkluc3BlY3Rvci5zZXR0aW5ncy5zZWFy Y2hJbkNvbnRlbnRTY3JpcHRzID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLmNyZWF0ZVNldHRpbmco InNlYXJjaEluQ29udGVudFNjcmlwdHMiLCBmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwppbmRleCAyYzhiZjY4ODA4NmNmOTUxYmM2N2U0 NzAzN2I4ZGI1YjNmNGY3NjIzLi5jZWJjOTFkMzJkNTdlMmFhNDc3NGRkZWM0OTY5ZjEwYTNiOGI1 ZTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRp bmdzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3Mu anMKQEAgLTEwMSw2ICsxMDEsNyBAQCBXZWJJbnNwZWN0b3IuU2V0dGluZ3MgPSBmdW5jdGlvbigp CiAgICAgdGhpcy5nZW9sb2NhdGlvbk92ZXJyaWRlID0gdGhpcy5jcmVhdGVTZXR0aW5nKCJnZW9s b2NhdGlvbk92ZXJyaWRlIiwgIiIpOwogICAgIHRoaXMuZGV2aWNlT3JpZW50YXRpb25PdmVycmlk ZSA9IHRoaXMuY3JlYXRlU2V0dGluZygiZGV2aWNlT3JpZW50YXRpb25PdmVycmlkZSIsICIiKTsK ICAgICB0aGlzLnNob3dIZWFwU25hcHNob3RPYmplY3RzSGlkZGVuUHJvcGVydGllcyA9IHRoaXMu Y3JlYXRlU2V0dGluZygic2hvd0hlYVNuYXBzaG90T2JqZWN0c0hpZGRlblByb3BlcnRpZXMiLCBm YWxzZSk7CisgICAgdGhpcy5zZWFyY2hJbkNvbnRlbnRTY3JpcHRzID0gdGhpcy5jcmVhdGVTZXR0 aW5nKCJzZWFyY2hJbkNvbnRlbnRTY3JpcHRzIiwgZmFsc2UpOwogCiAgICAgLy8gSWYgdGhlcmUg YXJlIHRvbyBtYW55IGJyZWFrcG9pbnRzIGluIGEgc3RvcmFnZSwgaXQgaXMgbGlrZWx5IGR1ZSB0 byBhIHJlY2VudCBidWcgdGhhdCBjYXVzZWQKICAgICAvLyBwZXJpb2RpY2FsIGJyZWFrcG9pbnRz IGR1cGxpY2F0aW9uIGxlYWRpbmcgdG8gaW5zcGVjdG9yIHNsb3duZXNzLgo=