94644 2012-08-21 16:17:18 -0700 Failure to dispatch delegate callbacks if resource load fails synchronously 2012-08-22 18:06:59 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 psolanki psolanki abarth ap cmarcelo japhet kbr koivisto macpherson menard psolanki webkit.review.bot oldest_to_newest 701253 0 psolanki 2012-08-21 16:17:18 -0700 This is similar to bug 91018, but instead of special casing Font resources, we should generalize it so that this can't happen for other resource load fails. 701255 1 psolanki 2012-08-21 16:17:54 -0700 <rdar://problem/12097409> 701272 2 159793 psolanki 2012-08-21 16:27:35 -0700 Created attachment 159793 Patch 701576 3 159793 koivisto 2012-08-21 22:47:07 -0700 Comment on attachment 159793 Patch r=me. A test case would be cool. 702124 4 psolanki 2012-08-22 11:44:25 -0700 Committed r126325: <http://trac.webkit.org/changeset/126325> 702552 5 kbr 2012-08-22 17:34:27 -0700 I'm afraid this introduced a subtle regression that, bizarrely enough, only showed up in Chromium Mac debug builds with the layout test svg/custom/linking-uri-01-b.svg . The failure is 100% reproducible on my Mac Pro with a debug build of Chromium's DumpRenderTree, and reverting this patch locally fixes the regression. The bug is that with this test case, the onload handler isn't being called at the right time, so the ellipse isn't zoomed to fill the view. I wasn't able to reproduce the failure on Linux and it looks like the Apple bots aren't affected either. I'm concerned that this indicates a change in behavior that will affect real web sites and therefore intend to roll out this patch. Pratik, I'll try to reach you on IRC before doing so. First failing builds: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28dbg%29/builds/12059 http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.7%20%28dbg%29/builds/54 Flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=svg%2Fcustom%2Flinking-uri-01-b.svg 702566 6 kbr 2012-08-22 17:46:26 -0700 Adding a couple more people who know the loader code. Changes in behavior in this area are really scary, so unless I can reach Pratik soon, I'll roll this out. Haven't had any luck yet identifying new layout test failures on the Apple Mac debug bots caused by this change, but still looking. 702584 7 kbr 2012-08-22 18:04:27 -0700 Pratik and I talked on IRC and he agreed that it would be OK to roll out this patch. I spent some time going through the Apple Mac test bots on build.webkit.org around the revision where this landed. The only evidence I could find that something might be going wrong on other ports is that the following bot started getting an elevated crash rate at r126325 (2x the previous crash rate, from 12 to 24) -- and it has a build (#2757) where only that revision was incorporated: http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29?numbuilds=25 Again, though, this change definitely affected the timing of the calling of the onload hander in the SVG layout test above in Chromium Mac Debug builds. I'm available to help test revisions to the patch. 702587 8 kbr 2012-08-22 18:06:59 -0700 Reverted r126325 for reason: Caused subtle but reproducible failure to call onload handler properly in an SVG layout test in Chromium Mac Debug builds, indicating potentially larger problem Committed r126373: <http://trac.webkit.org/changeset/126373> 159793 2012-08-21 16:27:35 -0700 2012-08-21 22:47:06 -0700 Patch bug-94644-20120821162734.patch text/plain 3606 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIwYjZiMzgzNzNiYWQx MGZmMDQxYWMyZmQzYmFhMWNmMjFlYmZjMC4uZDM2Y2FjNGY0MzM3MWYwZGRkYzU3ODRlZDMzODk4 ZWY2YWIzNmUzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTIxICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBGYWlsdXJlIHRvIGRp c3BhdGNoIGRlbGVnYXRlIGNhbGxiYWNrcyBpZiByZXNvdXJjZSBsb2FkIGZhaWxzIHN5bmNocm9u b3VzbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0 NjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVz b3VyY2UgbG9hZHMgY2FuIGJlIHRyaWdnZXJlZCBieSBsYXlvdXQgYWZ0ZXIgZG9jdW1lbnQgbG9h ZCBpcworICAgICAgICBjb21wbGV0ZSBidXQgYmVmb3JlIHdlIGhhdmUgZGlzcGF0Y2hlZCBkaWRG aW5pc2hMb2FkRm9yRnJhbWUgY2FsbGJhY2suCisgICAgICAgIEluIHN1Y2ggY2FzZXMsIGlmIHRo ZSBsb2FkIGZhaWxzIHN5bmNocm9ub3VzbHkgZHVlIHRvIHRoZSBjbGllbnQKKyAgICAgICAgcmV0 dXJuaW5nIDAgZnJvbSB3aWxsU2VuZFJlcXVlc3QgY2FsbGJhY2ssIHdlIHdvdWxkIGZhaWwgdG8g Y2FsbAorICAgICAgICBkaWRGaW5pc2hMb2FkaW5nLiB0aGlzIHdhcyBmaXhlZCBmb3IgRm9udCBy ZXNvdXJjZXMgaW4gcjEyMjQ0NiBmb3IgYnVnCisgICAgICAgIDkxMDE4LiBUaGlzIGZpeGVzIGl0 IGluIHRoZSBnZW5lcmFsIGNhc2UgYnkgaGF2aW5nIENhY2hlZFJlc291cmNlTG9hZGVyCisgICAg ICAgIGNhbGwgRnJhbWVMb2FkZXI6OmNoZWNrTG9hZENvbXBsZXRlKCkgd2hlbiBpdCBpcyBkb25l IGxvYWRpbmcgYWxsCisgICAgICAgIHJlc291cmNlcy4KKworICAgICAgICAqIGNzcy9DU1NGb250 U2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTRm9udFNlbGVjdG9yOjpiZWdpbkxv YWRUaW1lckZpcmVkKToKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2Fk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2VMb2FkZXI6OmRlY3JlbWVu dFJlcXVlc3RDb3VudCk6CisKIDIwMTItMDgtMjAgIEtlbiBCdWNoYW5hbiAgPGtlbnJiQGNocm9t aXVtLm9yZz4KICAgICAgICAgTGluZSBib3hlcyBub3QgYmVpbmcgZGlydGllZCBjb3JyZWN0bHkg ZHVyaW5nIGlubGluZSByZW1vdmFsCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MzE1NgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Zv bnRTZWxlY3Rvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udFNlbGVjdG9yLmNwcApp bmRleCBjYzVmZmEwNmNkMGU1MDE0NjRjMDcxMDNhYmZkZGExYWY1YTNlYWNjLi5mNDY2NmFkMDc1 ZmU2MjczYTVhNGQzOTQyYmJjMTVmMTE4ZTNlNWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTRm9udFNlbGVjdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9u dFNlbGVjdG9yLmNwcApAQCAtNTg5LDEwICs1ODksNiBAQCB2b2lkIENTU0ZvbnRTZWxlY3Rvcjo6 YmVnaW5Mb2FkVGltZXJGaXJlZChUaW1lcjxXZWJDb3JlOjpDU1NGb250U2VsZWN0b3I+KikKICAg ICB9CiAgICAgLy8gRW5zdXJlIHRoYXQgaWYgdGhlIHJlcXVlc3QgY291bnQgcmVhY2hlcyB6ZXJv LCB0aGUgZnJhbWUgbG9hZGVyIHdpbGwga25vdyBhYm91dCBpdC4KICAgICBjYWNoZWRSZXNvdXJj ZUxvYWRlci0+bG9hZERvbmUoKTsKLSAgICAvLyBOZXcgZm9udCBsb2FkcyBtYXkgYmUgdHJpZ2dl cmVkIGJ5IGxheW91dCBhZnRlciB0aGUgZG9jdW1lbnQgbG9hZCBpcyBjb21wbGV0ZSBidXQgYmVm b3JlIHdlIGhhdmUgZGlzcGF0Y2hlZAotICAgIC8vIGRpZEZpbmlzaExvYWRpbmcgZm9yIHRoZSBm cmFtZS4gTWFrZSBzdXJlIHRoZSBkZWxlZ2F0ZSBpcyBhbHdheXMgZGlzcGF0Y2hlZCBieSBjaGVj a2luZyBleHBsaWNpdGx5LgotICAgIGlmIChtX2RvY3VtZW50ICYmIG1fZG9jdW1lbnQtPmZyYW1l KCkpCi0gICAgICAgIG1fZG9jdW1lbnQtPmZyYW1lKCktPmxvYWRlcigpLT5jaGVja0xvYWRDb21w bGV0ZSgpOwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv Q2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlTG9hZGVyLmNwcAppbmRleCA3YjU2NDY1Mzg2NjZjM2ZlNDFhMzViZmIwMDYz ODJhOThhYjMzOTg2Li5iZDcxYjJhYjYyMmMwOTJlMDcwMzZhMTViYmQwZmI4OTEyZTA0YzU1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2Fk ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxv YWRlci5jcHAKQEAgLTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlICJDb250ZW50U2VjdXJpdHlQb2xp Y3kuaCIKICNpbmNsdWRlICJET01XaW5kb3cuaCIKICNpbmNsdWRlICJEb2N1bWVudC5oIgorI2lu Y2x1ZGUgIkRvY3VtZW50TG9hZGVyLmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJG cmFtZUxvYWRlci5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50LmgiCkBAIC03MjUsNiAr NzI2LDEyIEBAIHZvaWQgQ2FjaGVkUmVzb3VyY2VMb2FkZXI6OmRlY3JlbWVudFJlcXVlc3RDb3Vu dChjb25zdCBDYWNoZWRSZXNvdXJjZSogcmVzKQogCiAgICAgLS1tX3JlcXVlc3RDb3VudDsKICAg ICBBU1NFUlQobV9yZXF1ZXN0Q291bnQgPiAtMSk7CisKKyAgICAvLyBOZXcgcmVzb3VyY2UgbG9h ZHMgKGUuZy4gZm9udCBsb2FkcykgbWF5IGJlIHRyaWdnZXJlZCBieSBsYXlvdXQgYWZ0ZXIgdGhl IGRvY3VtZW50IGxvYWQgaXMKKyAgICAvLyBjb21wbGV0ZSBidXQgYmVmb3JlIHdlIGhhdmUgZGlz cGF0Y2hlZCBkaWRGaW5pc2hMb2FkaW5nIGZvciB0aGUgZnJhbWUuIE1ha2Ugc3VyZSB0aGUgZGVs ZWdhdGUKKyAgICAvLyBpcyBhbHdheXMgZGlzcGF0Y2hlZCBieSBjaGVja2luZyBleHBsaWNpdGx5 IG9uY2Ugd2UgYXJlIGRvbmUgbG9hZGluZyBhbGwgcmVzb3VyY2VzLgorICAgIGlmICghbV9yZXF1 ZXN0Q291bnQgJiYgbV9kb2N1bWVudCAmJiBtX2RvY3VtZW50LT5sb2FkZXIoKSAmJiBtX2RvY3Vt ZW50LT5sb2FkZXIoKS0+ZnJhbWVMb2FkZXIoKSkKKyAgICAgICAgbV9kb2N1bWVudC0+bG9hZGVy KCktPmZyYW1lTG9hZGVyKCktPmNoZWNrTG9hZENvbXBsZXRlKCk7CiB9CiAgICAgCiB2b2lkIENh Y2hlZFJlc291cmNlTG9hZGVyOjpwcmVsb2FkKENhY2hlZFJlc291cmNlOjpUeXBlIHR5cGUsIFJl c291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgU3RyaW5nJiBjaGFyc2V0LCBib29sIHJlZmVy ZW5jZWRGcm9tQm9keSkK