9463 2006-06-15 23:35:21 -0700 REGRESSION (r14879): Assertion failure in CSSParser::sinkFloatingSelector() (m_floatingSelectors.contains(selector)) in some CSS tests 2006-06-16 18:28:02 -0700 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned ddkilzer nickshanks oldest_to_newest 45889 0 mitz 2006-06-15 23:35:21 -0700 The debug build of TOT fails on css1/conformance/forward_compatible_parsing.html and fast/css/css3-modsel-22.html with this error: ASSERTION FAILED: m_floatingSelectors.contains(selector) (WebCore/css/cssparser.cpp:2864 WebCore::CSSSelector* WebCore::CSSParser::sinkFloatingSelector(WebCore::CSSSelector*)) 45896 1 ddkilzer 2006-06-16 03:30:00 -0700 Probably related to the fix for Bug 3233 (r14879). 45897 2 mitz 2006-06-16 04:09:19 -0700 (In reply to comment #1) > Probably related to the fix for Bug 3233 (r14879). > Yes, this is a regression from that fix (says so in the bug summary ;-) ). 45902 3 8866 ddkilzer 2006-06-16 04:29:57 -0700 Created attachment 8866 Patch v1 This patch fixes the two regressions in this bug. The full test suite is still running on my PB G4, though. 45903 4 ddkilzer 2006-06-16 04:31:45 -0700 (In reply to comment #2) > (In reply to comment #1) > > Probably related to the fix for Bug 3233 (r14879). > Yes, this is a regression from that fix (says so in the bug summary ;-) ). It was 5:30 AM local time when I wrote that. I was not fully mentally engaged yet. :) 45905 5 ddkilzer 2006-06-16 05:39:32 -0700 (In reply to comment #3) > Created an attachment (id=8866) [edit] > Patch v1 > > This patch fixes the two regressions in this bug. The full test suite is still > running on my PB G4, though. All of the tests passed. This looks like the fix. 45929 6 nickshanks 2006-06-16 09:22:04 -0700 Thanks. I had no clue what the cause was, nor how to go about fixing it. :-/ 45962 7 8866 darin 2006-06-16 13:23:04 -0700 Comment on attachment 8866 Patch v1 r=me 46006 8 ddkilzer 2006-06-16 18:10:48 -0700 Committed revision 14895. 46008 9 ddkilzer 2006-06-16 18:28:02 -0700 (In reply to comment #6) > Thanks. I had no clue what the cause was, nor how to go about fixing it. :-/ This fix was brought to you by Sesame Street: "One of these things is not like the others. One of these things just doesn't belong." http://members.tripod.com/tiny_dancer/one.html 8866 2006-06-16 04:29:57 -0700 2006-06-16 13:23:04 -0700 Patch v1 bug-9463-v1.diff text/plain 1216 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNDg4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDYtMDYtMTYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHpl ci5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NDYzCisgICAg ICAgIFJFR1JFU1NJT04gKHIxNDg3OSk6IEFzc2VydGlvbiBmYWlsdXJlIGluIENTU1BhcnNlcjo6 c2lua0Zsb2F0aW5nU2VsZWN0b3IoKQorICAgICAgICAobV9mbG9hdGluZ1NlbGVjdG9ycy5jb250 YWlucyhzZWxlY3RvcikpIGluIHNvbWUgQ1NTIHRlc3RzCisKKyAgICAgICAgKiBjc3MvQ1NTR3Jh bW1hci55OiBDcmVhdGUgQ1NTU2VsZWN0b3IgZm9yIEZVTkNUSU9OIHVzaW5nIENTU1BhcnNlcjo6 Y3JlYXRlRmxvYXRpbmdTZWxlY3RvcigpCisgICAgICAgIGluc3RlYWQgb2YgdGhlIGJhcmUgY29u c3RydWN0b3IuCisKIDIwMDYtMDYtMTUgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBsZXZpCkluZGV4OiBXZWJDb3JlL2Nzcy9D U1NHcmFtbWFyLnkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTR3JhbW1hci55CShyZXZp c2lvbiAxNDg4NikKKysrIFdlYkNvcmUvY3NzL0NTU0dyYW1tYXIueQkod29ya2luZyBjb3B5KQpA QCAtODM4LDcgKzgzOCw3IEBAIHBzZXVkbzoKICAgICB9CiAgICAgLy8gdXNlZCBieSA6bGFuZwog ICAgIHwgJzonIEZVTkNUSU9OIElERU5UICcpJyB7Ci0gICAgICAgICQkID0gbmV3IENTU1NlbGVj dG9yKCk7CisgICAgICAgICQkID0gc3RhdGljX2Nhc3Q8Q1NTUGFyc2VyKj4ocGFyc2VyKS0+Y3Jl YXRlRmxvYXRpbmdTZWxlY3RvcigpOwogICAgICAgICAkJC0+bWF0Y2ggPSBDU1NTZWxlY3Rvcjo6 UHNldWRvQ2xhc3M7CiAgICAgICAgICQkLT5hcmd1bWVudCA9IGF0b21pY1N0cmluZygkMyk7CiAg ICAgICAgICQyLmxvd2VyKCk7Cg==