94627 2012-08-21 13:07:03 -0700 [GTK] [WK2] Memory leaks in TestWebKitFindController 2012-08-21 17:18:19 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 701034 0 naginenis 2012-08-21 13:07:03 -0700 To avoid these leaks, adoptGRef must be used instead of just getting new reference of pixbuf. ==17717== 120,080 (80 direct, 120,000 indirect) bytes in 1 blocks are definitely lost in loss record 6,458 of 6,460 ==17717== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==17717== by 0xA6E7A38: g_malloc (gmem.c:159) ==17717== by 0xA6FAC62: g_slice_alloc (gslice.c:1003) ==17717== by 0xA6FB1A5: g_slice_alloc0 (gslice.c:1029) ==17717== by 0xA47B8B9: g_type_create_instance (gtype.c:1872) ==17717== by 0xA4600B8: g_object_constructor (gobject.c:1849) ==17717== by 0xA4616E3: g_object_newv (gobject.c:1713) ==17717== by 0xA461EC5: g_object_new_valist (gobject.c:1830) ==17717== by 0xA4621D3: g_object_new (gobject.c:1545) ==17717== by 0xA232E2E: gdk_pixbuf_new_from_data (in /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.2600.1) ==17717== by 0xA230F9D: gdk_pixbuf_new (in /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.2600.1) ==17717== by 0x9FD3FD3: gdk_pixbuf_get_from_surface (gdkpixbuf-drawable.c:246) ==17717== by 0x9FD4319: gdk_pixbuf_get_from_window (gdkpixbuf-drawable.c:97) ==17717== by 0x40B47D: testFindControllerHide(FindControllerTest*, void const*) (TestWebKitFindController.cpp:315) ==17717== by 0xA70264A: g_test_run_suite_internal (gtestutils.c:1663) ==17717== by 0xA7027C5: g_test_run_suite_internal (gtestutils.c:1727) ==17717== by 0xA7027C5: g_test_run_suite_internal (gtestutils.c:1727) ==17717== by 0xA702B1A: g_test_run_suite (gtestutils.c:1772) ==17717== by 0x40DD29: main (TestMain.cpp:35) ==17717== ==17717== 120,080 (80 direct, 120,000 indirect) bytes in 1 blocks are definitely lost in loss record 6,459 of 6,460 ==17717== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==17717== by 0xA6E7A38: g_malloc (gmem.c:159) ==17717== by 0xA6FAC62: g_slice_alloc (gslice.c:1003) ==17717== by 0xA6FB1A5: g_slice_alloc0 (gslice.c:1029) ==17717== by 0xA47B8B9: g_type_create_instance (gtype.c:1872) ==17717== by 0xA4600B8: g_object_constructor (gobject.c:1849) ==17717== by 0xA4616E3: g_object_newv (gobject.c:1713) ==17717== by 0xA461EC5: g_object_new_valist (gobject.c:1830) ==17717== by 0xA4621D3: g_object_new (gobject.c:1545) ==17717== by 0xA232E2E: gdk_pixbuf_new_from_data (in /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.2600.1) ==17717== by 0xA230F9D: gdk_pixbuf_new (in /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.2600.1) ==17717== by 0x9FD3FD3: gdk_pixbuf_get_from_surface (gdkpixbuf-drawable.c:246) ==17717== by 0x9FD4319: gdk_pixbuf_get_from_window (gdkpixbuf-drawable.c:97) ==17717== by 0x40B547: testFindControllerHide(FindControllerTest*, void const*) (TestWebKitFindController.cpp:323) ==17717== by 0xA70264A: g_test_run_suite_internal (gtestutils.c:1663) ==17717== by 0xA7027C5: g_test_run_suite_internal (gtestutils.c:1727) ==17717== by 0xA7027C5: g_test_run_suite_internal (gtestutils.c:1727) ==17717== by 0xA702B1A: g_test_run_suite (gtestutils.c:1772) ==17717== by 0x40DD29: main (TestMain.cpp:35) ==17717== ==17717== 120,080 (80 direct, 120,000 indirect) bytes in 1 blocks are definitely lost in loss record 6,460 of 6,460 ==17717== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==17717== by 0xA6E7A38: g_malloc (gmem.c:159) ==17717== by 0xA6FAC62: g_slice_alloc (gslice.c:1003) ==17717== by 0xA6FB1A5: g_slice_alloc0 (gslice.c:1029) ==17717== by 0xA47B8B9: g_type_create_instance (gtype.c:1872) ==17717== by 0xA4600B8: g_object_constructor (gobject.c:1849) ==17717== by 0xA4616E3: g_object_newv (gobject.c:1713) ==17717== by 0xA461EC5: g_object_new_valist (gobject.c:1830) ==17717== by 0xA4621D3: g_object_new (gobject.c:1545) ==17717== by 0xA232E2E: gdk_pixbuf_new_from_data (in /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.2600.1) ==17717== by 0xA230F9D: gdk_pixbuf_new (in /usr/lib/x86_64-linux-gnu/libgdk_pixbuf-2.0.so.0.2600.1) ==17717== by 0x9FD3FD3: gdk_pixbuf_get_from_surface (gdkpixbuf-drawable.c:246) ==17717== by 0x9FD4319: gdk_pixbuf_get_from_window (gdkpixbuf-drawable.c:97) ==17717== by 0x40B63F: testFindControllerHide(FindControllerTest*, void const*) (TestWebKitFindController.cpp:332) ==17717== by 0xA70264A: g_test_run_suite_internal (gtestutils.c:1663) ==17717== by 0xA7027C5: g_test_run_suite_internal (gtestutils.c:1727) ==17717== by 0xA7027C5: g_test_run_suite_internal (gtestutils.c:1727) ==17717== by 0xA702B1A: g_test_run_suite (gtestutils.c:1772) ==17717== by 0x40DD29: main (TestMain.cpp:35) 701057 1 159755 naginenis 2012-08-21 13:25:42 -0700 Created attachment 159755 Patch Add missing adoptGRef to avoid memory leaks. 701062 2 webkit.review.bot 2012-08-21 13:28:27 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 701347 3 159755 webkit.review.bot 2012-08-21 17:18:16 -0700 Comment on attachment 159755 Patch Clearing flags on attachment: 159755 Committed r126231: <http://trac.webkit.org/changeset/126231> 701348 4 webkit.review.bot 2012-08-21 17:18:19 -0700 All reviewed patches have been landed. Closing bug. 159755 2012-08-21 13:25:42 -0700 2012-08-21 17:18:16 -0700 Patch 94627.patch text/plain 2807 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwMmJlNzRiLi42Y2NhNTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDgtMjEgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gW1dLMl0gTWVtb3J5IGxlYWtzIGluIFRl c3RXZWJLaXRGaW5kQ29udHJvbGxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTQ2MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggbWVtb3J5IGxlYWtzIGluIFRlc3RXZWJLaXRGaW5kQ29udHJvbGxl ciBieSB1c2luZyBhZG9wdEdSZWYKKyAgICAgICAgaW5zdGVhZCBvZiBqdXN0IGdldHRpbmcgbmV3 IHJlZmVyZW5jZSBvZiBHZGtQaXhidWYuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90 ZXN0cy9UZXN0V2ViS2l0RmluZENvbnRyb2xsZXIuY3BwOgorICAgICAgICAodGVzdEZpbmRDb250 cm9sbGVySGlkZSk6CisKIDIwMTItMDgtMjEgIEplc3NlIHZhbiBkZW4gS2llYm9vbSAgPGplc3Nl dmRrQGdub21lLm9yZz4gYW5kIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBkZXN0cm95IG5vdGlmeSBmb3IgcmVnaXN0ZXJfdXJp X3NjaGVtZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVz dHMvVGVzdFdlYktpdEZpbmRDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL3Rlc3RzL1Rlc3RXZWJLaXRGaW5kQ29udHJvbGxlci5jcHAKaW5kZXggYTJhZjdi ZC4uOTAxNTliOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv dGVzdHMvVGVzdFdlYktpdEZpbmRDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0V2ViS2l0RmluZENvbnRyb2xsZXIuY3BwCkBAIC0z MTIsNyArMzEyLDcgQEAgc3RhdGljIHZvaWQgdGVzdEZpbmRDb250cm9sbGVySGlkZShGaW5kQ29u dHJvbGxlclRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgZ19hc3NlcnQod2ViVmlld0dk a1dpbmRvdyk7CiAKICAgICB0ZXN0LT53YWl0VW50aWxXZWJWaWV3RHJhd1NpZ25hbCgpOwotICAg IEdSZWZQdHI8R2RrUGl4YnVmPiBvcmlnaW5hbFBpeGJ1ZiA9IGdka19waXhidWZfZ2V0X2Zyb21f d2luZG93KHdlYlZpZXdHZGtXaW5kb3csIDAsIDAsIGFsbG9jYXRlZEhlaWdodCwgYWxsb2NhdGVk V2lkdGgpOworICAgIEdSZWZQdHI8R2RrUGl4YnVmPiBvcmlnaW5hbFBpeGJ1ZiA9IGFkb3B0R1Jl ZihnZGtfcGl4YnVmX2dldF9mcm9tX3dpbmRvdyh3ZWJWaWV3R2RrV2luZG93LCAwLCAwLCBhbGxv Y2F0ZWRIZWlnaHQsIGFsbG9jYXRlZFdpZHRoKSk7CiAgICAgZ19hc3NlcnQob3JpZ2luYWxQaXhi dWYpOwogCiAgICAgdGVzdC0+ZmluZCgidGVzdGluZyIsIFdFQktJVF9GSU5EX09QVElPTlNfTk9O RSwgMSk7CkBAIC0zMjAsNyArMzIwLDcgQEAgc3RhdGljIHZvaWQgdGVzdEZpbmRDb250cm9sbGVy SGlkZShGaW5kQ29udHJvbGxlclRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgZ19hc3Nl cnQodGVzdC0+bV90ZXh0Rm91bmQpOwogCiAgICAgdGVzdC0+d2FpdFVudGlsV2ViVmlld0RyYXdT aWduYWwoKTsKLSAgICBHUmVmUHRyPEdka1BpeGJ1Zj4gaGlnaGxpZ2h0UGl4YnVmID0gZ2RrX3Bp eGJ1Zl9nZXRfZnJvbV93aW5kb3cod2ViVmlld0dka1dpbmRvdywgMCwgMCwgYWxsb2NhdGVkSGVp Z2h0LCBhbGxvY2F0ZWRXaWR0aCk7CisgICAgR1JlZlB0cjxHZGtQaXhidWY+IGhpZ2hsaWdodFBp eGJ1ZiA9IGFkb3B0R1JlZihnZGtfcGl4YnVmX2dldF9mcm9tX3dpbmRvdyh3ZWJWaWV3R2RrV2lu ZG93LCAwLCAwLCBhbGxvY2F0ZWRIZWlnaHQsIGFsbG9jYXRlZFdpZHRoKSk7CiAgICAgZ19hc3Nl cnQoaGlnaGxpZ2h0UGl4YnVmKTsKICAgICBnX2Fzc2VydCghZ2RrUGl4YnVmRXF1YWwob3JpZ2lu YWxQaXhidWYuZ2V0KCksIGhpZ2hsaWdodFBpeGJ1Zi5nZXQoKSkpOwogCkBAIC0zMjksNyArMzI5 LDcgQEAgc3RhdGljIHZvaWQgdGVzdEZpbmRDb250cm9sbGVySGlkZShGaW5kQ29udHJvbGxlclRl c3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgd2Via2l0X3dlYl92aWV3X2V4ZWN1dGVfZWRp dGluZ19jb21tYW5kKHRlc3QtPm1fd2ViVmlldywgIlVuc2VsZWN0Iik7CiAKICAgICB0ZXN0LT53 YWl0VW50aWxXZWJWaWV3RHJhd1NpZ25hbCgpOwotICAgIEdSZWZQdHI8R2RrUGl4YnVmPiB1bmhp Z2hsaWdodFBpeGJ1ZiA9IGdka19waXhidWZfZ2V0X2Zyb21fd2luZG93KHdlYlZpZXdHZGtXaW5k b3csIDAsIDAsIGFsbG9jYXRlZEhlaWdodCwgYWxsb2NhdGVkV2lkdGgpOworICAgIEdSZWZQdHI8 R2RrUGl4YnVmPiB1bmhpZ2hsaWdodFBpeGJ1ZiA9IGFkb3B0R1JlZihnZGtfcGl4YnVmX2dldF9m cm9tX3dpbmRvdyh3ZWJWaWV3R2RrV2luZG93LCAwLCAwLCBhbGxvY2F0ZWRIZWlnaHQsIGFsbG9j YXRlZFdpZHRoKSk7CiAgICAgZ19hc3NlcnQodW5oaWdobGlnaHRQaXhidWYpOwogICAgIGdfYXNz ZXJ0KGdka1BpeGJ1ZkVxdWFsKG9yaWdpbmFsUGl4YnVmLmdldCgpLCB1bmhpZ2hsaWdodFBpeGJ1 Zi5nZXQoKSkpOwogfQo=