94621 2012-08-21 11:46:15 -0700 [BlackBerry] Add option to only add JavaScript object 'qnx' to private webviews 2012-08-21 17:18:24 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ben webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 700965 0 ben 2012-08-21 11:46:15 -0700 Currently the BlackBerry port is injecting the 'qnx' JavaScript object in every WebView to provide a way for JavaScript to callback out to native through an event. This qnx object is injected in both WebViews that are used for interacting with local resources (local webpage) and WebViews that are used for displaying public webpages (aka http://www.google.com) As long as the current codebase has a 'qnx' object there should be a way to enable/disable the injections so it can be turned off by default on WebView's loading public webpages to prevent any possible security risk. 701011 1 159741 ben 2012-08-21 12:41:42 -0700 Created attachment 159741 patch 701018 2 159741 yong.li.webkit 2012-08-21 12:51:02 -0700 Comment on attachment 159741 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159741&action=review > Source/WebKit/blackberry/Api/WebPage.h:387 > + void enableQnxJavaScriptObject(bool); Naming: 1. Qnx should be QNX 2. WebKit usually use setFooEnabled(boo) 701020 3 159741 yong.li.webkit 2012-08-21 12:52:02 -0700 Comment on attachment 159741 patch View in context: https://bugs.webkit.org/attachment.cgi?id=159741&action=review >> Source/WebKit/blackberry/Api/WebPage.h:387 >> + void enableQnxJavaScriptObject(bool); > > Naming: > 1. Qnx should be QNX > 2. WebKit usually use setFooEnabled(boo) hm.. probably Qnx is ok because the js object is "qnx" 701037 4 ben 2012-08-21 13:09:40 -0700 On the API note, the BlackBerry port api is inconsistent, has setFooEnabled(), enableFoo() and setEnableFoo() which is why I just picked one. 701349 5 159741 webkit.review.bot 2012-08-21 17:18:21 -0700 Comment on attachment 159741 patch Clearing flags on attachment: 159741 Committed r126232: <http://trac.webkit.org/changeset/126232> 701350 6 webkit.review.bot 2012-08-21 17:18:24 -0700 All reviewed patches have been landed. Closing bug. 159741 2012-08-21 12:41:42 -0700 2012-08-21 17:18:21 -0700 patch 0001-.patch text/plain 4372 ben RnJvbSAxYmJlNDRhMGExYmY2ZjM5NzkwN2QzZTQyODMxMzkzNGE3MzNlNzY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogVHVlLCAyMSBBdWcgMjAxMiAxNToyODoxMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIC4KCi0t LQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCAgICAgICAgICAgfCAg ICA2ICsrKysrKwogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmggICAgICAg ICAgICAgfCAgICAyICsrCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5o ICAgICAgICAgICB8ICAgIDIgKysKIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogLi4uL1dlYkNvcmVTdXBw b3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAgfCAgICA1ICsrLS0tCiA1IGZpbGVz IGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggOTc5ZWU0My4uM2JmMjU4YSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0zMzMsNiArMzMzLDExIEBA IHZvaWQgV2ViUGFnZTo6YXV0b2ZpbGxUZXh0RmllbGQoY29uc3Qgc3RyaW5nJiBpdGVtKQogICAg IGQtPm1fYXV0b2ZpbGxNYW5hZ2VyLT5hdXRvZmlsbFRleHRGaWVsZChpdGVtLmNfc3RyKCkpOwog fQogCit2b2lkIFdlYlBhZ2U6OmVuYWJsZVFueEphdmFTY3JpcHRPYmplY3QoYm9vbCBlbmFibGVk KQoreworICAgIGQtPm1fZW5hYmxlUW54SmF2YVNjcmlwdE9iamVjdCA9IGVuYWJsZWQ7Cit9CisK IFdlYlBhZ2VQcml2YXRlOjpXZWJQYWdlUHJpdmF0ZShXZWJQYWdlKiB3ZWJQYWdlLCBXZWJQYWdl Q2xpZW50KiBjbGllbnQsIGNvbnN0IEludFJlY3QmIHJlY3QpCiAgICAgOiBtX3dlYlBhZ2Uod2Vi UGFnZSkKICAgICAsIG1fY2xpZW50KGNsaWVudCkKQEAgLTQwNSw2ICs0MTAsNyBAQCBXZWJQYWdl UHJpdmF0ZTo6V2ViUGFnZVByaXZhdGUoV2ViUGFnZSogd2ViUGFnZSwgV2ViUGFnZUNsaWVudCog Y2xpZW50LCBjb25zdCBJbgogICAgICwgbV9mdWxsc2NyZWVuVmlkZW9Ob2RlKDApCiAgICAgLCBt X2hhc0luUmVnaW9uU2Nyb2xsYWJsZUFyZWFzKGZhbHNlKQogICAgICwgbV91cGRhdGVEZWxlZ2F0 ZWRPdmVybGF5c0Rpc3BhdGNoZWQoZmFsc2UpCisgICAgLCBtX2VuYWJsZVFueEphdmFTY3JpcHRP YmplY3QodHJ1ZSkKICAgICAsIG1fZGVmZXJyZWRUYXNrc1RpbWVyKHRoaXMsICZXZWJQYWdlUHJp dmF0ZTo6ZGVmZXJyZWRUYXNrc1RpbWVyRmlyZWQpCiAgICAgLCBtX3NlbGVjdFBvcHVwKDApCiAg ICAgLCBtX2F1dG9maWxsTWFuYWdlcihBdXRvZmlsbE1hbmFnZXI6OmNyZWF0ZSh0aGlzKSkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKaW5kZXggMWZhYTFiZi4uNjFlZmRlYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTM4NCw2ICszODQsOCBA QCBwdWJsaWM6CiAKICAgICB2b2lkIGF1dG9maWxsVGV4dEZpZWxkKGNvbnN0IHN0ZDo6c3RyaW5n Jik7CiAKKyAgICB2b2lkIGVuYWJsZVFueEphdmFTY3JpcHRPYmplY3QoYm9vbCk7CisKIHByaXZh dGU6CiAgICAgdmlydHVhbCB+V2ViUGFnZSgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9XZWJQYWdlX3AuaAppbmRleCAxNDA4N2FmLi5jZWMwYTFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZV9wLmgKQEAgLTYxMSw2ICs2MTEsOCBAQCBwdWJsaWM6CiAgICAg V2ViQ29yZTo6S1VSTCBtX2NhY2hlZE1hbnVhbFNjcmlwdDsKICAgICBib29sIG1fY2FjaGVkRm9j dXNlZDsKIAorICAgIGJvb2wgbV9lbmFibGVRbnhKYXZhU2NyaXB0T2JqZWN0OworCiAgICAgY2xh c3MgRGVmZXJyZWRUYXNrQmFzZSB7CiAgICAgcHVibGljOgogICAgICAgICB2b2lkIHBlcmZvcm0o V2ViUGFnZVByaXZhdGUqIHdlYlBhZ2VQcml2YXRlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKaW5kZXggMDFlMzc3My4uNGJjMTlkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDgtMjEgIEJlbmphbWluIEMgTWV5ZXIgIDxibWV5ZXJA cmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQWRkIG9wdGlvbiB0byBvbmx5IGFkZCBK YXZhU2NyaXB0IG9iamVjdCAncW54JyB0byBwcml2YXRlIHdlYnZpZXdzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDYyMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAg ICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjplbmFibGVRbnhKYXZhU2NyaXB0T2Jq ZWN0KToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6Oldl YlBhZ2VQcml2YXRlOjpXZWJQYWdlUHJpdmF0ZSk6CisgICAgICAgICogQXBpL1dlYlBhZ2UuaDoK KyAgICAgICAgKiBBcGkvV2ViUGFnZV9wLmg6CisgICAgICAgIChXZWJQYWdlUHJpdmF0ZSk6Cisg ICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGlzcGF0Y2hE aWRDbGVhcldpbmRvd09iamVjdEluV29ybGQpOgorCiAyMDEyLTA4LTE1ICBZb25nIExpICA8eW9s aUByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTaG91bGQgbm90IGtlZXAgcmVjcmVh dGluZyBHZW9UcmFja2VyIGluIHNldEVuYWJsZUhpZ2hBY2N1cmFjeSgpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRC bGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9G cmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IDUxNWQ3YTUuLjI1YTMzNWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxv YWRlckNsaWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC04OTEsOSAr ODkxLDggQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNoRGlkQ2xl YXJXaW5kb3dPYmplY3RJbldvcmxkKERPTVdyYXBwZXIKICAgICAgICAgcmV0dXJuOwogCiAgICAg Ly8gUHJvdmlkZSB0aGUgZXh0ZW5zaW9uIG9iamVjdCBmaXJzdCBpbiBjYXNlIHRoZSBjbGllbnQg b3Igb3RoZXJzIHdhbnQgdG8gdXNlIGl0LgotICAgIC8vIEZJWE1FOiBDb25kaXRpb25hbGx5IGF0 dGFjaCBleHRlbnNpb24gb2JqZWN0IGJhc2VkIG9uIHNvbWUgZmxhZyBvciB3aGV0aGVyIG9yIG5v dCB3ZQotICAgIC8vIGFyZSBicm93c2VyIG9yIHNvbWV0aGluZyBlbHNlLgotICAgIGF0dGFjaEV4 dGVuc2lvbk9iamVjdFRvRnJhbWUobV9mcmFtZSwgbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQp OworICAgIGlmIChtX3dlYlBhZ2VQcml2YXRlLT5tX2VuYWJsZVFueEphdmFTY3JpcHRPYmplY3Qp CisgICAgICAgIGF0dGFjaEV4dGVuc2lvbk9iamVjdFRvRnJhbWUobV9mcmFtZSwgbV93ZWJQYWdl UHJpdmF0ZS0+bV9jbGllbnQpOwogCiAgICAgbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPm5v dGlmeVdpbmRvd09iamVjdENsZWFyZWQoKTsKIAotLSAKMS43LjEKCg==