94611 2012-08-21 09:54:52 -0700 Chromium: WebAccessibilityObject should expose updateBackingStore 2012-08-24 17:33:43 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94619 1 dmazzoni dmazzoni abarth cfleizach dglazkov fishd inferno jamesr tkent+wkapi webkit.review.bot oldest_to_newest 700854 0 dmazzoni 2012-08-21 09:54:52 -0700 Right now most WebAccessibilityObject methods call updateBackingStore under the hood, but this is inefficient when several methods are used in a row, and also has the potential to cause bugs if updateBackingStore deletes the underlying object. Instead, WebAccessibilityObject should expose This will be a three-parter: first we'll expose updateBackingStore without a LayoutTest, then Chromium will be modified to use it, then finally WebKit will be modified to not call updateBackingStore automatically, with a new LayoutTest to cover the final change. 700862 1 159709 dmazzoni 2012-08-21 10:00:03 -0700 Created attachment 159709 Patch 700868 2 webkit.review.bot 2012-08-21 10:04:22 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 701243 3 159709 cfleizach 2012-08-21 16:11:38 -0700 Comment on attachment 159709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159709&action=review > Source/WebKit/chromium/public/WebAccessibilityObject.h:85 > + WEBKIT_EXPORT void updateBackingStore(); seems like you might be able to make this one method that returns a bool bool updateBackingStoreIfPossible() or something like that, so that you can check the result of this immediately then presumably inside you would call updateBackingStore() and then return isDetached 701330 4 dmazzoni 2012-08-21 17:07:11 -0700 (In reply to comment #3) > (From update of attachment 159709 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159709&action=review > > > Source/WebKit/chromium/public/WebAccessibilityObject.h:85 > > + WEBKIT_EXPORT void updateBackingStore(); > > seems like you might be able to make this one method that returns a bool > > bool updateBackingStoreIfPossible() or something like that, so that you can check the result of this immediately > > then presumably inside you would call updateBackingStore() and then return isDetached That's a good idea, except do you think that would imply that only this object's underlying node could be detached? Actually any AccessibilityObject could be detached... 701610 5 cfleizach 2012-08-21 23:35:10 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 159709 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=159709&action=review > > > > > Source/WebKit/chromium/public/WebAccessibilityObject.h:85 > > > + WEBKIT_EXPORT void updateBackingStore(); > > > > seems like you might be able to make this one method that returns a bool > > > > bool updateBackingStoreIfPossible() or something like that, so that you can check the result of this immediately > > > > then presumably inside you would call updateBackingStore() and then return isDetached > > That's a good idea, except do you think that would imply that only this object's underlying node could be detached? Actually any AccessibilityObject could be detached... My thinking was that if updateBackingStore() returned false, you would process anymore code and return a default value, because that element was no longer valid. Are you not using isDetached() for that purpose 702731 6 160094 dmazzoni 2012-08-22 23:37:35 -0700 Created attachment 160094 Patch 702732 7 dmazzoni 2012-08-22 23:39:19 -0700 (In reply to comment #5) > > That's a good idea, except do you think that would imply that only this object's underlying node could be detached? Actually any AccessibilityObject could be detached... > > My thinking was that if updateBackingStore() returned false, you would process anymore code and return a default value, because that element was no longer valid. > > Are you not using isDetached() for that purpose You're correct, isDetached is definitely used for that purpose. I made the change as suggested, I agree it will simplify things some of the time. I modified the comment to warn that calling updateBackingStore on one object may invalidate a separate object. 703083 8 160094 cfleizach 2012-08-23 09:40:47 -0700 Comment on attachment 160094 Patch should we change the name to something like "verifyBackingStoreIsValid()" or "ensureBackingStoreIsValid()" 703101 9 dmazzoni 2012-08-23 10:10:28 -0700 (In reply to comment #8) > (From update of attachment 160094 [details]) > should we change the name to something like "verifyBackingStoreIsValid()" or "ensureBackingStoreIsValid()" Do you want to change it in AccessibilityObject too? It doesn't make sense to call them something different. How about updateBackingStoreAndCheckValidity? I'll make the change in all of the ports that use it. 704353 10 dmazzoni 2012-08-24 12:42:47 -0700 Any thoughts? 704412 11 cfleizach 2012-08-24 14:01:57 -0700 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 160094 [details] [details]) > > should we change the name to something like "verifyBackingStoreIsValid()" or "ensureBackingStoreIsValid()" > > Do you want to change it in AccessibilityObject too? It doesn't make sense to call them something different. > > How about updateBackingStoreAndCheckValidity? I'll make the change in all of the ports that use it. We can change it in AXObject. I assume that would become a bool return as well. That name is a bit verbose, but I can't think of anything else good right now 704475 12 dmazzoni 2012-08-24 15:49:57 -0700 Hmmm, it looks like it wouldn't be so easy for AccessibilityObject::updateBackingStore to return a bool, because the object itself might be deleted at the time we'd want to check. We can't retain a pointer to the wrapper, because there is no wrapper on Chromium. It's probably not a good idea to retain the axID and check with AXObjectCache, because the hash lookup would be slower than the current code path. I guess I'll just leave AccessibilityObject for now and add the new method to chromium. We can revisit later. 704476 13 160515 dmazzoni 2012-08-24 15:50:37 -0700 Created attachment 160515 Patch for landing 704557 14 160515 webkit.review.bot 2012-08-24 17:33:40 -0700 Comment on attachment 160515 Patch for landing Clearing flags on attachment: 160515 Committed r126662: <http://trac.webkit.org/changeset/126662> 704558 15 webkit.review.bot 2012-08-24 17:33:43 -0700 All reviewed patches have been landed. Closing bug. 159709 2012-08-21 10:00:03 -0700 2012-08-22 23:37:33 -0700 Patch bug-94611-20120821100002.patch text/plain 3075 dmazzoni U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZmOWVlMTE5MDdhNDJlYWI1MGExMTdjNjJiMzk1YzY2OTJjYWQ2YzguLmMxYmUwODI5MjAyMTQ2 ZTMzYWEyNzU4MWM4MjFkYjM3OTEwNDJjOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDgtMjEgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdv b2dsZS5jb20+CisKKyAgICAgICAgQ2hyb21pdW06IFdlYkFjY2Vzc2liaWxpdHlPYmplY3Qgc2hv dWxkIGV4cG9zZSB1cGRhdGVCYWNraW5nU3RvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UganVzdCBleHBvc2VzIGEgbWV0aG9kLCB3 aXRoIG5vIG5ldyB0ZXN0cy4gTmV4dCwgQ2hyb21pdW0KKyAgICAgICAgd2lsbCBiZSBtb2RpZmll ZCB0byBjYWxsIHRoaXMgbmV3IG1ldGhvZCwgYW5kIHRoaXMgd2lsbCBiZSBmb2xsb3dlZAorICAg ICAgICBieSBhIGNoYW5nZSB0aGF0IGdldHMgcmlkIG9mIGNhbGxzIHRvIHVwZGF0ZUJhY2tpbmdT dG9yZSB1bmRlciB0aGUKKyAgICAgICAgaG9vZC4gVGhhdCBsYXN0IGNoYW5nZSBtYXkgYWRkIGEg dGVzdCBvciB1cGRhdGUgYW4gZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIHB1YmxpYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0KToK KyAgICAgICAgKiBzcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OnVwZGF0ZUJhY2tpbmdTdG9yZSk6CisgICAgICAg IChXZWJLaXQpOgorCiAyMDEyLTA4LTE2ICBEYXZpZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBTY2hlZHVsZSB0ZXh0dXJlIHVwbG9hZHMgYmFz ZWQgb24gaGFyZC1jb2RlZCB0aW1lciBhbmQgdnN5bmMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmggYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgKaW5kZXggMDI5ZjQz ODcyMjc2M2RhZjFlMTg0MjA0YTMyYTIwMjA3OTY5MWUyMi4uN2YxODk1YTczNGMxYTdhNjhiZTUw NDgyZmI2YzY2NzE1YTI1YTdlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuaApAQCAtNjksNiArNjksNyBAQCBwdWJs aWM6CiAgICAgV0VCS0lUX0VYUE9SVCBib29sIGVxdWFscyhjb25zdCBXZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0JikgY29uc3Q7CiAKICAgICBib29sIGlzTnVsbCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJp dmF0ZS5pc051bGwoKTsgfQorICAgIC8vIGlzRGV0YWNoZWQgYWxzbyBjaGVja3MgZm9yIG51bGws IHNvIGl0J3Mgc2FmZSB0byBqdXN0IGNhbGwgaXNEZXRhY2hlZC4KICAgICBXRUJLSVRfRVhQT1JU IGJvb2wgaXNEZXRhY2hlZCgpIGNvbnN0OwogCiAgICAgLy8gU3RhdGljIG1ldGhvZHMgZm9yIGVu YWJsaW5nIGFjY2Vzc2liaWxpdHkuCkBAIC03Nyw2ICs3OCwxMiBAQCBwdWJsaWM6CiAKICAgICBX RUJLSVRfRVhQT1JUIGludCBheElEKCkgY29uc3Q7CiAKKyAgICAvLyBOb3RlOiBpZiBhbnkgV2Vi S2l0IGNvZGUgaGFzIGV4ZWN1dGVkIGJldHdlZW4gd2hlbiB5b3UgYWNxdWlyZSBhCisgICAgLy8g V2ViQWNjZXNzaWJpbGl0eU9iamVjdCBhbmQgd2hlbiB5b3UgdXNlIGl0LCB5b3Ugc2hvdWxkIGFs d2F5cyBjYWxsCisgICAgLy8gdXBkYXRlQmFja2luZ1N0b3JlIHRvIHVwZGF0ZSB0aGUgdHJlZSwg dGhlbiBjaGVjayB0byBzZWUgaWYgdGhpcworICAgIC8vIG9iamVjdCBpcyBzdGlsbCBwYXJ0IG9m IHRoZSB0cmVlIGJ5IGNhbGxpbmcgaXNEZXRhY2hlZCgpLgorICAgIFdFQktJVF9FWFBPUlQgdm9p ZCB1cGRhdGVCYWNraW5nU3RvcmUoKTsKKwogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGFj Y2Vzc2liaWxpdHlEZXNjcmlwdGlvbigpIGNvbnN0OwogICAgIFdFQktJVF9FWFBPUlQgV2ViU3Ry aW5nIGFjdGlvblZlcmIoKSBjb25zdDsKICAgICBXRUJLSVRfRVhQT1JUIGJvb2wgY2FuU2V0Rm9j dXNBdHRyaWJ1dGUoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAKaW5kZXggMWViNjlkMjhmYWJlMDFhYjJjNjg5 ZTE2MDU4NzEyM2YwZjJkMDk4MS4uMzMxNzBjOTE2NDE1NjJmY2RmOGZhMTQzMzc2NDNlZjIyYjQ4 MTZiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJp bGl0eU9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNz aWJpbGl0eU9iamVjdC5jcHAKQEAgLTk5LDYgKzk5LDEyIEBAIGludCBXZWJBY2Nlc3NpYmlsaXR5 T2JqZWN0OjpheElEKCkgY29uc3QKICAgICByZXR1cm4gbV9wcml2YXRlLT5heE9iamVjdElEKCk7 CiB9CiAKK3ZvaWQgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6dXBkYXRlQmFja2luZ1N0b3JlKCkK K3sKKyAgICBpZiAoIWlzRGV0YWNoZWQoKSkKKyAgICAgICAgbV9wcml2YXRlLT51cGRhdGVCYWNr aW5nU3RvcmUoKTsKK30KKwogV2ViU3RyaW5nIFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OmFjY2Vz c2liaWxpdHlEZXNjcmlwdGlvbigpIGNvbnN0CiB7CiAgICAgaWYgKGlzRGV0YWNoZWQoKSkK 160094 2012-08-22 23:37:35 -0700 2012-08-24 15:50:34 -0700 Patch bug-94611-20120822233733.patch text/plain 3144 dmazzoni U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI1YjZkOTQ2N2EyMmM3ZTM2ZTZjYmRhODM4OGM3OGEyM2ZjZjg2NzUuLjk3NDU2OWM2MjkwNjBh MmI3MGU2ODJlMzg0ODFiZmZmYzI4NWQ5ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDgtMjEgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdv b2dsZS5jb20+CisKKyAgICAgICAgQ2hyb21pdW06IFdlYkFjY2Vzc2liaWxpdHlPYmplY3Qgc2hv dWxkIGV4cG9zZSB1cGRhdGVCYWNraW5nU3RvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UganVzdCBleHBvc2VzIGEgbWV0aG9kLCB3 aXRoIG5vIG5ldyB0ZXN0cy4gTmV4dCwgQ2hyb21pdW0KKyAgICAgICAgd2lsbCBiZSBtb2RpZmll ZCB0byBjYWxsIHRoaXMgbmV3IG1ldGhvZCwgYW5kIHRoaXMgd2lsbCBiZSBmb2xsb3dlZAorICAg ICAgICBieSBhIGNoYW5nZSB0aGF0IGdldHMgcmlkIG9mIGNhbGxzIHRvIHVwZGF0ZUJhY2tpbmdT dG9yZSB1bmRlciB0aGUKKyAgICAgICAgaG9vZC4gVGhhdCBsYXN0IGNoYW5nZSBtYXkgYWRkIGEg dGVzdCBvciB1cGRhdGUgYW4gZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIHB1YmxpYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0KToK KyAgICAgICAgKiBzcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OnVwZGF0ZUJhY2tpbmdTdG9yZSk6CisgICAgICAg IChXZWJLaXQpOgorCiAyMDEyLTA4LTE3ICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVHVybiBvZmYgRU5BQkxFX0RBVEFMSVNUX0VMRU1F TlQgZm9yIEFuZHJvaWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYkFjY2Vzc2liaWxpdHlPYmplY3QuaAppbmRleCAwMjlmNDM4NzIyNzYzZGFmMWUxODQyMDRh MzJhMjAyMDc5NjkxZTIyLi4zM2ZkYmM5MzQzNDE3MjIwZWVmZWY2ZjQ2ZWZjZTY1ZTMxYjVjNGNh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBY2Nlc3NpYmls aXR5T2JqZWN0LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQWNjZXNz aWJpbGl0eU9iamVjdC5oCkBAIC02OSw2ICs2OSw3IEBAIHB1YmxpYzoKICAgICBXRUJLSVRfRVhQ T1JUIGJvb2wgZXF1YWxzKGNvbnN0IFdlYkFjY2Vzc2liaWxpdHlPYmplY3QmKSBjb25zdDsKIAog ICAgIGJvb2wgaXNOdWxsKCkgY29uc3QgeyByZXR1cm4gbV9wcml2YXRlLmlzTnVsbCgpOyB9Cisg ICAgLy8gaXNEZXRhY2hlZCBhbHNvIGNoZWNrcyBmb3IgbnVsbCwgc28gaXQncyBzYWZlIHRvIGp1 c3QgY2FsbCBpc0RldGFjaGVkLgogICAgIFdFQktJVF9FWFBPUlQgYm9vbCBpc0RldGFjaGVkKCkg Y29uc3Q7CiAKICAgICAvLyBTdGF0aWMgbWV0aG9kcyBmb3IgZW5hYmxpbmcgYWNjZXNzaWJpbGl0 eS4KQEAgLTc3LDYgKzc4LDEzIEBAIHB1YmxpYzoKIAogICAgIFdFQktJVF9FWFBPUlQgaW50IGF4 SUQoKSBjb25zdDsKIAorICAgIC8vIFVwZGF0ZSB0aGUgdW5kZXJseWluZyB0cmVlLCBhbmQgcmV0 dXJuIHRydWUgaWYgdGhpcyBvYmplY3QgaXMKKyAgICAvLyBzdGlsbCB2YWxpZCAobm90IGRldGFj aGVkKS4gTm90ZSB0aGF0IGNhbGxpbmcgdXBkYXRlQmFja2luZ1N0b3JlCisgICAgLy8gY2FuIGNh dXNlIG90aGVyIFdlYkFjY2Vzc2liaWxpdHlPYmplY3RzIHRvIGJlY29tZSBpbnZhbGlkLCB0b28s CisgICAgLy8gc28gYWx3YXlzIGNhbGwgaXNEZXRhY2hlZCBpZiB1cGRhdGVCYWNraW5nU3RvcmUg aGFzIGJlZW4gY2FsbGVkIG9uCisgICAgLy8gYW55IG9iamVjdCwgb3IgaWYgYW55IG90aGVyIFdl YkNvcmUgY29kZSBoYXMgcnVuLgorICAgIFdFQktJVF9FWFBPUlQgYm9vbCB1cGRhdGVCYWNraW5n U3RvcmUoKTsKKwogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGFjY2Vzc2liaWxpdHlEZXNj cmlwdGlvbigpIGNvbnN0OwogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGFjdGlvblZlcmIo KSBjb25zdDsKICAgICBXRUJLSVRfRVhQT1JUIGJvb2wgY2FuU2V0Rm9jdXNBdHRyaWJ1dGUoKSBj b25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkFjY2Vzc2li aWxpdHlPYmplY3QuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJp bGl0eU9iamVjdC5jcHAKaW5kZXggMWViNjlkMjhmYWJlMDFhYjJjNjg5ZTE2MDU4NzEyM2YwZjJk MDk4MS4uNDdlZDFlNzMzNGQ2YWExNmMwMzQ2ZWFlZTgwYjhhODJiYzAyZmFmZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5j cHAKQEAgLTk5LDYgKzk5LDEzIEBAIGludCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0OjpheElEKCkg Y29uc3QKICAgICByZXR1cm4gbV9wcml2YXRlLT5heE9iamVjdElEKCk7CiB9CiAKK2Jvb2wgV2Vi QWNjZXNzaWJpbGl0eU9iamVjdDo6dXBkYXRlQmFja2luZ1N0b3JlKCkKK3sKKyAgICBpZiAoIWlz RGV0YWNoZWQoKSkKKyAgICAgICAgbV9wcml2YXRlLT51cGRhdGVCYWNraW5nU3RvcmUoKTsKKyAg ICByZXR1cm4gIWlzRGV0YWNoZWQoKTsKK30KKwogV2ViU3RyaW5nIFdlYkFjY2Vzc2liaWxpdHlP YmplY3Q6OmFjY2Vzc2liaWxpdHlEZXNjcmlwdGlvbigpIGNvbnN0CiB7CiAgICAgaWYgKGlzRGV0 YWNoZWQoKSkK 160515 2012-08-24 15:50:37 -0700 2012-08-24 17:33:39 -0700 Patch for landing bug-94611-20120824155033.patch text/plain 3240 dmazzoni U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDU5OGI5MjM2MTAzNTQzYWU1NTAxNTUwMmIxMTI3ZjRmM2FlZTcxYzUuLmJiNzUzYzI1YWJhOWQz YzRmMGRjYjM1MTBiMTExNGY0ZmQxZmMxODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDgtMjEgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdv b2dsZS5jb20+CisKKyAgICAgICAgQ2hyb21pdW06IFdlYkFjY2Vzc2liaWxpdHlPYmplY3Qgc2hv dWxkIGV4cG9zZSB1cGRhdGVCYWNraW5nU3RvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMg RmxlaXphY2guCisKKyAgICAgICAgVGhpcyBjaGFuZ2UganVzdCBleHBvc2VzIGEgbWV0aG9kLCB3 aXRoIG5vIG5ldyB0ZXN0cy4gTmV4dCwgQ2hyb21pdW0KKyAgICAgICAgd2lsbCBiZSBtb2RpZmll ZCB0byBjYWxsIHRoaXMgbmV3IG1ldGhvZCwgYW5kIHRoaXMgd2lsbCBiZSBmb2xsb3dlZAorICAg ICAgICBieSBhIGNoYW5nZSB0aGF0IGdldHMgcmlkIG9mIGNhbGxzIHRvIHVwZGF0ZUJhY2tpbmdT dG9yZSB1bmRlciB0aGUKKyAgICAgICAgaG9vZC4gVGhhdCBsYXN0IGNoYW5nZSBtYXkgYWRkIGEg dGVzdCBvciB1cGRhdGUgYW4gZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIHB1YmxpYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0KToK KyAgICAgICAgKiBzcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OnVwZGF0ZUJhY2tpbmdTdG9yZUFuZENoZWNrVmFs aWRpdHkpOgorICAgICAgICAoV2ViS2l0KToKKwogMjAxMi0wOC0yMyAgRGFuYSBKYW5zZW5zICA8 ZGFuYWtqQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIENyZWF0ZSBzaGFyZWRR dWFkU3RhdGUgYXQgc2FtZSB0aW1lIGFzIGNyZWF0aW5nIHF1YWRzIGFuZCBnaXZlIHRoZW0gdG8g dGhlIHF1YWRTaW5rCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgKaW5kZXggMDI5ZjQzODcyMjc2M2RhZjFlMTg0MjA0YTMy YTIwMjA3OTY5MWUyMi4uZTBjMjg4ODliMGY1YWY5Y2QyNzgyMmRkYWQzODgxY2E4Y2Y0YTYwNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkFjY2Vzc2li aWxpdHlPYmplY3QuaApAQCAtNjksNiArNjksNyBAQCBwdWJsaWM6CiAgICAgV0VCS0lUX0VYUE9S VCBib29sIGVxdWFscyhjb25zdCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0JikgY29uc3Q7CiAKICAg ICBib29sIGlzTnVsbCgpIGNvbnN0IHsgcmV0dXJuIG1fcHJpdmF0ZS5pc051bGwoKTsgfQorICAg IC8vIGlzRGV0YWNoZWQgYWxzbyBjaGVja3MgZm9yIG51bGwsIHNvIGl0J3Mgc2FmZSB0byBqdXN0 IGNhbGwgaXNEZXRhY2hlZC4KICAgICBXRUJLSVRfRVhQT1JUIGJvb2wgaXNEZXRhY2hlZCgpIGNv bnN0OwogCiAgICAgLy8gU3RhdGljIG1ldGhvZHMgZm9yIGVuYWJsaW5nIGFjY2Vzc2liaWxpdHku CkBAIC03Nyw2ICs3OCwxMyBAQCBwdWJsaWM6CiAKICAgICBXRUJLSVRfRVhQT1JUIGludCBheElE KCkgY29uc3Q7CiAKKyAgICAvLyBVcGRhdGUgdGhlIHVuZGVybHlpbmcgdHJlZSwgYW5kIHJldHVy biB0cnVlIGlmIHRoaXMgb2JqZWN0IGlzCisgICAgLy8gc3RpbGwgdmFsaWQgKG5vdCBkZXRhY2hl ZCkuIE5vdGUgdGhhdCBjYWxsaW5nIHRoaXMgbWV0aG9kCisgICAgLy8gY2FuIGNhdXNlIG90aGVy IFdlYkFjY2Vzc2liaWxpdHlPYmplY3RzIHRvIGJlY29tZSBpbnZhbGlkLCB0b28sCisgICAgLy8g c28gYWx3YXlzIGNhbGwgaXNEZXRhY2hlZCBpZiB1cGRhdGVCYWNraW5nU3RvcmVBbmRDaGVja1Zh bGlkaXR5CisgICAgLy8gaGFzIGJlZW4gY2FsbGVkIG9uIGFueSBvYmplY3QsIG9yIGlmIGFueSBv dGhlciBXZWJDb3JlIGNvZGUgaGFzIHJ1bi4KKyAgICBXRUJLSVRfRVhQT1JUIGJvb2wgdXBkYXRl QmFja2luZ1N0b3JlQW5kQ2hlY2tWYWxpZGl0eSgpOworCiAgICAgV0VCS0lUX0VYUE9SVCBXZWJT dHJpbmcgYWNjZXNzaWJpbGl0eURlc2NyaXB0aW9uKCkgY29uc3Q7CiAgICAgV0VCS0lUX0VYUE9S VCBXZWJTdHJpbmcgYWN0aW9uVmVyYigpIGNvbnN0OwogICAgIFdFQktJVF9FWFBPUlQgYm9vbCBj YW5TZXRGb2N1c0F0dHJpYnV0ZSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCAxZWI2OWQyOGZhYmUw MWFiMmM2ODllMTYwNTg3MTIzZjBmMmQwOTgxLi5lOWE5N2U4MmU1Njg0NWQzMTc1NTc5ZjZjMDQz NzNkODY3YWViZDBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcApAQCAtOTksNiArOTksMTMgQEAgaW50IFdlYkFjY2Vz c2liaWxpdHlPYmplY3Q6OmF4SUQoKSBjb25zdAogICAgIHJldHVybiBtX3ByaXZhdGUtPmF4T2Jq ZWN0SUQoKTsKIH0KIAorYm9vbCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0Ojp1cGRhdGVCYWNraW5n U3RvcmVBbmRDaGVja1ZhbGlkaXR5KCkKK3sKKyAgICBpZiAoIWlzRGV0YWNoZWQoKSkKKyAgICAg ICAgbV9wcml2YXRlLT51cGRhdGVCYWNraW5nU3RvcmUoKTsKKyAgICByZXR1cm4gIWlzRGV0YWNo ZWQoKTsKK30KKwogV2ViU3RyaW5nIFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OmFjY2Vzc2liaWxp dHlEZXNjcmlwdGlvbigpIGNvbnN0CiB7CiAgICAgaWYgKGlzRGV0YWNoZWQoKSkK