94602 2012-08-21 07:56:19 -0700 [Chromium/Skia] Filters should flush the SkCanvas 2012-08-21 17:06:03 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bsalomon bsalomon cc-bugs jamesr senorblanco webkit.review.bot oldest_to_newest 700758 0 bsalomon 2012-08-21 07:56:19 -0700 [Chromium/Skia] Filters should flush the SkCanvas 700761 1 159690 bsalomon 2012-08-21 07:59:54 -0700 Created attachment 159690 Patch 700764 2 159690 senorblanco 2012-08-21 08:02:05 -0700 Comment on attachment 159690 Patch Looks good, bots willing. r=me 700945 3 159690 jamesr 2012-08-21 11:19:28 -0700 Comment on attachment 159690 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159690&action=review > Source/WebCore/ChangeLog:10 > + Covered by existing css3/filters layout tests. Were any of these failing before? Will they start passing now? 700963 4 senorblanco 2012-08-21 11:41:18 -0700 (In reply to comment #3) > (From update of attachment 159690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159690&action=review > > > Source/WebCore/ChangeLog:10 > > + Covered by existing css3/filters layout tests. > > Were any of these failing before? Will they start passing now? They would fail (and did fail on the trybots) if we rolled past Brian's skia change we removes an implicit flush for filters. This is a preemptive change necessary for that roll. 700995 5 jamesr 2012-08-21 12:24:48 -0700 Ah, OK. Cool! 701326 6 159690 webkit.review.bot 2012-08-21 17:06:00 -0700 Comment on attachment 159690 Patch Clearing flags on attachment: 159690 Committed r126226: <http://trac.webkit.org/changeset/126226> 701327 7 webkit.review.bot 2012-08-21 17:06:03 -0700 All reviewed patches have been landed. Closing bug. 159690 2012-08-21 07:59:54 -0700 2012-08-21 17:06:00 -0700 Patch bug-94602-20120821105953.patch text/plain 1282 bsalomon SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjE1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTIxICBCcmlhbiBT YWxvbW9uICA8YnNhbG9tb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBbQ2hyb21pdW0vU2tpYV0g RmlsdGVycyBzaG91bGQgZmx1c2ggdGhlIFNrQ2FudmFzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDYwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBTa0NhbnZhczo6Zmx1c2ggY2FsbCB0byBG aWx0ZXJCdWZmZXJTdGF0ZTo6c3dhcCgpIHRvIGVuc3VyZSB0aGUgdGV4dHVyZXMgYXJlIHVwZGF0 ZWQgYmVmb3JlIHRoZXkgYXJlIGNvbnN1bWVkIGJ5IHRoZSBjb21wb3NpdG9yLgorCisgICAgICAg IENvdmVyZWQgYnkgZXhpc3RpbmcgY3NzMy9maWx0ZXJzIGxheW91dCB0ZXN0cy4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnMu Y3BwOgorCiAyMDEyLTA4LTIxICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOTUk6IE93blB0cjxUPiB3YXMgY291bnRlZCBh cyBSZWZQdHI8VD4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRl cnMuY3BwCShyZXZpc2lvbiAxMjYxNTYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2VGaWx0ZXJzLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzA0LDYgKzMwNCw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc3dhcCgpCiAgICAgewor ICAgICAgICBtX2NhbnZhcy0+Zmx1c2goKTsKICAgICAgICAgbV9jYW52YXMucmVzZXQoMCk7CiAg ICAgICAgIG1fZGV2aWNlLnJlc2V0KDApOwogCg==