94598 2012-08-21 07:19:23 -0700 [V8] Move reportUnsafeAccessTo() from V8Proxy to BindingSecurity 2012-08-21 09:07:47 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 85330 1 haraken haraken abarth gustavo japhet philn webkit.review.bot xan.lopez oldest_to_newest 700727 0 haraken 2012-08-21 07:19:23 -0700 To kill V8Proxy, we can move reportUnsafeAccessTo() from V8Proxy to BindingSecurity. 700732 1 159685 haraken 2012-08-21 07:25:09 -0700 Created attachment 159685 Patch 700743 2 159685 webkit-ews 2012-08-21 07:42:37 -0700 Comment on attachment 159685 Patch Attachment 159685 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13543788 700750 3 159685 buildbot 2012-08-21 07:48:24 -0700 Comment on attachment 159685 Patch Attachment 159685 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13556093 700755 4 159685 webkit-ews 2012-08-21 07:51:37 -0700 Comment on attachment 159685 Patch Attachment 159685 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13545547 700788 5 159685 gyuyoung.kim 2012-08-21 08:24:12 -0700 Comment on attachment 159685 Patch Attachment 159685 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13550375 700801 6 159685 abarth 2012-08-21 08:39:48 -0700 Comment on attachment 159685 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159685&action=review This isn't quite right. BindingSecurity.cpp is part of the "generic bindings", which means it's shared by JavaScriptCore and V8. JavaScriptCore has a much better implementation of this function. I'd like to delete the V8 implementation and share the better JSC implementation. I'll try to get that done in the next day or two. > Source/WebCore/bindings/generic/BindingSecurity.cpp:86 > + Frame* source = firstFrame(BindingState::instance()); The proximate problem is that you can't use BindingState::instance() outside of V8 because in JavaScriptCore, BindingState is the ExecState and JavaScriptCore doesn't keep the ExecState in a static the same way that V8 does. 700814 7 haraken 2012-08-21 09:07:47 -0700 (In reply to comment #6) > This isn't quite right. BindingSecurity.cpp is part of the "generic bindings", which means it's shared by JavaScriptCore and V8. JavaScriptCore has a much better implementation of this function. I'd like to delete the V8 implementation and share the better JSC implementation. I'll try to get that done in the next day or two. Makes sense. Then let me wait for your fix. (I'm not in a hurry:) Marking INVALID. 159685 2012-08-21 07:25:09 -0700 2012-08-21 08:39:48 -0700 Patch bug-94598-20120821232508.patch text/plain 10048 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjFhNTc1ZmE1OGUzOWM3 NmZjZjNmOTY1Y2ZhMmYwZTM3ZDY5ZWM0NC4uNTcwMTQwNjUwMWE2NTFjMGY1NTQxYWU4YjVkNDA3 ODg3MzQ1YTJhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDEyLTA4LTIxICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgcmVw b3J0VW5zYWZlQWNjZXNzVG8oKSBmcm9tIFY4UHJveHkgdG8gQmluZGluZ1NlY3VyaXR5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU5OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGtpbGwgVjhQcm94 eSwgd2UgY2FuIG1vdmUgcmVwb3J0VW5zYWZlQWNjZXNzVG8oKSBmcm9tIFY4UHJveHkKKyAgICAg ICAgdG8gQmluZGluZ1NlY3VyaXR5LgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4g YmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy9nZW5lcmljL0JpbmRpbmdTZWN1cml0eS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpCaW5kaW5nU2VjdXJpdHk6OnJlcG9ydFVuc2FmZUFjY2Vz c1RvKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGJpbmRpbmdzL2dlbmVyaWMvQmlu ZGluZ1NlY3VyaXR5Lmg6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKEJpbmRpbmdTZWN1 cml0eSk6CisgICAgICAgICogYmluZGluZ3MvanMvQmluZGluZ1N0YXRlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkJpbmRpbmdTdGF0ZTo6aW5zdGFuY2UpOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgICogYmluZGluZ3MvanMvQmluZGluZ1N0YXRlLmg6CisgICAgICAgIChCaW5kaW5nU3Rh dGUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L0JpbmRpbmdTdGF0ZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjppbW1lZGlhdGVseVJlcG9ydFVuc2FmZUFjY2Vzc1RvKToKKyAgICAgICAgKiBiaW5k aW5ncy92OC9WOEJpbmRpbmcuY3BwOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV2luZG93 U2hlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVwb3J0VW5zYWZlSmF2YVNjcmlwdEFjY2Vz cyk6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5jcHA6CisgICAgICAgICogYmluZGlu Z3MvdjgvVjhQcm94eS5oOgorICAgICAgICAoVjhQcm94eSk6CisKIDIwMTItMDgtMTcgIFNpbW9u IEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gUkVH UkVTU0lPTihyMTI1NDI4KTogZmFzdC9wcm9maWxlci9uZXN0ZWQtc3RhcnQtYW5kLXN0b3AtcHJv ZmlsZXIuaHRtbCBmYWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2Vu ZXJpYy9CaW5kaW5nU2VjdXJpdHkuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJp Yy9CaW5kaW5nU2VjdXJpdHkuY3BwCmluZGV4IDhkZGU2ODViNTU3OWVkMTNiZDUxNTBlZTIwMjZh ZDllZmE5NGI3YTMuLmNlODUwODBiMTgzMTc0YjRjNGUwMzg2MDExZWJiNDhlYmU4MGQ3MWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvQmluZGluZ1NlY3VyaXR5 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL0JpbmRpbmdTZWN1cml0 eS5jcHAKQEAgLTM3LDYgKzM3LDggQEAKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkhU TUxGcmFtZUVsZW1lbnRCYXNlLmgiCiAjaW5jbHVkZSAiSFRNTFBhcnNlcklkaW9tcy5oIgorI2lu Y2x1ZGUgIlNjcmlwdENhbGxTdGFjay5oIgorI2luY2x1ZGUgIlNjcmlwdENhbGxTdGFja0ZhY3Rv cnkuaCIKICNpbmNsdWRlICJTZWN1cml0eU9yaWdpbi5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgi CiAKQEAgLTc1LDQgKzc3LDMxIEBAIGJvb2wgQmluZGluZ1NlY3VyaXR5OjphbGxvd1NldHRpbmdG cmFtZVNyY1RvSmF2YXNjcmlwdFVybChCaW5kaW5nU3RhdGUqIHN0YXRlLCBICiAgICAgcmV0dXJu ICFwcm90b2NvbElzSmF2YVNjcmlwdChzdHJpcExlYWRpbmdBbmRUcmFpbGluZ0hUTUxTcGFjZXMo dmFsdWUpKSB8fCBjYW5BY2Nlc3NEb2N1bWVudChzdGF0ZSwgZnJhbWUtPmNvbnRlbnREb2N1bWVu dCgpKTsKIH0KIAordm9pZCBCaW5kaW5nU2VjdXJpdHk6OnJlcG9ydFVuc2FmZUFjY2Vzc1RvKERv Y3VtZW50KiB0YXJnZXREb2N1bWVudCkKK3sKKyAgICBpZiAoIXRhcmdldERvY3VtZW50KQorICAg ICAgICByZXR1cm47CisKKyAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIHBhc3MgYm90aCB0aGUgYWN0 aXZlIGFuZCB0YXJnZXQgZG9jdW1lbnRzIGluIGFzIGFyZ3VtZW50cy4KKyAgICBGcmFtZSogc291 cmNlID0gZmlyc3RGcmFtZShCaW5kaW5nU3RhdGU6Omluc3RhbmNlKCkpOworICAgIGlmICghc291 cmNlKQorICAgICAgICByZXR1cm47CisKKyAgICBEb2N1bWVudCogc291cmNlRG9jdW1lbnQgPSBz b3VyY2UtPmRvY3VtZW50KCk7CisgICAgaWYgKCFzb3VyY2VEb2N1bWVudCkKKyAgICAgICAgcmV0 dXJuOyAvLyBJZ25vcmUgZXJyb3IgaWYgdGhlIHNvdXJjZSBkb2N1bWVudCBpcyBnb25lLgorCisg ICAgLy8gRklYTUU6IFRoaXMgZXJyb3IgbWVzc2FnZSBzaG91bGQgY29udGFpbiBtb3JlIHNwZWNp ZmljcyBvZiB3aHkgdGhlIHNhbWUKKyAgICAvLyBvcmlnaW4gY2hlY2sgaGFzIGZhaWxlZC4KKyAg ICBTdHJpbmcgc3RyID0gIlVuc2FmZSBKYXZhU2NyaXB0IGF0dGVtcHQgdG8gYWNjZXNzIGZyYW1l IHdpdGggVVJMICIgKyB0YXJnZXREb2N1bWVudC0+dXJsKCkuc3RyaW5nKCkgKworICAgICAgICAg ICAgICAgICAiIGZyb20gZnJhbWUgd2l0aCBVUkwgIiArIHNvdXJjZURvY3VtZW50LT51cmwoKS5z dHJpbmcoKSArICIuIERvbWFpbnMsIHByb3RvY29scyBhbmQgcG9ydHMgbXVzdCBtYXRjaC5cbiI7 CisKKyAgICBSZWZQdHI8U2NyaXB0Q2FsbFN0YWNrPiBzdGFja1RyYWNlID0gY3JlYXRlU2NyaXB0 Q2FsbFN0YWNrKFNjcmlwdENhbGxTdGFjazo6bWF4Q2FsbFN0YWNrU2l6ZVRvQ2FwdHVyZSwgdHJ1 ZSk7CisKKyAgICAvLyBOT1RFOiBTYWZhcmkgcHJpbnRzIHRoZSBtZXNzYWdlIGluIHRoZSB0YXJn ZXQgcGFnZSwgYnV0IGl0IHNlZW1zIGxpa2UKKyAgICAvLyBpdCBzaG91bGQgYmUgaW4gdGhlIHNv dXJjZSBwYWdlLiBFdmVuIGZvciBkZWxheWVkIG1lc3NhZ2VzLCB3ZSBwdXQgaXQgaW4KKyAgICAv LyB0aGUgc291cmNlIHBhZ2UuCisgICAgc291cmNlRG9jdW1lbnQtPmFkZENvbnNvbGVNZXNzYWdl KEpTTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIEVycm9yTWVzc2FnZUxldmVsLCBzdHIs IHN0YWNrVHJhY2UucmVsZWFzZSgpKTsKK30KKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvZ2VuZXJpYy9CaW5kaW5nU2VjdXJpdHkuaCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2dlbmVyaWMvQmluZGluZ1NlY3VyaXR5LmgKaW5kZXggOTlkN2YwMDk3NzExYzQwNzMw MTBhZjhkYjVhZmY3NjgzODQzMzhlNy4uODU2NTczNWE1N2U0MTBmYTA5ODlmYTY2NTEwYWJjYWY5 MGEzOGM3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9CaW5k aW5nU2VjdXJpdHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL0JpbmRp bmdTZWN1cml0eS5oCkBAIC0zMSwxMSArMzEsMTMgQEAKICNpZm5kZWYgQmluZGluZ1NlY3VyaXR5 X2gKICNkZWZpbmUgQmluZGluZ1NlY3VyaXR5X2gKIAotI2luY2x1ZGUgIkJpbmRpbmdTdGF0ZS5o IgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKK2NsYXNzIEJpbmRpbmdTdGF0ZTsKK2NsYXNzIERvY3VtZW50OworY2xhc3MgRnJhbWU7CiBj bGFzcyBIVE1MRnJhbWVFbGVtZW50QmFzZTsKIGNsYXNzIE5vZGU7CiAKQEAgLTQ5LDYgKzUxLDcg QEAgcHVibGljOgogICAgIHN0YXRpYyBib29sIHNob3VsZEFsbG93QWNjZXNzVG9Ob2RlKEJpbmRp bmdTdGF0ZSosIE5vZGUqKTsKICAgICBzdGF0aWMgYm9vbCBzaG91bGRBbGxvd0FjY2Vzc1RvRnJh bWUoQmluZGluZ1N0YXRlKiwgRnJhbWUqLCBTZWN1cml0eVJlcG9ydGluZ09wdGlvbiA9IFJlcG9y dFNlY3VyaXR5RXJyb3IpOwogICAgIHN0YXRpYyBib29sIGFsbG93U2V0dGluZ0ZyYW1lU3JjVG9K YXZhc2NyaXB0VXJsKEJpbmRpbmdTdGF0ZSosIEhUTUxGcmFtZUVsZW1lbnRCYXNlKiwgY29uc3Qg U3RyaW5nJiB2YWx1ZSk7CisgICAgc3RhdGljIHZvaWQgcmVwb3J0VW5zYWZlQWNjZXNzVG8oRG9j dW1lbnQqKTsKIH07CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0JpbmRpbmdTdGF0ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9CaW5kaW5nU3Rh dGUuY3BwCmluZGV4IDcyYTJhOGExMzgyOTZmYjMwNzBhNGM4YzVlNmEwNTlkNzU4Y2Y4MDcuLjEz M2FiOGRhMDk2YTIxNjZhMjIzM2M1ZTA3NWY0N2ZhZmEyZTQwYTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0JpbmRpbmdTdGF0ZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvQmluZGluZ1N0YXRlLmNwcApAQCAtMzcsNiArMzcsMTIgQEAgdXNpbmcg bmFtZXNwYWNlIEpTQzsKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitCaW5kaW5nU3RhdGUqIEJp bmRpbmdTdGF0ZTo6aW5zdGFuY2UoKQoreworICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgdGhpcy4K KyAgICByZXR1cm4gMDsKK30KKwogRE9NV2luZG93KiBhY3RpdmVET01XaW5kb3coRXhlY1N0YXRl KiBleGVjKQogewogICAgIHJldHVybiBhc0pTRE9NV2luZG93KGV4ZWMtPmxleGljYWxHbG9iYWxP YmplY3QoKSktPmltcGwoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0JpbmRpbmdTdGF0ZS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvQmluZGluZ1N0YXRl LmgKaW5kZXggZGUxMzBmZTJiMWNjMGY0Mjk4MTMxZWUwNWFkMzI4MTg4M2M0ZTU4ZS4uM2ZiNDBi MWMyYjdhZGRkZDhkNjM4NmMzZTg0OWQyZTc0NTQ3M2UwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvQmluZGluZ1N0YXRlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvQmluZGluZ1N0YXRlLmgKQEAgLTM5LDcgKzM5LDEwIEBAIGNsYXNzIERPTVdpbmRv dzsKIGNsYXNzIERvY3VtZW50OwogY2xhc3MgRnJhbWU7CiAKLXR5cGVkZWYgSlNDOjpFeGVjU3Rh dGUgQmluZGluZ1N0YXRlOworY2xhc3MgQmluZGluZ1N0YXRlIHsKK3B1YmxpYzoKKyAgICBzdGF0 aWMgQmluZGluZ1N0YXRlKiBpbnN0YW5jZSgpOworfTsKIAogRE9NV2luZG93KiBhY3RpdmVET01X aW5kb3coQmluZGluZ1N0YXRlKik7CiBET01XaW5kb3cqIGZpcnN0RE9NV2luZG93KEJpbmRpbmdT dGF0ZSopOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvQmluZGluZ1N0 YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0JpbmRpbmdTdGF0ZS5jcHAKaW5k ZXggYThlM2U2OTMzNmJlNGViMzkxNzkyYTVmZjA3ZWE5MDFhZjZhZjhlNC4uNjNlMTRmMDY2ZWFj NDUxZTM2Njg3MTRkMTI1MTk4ZDk1MDQ2ODcwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvQmluZGluZ1N0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9CaW5kaW5nU3RhdGUuY3BwCkBAIC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiY29uZmln LmgiCiAjaW5jbHVkZSAiQmluZGluZ1N0YXRlLmgiCiAKKyNpbmNsdWRlICJCaW5kaW5nU2VjdXJp dHkuaCIKICNpbmNsdWRlICJET01XaW5kb3cuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1 ZGUgIlNjcmlwdENvbnRyb2xsZXIuaCIKQEAgLTEwMCw3ICsxMDEsNyBAQCBEb2N1bWVudCogY3Vy cmVudERvY3VtZW50KEJpbmRpbmdTdGF0ZSopCiAKIHZvaWQgaW1tZWRpYXRlbHlSZXBvcnRVbnNh ZmVBY2Nlc3NUbyhCaW5kaW5nU3RhdGUqLCBEb2N1bWVudCogdGFyZ2V0RG9jdW1lbnQpCiB7Ci0g ICAgVjhQcm94eTo6cmVwb3J0VW5zYWZlQWNjZXNzVG8odGFyZ2V0RG9jdW1lbnQpOworICAgIEJp bmRpbmdTZWN1cml0eTo6cmVwb3J0VW5zYWZlQWNjZXNzVG8odGFyZ2V0RG9jdW1lbnQpOwogfQog CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3Bw IGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAppbmRleCA2NDljZWI5 YzE5OWMwZDIzMmE4NmJlZjVlMjNiNWZkMzhmNjIxNTQ3Li44NWY3NGJmODI5N2I3NjQ0ZTYxNjM2 Y2I1ZmM0ZWVlN2YxODNiMDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGlu Zy5jcHAKQEAgLTQzLDYgKzQzLDggQEAKICNpbmNsdWRlICJWOERPTVdpbmRvdy5oIgogI2luY2x1 ZGUgIlY4RWxlbWVudC5oIgogI2luY2x1ZGUgIlY4T2JqZWN0Q29uc3RydWN0b3IuaCIKKyNpbmNs dWRlICJXb3JrZXJDb250ZXh0LmgiCisjaW5jbHVkZSAiV29ya2VyQ29udGV4dEV4ZWN1dGlvblBy b3h5LmgiCiAKICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9NYWlu VGhyZWFkLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdp bmRvd1NoZWxsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hl bGwuY3BwCmluZGV4IDM3OGZmMmQ1YjczNzRhMWE1MjVjMTVmYTdlMWRjNzNlMGY3NjA1ZjUuLjI4 NjEwZmUyODAwM2Q2NTkxY2E3ODc4MTlmYjkyNjUzMDYwNTEyZmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hlbGwuY3BwCkBAIC0zMSw2ICszMSw3IEBA CiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiVjhET01XaW5kb3dTaGVsbC5oIgogCisj aW5jbHVkZSAiQmluZGluZ1NlY3VyaXR5LmgiCiAjaW5jbHVkZSAiQmluZGluZ1N0YXRlLmgiCiAj aW5jbHVkZSAiQ29udGVudFNlY3VyaXR5UG9saWN5LmgiCiAjaW5jbHVkZSAiRGF0ZUV4dGVuc2lv bi5oIgpAQCAtMTU0LDcgKzE1NSw3IEBAIHN0YXRpYyB2b2lkIHJlcG9ydFVuc2FmZUphdmFTY3Jp cHRBY2Nlc3Modjg6OkxvY2FsPHY4OjpPYmplY3Q+IGhvc3QsIHY4OjpBY2Nlc3NUCiB7CiAgICAg RnJhbWUqIHRhcmdldCA9IGdldFRhcmdldEZyYW1lKGhvc3QsIGRhdGEpOwogICAgIGlmICh0YXJn ZXQpCi0gICAgICAgIFY4UHJveHk6OnJlcG9ydFVuc2FmZUFjY2Vzc1RvKHRhcmdldC0+ZG9jdW1l bnQoKSk7CisgICAgICAgIEJpbmRpbmdTZWN1cml0eTo6cmVwb3J0VW5zYWZlQWNjZXNzVG8odGFy Z2V0LT5kb2N1bWVudCgpKTsKIH0KIAogUGFzc1JlZlB0cjxWOERPTVdpbmRvd1NoZWxsPiBWOERP TVdpbmRvd1NoZWxsOjpjcmVhdGUoRnJhbWUqIGZyYW1lKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOFByb3h5LmNwcAppbmRleCBiMWEwZmEwYTQwMDBlNTRiYTQ1YWJkMGJjMmI5NGU3ZDdjM2Y2 NGI0Li40NTkzYmM3NWUwNjg1MDNmYTEwN2FkMzQ0YTEzYjNlMGYzZGViMzYyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcApAQCAtNzcsMzMgKzc3LDYgQEAKIAogbmFtZXNw YWNlIFdlYkNvcmUgewogCi12b2lkIFY4UHJveHk6OnJlcG9ydFVuc2FmZUFjY2Vzc1RvKERvY3Vt ZW50KiB0YXJnZXREb2N1bWVudCkKLXsKLSAgICBpZiAoIXRhcmdldERvY3VtZW50KQotICAgICAg ICByZXR1cm47Ci0KLSAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIHBhc3MgYm90aCB0aGUgYWN0aXZl IGFuZCB0YXJnZXQgZG9jdW1lbnRzIGluIGFzIGFyZ3VtZW50cy4KLSAgICBGcmFtZSogc291cmNl ID0gZmlyc3RGcmFtZShCaW5kaW5nU3RhdGU6Omluc3RhbmNlKCkpOwotICAgIGlmICghc291cmNl KQotICAgICAgICByZXR1cm47Ci0KLSAgICBEb2N1bWVudCogc291cmNlRG9jdW1lbnQgPSBzb3Vy Y2UtPmRvY3VtZW50KCk7Ci0gICAgaWYgKCFzb3VyY2VEb2N1bWVudCkKLSAgICAgICAgcmV0dXJu OyAvLyBJZ25vcmUgZXJyb3IgaWYgdGhlIHNvdXJjZSBkb2N1bWVudCBpcyBnb25lLgotCi0gICAg Ly8gRklYTUU6IFRoaXMgZXJyb3IgbWVzc2FnZSBzaG91bGQgY29udGFpbiBtb3JlIHNwZWNpZmlj cyBvZiB3aHkgdGhlIHNhbWUKLSAgICAvLyBvcmlnaW4gY2hlY2sgaGFzIGZhaWxlZC4KLSAgICBT dHJpbmcgc3RyID0gIlVuc2FmZSBKYXZhU2NyaXB0IGF0dGVtcHQgdG8gYWNjZXNzIGZyYW1lIHdp dGggVVJMICIgKyB0YXJnZXREb2N1bWVudC0+dXJsKCkuc3RyaW5nKCkgKwotICAgICAgICAgICAg ICAgICAiIGZyb20gZnJhbWUgd2l0aCBVUkwgIiArIHNvdXJjZURvY3VtZW50LT51cmwoKS5zdHJp bmcoKSArICIuIERvbWFpbnMsIHByb3RvY29scyBhbmQgcG9ydHMgbXVzdCBtYXRjaC5cbiI7Ci0K LSAgICBSZWZQdHI8U2NyaXB0Q2FsbFN0YWNrPiBzdGFja1RyYWNlID0gY3JlYXRlU2NyaXB0Q2Fs bFN0YWNrKFNjcmlwdENhbGxTdGFjazo6bWF4Q2FsbFN0YWNrU2l6ZVRvQ2FwdHVyZSwgdHJ1ZSk7 Ci0KLSAgICAvLyBOT1RFOiBTYWZhcmkgcHJpbnRzIHRoZSBtZXNzYWdlIGluIHRoZSB0YXJnZXQg cGFnZSwgYnV0IGl0IHNlZW1zIGxpa2UKLSAgICAvLyBpdCBzaG91bGQgYmUgaW4gdGhlIHNvdXJj ZSBwYWdlLiBFdmVuIGZvciBkZWxheWVkIG1lc3NhZ2VzLCB3ZSBwdXQgaXQgaW4KLSAgICAvLyB0 aGUgc291cmNlIHBhZ2UuCi0gICAgc291cmNlRG9jdW1lbnQtPmFkZENvbnNvbGVNZXNzYWdlKEpT TWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIEVycm9yTWVzc2FnZUxldmVsLCBzdHIsIHN0 YWNrVHJhY2UucmVsZWFzZSgpKTsKLX0KLQogLy8gRklYTUU6IFRoaXMgd2lsbCBiZSBzb29uIHJl bW92ZWQgd2hlbiB3ZSBtb3ZlIHJ1blNjcmlwdCgpIHRvIFNjcmlwdENvbnRyb2xsZXIuCiBzdGF0 aWMgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gaGFuZGxlTWF4UmVjdXJzaW9uRGVwdGhFeGNlZWRlZCgp CiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmggYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKaW5kZXggMWUzZDY3YjQ2ODdlZDYw MmFlYmYyYmJjYjk5NzhlYmQzOTgxZGNlYi4uYTRhYWVkZDlkNzYyY2RkM2JkMzI5OWI0MTAwNDQz ZTY5ZmQ2MzdlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94 eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaApAQCAtMTE1LDgg KzExNSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgLy8gd2lsbCBiZSBtb3ZlZCB0 byBTY3JpcHRDb250cm9sbGVyLgogICAgICAgICBWOERPTVdpbmRvd1NoZWxsKiB3aW5kb3dTaGVs bCgpIGNvbnN0OwogCi0gICAgICAgIHN0YXRpYyB2b2lkIHJlcG9ydFVuc2FmZUFjY2Vzc1RvKERv Y3VtZW50KiB0YXJnZXREb2N1bWVudCk7Ci0KICAgICAgICAgLy8gRklYTUU6IE1vdmUgbV9pc29s YXRlZFdvcmxkcyB0byBTY3JpcHRDb250cm9sbGVyIGFuZCByZW1vdmUgdGhpcyBnZXR0ZXIuCiAg ICAgICAgIElzb2xhdGVkV29ybGRNYXAmIGlzb2xhdGVkV29ybGRzKCkgeyByZXR1cm4gbV9pc29s YXRlZFdvcmxkczsgfQogCg==