94592 2012-08-21 05:47:56 -0700 Web Inspector: remove DOMNodeRemoved listener from the DefaultTextEditor 2012-08-21 16:18:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman aandrey apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 700665 0 pfeldman 2012-08-21 05:47:56 -0700 It seems to be not necessary. 700670 1 159668 pfeldman 2012-08-21 05:50:50 -0700 Created attachment 159668 Patch 700688 2 aandrey 2012-08-21 06:13:04 -0700 LGTM 701259 3 159668 webkit.review.bot 2012-08-21 16:18:47 -0700 Comment on attachment 159668 Patch Clearing flags on attachment: 159668 Committed r126210: <http://trac.webkit.org/changeset/126210> 701260 4 webkit.review.bot 2012-08-21 16:18:50 -0700 All reviewed patches have been landed. Closing bug. 159668 2012-08-21 05:50:50 -0700 2012-08-21 16:18:47 -0700 Patch bug-94592-20120821165009.patch text/plain 5171 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTg1MGFkOWI3YTE0NDUx ZDU0NDE5NzBlMTBkNmJlOGQwNTQ1OTkyNS4uOGVmMWRkMTliYTFkZmI2OWVmYmU0ODFjNTdjZDJj ODcxMDg3ZjI4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTIxICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHJlbW92ZSBET01Ob2RlUmVtb3ZlZCBsaXN0ZW5lciBmcm9tIHRoZSBEZWZhdWx0VGV4dEVk aXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ1 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBz ZWVtcyB0byBiZSBub3QgbmVjZXNzYXJ5LgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9EZWZhdWx0VGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y TWFpblBhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnBy b3RvdHlwZS5faGFuZGxlRE9NVXBkYXRlcyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVk aXRvck1haW5DaHVuayk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5DaHVu ay5wcm90b3R5cGUuc2V0IGV4cGFuZGVkKToKKwogMjAxMi0wOC0yMCAgS2VudGFybyBIYXJhICA8 aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBNb3ZlIFN0cmluZyByZWxhdGVk IGNvZGUgaW4gVjhCaW5kaW5nIHRvIGEgc2VwYXJhdGUgZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVsdFRleHRFZGl0b3IuanMKaW5kZXgg MjE5NjE2NmFkYTk3OWI2OGQ5MDczNGJjYTBmYWQ4NzJhZmNjNzFiNS4uOTE3OTE0ZDljNWIwMDc4 YjA4ZmFhYmI2NTFhNWM0ZTdjNGU3MGQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9EZWZhdWx0VGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9yLmpzCkBAIC0xMjM2LDExICsx MjM2LDYgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwgPSBmdW5jdGlvbih0ZXh0 TW9kZWwsIHVybCwgc3luY1Njcm9sbExpc3RlbmVyLAogICAgIHRoaXMuZWxlbWVudC5hZGRFdmVu dExpc3RlbmVyKCJzY3JvbGwiLCB0aGlzLl9zY3JvbGwuYmluZCh0aGlzKSwgZmFsc2UpOwogICAg IHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJmb2N1cyIsIHRoaXMuX2hhbmRsZUVsZW1l bnRGb2N1cy5iaW5kKHRoaXMpLCBmYWxzZSk7CiAKLSAgICAvLyBJbiBXZWJLaXQgdGhlIERPTU5v ZGVSZW1vdmVkIGV2ZW50IGlzIGZpcmVkIEFGVEVSIHRoZSBub2RlIGlzIHJlbW92ZWQsIHRodXMg aXQgc2hvdWxkIGJlCi0gICAgLy8gYXR0YWNoZWQgdG8gYWxsIERPTSBub2RlcyB0aGF0IHdlIHdh bnQgdG8gdHJhY2suIEluc3RlYWQsIHdlIGF0dGFjaCB0aGUgRE9NTm9kZVJlbW92ZWQKLSAgICAv LyBsaXN0ZW5lcnMgb25seSBvbiB0aGUgbGluZSByb3dzLCBhbmQgdXNlIERPTVN1YnRyZWVNb2Rp ZmllZCB0byB0cmFjayBub2RlIHJlbW92YWxzIGluc2lkZQotICAgIC8vIHRoZSBsaW5lIHJvd3Mu IEZvciBtb3JlIGluZm8gc2VlOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTU2NjYKLSAgICAvLwogICAgIC8vIE9QVElNSVpBVElPTi4gSXQgaXMgdmVyeSBleHBlbnNp dmUgdG8gbGlzdGVuIHRvIHRoZSBET00gbXV0YXRpb24gZXZlbnRzLCB0aHVzIHdlIHJlbW92ZSB0 aGUKICAgICAvLyBsaXN0ZW5lcnMgd2hlbmV2ZXIgd2UgZG8gYW55IGludGVybmFsIERPTSBtYW5p cHVsYXRpb25zIChzdWNoIGFzIGV4cGFuZC9jb2xsYXBzZSBsaW5lIHJvd3MpCiAgICAgLy8gYW5k IHNldCB0aGUgbGlzdGVuZXJzIGJhY2sgd2hlbiB3ZSBhcmUgZmluaXNoZWQuCkBAIC0xNjUzLDE4 ICsxNjQ4LDYgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBlID0g ewogICAgICAgICB9CiAgICAgfSwKIAotICAgIC8qKgotICAgICAqIEBwYXJhbSB7RWxlbWVudH0g bGluZVJvdwotICAgICAqIEBwYXJhbSB7Ym9vbGVhbn0gZW5hYmxlCi0gICAgICovCi0gICAgX2Vu YWJsZURPTU5vZGVSZW1vdmVkTGlzdGVuZXI6IGZ1bmN0aW9uKGxpbmVSb3csIGVuYWJsZSkKLSAg ICB7Ci0gICAgICAgIGlmIChlbmFibGUpCi0gICAgICAgICAgICBsaW5lUm93LmFkZEV2ZW50TGlz dGVuZXIoIkRPTU5vZGVSZW1vdmVkIiwgdGhpcy5faGFuZGxlRE9NVXBkYXRlc0NhbGxiYWNrLCBm YWxzZSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGxpbmVSb3cucmVtb3ZlRXZlbnRMaXN0 ZW5lcigiRE9NTm9kZVJlbW92ZWQiLCB0aGlzLl9oYW5kbGVET01VcGRhdGVzQ2FsbGJhY2ssIGZh bHNlKTsKLSAgICB9LAotCiAgICAgX2J1aWxkQ2h1bmtzOiBmdW5jdGlvbigpCiAgICAgewogICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX3RleHRNb2RlbC5saW5lc0NvdW50OyArK2kp CkBAIC0yMTczLDExICsyMTU2LDYgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwu cHJvdG90eXBlID0gewogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgaWYgKHRh cmdldCA9PT0gbGluZVJvdyAmJiBlLnR5cGUgPT09ICJET01Ob2RlUmVtb3ZlZCIpIHsKLSAgICAg ICAgICAgIC8vIE5vdyB0aGlzIHdpbGwgbm8gbG9uZ2VyIGJlIHZhbGlkLgotICAgICAgICAgICAg ZGVsZXRlIGxpbmVSb3cubGluZU51bWJlcjsKLSAgICAgICAgfQotCiAgICAgICAgIGlmICh0aGlz Ll9kaXJ0eUxpbmVzKSB7CiAgICAgICAgICAgICB0aGlzLl9kaXJ0eUxpbmVzLnN0YXJ0ID0gTWF0 aC5taW4odGhpcy5fZGlydHlMaW5lcy5zdGFydCwgc3RhcnRMaW5lKTsKICAgICAgICAgICAgIHRo aXMuX2RpcnR5TGluZXMuZW5kID0gTWF0aC5tYXgodGhpcy5fZGlydHlMaW5lcy5lbmQsIGVuZExp bmUpOwpAQCAtMjU0NCw3ICsyNTIyLDYgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluQ2h1 bmsgPSBmdW5jdGlvbihjaHVua2VkUGFuZWwsIHN0YXJ0TGluZSwgZW5kTGluZSkKICAgICB0aGlz LmVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAgICB0aGlzLmVsZW1l bnQubGluZU51bWJlciA9IHN0YXJ0TGluZTsKICAgICB0aGlzLmVsZW1lbnQuY2xhc3NOYW1lID0g IndlYmtpdC1saW5lLWNvbnRlbnQiOwotICAgIHRoaXMuX2NodW5rZWRQYW5lbC5fZW5hYmxlRE9N Tm9kZVJlbW92ZWRMaXN0ZW5lcih0aGlzLmVsZW1lbnQsIHRydWUpOwogCiAgICAgdGhpcy5fc3Rh cnRMaW5lID0gc3RhcnRMaW5lOwogICAgIGVuZExpbmUgPSBNYXRoLm1pbih0aGlzLl90ZXh0TW9k ZWwubGluZXNDb3VudCwgZW5kTGluZSk7CkBAIC0yNjUxLDI0ICsyNjI4LDIwIEBAIFdlYkluc3Bl Y3Rvci5UZXh0RWRpdG9yTWFpbkNodW5rLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHZhciBw YXJlbnRFbGVtZW50ID0gdGhpcy5lbGVtZW50LnBhcmVudEVsZW1lbnQ7CiAgICAgICAgICAgICBm b3IgKHZhciBpID0gdGhpcy5zdGFydExpbmU7IGkgPCB0aGlzLnN0YXJ0TGluZSArIHRoaXMubGlu ZXNDb3VudDsgKytpKSB7CiAgICAgICAgICAgICAgICAgdmFyIGxpbmVSb3cgPSB0aGlzLl9jcmVh dGVSb3coaSk7Ci0gICAgICAgICAgICAgICAgdGhpcy5fY2h1bmtlZFBhbmVsLl9lbmFibGVET01O b2RlUmVtb3ZlZExpc3RlbmVyKGxpbmVSb3csIHRydWUpOwogICAgICAgICAgICAgICAgIHRoaXMu X3VwZGF0ZUVsZW1lbnRSZWFkT25seVN0YXRlKGxpbmVSb3cpOwogICAgICAgICAgICAgICAgIHBh cmVudEVsZW1lbnQuaW5zZXJ0QmVmb3JlKGxpbmVSb3csIHRoaXMuZWxlbWVudCk7CiAgICAgICAg ICAgICAgICAgdGhpcy5fZXhwYW5kZWRMaW5lUm93cy5wdXNoKGxpbmVSb3cpOwogICAgICAgICAg ICAgfQotICAgICAgICAgICAgdGhpcy5fY2h1bmtlZFBhbmVsLl9lbmFibGVET01Ob2RlUmVtb3Zl ZExpc3RlbmVyKHRoaXMuZWxlbWVudCwgZmFsc2UpOwogICAgICAgICAgICAgcGFyZW50RWxlbWVu dC5yZW1vdmVDaGlsZCh0aGlzLmVsZW1lbnQpOwogICAgICAgICAgICAgdGhpcy5fY2h1bmtlZFBh bmVsLl9wYWludExpbmVzKHRoaXMuc3RhcnRMaW5lLCB0aGlzLnN0YXJ0TGluZSArIHRoaXMubGlu ZXNDb3VudCk7CiAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICB2YXIgZWxlbWVudEluc2Vy dGVkID0gZmFsc2U7CiAgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX2V4cGFu ZGVkTGluZVJvd3MubGVuZ3RoOyArK2kpIHsKICAgICAgICAgICAgICAgICB2YXIgbGluZVJvdyA9 IHRoaXMuX2V4cGFuZGVkTGluZVJvd3NbaV07Ci0gICAgICAgICAgICAgICAgdGhpcy5fY2h1bmtl ZFBhbmVsLl9lbmFibGVET01Ob2RlUmVtb3ZlZExpc3RlbmVyKGxpbmVSb3csIGZhbHNlKTsKICAg ICAgICAgICAgICAgICB2YXIgcGFyZW50RWxlbWVudCA9IGxpbmVSb3cucGFyZW50RWxlbWVudDsK ICAgICAgICAgICAgICAgICBpZiAocGFyZW50RWxlbWVudCkgewogICAgICAgICAgICAgICAgICAg ICBpZiAoIWVsZW1lbnRJbnNlcnRlZCkgewogICAgICAgICAgICAgICAgICAgICAgICAgZWxlbWVu dEluc2VydGVkID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICAgICAgICAgIHRoaXMuX2NodW5rZWRQ YW5lbC5fZW5hYmxlRE9NTm9kZVJlbW92ZWRMaXN0ZW5lcih0aGlzLmVsZW1lbnQsIHRydWUpOwog ICAgICAgICAgICAgICAgICAgICAgICAgcGFyZW50RWxlbWVudC5pbnNlcnRCZWZvcmUodGhpcy5l bGVtZW50LCBsaW5lUm93KTsKICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAg ICAgICBwYXJlbnRFbGVtZW50LnJlbW92ZUNoaWxkKGxpbmVSb3cpOwo=