94579 2012-08-21 01:20:40 -0700 [Forms] multiple fields time input UI should not have two focus ring. 2012-08-21 19:05:28 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin cmarcelo macpherson menard morrita tkent webkit.review.bot oldest_to_newest 700564 0 yosin 2012-08-21 01:20:40 -0700 There are two focus ring in multiple fields time input UI, one is for all fields and another is focus field. The focus field should not have focus ring and have highlight color. 701446 1 159837 yosin 2012-08-21 18:28:11 -0700 Created attachment 159837 Patch 1 701451 2 159837 yosin 2012-08-21 18:29:03 -0700 Comment on attachment 159837 Patch 1 Could you review this patch? Thanks in advance. 701488 3 159837 yosin 2012-08-21 19:05:24 -0700 Comment on attachment 159837 Patch 1 Clearing flags on attachment: 159837 Committed r126250: <http://trac.webkit.org/changeset/126250> 701489 4 yosin 2012-08-21 19:05:28 -0700 All reviewed patches have been landed. Closing bug. 159837 2012-08-21 18:28:11 -0700 2012-08-21 19:05:24 -0700 Patch 1 bug-94579-20120822102809.patch text/plain 5847 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZkMzQyMTI1OWI0YTFk ZWE4YjI3ZTEwZjZhYTFjM2UzZjBlZGY2Ni4uZTRiYmYzNDMxOGZhODVjZDE4ZDc2OWRhYzczZDlj NTI2YWZiMWE1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTIxICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Zvcm1zXSBtdWx0 aXBsZSBmaWVsZHMgdGltZSBpbnB1dCBVSSBzaG91bGQgbm90IGhhdmUgdHdvIGZvY3VzIHJpbmcu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU3OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggYWRkcyBDU1Mgc2VsZWN0b3JzIHRvIG92ZXJyaWRlIGZvY3VzIHN0eWxlIGZvciBtdWx0aXBs ZQorICAgICAgICBmaWVsZHMgdGltZSBpbnB1dCBVSS4KKworICAgICAgICBObyBuZXcgdGVzdHMu IGZhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtYXBw ZWFyYW5jZS1iYXNpYy5odG1sCisgICAgICAgIGlzIHVwZGF0ZWQgZm9yIGluY2x1ZGluZyBmb2N1 cyBzdGF0ZSBhcHBlYXJhbmNlLgorCisgICAgICAgICogY3NzL2h0bWwuY3NzOgorICAgICAgICAo aW5wdXQ6Oi13ZWJraXQtZGF0ZXRpbWUtZWRpdC1hbXBtLWZpZWxkOmZvY3VzKTogT3ZlcnJpZGUg ZGVmYXVsdCBmb2N1cyBhcHBlYXJhbmNlLgorICAgICAgICAoaW5wdXQ6Oi13ZWJraXQtZGF0ZXRp bWUtZWRpdC1ob3VyLWZpZWxkOmZvY3VzKTogZGl0dG8KKyAgICAgICAgKGlucHV0Ojotd2Via2l0 LWRhdGV0aW1lLWVkaXQtbWlsbGlzZWNvbmQtZmllbGQ6Zm9jdXMpOiBkaXR0bworICAgICAgICAo aW5wdXQ6Oi13ZWJraXQtZGF0ZXRpbWUtZWRpdC1taW51dGUtZmllbGQ6Zm9jdXMpOiBkaXR0bwor ICAgICAgICAoaW5wdXQ6Oi13ZWJraXQtZGF0ZXRpbWUtZWRpdC1zZWNvbmQtZmllbGQ6Zm9jdXMp OiBkaXR0bworCiAyMDEyLTA4LTIwICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbVjhdIFJlbW92ZSBnZXRUb1N0cmluZ05hbWUoKSBhbmQgZ2V0VG9TdHJp bmdUZW1wbGF0ZSgpIGZyb20gVjhCaW5kaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvaHRtbC5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MKaW5kZXggZDYwY2EwZWQ1 NzM4ZWNmMzk0NTY0OGJlZWZlOTdiNzk3ZTNkYWJlZi4uYzIxM2QzOGQ2YjAzMzExNDg1ZDU0ZWZh MGE3NzI1Y2RhN2YxZmFjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3Nz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1sLmNzcwpAQCAtNTMwLDYgKzUzMCwxNyBAQCBp bnB1dDo6LXdlYmtpdC1kYXRldGltZS1lZGl0LXNlY29uZC1maWVsZCB7CiAgICAgcGFkZGluZzog MC4xNWVtOwogfQogCisvKiBSZW1vdmUgZm9jdXMgcmluZyBmcm9tIGZpZWxkcyBhbmQgdXNlIGhp Z2hsaWdodCBjb2xvciAqLworaW5wdXQ6Oi13ZWJraXQtZGF0ZXRpbWUtZWRpdC1hbXBtLWZpZWxk OmZvY3VzLAoraW5wdXQ6Oi13ZWJraXQtZGF0ZXRpbWUtZWRpdC1ob3VyLWZpZWxkOmZvY3VzLAor aW5wdXQ6Oi13ZWJraXQtZGF0ZXRpbWUtZWRpdC1taWxsaXNlY29uZC1maWVsOmZvY3VzLAoraW5w dXQ6Oi13ZWJraXQtZGF0ZXRpbWUtZWRpdC1taW51dGUtZmllbGQ6Zm9jdXMsCitpbnB1dDo6LXdl YmtpdC1kYXRldGltZS1lZGl0LXNlY29uZC1maWVsZDpmb2N1cyB7CisgIGJhY2tncm91bmQtY29s b3I6IGhpZ2hsaWdodDsKKyAgY29sb3I6IGhpZ2hsaWdodHRleHQ7CisgIG91dGxpbmU6IG5vbmU7 Cit9CisKIC8qIFRoaXMgc2VsZWN0b3IgaXMgdXNlZCB3aGVuIHN0ZXAgPj0gNjAgc2Vjb25kIGJ1 dCBmb3JtYXQgY29udGFpbnMgc2Vjb25kIGZpZWxkLiAqLwogaW5wdXQ6Oi13ZWJraXQtZGF0ZXRp bWUtZWRpdC1zZWNvbmQtZmllbGRbcmVhZG9ubHldIHsKICAgICBjb2xvcjogR3JheVRleHQ7CmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggNjE1YmUwODFmMTc0ZjM2MTdlODBkNThhNmVjN2E0NDBjMTM5ZDg3YS4uNWI0NTdiNjY1 NDY5Nzg0Y2M4MTY4NTlhNDYzODUyZGI4NmJmZmJhMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisy MDEyLTA4LTIxICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW0Zvcm1zXSBtdWx0aXBsZSBmaWVsZHMgdGltZSBpbnB1dCBVSSBzaG91bGQgbm90IGhhdmUg dHdvIGZvY3VzIHJpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NDU3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIHRlc3QgY2FzZSBvZiBmb2N1cyBhcHBlYXJhbmNlIG11 bHRpcGxlIGZpZWxkcyB0aW1lCisgICAgICAgIGlucHV0IFVJLgorCisgICAgICAgICogZmFzdC9m b3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNl LWJhc2ljLWV4cGVjdGVkLmh0bWw6IEFkZGVkIHNjcmlwdCB0byBtYWtlIGZvY3VzIGFwcGVhcmFu Y2UuCisgICAgICAgICogZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRp cGxlLWZpZWxkcy1hcHBlYXJhbmNlLWJhc2ljLmh0bWw6IEFkZGVkIHNjcmlwdCB0byBzZXQgZm9j dXMgdG8gaW5wdXQgZWxlbWVudC4KKwogMjAxMi0wOC0yMSAgVmljdG9yIENhcmJ1bmUgIDx2aWN0 b3JAcm9zZWR1Lm9yZz4KIAogICAgICAgICBEaXNwbGF5IGEgVGV4dFRyYWNrQ3VlIHdoZW4gc25h cC10by1saW5lcyBmbGFnIGlzIHNldApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLWJh c2ljLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUt ZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVhcmFuY2UtYmFzaWMtZXhwZWN0ZWQuaHRt bAppbmRleCA4YTA4MzI3YTg5MDFjMzk1NThjOGE4MTYyNjA2MWRmNDg4YjdiZmFhLi43N2JhMDMz Y2QxYzk0MGMzMTk1ZTZhYzQ0Njc1NzcwMmYyM2M2YTVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWFw cGVhcmFuY2UtYmFzaWMtZXhwZWN0ZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVhcmFuY2UtYmFz aWMtZXhwZWN0ZWQuaHRtbApAQCAtNCw3ICs0LDcgQEAKIDwvaGVhZD4KIDxib2R5PgogPHVsPgot ICAgIDxsaT5zdGVwPW5vbmUgPHNwYW4gdHlwZT0idGltZSI+PC9zcGFuPiA8c3BhbiB0eXBlPSJ0 aW1lIiB2YWx1ZT0iMTI6MzQ6NTYuNzg5Ij48L3NwYW4+PC9saT4KKyAgICA8bGk+c3RlcD1ub25l IDxzcGFuIGlkPSJmb2N1cyIgdHlwZT0idGltZSI+PC9zcGFuPiA8c3BhbiB0eXBlPSJ0aW1lIiB2 YWx1ZT0iMTI6MzQ6NTYuNzg5Ij48L3NwYW4+PC9saT4KICAgICA8bGk+c3RlcD0xIDxzcGFuIHR5 cGU9InRpbWUiIHN0ZXA9IjEiPjwvc3Bhbj4gPHNwYW4gc3RlcD0iMSIgdHlwZT0idGltZSIgdmFs dWU9IjEyOjM0OjU2Ljc4OSI+PC9zcGFuPjwvbGk+CiAgICAgPGxpPnN0ZXA9MC4wMDAxIDxzcGFu IHR5cGU9InRpbWUiIHN0ZXA9IjAuMDAxIj48L3NwYW4+IDxzcGFuIHN0ZXA9IjAuMDAxIiB0eXBl PSJ0aW1lIiB2YWx1ZT0iMTI6MzQ6NTYuNzg5Ij48L3NwYW4+PC9saT4KICAgICA8bGk+c3RlcD02 MCA8c3BhbiB0eXBlPSJ0aW1lIiBzdGVwPSI2MCI+PC9zcGFuPiA8c3BhbiBzdGVwPSI2MCIgdHlw ZT0idGltZSIgdmFsdWU9IjEyOjM0OjU2Ljc4OSI+PC9zcGFuPjwvbGk+CkBAIC0xMiw0ICsxMiwx MSBAQAogPC91bD4KIDwvYm9keT4KIDxzY3JpcHQgc3JjPSIuL3Jlc291cmNlcy90aW1lLW11bHRp cGxlLWZpZWxkcy1hcHBlYXJhbmNlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+Cit2YXIgZm9jdXNF bG1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZm9jdXMiKTsKK2ZvY3VzRWxtZW50LnNl dEF0dHJpYnV0ZSgic3R5bGUiLCAib3V0bGluZTogYXV0byA1cHggLXdlYmtpdC1mb2N1cy1yaW5n LWNvbG9yOyBvdXRsaW5lLW9mZnNldDogLTJweDsiKTsKK3ZhciBob3VyRmllbGQgPSBmb2N1c0Vs bWVudC5maXJzdENoaWxkLmZpcnN0Q2hpbGQ7Citob3VyRmllbGQuc3R5bGUuYmFja2dyb3VuZENv bG9yID0gImhpZ2hsaWdodCI7Citob3VyRmllbGQuc3R5bGUuY29sb3IgPSAiaGlnaGxpZ2h0dGV4 dCI7Cis8L3NjcmlwdD4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS1i YXNpYy5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90 aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLWJhc2ljLmh0bWwKaW5kZXggZmJkN2MzZWM2 YmVjMzcxZmU1OTQ1YWYwOGU3N2Q4NGRjMmJmOTZlZi4uNDA4NDFlYTU4MmZhMGM2ZGViM2I2OGJk ODQ0YTY4Y2E4ODcyYWM5MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1l LW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLWJhc2ljLmh0 bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1l LW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLWJhc2ljLmh0bWwKQEAgLTEsMTEgKzEsMTQgQEAK IDxodG1sPgogPGJvZHk+CiA8dWw+Ci0gICAgPGxpPnN0ZXA9bm9uZSA8aW5wdXQgdHlwZT0idGlt ZSI+IDxpbnB1dCB0eXBlPSJ0aW1lIiB2YWx1ZT0iMTI6MzQ6NTYuNzg5Ij48L2xpPgorICAgIDxs aT5zdGVwPW5vbmUgPGlucHV0IGlkPSJmb2N1cyIgdHlwZT0idGltZSI+IDxpbnB1dCB0eXBlPSJ0 aW1lIiB2YWx1ZT0iMTI6MzQ6NTYuNzg5Ij48L2xpPgogICAgIDxsaT5zdGVwPTEgPGlucHV0IHR5 cGU9InRpbWUiIHN0ZXA9IjEiPiA8aW5wdXQgc3RlcD0iMSIgdHlwZT0idGltZSIgdmFsdWU9IjEy OjM0OjU2Ljc4OSI+PC9saT4KICAgICA8bGk+c3RlcD0wLjAwMDEgPGlucHV0IHR5cGU9InRpbWUi IHN0ZXA9IjAuMDAxIj4gPGlucHV0IHN0ZXA9IjAuMDAxIiB0eXBlPSJ0aW1lIiB2YWx1ZT0iMTI6 MzQ6NTYuNzg5Ij48L2xpPgogICAgIDxsaT5zdGVwPTYwIDxpbnB1dCB0eXBlPSJ0aW1lIiBzdGVw PSI2MCI+IDxpbnB1dCBzdGVwPSI2MCIgdHlwZT0idGltZSIgdmFsdWU9IjEyOjM0OjU2Ljc4OSI+ PC9saT4KICAgICA8bGk+c3RlcD0zNjAwIDxpbnB1dCB0eXBlPSJ0aW1lIiBzdGVwPSIzNjAwIj4g PGlucHV0IHN0ZXA9IjM2MDAiIHR5cGU9InRpbWUiIHZhbHVlPSIxMjozNDo1Ni43ODkiPjwvbGk+ CiA8L3VsPgogPC9ib2R5PgorPHNjcmlwdD4KK2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJmb2N1 cyIpLmZvY3VzKCk7Cis8L3NjcmlwdD4KIDwvaHRtbD4K