94578 2012-08-21 01:07:57 -0700 REGRESSION (r126132): fast/forms/range/range-hit-test-with-padding.html failing on non-Chromium ports 2012-09-17 00:08:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r126132%20(27786)/results.html LayoutTestFailure, MakingBotsRed, Qt, QtTriaged, Regression P2 Normal --- 87008 94473 1 zan webkit-unassigned beidson keishi ossy tmpsantos oldest_to_newest 700560 0 zan 2012-08-21 01:07:57 -0700 fast/forms/range/range-hit-test-with-padding.html started failing on non-Chromium ports after r126132. The diff looks something like this (the actual value is about 506 or 507): --- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/forms/range/range-hit-test-with-padding-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/forms/range/range-hit-test-with-padding-actual.txt @@ -1,6 +1,6 @@ Clicking middle of input type=range with padding should set the value to middle. -PASS input.value is "500" +FAIL input.value should be 500. Was 507. PASS successfullyParsed is true TEST COMPLETE 700599 1 tmpsantos 2012-08-21 04:03:11 -0700 Discrepancy is even higher on EFL: -PASS input.value is "500" +FAIL input.value should be 500. Was 727. 700625 2 ossy 2012-08-21 04:53:08 -0700 It is skipped on Qt - https://trac.webkit.org/changeset/126149 700664 3 keishi 2012-08-21 05:45:35 -0700 (In reply to comment #1) > Discrepancy is even higher on EFL: > > -PASS input.value is "500" > +FAIL input.value should be 500. Was 727. I learned that ports without subpixel layout will not be able to match the value exactly. I am modifying the test in Bug 94585. Qt should rebaseline when it lands. But EFL is way off so there might be something else going on. I can't figure it out. 700683 4 tmpsantos 2012-08-21 06:06:59 -0700 (In reply to comment #3) > (In reply to comment #1) > > Discrepancy is even higher on EFL: > > > > -PASS input.value is "500" > > +FAIL input.value should be 500. Was 727. > > I learned that ports without subpixel layout will not be able to match the value exactly. I am modifying the test in Bug 94585. > Qt should rebaseline when it lands. > But EFL is way off so there might be something else going on. I can't figure it out. - clickSlider(70); // left padding (20px) + middle (50px) + clickSlider(50); // middle (50px) Hits bull's-eye (500) on EFL. I'm investigating why. 700685 5 keishi 2012-08-21 06:11:46 -0700 Bug 94585 is in the commit queue. I was able to change the test in a way that you won't need to rebaseline. 719324 6 ossy 2012-09-13 04:19:12 -0700 (In reply to comment #5) > Bug 94585 is in the commit queue. I was able to change the test in a way that you won't need to rebaseline. It fixed it on Qt, unskip landed in https://trac.webkit.org/changeset/128444 721714 7 zan 2012-09-17 00:08:52 -0700 (In reply to comment #5) > Bug 94585 is in the commit queue. I was able to change the test in a way that you won't need to rebaseline. Great, the test is now running OK, closing the bug.