94575 2012-08-20 23:42:02 -0700 [Chromium] DRT produces wrong back-forward list 2012-08-21 16:23:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 90207 1 tkent tkent abarth dglazkov webkit.review.bot oldest_to_newest 700505 0 tkent 2012-08-20 23:42:02 -0700 [Chromium] DRT produces wrong back-forward list 700675 1 159671 tkent 2012-08-21 05:57:10 -0700 Created attachment 159671 Patch 700778 2 159671 abarth 2012-08-21 08:18:21 -0700 Comment on attachment 159671 Patch Are there any observable effects of this change? (e.g., test that now pass that failed previously) 700779 3 159671 abarth 2012-08-21 08:19:13 -0700 Comment on attachment 159671 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159671&action=review > Tools/DumpRenderTree/chromium/WebViewHost.cpp:1675 > + bool nonBlankPageAfterReset = m_pageId == -1 && strcmp(frame->dataSource()->request().url().spec().data(), "about:blank"); It feels a bit wrong to be comparing against the string "about:blank"... 700781 4 abarth 2012-08-21 08:19:51 -0700 I fail at reading ChangeLogs. 701267 5 159671 webkit.review.bot 2012-08-21 16:23:37 -0700 Comment on attachment 159671 Patch Clearing flags on attachment: 159671 Committed r126212: <http://trac.webkit.org/changeset/126212> 701268 6 webkit.review.bot 2012-08-21 16:23:40 -0700 All reviewed patches have been landed. Closing bug. 159671 2012-08-21 05:57:10 -0700 2012-08-21 16:23:37 -0700 Patch bug-94575-20120821215629.patch text/plain 2140 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTNjYjA1YmQ5MTI3MDdjNjdkZTk4ZmRhMjI5YTQwNTY1 M2EwOTdhZC4uNWJhNzhmYWU5ZDRhNGM0OTYyN2MwMTFhYjM1MDBiZWY4NTNhM2QxNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTA4LTIxICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAg ICAgICBbQ2hyb21pdW1dIERSVCBwcm9kdWNlcyB3cm9uZyBiYWNrLWZvcndhcmQgbGlzdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ1NzUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEUlQgY2xlYXJzIGl0 cyBoaXN0b3J5IHN0YXRlIGJlZm9yZSBydW5uaW5nIGV2ZXJ5IHRlc3RzLiBIb3dldmVyCisgICAg ICAgIEhpc3RvcnlDb250cm9sbGVyIGluIFdlYkNvcmUgaXNuJ3QgcmVzZXQuIFNvLCBpdCBpcyBw b3NzaWJsZSB0aGF0CisgICAgICAgICdpc05ld05hdmlnYXRpb24nIGZsYWcgaXMgZmFsc2UgZXZl biB0aG91Z2ggdGhlIG5hdmlnYXRpb24gc2hvdWxkIGJlCisgICAgICAgIGhhbmRsZWQgYXMgIm5l dyIgZm9yIERSVC4KKworICAgICAgICBUaGlzIGNoYW5nZSBtaWdodCBmaXggYSBwcm9ibGVtIG9m CisgICAgICAgIGZhc3QvZm9ybXMvc2VsZWN0L3NlbGVjdC1zdGF0ZS1yZXN0b3JlLmh0bWwgKEJ1 ZyA5MDIwNykuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9z dC5jcHA6CisgICAgICAgIChXZWJWaWV3SG9zdDo6dXBkYXRlRm9yQ29tbWl0dGVkTG9hZCk6Cisg ICAgICAgIFRyZWF0IHRoZSBmaXJzdCBwYWdlIGxvYWQgKG1fcGFnZUlEID09IC0xKSBhcyBuZXcg bmF2aWdhdGlvbiBleGNlcHQgZm9yIGFib3V0OmJsYW5rLgorICAgICAgICBXaXRob3V0IHRoaXMg Y2hhbmdlLCBhIG5hdmlnYXRpb24gZW50cnkgZm9yIHRoaXMgbG9hZGluZyB3b24ndCBiZSByZWNv cmRlZC4KKwogMjAxMi0wOC0yMSAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tp YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggZm9yIG5ld2VyIFF0IDU6IFRo ZSBtZWFuaW5nIG9mIHByaXZhdGVfaW5jbHVkZXMgY2hhbmdlZCB0byBiZSBmdWxseQpkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwIGIvVG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCmluZGV4IGE2N2QxZTMw NGM2MzdlMDk5MTc0NGIzYzQ5MjY4ZDMzMjgyYjIyNDUuLjNhYjhhODYzOTllYTBkZTUxZGYxMmQ2 Njc4OGNjYWRjYWY3MDQxY2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL1dlYlZpZXdIb3N0LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9X ZWJWaWV3SG9zdC5jcHAKQEAgLTE2NzIsOCArMTY3Miw5IEBAIHZvaWQgV2ViVmlld0hvc3Q6OnVw ZGF0ZUZvckNvbW1pdHRlZExvYWQoV2ViRnJhbWUqIGZyYW1lLCBib29sIGlzTmV3TmF2aWdhdGlv bikKIHsKICAgICAvLyBDb2RlIGR1cGxpY2F0ZWQgZnJvbSBSZW5kZXJWaWV3OjpEaWRDb21taXRM b2FkRm9yRnJhbWUuCiAgICAgVGVzdFNoZWxsRXh0cmFEYXRhKiBleHRyYURhdGEgPSBzdGF0aWNf Y2FzdDxUZXN0U2hlbGxFeHRyYURhdGEqPihmcmFtZS0+ZGF0YVNvdXJjZSgpLT5leHRyYURhdGEo KSk7CisgICAgYm9vbCBub25CbGFua1BhZ2VBZnRlclJlc2V0ID0gbV9wYWdlSWQgPT0gLTEgJiYg c3RyY21wKGZyYW1lLT5kYXRhU291cmNlKCktPnJlcXVlc3QoKS51cmwoKS5zcGVjKCkuZGF0YSgp LCAiYWJvdXQ6YmxhbmsiKTsKIAotICAgIGlmIChpc05ld05hdmlnYXRpb24pIHsKKyAgICBpZiAo aXNOZXdOYXZpZ2F0aW9uIHx8IG5vbkJsYW5rUGFnZUFmdGVyUmVzZXQpIHsKICAgICAgICAgLy8g TmV3IG5hdmlnYXRpb24uCiAgICAgICAgIHVwZGF0ZVNlc3Npb25IaXN0b3J5KGZyYW1lKTsKICAg ICAgICAgbV9wYWdlSWQgPSBuZXh0UGFnZUlEKys7Cg==