94570 2012-08-20 21:24:21 -0700 InsertionShouldCallDidNotifyDescendantInsertions should be merged to InsertionShouldCallDidNotifySubtreeInsertions 2012-08-20 23:49:46 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94447 1 morrita morrita mifenton rniwa tkent webkit.review.bot oldest_to_newest 700434 0 morrita 2012-08-20 21:24:21 -0700 This is a follow up of Bug 94447 (http://trac.webkit.org/changeset/126131) Node::insertedInto() doesn't need three type of return values. These can be foled into two. 700440 1 morrita 2012-08-20 21:32:33 -0700 Huh, InsertionShouldCallDidNotifyDescendantInsertions is only used by HTMLBodyElement. I belive there were more. But it's no longer true - and that is good news for us. 700470 2 159619 morrita 2012-08-20 22:08:48 -0700 Created attachment 159619 Patch 700507 3 159619 webkit.review.bot 2012-08-20 23:49:43 -0700 Comment on attachment 159619 Patch Clearing flags on attachment: 159619 Committed r126136: <http://trac.webkit.org/changeset/126136> 700508 4 webkit.review.bot 2012-08-20 23:49:46 -0700 All reviewed patches have been landed. Closing bug. 159619 2012-08-20 22:08:48 -0700 2012-08-20 23:49:42 -0700 Patch bug-94570-20120821140807.patch text/plain 6834 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E4ZTg2NjIzMWZkYzIy MzgyYzU3OTkzYTU4ZGE1YTQ5NDlmZGZhZS4uOGE0MzNmYTk3OWUxMzI0YTY3NTBiYmUzYWZkMDI0 ZmQyYTk5ZTdjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTA4LTIwICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIEluc2VydGlvblNob3Vs ZENhbGxEaWROb3RpZnlEZXNjZW5kYW50SW5zZXJ0aW9ucyBzaG91bGQgYmUgbWVyZ2VkIHRvIElu c2VydGlvblNob3VsZENhbGxEaWROb3RpZnlTdWJ0cmVlSW5zZXJ0aW9ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ1NzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb2RlOjpkaWROb3RpZnlTdWJ0cmVl SW5zZXJ0aW9ucygpIGFuZCBOb2RlOjpkaWROb3RpZnlEZXNjZW5kYW50SW5zZXJ0aW9ucygpIGFy ZSB1c2VkIGZvciBzaW1pbGFyIHB1cnBvc2UgYW5kCisgICAgICAgIHdlIGNvdWxkIHVuaWZ5IHRo ZW0gdG8gdGhlIHNhZmVyIG9uZSwgd2hpY2ggaXMgZGlkTm90aWZ5U3VidHJlZUluc2VydGlvbnMo KS4KKworICAgICAgICBUaGlzIGNoYW5nZSByZXBsYWNlcyB0aGUgbGFzdCBkaWROb3RpZnlEZXNj ZW5kYW50SW5zZXJ0aW9ucygpIGltcGxlbWVudGF0aW9uIGluIEhUTUxCb2R5RWxlbWVudCB3aXRo IGRpZE5vdGlmeVN1YnRyZWVJbnNlcnRpb25zKCkKKyAgICAgICAgdGhlbiBlbGltaW5hdGVzIHJl bGF0ZWQgY29kZSB3aGljaCBpcyBubyBsb25nZXIgdXNlZC4KKworICAgICAgICBObyBuZXcgdGVz dHMuIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBkb20vQ29udGFpbmVy Tm9kZUFsZ29yaXRobXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNoaWxkTm9kZUluc2VydGlvbk5v dGlmaWVyOjpub3RpZnlOb2RlSW5zZXJ0ZWRJbnRvRG9jdW1lbnQpOgorICAgICAgICAoV2ViQ29y ZTo6Q2hpbGROb2RlSW5zZXJ0aW9uTm90aWZpZXI6Om5vdGlmeU5vZGVJbnNlcnRlZEludG9UcmVl KToKKyAgICAgICAgKiBkb20vTm9kZS5oOiBSZW1vdmVkIGRpZE5vdGlmeURlc2NlbmRhbnRJbnNl cnRpb25zKCkgc3R1YiBhbmQgSW5zZXJ0aW9uU2hvdWxkQ2FsbERpZE5vdGlmeURlc2NlbmRhbnRJ bnNlcnRpb25zIGVudW0gdmFsdWUuCisgICAgICAgICogaHRtbC9IVE1MQm9keUVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SFRNTEJvZHlFbGVtZW50OjppbnNlcnRlZEludG8pOgorICAg ICAgICAoV2ViQ29yZTo6SFRNTEJvZHlFbGVtZW50OjpkaWROb3RpZnlTdWJ0cmVlSW5zZXJ0aW9u cyk6IG1vcnBoZWQgZnJvbSBkaWROb3RpZnlEZXNjZW5kYW50SW5zZXJ0aW9ucygpCisgICAgICAg ICogaHRtbC9IVE1MQm9keUVsZW1lbnQuaDoKKyAgICAgICAgKEhUTUxCb2R5RWxlbWVudCk6Cisg ICAgICAgICogaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TEZvcm1FbGVtZW50OjppbnNlcnRlZEludG8pOiBSZW1vdmUgdXNlbGVzcyBJbnNlcnRpb25TaG91 bGRDYWxsRGlkTm90aWZ5RGVzY2VuZGFudEluc2VydGlvbnMgcmV0dXJuIHN0YXRlbWVudC4KKwog MjAxMi0wOC0yMCAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAg ICBDbGlja2luZyBpbnB1dCB0eXBlPXJhbmdlIHdpdGggcGFkZGluZyBvciBib3JkZXIgc2V0cyB3 cm9uZyB2YWx1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGVB bGdvcml0aG1zLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZUFsZ29yaXRobXMu aAppbmRleCAwNmJlNDY5NzhjOTgwY2RlMTVhZjZjYWYxYWFjMzcwNGFkZDQ0OGQ2Li4xNjMyOTU1 NDEzNTVlN2QzNjIyOGU0MmIzNDExOTRjMDIwYWNkMTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vQ29udGFpbmVyTm9kZUFsZ29yaXRobXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vQ29udGFpbmVyTm9kZUFsZ29yaXRobXMuaApAQCAtMTkzLDIxICsxOTMsMTAgQEAgaW5saW5l IHZvaWQgQ2hpbGROb2RlSW5zZXJ0aW9uTm90aWZpZXI6Om5vdGlmeU5vZGVJbnNlcnRlZEludG9E b2N1bWVudChOb2RlKiBub2QKIHsKICAgICBBU1NFUlQobV9pbnNlcnRpb25Qb2ludC0+aW5Eb2N1 bWVudCgpKTsKICAgICBSZWZQdHI8Tm9kZT4gcHJvdGVjdChub2RlKTsKLSAgICBOb2RlOjpJbnNl cnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IHJlcXVlc3QgPSBub2RlLT5pbnNlcnRlZEludG8obV9p bnNlcnRpb25Qb2ludCk7Ci0KKyAgICBpZiAoTm9kZTo6SW5zZXJ0aW9uU2hvdWxkQ2FsbERpZE5v dGlmeVN1YnRyZWVJbnNlcnRpb25zID09IG5vZGUtPmluc2VydGVkSW50byhtX2luc2VydGlvblBv aW50KSkKKyAgICAgICAgbV9wb3N0SW5zZXJ0aW9uTm90aWZpY2F0aW9uVGFyZ2V0cy5hcHBlbmQo bm9kZSk7CiAgICAgaWYgKG5vZGUtPmlzQ29udGFpbmVyTm9kZSgpKQogICAgICAgICBub3RpZnlE ZXNjZW5kYW50SW5zZXJ0ZWRJbnRvRG9jdW1lbnQodG9Db250YWluZXJOb2RlKG5vZGUpKTsKLQot ICAgIHN3aXRjaCAocmVxdWVzdCkgewotICAgIGNhc2UgTm9kZTo6SW5zZXJ0aW9uRG9uZToKLSAg ICAgICAgYnJlYWs7Ci0gICAgY2FzZSBOb2RlOjpJbnNlcnRpb25TaG91bGRDYWxsRGlkTm90aWZ5 RGVzY2VuZGFudEluc2VydGlvbnM6Ci0gICAgICAgIG5vZGUtPmRpZE5vdGlmeURlc2NlbmRhbnRJ bnNlcnRpb25zKG1faW5zZXJ0aW9uUG9pbnQpOwotICAgICAgICBicmVhazsKLSAgICBjYXNlIE5v ZGU6Okluc2VydGlvblNob3VsZENhbGxEaWROb3RpZnlTdWJ0cmVlSW5zZXJ0aW9uczoKLSAgICAg ICAgbV9wb3N0SW5zZXJ0aW9uTm90aWZpY2F0aW9uVGFyZ2V0cy5hcHBlbmQobm9kZSk7Ci0gICAg ICAgIGJyZWFrOwotICAgIH0KIH0KIAogaW5saW5lIHZvaWQgQ2hpbGROb2RlSW5zZXJ0aW9uTm90 aWZpZXI6Om5vdGlmeU5vZGVJbnNlcnRlZEludG9UcmVlKENvbnRhaW5lck5vZGUqIG5vZGUpCkBA IC0yMTUsMTEgKzIwNCw5IEBAIGlubGluZSB2b2lkIENoaWxkTm9kZUluc2VydGlvbk5vdGlmaWVy Ojpub3RpZnlOb2RlSW5zZXJ0ZWRJbnRvVHJlZShDb250YWluZXJOb2RlCiAgICAgQVNTRVJUKCFt X2luc2VydGlvblBvaW50LT5pbkRvY3VtZW50KCkpOwogICAgIGZvcmJpZEV2ZW50RGlzcGF0Y2go KTsKIAotICAgIE5vZGU6Okluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgcmVxdWVzdCA9IG5v ZGUtPmluc2VydGVkSW50byhtX2luc2VydGlvblBvaW50KTsKLQorICAgIGlmIChOb2RlOjpJbnNl cnRpb25TaG91bGRDYWxsRGlkTm90aWZ5U3VidHJlZUluc2VydGlvbnMgPT0gbm9kZS0+aW5zZXJ0 ZWRJbnRvKG1faW5zZXJ0aW9uUG9pbnQpKQorICAgICAgICBtX3Bvc3RJbnNlcnRpb25Ob3RpZmlj YXRpb25UYXJnZXRzLmFwcGVuZChub2RlKTsKICAgICBub3RpZnlEZXNjZW5kYW50SW5zZXJ0ZWRJ bnRvVHJlZShub2RlKTsKLSAgICBpZiAocmVxdWVzdCA9PSBOb2RlOjpJbnNlcnRpb25TaG91bGRD YWxsRGlkTm90aWZ5RGVzY2VuZGFudEluc2VydGlvbnMpCi0gICAgICAgIG5vZGUtPmRpZE5vdGlm eURlc2NlbmRhbnRJbnNlcnRpb25zKG1faW5zZXJ0aW9uUG9pbnQpOwogCiAgICAgYWxsb3dFdmVu dERpc3BhdGNoKCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oIGIv U291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAppbmRleCAwY2IyYTllOTk4MzVjMGQxNjIxMTU1NTI1 ZDJjMTg4ZmMxY2Y2MzE3Li40MzlhYTkzNmE5ZDM0YzJkOTE0NzI3ZThhNGZlNzM0MTM0ZjRlZjA4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Ob2RlLmgKQEAgLTU0NywxMiArNTQ3LDEwIEBAIHB1YmxpYzoKICAgICAvLwogICAg IGVudW0gSW5zZXJ0aW9uTm90aWZpY2F0aW9uUmVxdWVzdCB7CiAgICAgICAgIEluc2VydGlvbkRv bmUsCi0gICAgICAgIEluc2VydGlvblNob3VsZENhbGxEaWROb3RpZnlEZXNjZW5kYW50SW5zZXJ0 aW9ucywKICAgICAgICAgSW5zZXJ0aW9uU2hvdWxkQ2FsbERpZE5vdGlmeVN1YnRyZWVJbnNlcnRp b25zCiAgICAgfTsKIAogICAgIHZpcnR1YWwgSW5zZXJ0aW9uTm90aWZpY2F0aW9uUmVxdWVzdCBp bnNlcnRlZEludG8oQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9uUG9pbnQpOwotICAgIHZpcnR1YWwg dm9pZCBkaWROb3RpZnlEZXNjZW5kYW50SW5zZXJ0aW9ucyhDb250YWluZXJOb2RlKikgeyB9CiAg ICAgdmlydHVhbCB2b2lkIGRpZE5vdGlmeVN1YnRyZWVJbnNlcnRpb25zKENvbnRhaW5lck5vZGUq KSB7IH0KIAogICAgIC8vIE5vdGlmaWVzIHRoZSBub2RlIHRoYXQgaXQgaXMgbm8gbG9uZ2VyIHBh cnQgb2YgdGhlIHRyZWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5 RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5jcHAKaW5k ZXggODQ2ZTMzMWUwMGFhZjRmY2YwYzFhN2ZmMThiYTQ1YWNmNGFmMGU0Yy4uODVjZGYzOGIxMjVk NzYzZjg2NDAzNTA0OTI2ZjE2ZDc1MTIyNjhkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MQm9keUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJv ZHlFbGVtZW50LmNwcApAQCAtMTU2LDExICsxNTYsMTEgQEAgTm9kZTo6SW5zZXJ0aW9uTm90aWZp Y2F0aW9uUmVxdWVzdCBIVE1MQm9keUVsZW1lbnQ6Omluc2VydGVkSW50byhDb250YWluZXJOb2Rl KgogewogICAgIEhUTUxFbGVtZW50OjppbnNlcnRlZEludG8oaW5zZXJ0aW9uUG9pbnQpOwogICAg IGlmIChpbnNlcnRpb25Qb2ludC0+aW5Eb2N1bWVudCgpKQotICAgICAgICByZXR1cm4gSW5zZXJ0 aW9uU2hvdWxkQ2FsbERpZE5vdGlmeURlc2NlbmRhbnRJbnNlcnRpb25zOworICAgICAgICByZXR1 cm4gSW5zZXJ0aW9uU2hvdWxkQ2FsbERpZE5vdGlmeVN1YnRyZWVJbnNlcnRpb25zOwogICAgIHJl dHVybiBJbnNlcnRpb25Eb25lOwogfQogCi12b2lkIEhUTUxCb2R5RWxlbWVudDo6ZGlkTm90aWZ5 RGVzY2VuZGFudEluc2VydGlvbnMoQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9uUG9pbnQpCit2b2lk IEhUTUxCb2R5RWxlbWVudDo6ZGlkTm90aWZ5U3VidHJlZUluc2VydGlvbnMoQ29udGFpbmVyTm9k ZSogaW5zZXJ0aW9uUG9pbnQpCiB7CiAgICAgQVNTRVJUX1VOVVNFRChpbnNlcnRpb25Qb2ludCwg aW5zZXJ0aW9uUG9pbnQtPmluRG9jdW1lbnQoKSk7CiAgICAgQVNTRVJUKGRvY3VtZW50KCkpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuaCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmgKaW5kZXggMjJhYzE5Yzc2M2EzMmI3NGI0 MWMxNDFmZGUzMDJhNWZjNWVhMWI2Yi4uNDIyYWQzMDY2NTU5ZmY4ODMwOTg4YzZjYmJlYjVhN2M1 MGJkMzZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5oCkBAIC03NSw3ICs3 NSw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIGNvbGxlY3RTdHlsZUZvckF0dHJpYnV0 ZShjb25zdCBBdHRyaWJ1dGUmLCBTdHlsZVByb3BlcnR5U2V0KikgT1ZFUlJJREU7CiAKICAgICB2 aXJ0dWFsIEluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgaW5zZXJ0ZWRJbnRvKENvbnRhaW5l ck5vZGUqKSBPVkVSUklERTsKLSAgICB2aXJ0dWFsIHZvaWQgZGlkTm90aWZ5RGVzY2VuZGFudElu c2VydGlvbnMoQ29udGFpbmVyTm9kZSopIE9WRVJSSURFOworICAgIHZpcnR1YWwgdm9pZCBkaWRO b3RpZnlTdWJ0cmVlSW5zZXJ0aW9ucyhDb250YWluZXJOb2RlKikgT1ZFUlJJREU7CiAgICAgCiAg ICAgdmlydHVhbCBib29sIGlzVVJMQXR0cmlidXRlKGNvbnN0IEF0dHJpYnV0ZSYpIGNvbnN0IE9W RVJSSURFOwogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUVsZW1lbnQuY3BwCmluZGV4 IDdjM2JiNjFiMWRmZWU0ZmUxZTA4ZGE2YjY4ZDNmMmY1OTQxMDkwMDIuLjk0N2Y0ZDkyYmE2YjBl MDU1YWU3Yzg4MTRkYjQ2YmY3NTFjY2MzMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEZvcm1FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3Jt RWxlbWVudC5jcHAKQEAgLTEzNiw4ICsxMzYsNiBAQCBib29sIEhUTUxGb3JtRWxlbWVudDo6cmVu ZGVyZXJJc05lZWRlZChjb25zdCBOb2RlUmVuZGVyaW5nQ29udGV4dCYgY29udGV4dCkKIE5vZGU6 Okluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgSFRNTEZvcm1FbGVtZW50OjppbnNlcnRlZElu dG8oQ29udGFpbmVyTm9kZSogaW5zZXJ0aW9uUG9pbnQpCiB7CiAgICAgSFRNTEVsZW1lbnQ6Omlu c2VydGVkSW50byhpbnNlcnRpb25Qb2ludCk7Ci0gICAgaWYgKGluc2VydGlvblBvaW50LT5pbkRv Y3VtZW50KCkpCi0gICAgICAgIHJldHVybiBJbnNlcnRpb25TaG91bGRDYWxsRGlkTm90aWZ5RGVz Y2VuZGFudEluc2VydGlvbnM7CiAgICAgcmV0dXJuIEluc2VydGlvbkRvbmU7CiB9CiAK