94565 2012-08-20 20:00:00 -0700 [chromium] Allow enumeration of WebRenderingStats structure 2012-09-07 01:58:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 700378 0 nduca 2012-08-20 20:00:00 -0700 [chromium] Allow enumeration of WebRenderingStats structure 700380 1 159598 nduca 2012-08-20 20:03:06 -0700 Created attachment 159598 Patch 700381 2 nduca 2012-08-20 20:03:43 -0700 We constantly have to do 2-way commits to add new fields to this struct. So, allow enumerating them. 700386 3 webkit.review.bot 2012-08-20 20:06:01 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 700409 4 159598 webkit.review.bot 2012-08-20 20:34:30 -0700 Comment on attachment 159598 Patch Attachment 159598 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13547274 700424 5 159611 nduca 2012-08-20 20:56:03 -0700 Created attachment 159611 Patch 714214 6 162691 nduca 2012-09-07 00:32:08 -0700 Created attachment 162691 Patch for landing 714301 7 162691 webkit.review.bot 2012-09-07 01:58:13 -0700 Comment on attachment 162691 Patch for landing Clearing flags on attachment: 162691 Committed r127846: <http://trac.webkit.org/changeset/127846> 714302 8 webkit.review.bot 2012-09-07 01:58:16 -0700 All reviewed patches have been landed. Closing bug. 159598 2012-08-20 20:03:06 -0700 2012-08-20 20:55:59 -0700 Patch bug-94565-20120820200227.patch text/plain 2438 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBkY2RiNWVkZDAyZDlj NmU4NDRiYmNiMzBhMjQ2NjQ2MTUzZTQ1ODg1Li44OTMxNjhmNTA2MDdhZWU0NDZlOWI1NmM1YTBh NGIwMjBiMzQ0OTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOC0yMCAg TmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBbGxv dyBlbnVtZXJhdGlvbiBvZiBXZWJSZW5kZXJpbmdTdGF0cyBzdHJ1Y3R1cmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NTY1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2Vi UmVuZGVyaW5nU3RhdHMuaDoKKyAgICAgICAgKFdlYlJlbmRlcmluZ1N0YXRzKToKKyAgICAgICAg KEVudW1lcmF0b3IpOgorICAgICAgICAoV2ViS2l0OjpXZWJSZW5kZXJpbmdTdGF0czo6RW51bWVy YXRvcjo6fkVudW1lcmF0b3IpOgorICAgICAgICAoV2ViS2l0OjpXZWJSZW5kZXJpbmdTdGF0czo6 ZW51bWVyYXRlRmllbGRzKToKKwogMjAxMi0wOC0xNyAgWmFjaCBLdXpuaWEgIDx6b3JrQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgU2tpYSBNYWduaWZpZXIgZmlsdGVy IHRvIENocm9taXVtIGxheWVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oCmluZGV4IDQwNDc3NjM3OGJiMzZjMTk0NDU4NGE2NjBj NDA1M2FkNjYxYjU2YTguLjk1OWUzMjllYjM5YmVkZmFhYmYwZmJkOTQ0NGFhOTllZTU5NThhYWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUmVuZGVyaW5n U3RhdHMuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlbmRlcmlu Z1N0YXRzLmgKQEAgLTQzLDYgKzQzLDI5IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7CiAg ICAgICAgICwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKDApCiAgICAgewogICAgIH0KKwor ICAgIC8vIEluIGNvbmp1bmN0aW9uIHdpdGggZW51bWVyYXRlRmllbGRzLCB0aGlzIGFsbG93cyB0 aGUgZW1iZWRkZXIgdG8KKyAgICAvLyBlbnVtZXJhdGUgdGhlIHZhbHVlcyBpbiB0aGlzIHN0cnVj dHVyZSB3aXRob3V0CisgICAgLy8gaGF2aW5nIHRvIGVtYmVkIHJlZmVyZW5jZXMgdG8gaXRzIHNw ZWNpZmljIG1lbWJlciB2YXJpYWJsZXMuIFRoaXMKKyAgICAvLyBzaW1wbGlmaWVzIHRoZSBhZGRp dGlvbiBvZiBuZXcgZmllbGRzIHRvIHRoaXMgdHlwZS4KKyAgICBjbGFzcyBFbnVtZXJhdG9yIHsK KyAgICBwdWJsaWM6CisgICAgICAgIHZpcnR1YWwgdm9pZCBhZGRJbnQoY29uc3QgY2hhciogbmFt ZSwgaW50IHZhbHVlKSA9IDA7CisgICAgICAgIHZpcnR1YWwgdm9pZCBhZGREb3VibGUoY29uc3Qg Y2hhciogbmFtZSwgZG91YmxlIHZhbHVlKSA9IDA7CisgICAgcHJvdGVjdGVkOgorICAgICAgICB2 aXJ0dWFsIH5FbnVtZXJhdG9yKCkgeyB9CisgICAgfTsKKworICAgIC8vIE91dHB1dHMgdGhlIGZp ZWxkcyBpbiB0aGlzIHN0cnVjdHVyZSB0byB0aGUgcHJvdmlkZWQgZW51bWVyYXRvci4KKyAgICB2 b2lkIGVudW1lcmF0ZUZpZWxkcyhFbnVtZXJhdG9yKiBlbnVtZXJhdG9yKSBjb25zdAorICAgIHsK KyAgICAgICAgZW51bWVyYXRvci0+YWRkSW50KCJudW1BbmltYXRpb25GcmFtZXMiLCBudW1Bbmlt YXRpb25GcmFtZXMpOworICAgICAgICBlbnVtZXJhdG9yLT5hZGRJbnQoIm51bUZyYW1lc1NlbnRU b1NjcmVlbiIsIG51bUZyYW1lc1NlbnRUb1NjcmVlbik7CisgICAgICAgIGVudW1lcmF0b3ItPmFk ZEludCgiZHJvcHBlZEZyYW1lQ291bnQiLCBkcm9wcGVkRnJhbWVDb3VudCk7CisgICAgICAgIGVu dW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxQYWludFRpbWVJblNlY29uZHMiLCB0b3RhbFBhaW50 VGltZUluU2Vjb25kcyk7CisgICAgICAgIGVudW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxSYXN0 ZXJpemVUaW1lSW5TZWNvbmRzIiwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKTsKKyAgICAg ICAgZW51bWVyYXRvci0+YWRkRG91YmxlKCJtb25vdG9uaWNUaW1lT2ZMYXN0RnJhbWVTZW50VG9T Y3JlZW5JblNlY29uZHMiLCBtb25vdG9uaWNUaW1lT2ZMYXN0RnJhbWVTZW50VG9TY3JlZW5JblNl Y29uZHMpOworICAgIH0KIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo= 159611 2012-08-20 20:56:03 -0700 2012-09-07 00:32:05 -0700 Patch bug-94565-20120820205523.patch text/plain 2310 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBkY2RiNWVkZDAyZDlj NmU4NDRiYmNiMzBhMjQ2NjQ2MTUzZTQ1ODg1Li44OTMxNjhmNTA2MDdhZWU0NDZlOWI1NmM1YTBh NGIwMjBiMzQ0OTg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOC0yMCAg TmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBbGxv dyBlbnVtZXJhdGlvbiBvZiBXZWJSZW5kZXJpbmdTdGF0cyBzdHJ1Y3R1cmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NTY1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2Vi UmVuZGVyaW5nU3RhdHMuaDoKKyAgICAgICAgKFdlYlJlbmRlcmluZ1N0YXRzKToKKyAgICAgICAg KEVudW1lcmF0b3IpOgorICAgICAgICAoV2ViS2l0OjpXZWJSZW5kZXJpbmdTdGF0czo6RW51bWVy YXRvcjo6fkVudW1lcmF0b3IpOgorICAgICAgICAoV2ViS2l0OjpXZWJSZW5kZXJpbmdTdGF0czo6 ZW51bWVyYXRlRmllbGRzKToKKwogMjAxMi0wOC0xNyAgWmFjaCBLdXpuaWEgIDx6b3JrQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgU2tpYSBNYWduaWZpZXIgZmlsdGVy IHRvIENocm9taXVtIGxheWVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oCmluZGV4IDQwNDc3NjM3OGJiMzZjMTk0NDU4NGE2NjBj NDA1M2FkNjYxYjU2YTguLjdiMmY2NDEwYmMwZGU1OGU2OGMwYjJmMDdiNDAwODAzMjBiYTdmOTIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUmVuZGVyaW5n U3RhdHMuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlbmRlcmlu Z1N0YXRzLmgKQEAgLTQzLDYgKzQzLDI4IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7CiAg ICAgICAgICwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKDApCiAgICAgewogICAgIH0KKwor ICAgIC8vIEluIGNvbmp1bmN0aW9uIHdpdGggZW51bWVyYXRlRmllbGRzLCB0aGlzIGFsbG93cyB0 aGUgZW1iZWRkZXIgdG8KKyAgICAvLyBlbnVtZXJhdGUgdGhlIHZhbHVlcyBpbiB0aGlzIHN0cnVj dHVyZSB3aXRob3V0CisgICAgLy8gaGF2aW5nIHRvIGVtYmVkIHJlZmVyZW5jZXMgdG8gaXRzIHNw ZWNpZmljIG1lbWJlciB2YXJpYWJsZXMuIFRoaXMKKyAgICAvLyBzaW1wbGlmaWVzIHRoZSBhZGRp dGlvbiBvZiBuZXcgZmllbGRzIHRvIHRoaXMgdHlwZS4KKyAgICBjbGFzcyBFbnVtZXJhdG9yIHsK KyAgICBwdWJsaWM6CisgICAgICAgIHZpcnR1YWwgdm9pZCBhZGRJbnQoY29uc3QgY2hhciogbmFt ZSwgaW50IHZhbHVlKSA9IDA7CisgICAgICAgIHZpcnR1YWwgdm9pZCBhZGREb3VibGUoY29uc3Qg Y2hhciogbmFtZSwgZG91YmxlIHZhbHVlKSA9IDA7CisgICAgcHJvdGVjdGVkOgorICAgICAgICB2 aXJ0dWFsIH5FbnVtZXJhdG9yKCkgeyB9CisgICAgfTsKKworICAgIC8vIE91dHB1dHMgdGhlIGZp ZWxkcyBpbiB0aGlzIHN0cnVjdHVyZSB0byB0aGUgcHJvdmlkZWQgZW51bWVyYXRvci4KKyAgICB2 b2lkIGVudW1lcmF0ZUZpZWxkcyhFbnVtZXJhdG9yKiBlbnVtZXJhdG9yKSBjb25zdAorICAgIHsK KyAgICAgICAgZW51bWVyYXRvci0+YWRkSW50KCJudW1BbmltYXRpb25GcmFtZXMiLCBudW1Bbmlt YXRpb25GcmFtZXMpOworICAgICAgICBlbnVtZXJhdG9yLT5hZGRJbnQoIm51bUZyYW1lc1NlbnRU b1NjcmVlbiIsIG51bUZyYW1lc1NlbnRUb1NjcmVlbik7CisgICAgICAgIGVudW1lcmF0b3ItPmFk ZEludCgiZHJvcHBlZEZyYW1lQ291bnQiLCBkcm9wcGVkRnJhbWVDb3VudCk7CisgICAgICAgIGVu dW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxQYWludFRpbWVJblNlY29uZHMiLCB0b3RhbFBhaW50 VGltZUluU2Vjb25kcyk7CisgICAgICAgIGVudW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxSYXN0 ZXJpemVUaW1lSW5TZWNvbmRzIiwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKTsKKyAgICB9 CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK 162691 2012-09-07 00:32:08 -0700 2012-09-07 01:58:13 -0700 Patch for landing bug-94565-20120907003148.patch text/plain 2313 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA3NjQ4ZmIwMzEyYzli ZTk1OWE2ZTRhNDljODU0M2VlMGIwYWI3ZmIzLi41OWNhYjNmYWRkZTVlMWZhNGJiZTEwNTA5MDUz NzkyMzg4YjQ5NWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0wNyAg TmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+CisgICAgICAgIFtjaHJvbWl1bV0gQWxsb3cg ZW51bWVyYXRpb24gb2YgV2ViUmVuZGVyaW5nU3RhdHMgc3RydWN0dXJlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2NQorCisgICAgICAgIFJldmll d2VkIGJ5IEphbWVzIFJvYmluc29uLgorCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYlJl bmRlcmluZ1N0YXRzLmg6CisgICAgICAgIChXZWJSZW5kZXJpbmdTdGF0cyk6CisgICAgICAgIChF bnVtZXJhdG9yKToKKyAgICAgICAgKFdlYktpdDo6V2ViUmVuZGVyaW5nU3RhdHM6OkVudW1lcmF0 b3I6On5FbnVtZXJhdG9yKToKKyAgICAgICAgKFdlYktpdDo6V2ViUmVuZGVyaW5nU3RhdHM6OmVu dW1lcmF0ZUZpZWxkcyk6CisKIDIwMTItMDktMDUgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjc2MTIs IHIxMjc2NjAsIGFuZCByMTI3NjY0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3B1YmxpYy9XZWJSZW5kZXJpbmdTdGF0cy5oCmluZGV4IDQwNDc3NjM3OGJiMzZjMTk0NDU4NGE2 NjBjNDA1M2FkNjYxYjU2YTguLjdiMmY2NDEwYmMwZGU1OGU2OGMwYjJmMDdiNDAwODAzMjBiYTdm OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViUmVuZGVy aW5nU3RhdHMuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYlJlbmRl cmluZ1N0YXRzLmgKQEAgLTQzLDYgKzQzLDI4IEBAIHN0cnVjdCBXZWJSZW5kZXJpbmdTdGF0cyB7 CiAgICAgICAgICwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKDApCiAgICAgewogICAgIH0K KworICAgIC8vIEluIGNvbmp1bmN0aW9uIHdpdGggZW51bWVyYXRlRmllbGRzLCB0aGlzIGFsbG93 cyB0aGUgZW1iZWRkZXIgdG8KKyAgICAvLyBlbnVtZXJhdGUgdGhlIHZhbHVlcyBpbiB0aGlzIHN0 cnVjdHVyZSB3aXRob3V0CisgICAgLy8gaGF2aW5nIHRvIGVtYmVkIHJlZmVyZW5jZXMgdG8gaXRz IHNwZWNpZmljIG1lbWJlciB2YXJpYWJsZXMuIFRoaXMKKyAgICAvLyBzaW1wbGlmaWVzIHRoZSBh ZGRpdGlvbiBvZiBuZXcgZmllbGRzIHRvIHRoaXMgdHlwZS4KKyAgICBjbGFzcyBFbnVtZXJhdG9y IHsKKyAgICBwdWJsaWM6CisgICAgICAgIHZpcnR1YWwgdm9pZCBhZGRJbnQoY29uc3QgY2hhciog bmFtZSwgaW50IHZhbHVlKSA9IDA7CisgICAgICAgIHZpcnR1YWwgdm9pZCBhZGREb3VibGUoY29u c3QgY2hhciogbmFtZSwgZG91YmxlIHZhbHVlKSA9IDA7CisgICAgcHJvdGVjdGVkOgorICAgICAg ICB2aXJ0dWFsIH5FbnVtZXJhdG9yKCkgeyB9CisgICAgfTsKKworICAgIC8vIE91dHB1dHMgdGhl IGZpZWxkcyBpbiB0aGlzIHN0cnVjdHVyZSB0byB0aGUgcHJvdmlkZWQgZW51bWVyYXRvci4KKyAg ICB2b2lkIGVudW1lcmF0ZUZpZWxkcyhFbnVtZXJhdG9yKiBlbnVtZXJhdG9yKSBjb25zdAorICAg IHsKKyAgICAgICAgZW51bWVyYXRvci0+YWRkSW50KCJudW1BbmltYXRpb25GcmFtZXMiLCBudW1B bmltYXRpb25GcmFtZXMpOworICAgICAgICBlbnVtZXJhdG9yLT5hZGRJbnQoIm51bUZyYW1lc1Nl bnRUb1NjcmVlbiIsIG51bUZyYW1lc1NlbnRUb1NjcmVlbik7CisgICAgICAgIGVudW1lcmF0b3It PmFkZEludCgiZHJvcHBlZEZyYW1lQ291bnQiLCBkcm9wcGVkRnJhbWVDb3VudCk7CisgICAgICAg IGVudW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxQYWludFRpbWVJblNlY29uZHMiLCB0b3RhbFBh aW50VGltZUluU2Vjb25kcyk7CisgICAgICAgIGVudW1lcmF0b3ItPmFkZERvdWJsZSgidG90YWxS YXN0ZXJpemVUaW1lSW5TZWNvbmRzIiwgdG90YWxSYXN0ZXJpemVUaW1lSW5TZWNvbmRzKTsKKyAg ICB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK