94563 2012-08-20 19:23:00 -0700 [V8] Move handleOutOfMemory() from V8Proxy to V8Binding 2012-08-20 23:51:02 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 700356 0 haraken 2012-08-20 19:23:00 -0700 To kill V8Proxy, we can move handleOutOfMemory() from V8Proxy to V8Binding. 700415 1 159606 haraken 2012-08-20 20:50:35 -0700 Created attachment 159606 Patch 700511 2 159606 webkit.review.bot 2012-08-20 23:50:58 -0700 Comment on attachment 159606 Patch Clearing flags on attachment: 159606 Committed r126137: <http://trac.webkit.org/changeset/126137> 700512 3 webkit.review.bot 2012-08-20 23:51:02 -0700 All reviewed patches have been landed. Closing bug. 159606 2012-08-20 20:50:35 -0700 2012-08-20 23:50:58 -0700 Patch bug-94563-20120821124955.patch text/plain 6729 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTgzNDUzMGFhYWZjZjNm YjMyNTk0YmI3YTVmNGVmOTAzNDJlMjk2Ny4uYjJlYzAwZTVhM2JiZjQ5MzIxZmQ0MzQxODZjYjc2 MTdmNWZhZjg5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA4LTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgaGFu ZGxlT3V0T2ZNZW1vcnkoKSBmcm9tIFY4UHJveHkgdG8gVjhCaW5kaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRvIGtpbGwgVjhQcm94eSwgdGhpcyBw YXRjaCBtb3ZlcyBoYW5kbGVPdXRPZk1lbW9yeSgpIGZyb20gVjhQcm94eSB0byBWOEJpbmRpbmcu CisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAq IGJpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjppbnZva2VFdmVudEhhbmRsZXIpOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYW5kbGVP dXRPZk1lbW9yeSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9W OEJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4 UHJveHkuY3BwOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuaDoKKyAgICAgICAgKFY4 UHJveHkpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94 eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OnJ1 blNjcmlwdCk6CisKIDIwMTItMDgtMjAgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFNoYWRvd1Jvb3QuY2xvbmVOb2RlKCkgbXVzdCBhbHdheXMgdGhy b3cgYSBEQVRBX0NMT05FX0VSUiBleGNlcHRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5jcHAKaW5kZXggMTdhMDM3OWVm Y2QxM2U1ZWM0MzI0ZjYyNGMyZmYzNjAyNmI3MzZhNy4uYmM0Nzc2NmY5NGI0OGFkMGI2NmVhZDll NDE1ZmYzY2IzZTU5YTRmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcApAQCAtMTgxLDcgKzE4MSw3IEBAIHZvaWQg VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6Omludm9rZUV2ZW50SGFuZGxlcihTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBjb250ZXh0CiAgICAgaWYgKGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygp LmJlZm9yZXVubG9hZEV2ZW50IHx8IGV2ZW50LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLnVubG9h ZEV2ZW50KQogICAgICAgICBEYXRlRXh0ZW5zaW9uOjpnZXQoKS0+c2V0QWxsb3dTbGVlcCh0cnVl KTsKIAotICAgIEFTU0VSVCghVjhQcm94eTo6aGFuZGxlT3V0T2ZNZW1vcnkoKSB8fCByZXR1cm5W YWx1ZS5Jc0VtcHR5KCkpOworICAgIEFTU0VSVCghaGFuZGxlT3V0T2ZNZW1vcnkoKSB8fCByZXR1 cm5WYWx1ZS5Jc0VtcHR5KCkpOwogCiAgICAgaWYgKHJldHVyblZhbHVlLklzRW1wdHkoKSkKICAg ICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhC aW5kaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKaW5k ZXggOWU3OWYzOWI3NDAzMDEyYzEwZWM2OTY2ODQ5YjBlNzA4N2NjZTg3Yi4uNjQ5Y2ViOWMxOTlj MGQyMzJhODZiZWY1ZTIzYjVmZDM4ZjYyMTU0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5jbHVkZSAiTWVtb3J5SW5zdHJ1 bWVudGF0aW9uLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJpbmcuaCIKICNpbmNsdWRlICJRdWFs aWZpZWROYW1lLmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJWOERPTVN0cmlu Z0xpc3QuaCIKICNpbmNsdWRlICJWOERPTVdpbmRvdy5oIgogI2luY2x1ZGUgIlY4RWxlbWVudC5o IgpAQCAtNDEwLDYgKzQxMSwzMSBAQCBWOFBlckNvbnRleHREYXRhKiBwZXJDb250ZXh0RGF0YUZv ckN1cnJlbnRXb3JsZChGcmFtZSogZnJhbWUpCiAgICAgcmV0dXJuIGZyYW1lLT5zY3JpcHQoKS0+ d2luZG93U2hlbGwoKS0+cGVyQ29udGV4dERhdGEoKTsKIH0KIAorYm9vbCBoYW5kbGVPdXRPZk1l bW9yeSgpCit7CisgICAgdjg6OkxvY2FsPHY4OjpDb250ZXh0PiBjb250ZXh0ID0gdjg6OkNvbnRl eHQ6OkdldEN1cnJlbnQoKTsKKworICAgIGlmICghY29udGV4dC0+SGFzT3V0T2ZNZW1vcnlFeGNl cHRpb24oKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gV2FybmluZywgZXJyb3Is IGRpc2FibGUgSlMgZm9yIHRoaXMgZnJhbWU/CisgICAgRnJhbWUqIGZyYW1lID0gdG9GcmFtZUlm Tm90RGV0YWNoZWQoY29udGV4dCk7CisgICAgaWYgKCFmcmFtZSkKKyAgICAgICAgcmV0dXJuIHRy dWU7CisKKyAgICBmcmFtZS0+c2NyaXB0KCktPmNsZWFyRm9yQ2xvc2UoKTsKKyAgICBmcmFtZS0+ c2NyaXB0KCktPndpbmRvd1NoZWxsKCktPmRlc3Ryb3lHbG9iYWwoKTsKKworI2lmIFBMQVRGT1JN KENIUk9NSVVNKQorICAgIFBsYXRmb3JtU3VwcG9ydDo6bm90aWZ5SlNPdXRPZk1lbW9yeShmcmFt ZSk7CisjZW5kaWYKKworICAgIGlmIChTZXR0aW5ncyogc2V0dGluZ3MgPSBmcmFtZS0+c2V0dGlu Z3MoKSkKKyAgICAgICAgc2V0dGluZ3MtPnNldFNjcmlwdEVuYWJsZWQoZmFsc2UpOworCisgICAg cmV0dXJuIHRydWU7Cit9CisKIHZvaWQgY3Jhc2hJZlY4SXNEZWFkKCkKIHsKICAgICBpZiAodjg6 OlY4OjpJc0RlYWQoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhCaW5kaW5nLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuaAppbmRl eCAzNDE5ZWI2MGY5MDZiYTQxYTQ4ODQyYThjMzY1YTU5NjJlNWNhOGQ5Li5hNGM1ZjBiNWQyZDdj Mjc2MzlhMzJmNmQwYzA4MGNkMzZkNGEzNWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOEJpbmRpbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OEJpbmRpbmcuaApAQCAtMzc4LDYgKzM3OCwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg Ly8gUmV0dXJucyB0aGUgUGVyQ29udGV4dERhdGEgYXNzb2NpYXRlZCB3aXRoIGEgZnJhbWUgZm9y IHRoZSBjdXJyZW50IGlzb2xhdGVkIHdvcmxkLgogICAgIFY4UGVyQ29udGV4dERhdGEqIHBlckNv bnRleHREYXRhRm9yQ3VycmVudFdvcmxkKEZyYW1lKik7CiAKKyAgICAvLyBJZiB0aGUgY3VycmVu dCBjb250ZXh0IGNhdXNlcyBvdXQgb2YgbWVtb3J5LCBKYXZhU2NyaXB0IHNldHRpbmcKKyAgICAv LyBpcyBkaXNhYmxlZCBhbmQgaXQgcmV0dXJucyB0cnVlLgorICAgIGJvb2wgaGFuZGxlT3V0T2ZN ZW1vcnkoKTsKKwogICAgIHZvaWQgY3Jhc2hJZlY4SXNEZWFkKCk7CiAKICAgICBjbGFzcyBWOFBh cmFtZXRlckJhc2UgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAppbmRleCBl YWJlMDJhNGYzNmU5OGMwMTU2OTJiODFkMTBjM2U5NWU3OGE4OWQ0Li5iMWEwZmEwYTQwMDBlNTRi YTQ1YWJkMGJjMmI5NGU3ZDdjM2Y2NGI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBy b3h5LmNwcApAQCAtMTMyLDMxICsxMzIsNiBAQCB2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+IFY4UHJv eHk6OmNvbXBpbGVTY3JpcHQodjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBjb2RlLCBjb25zdAogICAg IHJldHVybiBzY3JpcHQ7CiB9CiAKLWJvb2wgVjhQcm94eTo6aGFuZGxlT3V0T2ZNZW1vcnkoKQot ewotICAgIHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dCA9IHY4OjpDb250ZXh0OjpHZXRD dXJyZW50KCk7Ci0KLSAgICBpZiAoIWNvbnRleHQtPkhhc091dE9mTWVtb3J5RXhjZXB0aW9uKCkp Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIC8vIFdhcm5pbmcsIGVycm9yLCBkaXNhYmxl IEpTIGZvciB0aGlzIGZyYW1lPwotICAgIEZyYW1lKiBmcmFtZSA9IHRvRnJhbWVJZk5vdERldGFj aGVkKGNvbnRleHQpOwotICAgIGlmICghZnJhbWUpCi0gICAgICAgIHJldHVybiB0cnVlOwotCi0g ICAgZnJhbWUtPnNjcmlwdCgpLT5jbGVhckZvckNsb3NlKCk7Ci0gICAgZnJhbWUtPnNjcmlwdCgp LT53aW5kb3dTaGVsbCgpLT5kZXN0cm95R2xvYmFsKCk7Ci0KLSNpZiBQTEFURk9STShDSFJPTUlV TSkKLSAgICBQbGF0Zm9ybVN1cHBvcnQ6Om5vdGlmeUpTT3V0T2ZNZW1vcnkoZnJhbWUpOwotI2Vu ZGlmCi0KLSAgICBpZiAoU2V0dGluZ3MqIHNldHRpbmdzID0gZnJhbWUtPnNldHRpbmdzKCkpCi0g ICAgICAgIHNldHRpbmdzLT5zZXRTY3JpcHRFbmFibGVkKGZhbHNlKTsKLQotICAgIHJldHVybiB0 cnVlOwotfQotCiBQYXNzT3duUHRyPHY4OjpTY3JpcHREYXRhPiBWOFByb3h5OjpwcmVjb21waWxl U2NyaXB0KHY4OjpIYW5kbGU8djg6OlN0cmluZz4gY29kZSwgQ2FjaGVkU2NyaXB0KiBjYWNoZWRT Y3JpcHQpCiB7CiAgICAgLy8gQSBwc2V1ZG8tcmFuZG9tbHkgY2hvc2VuIElEIHVzZWQgdG8gc3Rv cmUgYW5kIHJldHJpZXZlIFY4IFNjcmlwdERhdGEgZnJvbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhQcm94eS5oCmluZGV4IGFmYjA0MDM3ZGNmOGMxZGM4MDJiZjE3MTVkY2ZjOWVmMGU0NjUwNDUu LjFlM2Q2N2I0Njg3ZWQ2MDJhZWJmMmJiY2I5OTc4ZWJkMzk4MWRjZWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOFByb3h5LmgKQEAgLTEwNCwxMCArMTA0LDYgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICAvLyBhIG5ldyBjb250ZXh0LiBJdCBpcyBwb3RlbnRpYWxseSBzbG93IGFu ZCBjb25zdW1lcyBtZW1vcnkuCiAgICAgICAgIHN0YXRpYyB2ODo6TG9jYWw8djg6OkNvbnRleHQ+ IGNvbnRleHQoRnJhbWUqKTsKIAotICAgICAgICAvLyBJZiB0aGUgY3VycmVudCBjb250ZXh0IGNh dXNlcyBvdXQgb2YgbWVtb3J5LCBKYXZhU2NyaXB0IHNldHRpbmcKLSAgICAgICAgLy8gaXMgZGlz YWJsZWQgYW5kIGl0IHJldHVybnMgdHJ1ZS4KLSAgICAgICAgc3RhdGljIGJvb2wgaGFuZGxlT3V0 T2ZNZW1vcnkoKTsKLQogICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6U2NyaXB0PiBjb21w aWxlU2NyaXB0KHY4OjpIYW5kbGU8djg6OlN0cmluZz4gY29kZSwgY29uc3QgU3RyaW5nJiBmaWxl TmFtZSwgY29uc3QgVGV4dFBvc2l0aW9uJiBzY3JpcHRTdGFydFBvc2l0aW9uLCB2ODo6U2NyaXB0 RGF0YSogPSAwKTsKIAogICAgICAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRleHQoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVj dXRpb25Qcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJDb250ZXh0 RXhlY3V0aW9uUHJveHkuY3BwCmluZGV4IGUwMzI1NWY4Mjg3NmZkOWJkMTkzOWYxMzM4MzViZjk0 YzgxYzhlNDAuLjA3YTM2Nzk2YjM3NjRiYWQ0YzdiMGUyYjEwYjM0MGZlZTBlYjNlMTQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4 ZWN1dGlvblByb3h5LmNwcApAQCAtMjUzLDcgKzI1Myw3IEBAIHY4OjpMb2NhbDx2ODo6VmFsdWU+ IFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6cnVuU2NyaXB0KHY4OjpIYW5kbGU8djg6OlNj cmlwCiAgICAgICAgIHNjcmlwdCA9IFY4UHJveHk6OmNvbXBpbGVTY3JpcHQoY29kZSwgIiIsIFRl eHRQb3NpdGlvbjo6bWluaW11bVBvc2l0aW9uKCkpOwogICAgIH0KIAotICAgIGlmIChWOFByb3h5 OjpoYW5kbGVPdXRPZk1lbW9yeSgpKQorICAgIGlmIChoYW5kbGVPdXRPZk1lbW9yeSgpKQogICAg ICAgICBBU1NFUlQoc2NyaXB0LklzRW1wdHkoKSk7CiAKICAgICBpZiAoc2NyaXB0LklzRW1wdHko KSkK