94560 2012-08-20 19:13:33 -0700 [EFL] Support slider tick mark snapping 2012-08-22 05:48:28 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 ky0.choi webkit-unassigned gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 700346 0 ky0.choi 2012-08-20 19:13:33 -0700 Support slider tick mark snapping by implementing RenderThemeEfl::sliderTickSnappingThreshold(). 700360 1 159591 ky0.choi 2012-08-20 19:28:43 -0700 Created attachment 159591 Patch I set threshold value 5. It's natural, I think. Chromium port uses 5 also. 700738 2 159591 rakuco 2012-08-21 07:39:39 -0700 Comment on attachment 159591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159591&action=review > Source/WebCore/platform/efl/RenderThemeEfl.cpp:817 > + static const int threshold = 5; > + > + return threshold; Why not `return 5', perhaps with a comment explaining where the number came from? 701382 3 ky0.choi 2012-08-21 17:43:07 -0700 (In reply to comment #2) > (From update of attachment 159591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159591&action=review > > > Source/WebCore/platform/efl/RenderThemeEfl.cpp:817 > > + static const int threshold = 5; > > + > > + return threshold; > > Why not `return 5', perhaps with a comment explaining where the number came from? I refer to already merged code above this method. int RenderThemeEfl::sliderTickOffsetFromTrackCenter() const { static const int sliderTickOffset = -12; return sliderTickOffset; } What shall I do? change it to 'return 5;' with a comment? 701454 4 159591 rakuco 2012-08-21 18:29:12 -0700 Comment on attachment 159591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159591&action=review >>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:817 >>> + return threshold; >> >> Why not `return 5', perhaps with a comment explaining where the number came from? > > I refer to already merged code above this method. > > int RenderThemeEfl::sliderTickOffsetFromTrackCenter() const > { > static const int sliderTickOffset = -12; > > return sliderTickOffset; > } > > What shall I do? change it to 'return 5;' with a comment? Yes, that looks clearer. 701456 5 ky0.choi 2012-08-21 18:32:26 -0700 (In reply to comment #4) > (From update of attachment 159591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159591&action=review > > >>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:817 > >>> + return threshold; > >> > >> Why not `return 5', perhaps with a comment explaining where the number came from? > > > > I refer to already merged code above this method. > > > > int RenderThemeEfl::sliderTickOffsetFromTrackCenter() const > > { > > static const int sliderTickOffset = -12; > > > > return sliderTickOffset; > > } > > > > What shall I do? change it to 'return 5;' with a comment? > > Yes, that looks clearer. OK. I will. 701487 6 159843 ky0.choi 2012-08-21 19:04:47 -0700 Created attachment 159843 Patch 701497 7 gyuyoung.kim 2012-08-21 19:20:30 -0700 (In reply to comment #3) int RenderThemeEfl::sliderTickOffsetFromTrackCenter() const { static const int sliderTickOffset = -12; return sliderTickOffset; } In my opinion, above style is also good. But, *return 5* is being used by chromium port. So, if there is no objection, looks good to me. 701498 8 159843 rakuco 2012-08-21 19:34:21 -0700 Comment on attachment 159843 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159843&action=review > Source/WebCore/platform/efl/RenderThemeEfl.cpp:815 > + // It's natural to use 5 px for threshold. Erm, that doesn't sound very convincing. You can say you are using the same threshold value as the Chromium port, or explain why 5px makes more sense than any other value. 701561 9 159857 ky0.choi 2012-08-21 22:08:12 -0700 Created attachment 159857 Patch Modified comment. 701565 10 159857 rakuco 2012-08-21 22:20:44 -0700 Comment on attachment 159857 Patch Looks OK to me now. 701780 11 159857 kenneth 2012-08-22 05:14:16 -0700 Comment on attachment 159857 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159857&action=review > LayoutTests/platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:-8 > value for 42 is <500 > value for 43 is <500 > value for 44 is <500 > -value for 45 is <500 Why do we need a platform expected result? like do we still differ? Like how are the Android values for instnace? > Source/WebCore/platform/efl/RenderThemeEfl.cpp:817 > +LayoutUnit RenderThemeEfl::sliderTickSnappingThreshold() const > +{ > + // The same threshold value as the Chromium port. > + return 5; > +} So this sounds as we can share the result 701804 12 159857 ky0.choi 2012-08-22 05:41:51 -0700 Comment on attachment 159857 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159857&action=review >> LayoutTests/platform/efl/fast/forms/datalist/range-snap-to-datalist-expected.txt:-8 >> -value for 45 is <500 > > Why do we need a platform expected result? like do we still differ? Like how are the Android values for instnace? Actually, there is no common expected result for this test. And, only Chrome port has a platform expected result which is same as EFL for now. 701811 13 159857 webkit.review.bot 2012-08-22 05:48:24 -0700 Comment on attachment 159857 Patch Clearing flags on attachment: 159857 Committed r126292: <http://trac.webkit.org/changeset/126292> 701812 14 webkit.review.bot 2012-08-22 05:48:28 -0700 All reviewed patches have been landed. Closing bug. 159591 2012-08-20 19:28:43 -0700 2012-08-21 19:04:47 -0700 Patch diff text/plain 3786 ky0.choi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmNDk2Mjc5Li45YmRiY2MwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgt MjAgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gU3VwcG9ydCBzbGlkZXIgdGljayBtYXJrIHNuYXBwaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBleHBlY3RlZCByZXN1bHQgb2YgZmFzdC9m b3Jtcy9kYXRhbGlzdC9yYW5nZS1zbmFwLXRvLWRhdGFsaXN0Lmh0bWwKKyAgICAgICAgaXMgdXBk YXRlZCBiZWNhdXNlIHNsaWRlciB0aWNrIG1hcmsgc25hcHBpbmcgdGhyZXNob2xkIGlzIGNoYW5n ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvZmFzdC9mb3Jtcy9kYXRhbGlzdC9yYW5nZS1z bmFwLXRvLWRhdGFsaXN0LWV4cGVjdGVkLnR4dDoKKwogMjAxMi0wOC0yMCAgTGV2aSBXZWludHJh dWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1N1Yi1waXhlbCBMYXlvdXRdIEJs b2NrIHNlbGVjdGlvbiBnYXAgcmVwYWludGluZyBjYW4gbGVhdmUgb25lIHBpeGVsIGdhcHMKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0L2Zvcm1zL2RhdGFsaXN0L3Jh bmdlLXNuYXAtdG8tZGF0YWxpc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL2Zhc3QvZm9ybXMvZGF0YWxpc3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBlY3RlZC50 eHQKaW5kZXggZDlkM2I1MS4uMDc2NmY2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxpc3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxpc3Qv cmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBlY3RlZC50eHQKQEAgLTUsMTcgKzUsMTcgQEAgdmFs dWUgZm9yIDQxIGlzIDw1MDAKIHZhbHVlIGZvciA0MiBpcyA8NTAwCiB2YWx1ZSBmb3IgNDMgaXMg PDUwMAogdmFsdWUgZm9yIDQ0IGlzIDw1MDAKLXZhbHVlIGZvciA0NSBpcyA8NTAwCi12YWx1ZSBm b3IgNDYgaXMgPDUwMAotdmFsdWUgZm9yIDQ3IGlzIDw1MDAKLXZhbHVlIGZvciA0OCBpcyA8NTAw Ci12YWx1ZSBmb3IgNDkgaXMgPDUwMAordmFsdWUgZm9yIDQ1IGlzID01MDAKK3ZhbHVlIGZvciA0 NiBpcyA9NTAwCit2YWx1ZSBmb3IgNDcgaXMgPTUwMAordmFsdWUgZm9yIDQ4IGlzID01MDAKK3Zh bHVlIGZvciA0OSBpcyA9NTAwCiB2YWx1ZSBmb3IgNTAgaXMgPTUwMAotdmFsdWUgZm9yIDUxIGlz ID41MDAKLXZhbHVlIGZvciA1MiBpcyA+NTAwCi12YWx1ZSBmb3IgNTMgaXMgPjUwMAotdmFsdWUg Zm9yIDU0IGlzID41MDAKLXZhbHVlIGZvciA1NSBpcyA+NTAwCit2YWx1ZSBmb3IgNTEgaXMgPTUw MAordmFsdWUgZm9yIDUyIGlzID01MDAKK3ZhbHVlIGZvciA1MyBpcyA9NTAwCit2YWx1ZSBmb3Ig NTQgaXMgPTUwMAordmFsdWUgZm9yIDU1IGlzID01MDAKIHZhbHVlIGZvciA1NiBpcyA+NTAwCiB2 YWx1ZSBmb3IgNTcgaXMgPjUwMAogdmFsdWUgZm9yIDU4IGlzID41MDAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1 Y2QyOTMzLi4wMWQ5M2IxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDgtMjAg IEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0g U3VwcG9ydCBzbGlkZXIgdGljayBtYXJrIHNuYXBwaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY3JlYXNlZCB0aGUgdGhyZXNob2xkIGZvciB0aGUg RUZMIHBvcnQuIFRoZSB2YWx1ZSBpcyBzbmFwcGVkCisgICAgICAgIHdoZW4gaXQgY2xpY2tlZCBu ZWFyIHRpY2sgbWFyay4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgZmFzdC9m b3Jtcy9kYXRhbGlzdC9yYW5nZS1zbmFwLXRvLWRhdGFsaXN0Lmh0bWwuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6c2xpZGVyVGlja1NuYXBwaW5nVGhyZXNob2xk KToKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaDoKKyAgICAgICAgKFJl bmRlclRoZW1lRWZsKToKKwogMjAxMi0wOC0yMCAgQWRhbSBLbGVpbiAgPGFkYW1rQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBBbGxvdyBNdXRhdGlvbkV2ZW50cyB0byBiZSBlbmFibGVkL2Rpc2Fi bGVkIHBlciBjb250ZXh0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRo ZW1lRWZsLmNwcAppbmRleCBlMDdkZDg0Li5mMWI2NjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5jcHAKQEAgLTgwOSw2ICs4MDksMTMgQEAgaW50 IFJlbmRlclRoZW1lRWZsOjpzbGlkZXJUaWNrT2Zmc2V0RnJvbVRyYWNrQ2VudGVyKCkgY29uc3QK IAogICAgIHJldHVybiBzbGlkZXJUaWNrT2Zmc2V0OwogfQorCitMYXlvdXRVbml0IFJlbmRlclRo ZW1lRWZsOjpzbGlkZXJUaWNrU25hcHBpbmdUaHJlc2hvbGQoKSBjb25zdAoreworICAgIHN0YXRp YyBjb25zdCBpbnQgdGhyZXNob2xkID0gNTsKKworICAgIHJldHVybiB0aHJlc2hvbGQ7Cit9CiAj ZW5kaWYKIAogYm9vbCBSZW5kZXJUaGVtZUVmbDo6c3VwcG9ydHNEYXRhTGlzdFVJKGNvbnN0IEF0 b21pY1N0cmluZyYgdHlwZSkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Jl bmRlclRoZW1lRWZsLmgKaW5kZXggNjQxZTUyNi4uYjk3ZmRkMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKQEAgLTE2NCw2ICsxNjQsNyBAQCBwdWJs aWM6CiAjaWYgRU5BQkxFKERBVEFMSVNUX0VMRU1FTlQpCiAgICAgdmlydHVhbCBJbnRTaXplIHNs aWRlclRpY2tTaXplKCkgY29uc3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBpbnQgc2xpZGVyVGlj a09mZnNldEZyb21UcmFja0NlbnRlcigpIGNvbnN0IE9WRVJSSURFOworICAgIHZpcnR1YWwgTGF5 b3V0VW5pdCBzbGlkZXJUaWNrU25hcHBpbmdUaHJlc2hvbGQoKSBjb25zdCBPVkVSUklERTsKICNl bmRpZgogCiAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzRGF0YUxpc3RVSShjb25zdCBBdG9taWNT dHJpbmcmKSBjb25zdCBPVkVSUklERTsK 159843 2012-08-21 19:04:47 -0700 2012-08-21 22:08:12 -0700 Patch diff text/plain 3826 ky0.choi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyZGM5ZGZjLi5jMDZhZTM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgt MjEgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gU3VwcG9ydCBzbGlkZXIgdGljayBtYXJrIHNuYXBwaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBleHBlY3RlZCByZXN1bHQgb2YgZmFzdC9m b3Jtcy9kYXRhbGlzdC9yYW5nZS1zbmFwLXRvLWRhdGFsaXN0Lmh0bWwKKyAgICAgICAgaXMgdXBk YXRlZCBiZWNhdXNlIHNsaWRlciB0aWNrIG1hcmsgc25hcHBpbmcgdGhyZXNob2xkIGlzIGNoYW5n ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvZmFzdC9mb3Jtcy9kYXRhbGlzdC9yYW5nZS1z bmFwLXRvLWRhdGFsaXN0LWV4cGVjdGVkLnR4dDoKKwogMjAxMi0wOC0yMSAgQnJhZHkgRWlkc29u ICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmViYXNlbGluZSB2YXJpb3VzIHRlc3Rz IGZvciBNb3VudGFpbiBMaW9uIHRoYXQgZGlmZmVyIGZyb20gdGhlIGdlbmVyaWMgcmVzdWx0cy4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0L2Zvcm1zL2RhdGFsaXN0 L3JhbmdlLXNuYXAtdG8tZGF0YWxpc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxpc3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBlY3Rl ZC50eHQKaW5kZXggZDlkM2I1MS4uMDc2NmY2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxpc3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxp c3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBlY3RlZC50eHQKQEAgLTUsMTcgKzUsMTcgQEAg dmFsdWUgZm9yIDQxIGlzIDw1MDAKIHZhbHVlIGZvciA0MiBpcyA8NTAwCiB2YWx1ZSBmb3IgNDMg aXMgPDUwMAogdmFsdWUgZm9yIDQ0IGlzIDw1MDAKLXZhbHVlIGZvciA0NSBpcyA8NTAwCi12YWx1 ZSBmb3IgNDYgaXMgPDUwMAotdmFsdWUgZm9yIDQ3IGlzIDw1MDAKLXZhbHVlIGZvciA0OCBpcyA8 NTAwCi12YWx1ZSBmb3IgNDkgaXMgPDUwMAordmFsdWUgZm9yIDQ1IGlzID01MDAKK3ZhbHVlIGZv ciA0NiBpcyA9NTAwCit2YWx1ZSBmb3IgNDcgaXMgPTUwMAordmFsdWUgZm9yIDQ4IGlzID01MDAK K3ZhbHVlIGZvciA0OSBpcyA9NTAwCiB2YWx1ZSBmb3IgNTAgaXMgPTUwMAotdmFsdWUgZm9yIDUx IGlzID41MDAKLXZhbHVlIGZvciA1MiBpcyA+NTAwCi12YWx1ZSBmb3IgNTMgaXMgPjUwMAotdmFs dWUgZm9yIDU0IGlzID41MDAKLXZhbHVlIGZvciA1NSBpcyA+NTAwCit2YWx1ZSBmb3IgNTEgaXMg PTUwMAordmFsdWUgZm9yIDUyIGlzID01MDAKK3ZhbHVlIGZvciA1MyBpcyA9NTAwCit2YWx1ZSBm b3IgNTQgaXMgPTUwMAordmFsdWUgZm9yIDU1IGlzID01MDAKIHZhbHVlIGZvciA1NiBpcyA+NTAw CiB2YWx1ZSBmb3IgNTcgaXMgPjUwMAogdmFsdWUgZm9yIDU4IGlzID41MDAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAxMjNmMzI0Li5jNDMyMjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDgt MjEgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gU3VwcG9ydCBzbGlkZXIgdGljayBtYXJrIHNuYXBwaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY3JlYXNlZCB0aGUgdGhyZXNob2xkIGZvciB0 aGUgRUZMIHBvcnQuIFRoZSB2YWx1ZSBpcyBzbmFwcGVkCisgICAgICAgIHdoZW4gaXQgY2xpY2tl ZCBuZWFyIHRpY2sgbWFyay4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgZmFz dC9mb3Jtcy9kYXRhbGlzdC9yYW5nZS1zbmFwLXRvLWRhdGFsaXN0Lmh0bWwuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6c2xpZGVyVGlja1NuYXBwaW5nVGhyZXNo b2xkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaDoKKyAgICAgICAg KFJlbmRlclRoZW1lRWZsKToKKwogMjAxMi0wOC0yMSAgQW5kcmV3IExvICA8YW5sb0ByaW0uY29t PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSByZXF1ZXN0QW5pbWF0aW9uRnJhbWU6IFVuc2NoZWR1 bGVkIGRpc3BsYXkgbGluayBmcmFtZXMgbmVlZCB0byBiZSBzZW50IHRvIG1haW4gdGhyZWFkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAppbmRleCBl MDdkZDg0Li4xZmYxYjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5k ZXJUaGVtZUVmbC5jcHAKQEAgLTgwOSw2ICs4MDksMTIgQEAgaW50IFJlbmRlclRoZW1lRWZsOjpz bGlkZXJUaWNrT2Zmc2V0RnJvbVRyYWNrQ2VudGVyKCkgY29uc3QKIAogICAgIHJldHVybiBzbGlk ZXJUaWNrT2Zmc2V0OwogfQorCitMYXlvdXRVbml0IFJlbmRlclRoZW1lRWZsOjpzbGlkZXJUaWNr U25hcHBpbmdUaHJlc2hvbGQoKSBjb25zdAoreworICAgIC8vIEl0J3MgbmF0dXJhbCB0byB1c2Ug NSBweCBmb3IgdGhyZXNob2xkLgorICAgIHJldHVybiA1OworfQogI2VuZGlmCiAKIGJvb2wgUmVu ZGVyVGhlbWVFZmw6OnN1cHBvcnRzRGF0YUxpc3RVSShjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUp IGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhl bWVFZmwuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCmlu ZGV4IDY0MWU1MjYuLmI5N2ZkZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC9SZW5kZXJUaGVtZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9S ZW5kZXJUaGVtZUVmbC5oCkBAIC0xNjQsNiArMTY0LDcgQEAgcHVibGljOgogI2lmIEVOQUJMRShE QVRBTElTVF9FTEVNRU5UKQogICAgIHZpcnR1YWwgSW50U2l6ZSBzbGlkZXJUaWNrU2l6ZSgpIGNv bnN0IE9WRVJSSURFOwogICAgIHZpcnR1YWwgaW50IHNsaWRlclRpY2tPZmZzZXRGcm9tVHJhY2tD ZW50ZXIoKSBjb25zdCBPVkVSUklERTsKKyAgICB2aXJ0dWFsIExheW91dFVuaXQgc2xpZGVyVGlj a1NuYXBwaW5nVGhyZXNob2xkKCkgY29uc3QgT1ZFUlJJREU7CiAjZW5kaWYKIAogICAgIHZpcnR1 YWwgYm9vbCBzdXBwb3J0c0RhdGFMaXN0VUkoY29uc3QgQXRvbWljU3RyaW5nJikgY29uc3QgT1ZF UlJJREU7Cg== 159857 2012-08-21 22:08:12 -0700 2012-08-22 05:48:24 -0700 Patch diff text/plain 3833 ky0.choi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyZGM5ZGZjLi5jMDZhZTM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgt MjEgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gU3VwcG9ydCBzbGlkZXIgdGljayBtYXJrIHNuYXBwaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBleHBlY3RlZCByZXN1bHQgb2YgZmFzdC9m b3Jtcy9kYXRhbGlzdC9yYW5nZS1zbmFwLXRvLWRhdGFsaXN0Lmh0bWwKKyAgICAgICAgaXMgdXBk YXRlZCBiZWNhdXNlIHNsaWRlciB0aWNrIG1hcmsgc25hcHBpbmcgdGhyZXNob2xkIGlzIGNoYW5n ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvZmFzdC9mb3Jtcy9kYXRhbGlzdC9yYW5nZS1z bmFwLXRvLWRhdGFsaXN0LWV4cGVjdGVkLnR4dDoKKwogMjAxMi0wOC0yMSAgQnJhZHkgRWlkc29u ICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmViYXNlbGluZSB2YXJpb3VzIHRlc3Rz IGZvciBNb3VudGFpbiBMaW9uIHRoYXQgZGlmZmVyIGZyb20gdGhlIGdlbmVyaWMgcmVzdWx0cy4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9mYXN0L2Zvcm1zL2RhdGFsaXN0 L3JhbmdlLXNuYXAtdG8tZGF0YWxpc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxpc3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBlY3Rl ZC50eHQKaW5kZXggZDlkM2I1MS4uMDc2NmY2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxpc3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvZm9ybXMvZGF0YWxp c3QvcmFuZ2Utc25hcC10by1kYXRhbGlzdC1leHBlY3RlZC50eHQKQEAgLTUsMTcgKzUsMTcgQEAg dmFsdWUgZm9yIDQxIGlzIDw1MDAKIHZhbHVlIGZvciA0MiBpcyA8NTAwCiB2YWx1ZSBmb3IgNDMg aXMgPDUwMAogdmFsdWUgZm9yIDQ0IGlzIDw1MDAKLXZhbHVlIGZvciA0NSBpcyA8NTAwCi12YWx1 ZSBmb3IgNDYgaXMgPDUwMAotdmFsdWUgZm9yIDQ3IGlzIDw1MDAKLXZhbHVlIGZvciA0OCBpcyA8 NTAwCi12YWx1ZSBmb3IgNDkgaXMgPDUwMAordmFsdWUgZm9yIDQ1IGlzID01MDAKK3ZhbHVlIGZv ciA0NiBpcyA9NTAwCit2YWx1ZSBmb3IgNDcgaXMgPTUwMAordmFsdWUgZm9yIDQ4IGlzID01MDAK K3ZhbHVlIGZvciA0OSBpcyA9NTAwCiB2YWx1ZSBmb3IgNTAgaXMgPTUwMAotdmFsdWUgZm9yIDUx IGlzID41MDAKLXZhbHVlIGZvciA1MiBpcyA+NTAwCi12YWx1ZSBmb3IgNTMgaXMgPjUwMAotdmFs dWUgZm9yIDU0IGlzID41MDAKLXZhbHVlIGZvciA1NSBpcyA+NTAwCit2YWx1ZSBmb3IgNTEgaXMg PTUwMAordmFsdWUgZm9yIDUyIGlzID01MDAKK3ZhbHVlIGZvciA1MyBpcyA9NTAwCit2YWx1ZSBm b3IgNTQgaXMgPTUwMAordmFsdWUgZm9yIDU1IGlzID01MDAKIHZhbHVlIGZvciA1NiBpcyA+NTAw CiB2YWx1ZSBmb3IgNTcgaXMgPjUwMAogdmFsdWUgZm9yIDU4IGlzID41MDAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAxMjNmMzI0Li5jNDMyMjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDgt MjEgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF0gU3VwcG9ydCBzbGlkZXIgdGljayBtYXJrIHNuYXBwaW5nCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluY3JlYXNlZCB0aGUgdGhyZXNob2xkIGZvciB0 aGUgRUZMIHBvcnQuIFRoZSB2YWx1ZSBpcyBzbmFwcGVkCisgICAgICAgIHdoZW4gaXQgY2xpY2tl ZCBuZWFyIHRpY2sgbWFyay4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgZmFz dC9mb3Jtcy9kYXRhbGlzdC9yYW5nZS1zbmFwLXRvLWRhdGFsaXN0Lmh0bWwuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUVmbDo6c2xpZGVyVGlja1NuYXBwaW5nVGhyZXNo b2xkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaDoKKyAgICAgICAg KFJlbmRlclRoZW1lRWZsKToKKwogMjAxMi0wOC0yMSAgQW5kcmV3IExvICA8YW5sb0ByaW0uY29t PgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSByZXF1ZXN0QW5pbWF0aW9uRnJhbWU6IFVuc2NoZWR1 bGVkIGRpc3BsYXkgbGluayBmcmFtZXMgbmVlZCB0byBiZSBzZW50IHRvIG1haW4gdGhyZWFkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAppbmRleCBl MDdkZDg0Li45MmM2OTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv UmVuZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5k ZXJUaGVtZUVmbC5jcHAKQEAgLTgwOSw2ICs4MDksMTIgQEAgaW50IFJlbmRlclRoZW1lRWZsOjpz bGlkZXJUaWNrT2Zmc2V0RnJvbVRyYWNrQ2VudGVyKCkgY29uc3QKIAogICAgIHJldHVybiBzbGlk ZXJUaWNrT2Zmc2V0OwogfQorCitMYXlvdXRVbml0IFJlbmRlclRoZW1lRWZsOjpzbGlkZXJUaWNr U25hcHBpbmdUaHJlc2hvbGQoKSBjb25zdAoreworICAgIC8vIFRoZSBzYW1lIHRocmVzaG9sZCB2 YWx1ZSBhcyB0aGUgQ2hyb21pdW0gcG9ydC4KKyAgICByZXR1cm4gNTsKK30KICNlbmRpZgogCiBi b29sIFJlbmRlclRoZW1lRWZsOjpzdXBwb3J0c0RhdGFMaXN0VUkoY29uc3QgQXRvbWljU3RyaW5n JiB0eXBlKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1Jl bmRlclRoZW1lRWZsLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVF ZmwuaAppbmRleCA2NDFlNTI2Li5iOTdmZGQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9lZmwvUmVuZGVyVGhlbWVFZmwuaApAQCAtMTY0LDYgKzE2NCw3IEBAIHB1YmxpYzoKICNpZiBF TkFCTEUoREFUQUxJU1RfRUxFTUVOVCkKICAgICB2aXJ0dWFsIEludFNpemUgc2xpZGVyVGlja1Np emUoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIGludCBzbGlkZXJUaWNrT2Zmc2V0RnJv bVRyYWNrQ2VudGVyKCkgY29uc3QgT1ZFUlJJREU7CisgICAgdmlydHVhbCBMYXlvdXRVbml0IHNs aWRlclRpY2tTbmFwcGluZ1RocmVzaG9sZCgpIGNvbnN0IE9WRVJSSURFOwogI2VuZGlmCiAKICAg ICB2aXJ0dWFsIGJvb2wgc3VwcG9ydHNEYXRhTGlzdFVJKGNvbnN0IEF0b21pY1N0cmluZyYpIGNv bnN0IE9WRVJSSURFOwo=