9456 2006-06-15 10:52:04 -0700 REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E 2006-06-15 13:01:44 -0700 1 1 1 Unclassified WebKit Text 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 sullivan justin.garcia mitz sullivan oldest_to_newest 45814 0 sullivan 2006-06-15 10:52:04 -0700 This bug is also in Radar as <rdar://4587986> To reproduce: 1. Visit any page that contains a word that occurs more than once, e.g. http://www.amazon.com 2. Double-click such a word (e.g. "the") 3. Cmd-E to put the word on the Find pasteboard 4. Cmd-G to select and reveal the next occurrence The next occurrence isn't found; the selection remains on the word double-clicked in step 1. Note that dragging across the word instead of double-clicking it does not cause this bug to occur, so there's something special about double-clicking here. Also note that if you click outside of the selection after step 3, then Cmd-G will correctly cycle around all occurrences of the word including the first one. So it seems that the text put on the Find pasteboard is correct. ------------------------------------------- 45815 1 sullivan 2006-06-15 11:07:17 -0700 The problem is in Frame::findString() -- there's a test to see whether the result range after calling findPlainText() matches the current selection. If so, the code looks for the next occurrence. But when this bug occurs, the code thinks the result range does not match the selection, so the already-selected text is left selected. This code has not changed recently, and I'm pretty sure that this bug is pretty new. So it seems that the problem is that the Selection computed after double-clicking a word no longer matches the Selection computed after (e.g.) dragging across the same word. Maybe the definition of the "=" operator changed for Selection? Maybe double-clicking is now making the Selection object different in some way than it used to? 45816 2 sullivan 2006-06-15 11:13:43 -0700 I was wrong -- this code has actually changed recently: 2006-06-09 Justin Garcia <justin.garcia@apple.com> Reviewed by levi <rdar://problem/4549980> REGRESSION: "Find Again" can get stuck when searching for string with a trailing space <...> * page/Frame.cpp: (WebCore::Frame::findString): Moved from FrameMac. Compare a selection created using the found range with the current selection in case the current selection is the found range minus some collapsed whitespace on the edges. I strongly suspect that this change was the cause of this regression. I'm reassigning to Justin since he knows this Selection stuff well and he made that recent change. 45827 3 8860 justin.garcia 2006-06-15 12:15:28 -0700 Created attachment 8860 patch 45830 4 8860 justin.garcia 2006-06-15 12:56:38 -0700 Comment on attachment 8860 patch dave reviewed this 45831 5 8860 harrison 2006-06-15 12:56:39 -0700 Comment on attachment 8860 patch r=me 45832 6 justin.garcia 2006-06-15 13:01:44 -0700 r14877 8860 2006-06-15 12:15:28 -0700 2006-06-15 12:56:38 -0700 patch 9456.txt text/plain 6727 justin.garcia SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNDg3NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDYtMDYtMTUgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lh QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIDxodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dp P2lkPTk0NTY+CisgICAgICAgIFJFR1JFU1NJT04gKDQxNy45LjItNDIwKyk6IENtZC1HIGRvZXNu J3Qgd29yayBpbiBTYWZhcmkgYWZ0ZXIgZG91YmxlLWNsaWNrIGFuZCBDbWQtRQorICAgICAgICAK KyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpmaW5k U3RyaW5nKTogV2hlbiBjb21wYXJpbmcgdGhlIGZvdW5kIHJhbmdlIHdpdGgKKyAgICAgICAgd2hh dCdzIGN1cnJlbnRseSBzZWxlY3RlZCBhKSBidWlsZCBhIHNlbGVjdGlvbiB3aXRoIHRoZSBmb3Vu ZAorICAgICAgICByYW5nZSB0byByZW1vdmUgY29sbGFwc2VkIHdoaXRlc3BhY2UgYW5kIGIpIGNv bXBhcmUgcmFuZ2VzIAorICAgICAgICBpbnN0ZWFkIG9mIHNlbGVjdGlvbiBvYmplY3RzIHRvIGln bm9yZSB0aGUgd2F5IHRoYXQgdGhlIAorICAgICAgICBjdXJyZW50IHNlbGVjdGlvbiB3YXMgbWFk ZSAodG8gaWdub3JlIHRoZSBiYXNlIGFuZCBleHRlbnQpLgorCiAyMDA2LTA2LTE1ICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBraWx6ZXIubmV0PgogCiAgICAgICAgIFJldmlld2VkIGJ5IG1qcy4K SW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdl L0ZyYW1lLmNwcAkocmV2aXNpb24gMTQ4NjcpCisrKyBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMzgxLDggKzMzODEsMTAgQEAKICAgICB9CiAgICAgUmVmUHRyPFJh bmdlPiByZXN1bHRSYW5nZShmaW5kUGxhaW5UZXh0KHNlYXJjaFJhbmdlLmdldCgpLCB0YXJnZXQs IGZvcndhcmQsIGNhc2VGbGFnKSk7CiAgICAgU2VsZWN0aW9uIHNlbCA9IHNlbGVjdGlvbigpLnNl bGVjdGlvbigpOwotICAgIC8vIElmIHRoZSBmb3VuZCByYW5nZSBpcyBvbmUgdGhhdCdzIGFscmVh ZHkgc2VsZWN0ZWQsIGZpbmQgYWdhaW4uCi0gICAgaWYgKCFzZWwuaXNOb25lKCkgJiYgU2VsZWN0 aW9uKHJlc3VsdFJhbmdlLmdldCgpKSA9PSBzZWwpIHsKKyAgICAvLyBJZiB0aGUgZm91bmQgcmFu Z2UgaXMgYWxyZWFkeSBzZWxlY3RlZCwgZmluZCBhZ2Fpbi4KKyAgICAvLyBCdWlsZCBhIHNlbGVj dGlvbiB3aXRoIHRoZSBmb3VuZCByYW5nZSB0byByZW1vdmUgY29sbGFwc2VkIHdoaXRlc3BhY2Uu CisgICAgLy8gQ29tcGFyZSByYW5nZXMgaW5zdGVhZCBvZiBzZWxlY3Rpb24gb2JqZWN0cyB0byBp Z25vcmUgdGhlIHdheSB0aGF0IHRoZSBjdXJyZW50IHNlbGVjdGlvbiB3YXMgbWFkZS4KKyAgICBp ZiAoIXNlbC5pc05vbmUoKSAmJiAqU2VsZWN0aW9uKHJlc3VsdFJhbmdlLmdldCgpKS50b1Jhbmdl KCkgPT0gKnNlbC50b1JhbmdlKCkpIHsKICAgICAgICAgc2VhcmNoUmFuZ2UgPSByYW5nZU9mQ29u dGVudHMoZG9jdW1lbnQoKSk7CiAgICAgICAgIGlmIChmb3J3YXJkKQogICAgICAgICAgICAgc2V0 U3RhcnQoc2VhcmNoUmFuZ2UuZ2V0KCksIFZpc2libGVQb3NpdGlvbihzZWwuZW5kKCksIHNlbC5h ZmZpbml0eSgpKSk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNDg3NikKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA2LTA2LTE1ICBKdXN0 aW4gR2FyY2lhICA8anVzdGluLmdhcmNpYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICA8aHR0cDovL2J1Z3ppbGxhLm9w ZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NDU2PgorICAgICAgICBSRUdSRVNTSU9OICg0 MTcuOS4yLTQyMCspOiBDbWQtRyBkb2Vzbid0IHdvcmsgaW4gU2FmYXJpIGFmdGVyIGRvdWJsZS1j bGljayBhbmQgQ21kLUUKKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvZmluZFN0cmlu Zy0yLWV4cGVjdGVkLmNoZWNrc3VtOiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21t YW5kL2ZpbmRTdHJpbmctMi1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcv ZXhlY0NvbW1hbmQvZmluZFN0cmluZy0yLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZWRpdGluZy9leGVjQ29tbWFuZC9maW5kU3RyaW5nLTIuaHRtbDogQWRkZWQuCisKIDIwMDYtMDYt MTQgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBsZXZpCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2Zp bmRTdHJpbmctMi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGlu Zy9leGVjQ29tbWFuZC9maW5kU3RyaW5nLTItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9maW5kU3RyaW5nLTItZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDI0IEBACitFRElUSU5HIERFTEVHQVRFOiBzaG91bGRD aGFuZ2VTZWxlY3RlZERPTVJhbmdlOihudWxsKSB0b0RPTVJhbmdlOnJhbmdlIGZyb20gMSBvZiAj dGV4dCA+IFNQQU4gPiBESVYgPiBCT0RZID4gSFRNTCA+ICNkb2N1bWVudCB0byAxIG9mICN0ZXh0 ID4gU1BBTiA+IERJViA+IEJPRFkgPiBIVE1MID4gI2RvY3VtZW50IGFmZmluaXR5Ok5TU2VsZWN0 aW9uQWZmaW5pdHlEb3duc3RyZWFtIHN0aWxsU2VsZWN0aW5nOkZBTFNFCitFRElUSU5HIERFTEVH QVRFOiB3ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uOldlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb25O b3RpZmljYXRpb24KK0VESVRJTkcgREVMRUdBVEU6IHNob3VsZENoYW5nZVNlbGVjdGVkRE9NUmFu Z2U6cmFuZ2UgZnJvbSAxIG9mICN0ZXh0ID4gU1BBTiA+IERJViA+IEJPRFkgPiBIVE1MID4gI2Rv Y3VtZW50IHRvIDEgb2YgI3RleHQgPiBTUEFOID4gRElWID4gQk9EWSA+IEhUTUwgPiAjZG9jdW1l bnQgdG9ET01SYW5nZTpyYW5nZSBmcm9tIDAgb2YgI3RleHQgPiBTUEFOID4gRElWID4gQk9EWSA+ IEhUTUwgPiAjZG9jdW1lbnQgdG8gMyBvZiAjdGV4dCA+IFNQQU4gPiBESVYgPiBCT0RZID4gSFRN TCA+ICNkb2N1bWVudCBhZmZpbml0eTpOU1NlbGVjdGlvbkFmZmluaXR5RG93bnN0cmVhbSBzdGls bFNlbGVjdGluZzpGQUxTRQorRURJVElORyBERUxFR0FURTogd2ViVmlld0RpZENoYW5nZVNlbGVj dGlvbjpXZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uTm90aWZpY2F0aW9uCitFRElUSU5HIERFTEVH QVRFOiB3ZWJWaWV3RGlkQ2hhbmdlU2VsZWN0aW9uOldlYlZpZXdEaWRDaGFuZ2VTZWxlY3Rpb25O b3RpZmljYXRpb24KK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0 ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRl ckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZ fSBhdCAoOCw4KSBzaXplIDc4NHg1ODQKKyAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAoMCwwKSBz aXplIDc4NHgzNgorICAgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSA3NjV4 MzYKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCA3NjU6ICJUaGlzIHRlc3RzIHRv IHNlZSBpZiBGaW5kIHdpbGwgZ2V0IHN0dWNrIHdoZW4gc2VhcmNoaW5nIGZvciBhIHdvcmQgdGhh dCBpcyBjdXJyZW50bHkgc2VsZWN0ZWQsIGFuZCB3YXMgc2VsZWN0ZWQgd2l0aCBhIGRvdWJsZSIK KyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwxOCkgd2lkdGggMzQ6ICJjbGljay4iCisgICAgICBS ZW5kZXJCbG9jayB7RElWfSBhdCAoMCw1Mikgc2l6ZSA3ODR4MTgKKyAgICAgICAgUmVuZGVyVGV4 dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMjV4MTgKKyAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCww KSB3aWR0aCAyNTogImZvbyAiCisgICAgICAgIFJlbmRlcklubGluZSB7U1BBTn0gYXQgKDAsMCkg c2l6ZSAyMHgxOAorICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMjUsMCkgc2l6ZSAy MHgxOAorICAgICAgICAgICAgdGV4dCBydW4gYXQgKDI1LDApIHdpZHRoIDIwOiAiYmFyIgorICAg ICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDQ1LDApIHNpemUgMTAxeDE4CisgICAgICAgICAg dGV4dCBydW4gYXQgKDQ1LDApIHdpZHRoIDEwMTogIiBiYXogZm9vIGJhciBiYXoiCitzZWxlY3Rp b24gc3RhcnQ6IHBvc2l0aW9uIDkgb2YgY2hpbGQgMiB7I3RleHR9IG9mIGNoaWxkIDIge0RJVn0g b2YgY2hpbGQgMCB7Qk9EWX0gb2YgY2hpbGQgMCB7SFRNTH0gb2YgZG9jdW1lbnQKK3NlbGVjdGlv biBlbmQ6ICAgcG9zaXRpb24gMTIgb2YgY2hpbGQgMiB7I3RleHR9IG9mIGNoaWxkIDIge0RJVn0g b2YgY2hpbGQgMCB7Qk9EWX0gb2YgY2hpbGQgMCB7SFRNTH0gb2YgZG9jdW1lbnQKSW5kZXg6IExh eW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvZmluZFN0cmluZy0yLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9maW5kU3RyaW5nLTIuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvZmluZFN0cmlu Zy0yLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTggQEAKKzxwPlRoaXMgdGVzdHMgdG8g c2VlIGlmIEZpbmQgd2lsbCBnZXQgc3R1Y2sgd2hlbiBzZWFyY2hpbmcgZm9yIGEgd29yZCB0aGF0 IGlzIGN1cnJlbnRseSBzZWxlY3RlZCwgYW5kIHdhcyBzZWxlY3RlZCB3aXRoIGEgZG91YmxlIGNs aWNrLjwvcD4KKworPGRpdj5mb28gPHNwYW4gaWQ9InNlbGVjdG1lIj5iYXI8L3NwYW4+IGJheiBm b28gYmFyIGJhejwvZGl2PgorCis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikgeworICAgIHZhciBlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInNlbGVjdG1lIik7 CisgICAgdmFyIHggPSBlLm9mZnNldFBhcmVudC5vZmZzZXRMZWZ0ICsgZS5vZmZzZXRMZWZ0ICsg ZS5vZmZzZXRXaWR0aCAvIDI7CisgICAgdmFyIHkgPSBlLm9mZnNldFBhcmVudC5vZmZzZXRUb3Ag KyBlLm9mZnNldFRvcCArIGUub2Zmc2V0SGVpZ2h0IC8gMjsKKyAgICBldmVudFNlbmRlci5tb3Vz ZU1vdmVUbyh4LCB5KTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBldmVudFNl bmRlci5tb3VzZVVwKCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgZXZlbnRT ZW5kZXIubW91c2VVcCgpOworICAgIAorICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJGaW5kU3Ry aW5nIiwgZmFsc2UsICJiYXIiKTsKK30KKzwvc2NyaXB0PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvZmluZFN0cmluZy0y LWV4cGVjdGVkLnBuZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1hcmtlZCBhcyBh IGJpbmFyeSB0eXBlLgpzdm46bWltZS10eXBlID0gYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtCgpQ cm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2ZpbmRT dHJpbmctMi1leHBlY3RlZC5wbmcKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsg YXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtCgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9leGVj Q29tbWFuZC9maW5kU3RyaW5nLTItZXhwZWN0ZWQuY2hlY2tzdW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9maW5kU3RyaW5nLTItZXhwZWN0ZWQuY2hlY2tz dW0JKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2ZpbmRT dHJpbmctMi1leHBlY3RlZC5jaGVja3N1bQkocmV2aXNpb24gMCkKQEAgLTAsMCArMSBAQAorY2Zh ODY4NjM0MGE3Y2FmNjMxZjliOTFhNmUxMzlmZDQKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxl Cg==