94555 2012-08-20 17:56:13 -0700 REGRESSION(r126095): Breaks compilation of downstream WebWidget::paint implementations (Requested by jamesr on #webkit). 2012-08-20 18:01:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92043 1 webkit.review.bot webkit.review.bot abarth jamesr kbr oldest_to_newest 700271 0 webkit.review.bot 2012-08-20 17:56:13 -0700 http://trac.webkit.org/changeset/126095 broke the build: Breaks compilation of downstream WebWidget::paint implementations (Requested by jamesr on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 700275 1 159579 webkit.review.bot 2012-08-20 17:56:56 -0700 Created attachment 159579 ROLLOUT of r126095 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 700276 2 jamesr 2012-08-20 17:57:48 -0700 Log: FAILED: clang++ -MMD -MF obj/content/renderer/content_renderer.render_widget_fullscreen_pepper.o.d -DCONTENT_IMPLEMENTATION -DCHROMIUM_BUILD -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DSK_BUILD_NO_IMAGE_ENCODE -DSK_DEFERRED_CANVAS_USES_GPIPE=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DGR_AGGRESSIVE_SHADER_OPTS=1 -DHYPHEN_CHROME_CLIENT -DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DJSONCPP_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DOSX -DPOSIX -DXML_STATIC -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/icu/public/i18n -I../../third_party/icu/public/common -I../.. -I../../third_party/khronos -Igen/content -I../../skia/config -I../../third_party/skia/src/core -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/skia/include/utils/mac -I../../third_party/hyphen -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party/webrtc -I../../third_party/expat/files/lib -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/WebKit/Source/Platform/chromium -Igen/webcore_headers -I../../v8/include -I../../third_party/webrtc/modules/video_capture/main/interface -I../../third_party/webrtc/modules/interface -I../../third_party/webrtc/common_video/libyuv/include -I../../third_party/webrtc/system_wrappers/interface -I../../third_party/webrtc/video_engine/include -I../../third_party/webrtc/voice_engine/include -isysroot /Developer/SDKs/MacOSX10.6.sdk -O3 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-char-subscripts -Wno-unused-function -Wno-unnamed-type-template-args -Wno-c++11-extensions -Wno-covered-switch-default -Wexit-time-destructors -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -fno-strict-aliasing -Xclang -load -Xclang /b/build/slave/GPU_Mac/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations -Xclang -plugin-arg-find-bad-constructs -Xclang check-inner-classes -fcolor-diagnostics -c ../../content/renderer/render_widget_fullscreen_pepper.cc -o obj/content/renderer/content_renderer.render_widget_fullscreen_pepper.o ../../content/renderer/render_widget_fullscreen_pepper.cc:111:16:error: '<anonymous namespace>::PepperWidget::paint' hides overloaded virtual function [-Werror,-Woverloaded-virtual] virtual void paint(WebCanvas* canvas, const WebRect& rect) { ^ ../../third_party/WebKit/Source/WebKit/chromium/public/WebWidget.h:115:18: note: hidden overloaded virtual function 'WebKit::WebWidget::paint' declared here virtual void paint(WebCanvas*, const WebRect& viewPort, PaintOptions = ReadbackFromCompositorIfAvailable) { } ^ 1 error generated. 700279 3 159579 kbr 2012-08-20 18:00:59 -0700 Comment on attachment 159579 ROLLOUT of r126095 Clearing flags on attachment: 159579 Committed r126111: <http://trac.webkit.org/changeset/126111> 700281 4 kbr 2012-08-20 18:01:04 -0700 All reviewed patches have been landed. Closing bug. 159579 2012-08-20 17:56:56 -0700 2012-08-20 18:00:59 -0700 ROLLOUT of r126095 bug-94555-20120821010235.patch text/plain 9111 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQ5MGI5ZjNmMGE0MDE2MTIwNTllMmIzMzU0MGM2ZGMxNzQ3MDJiNDUuLjIxMDU5NzM4OTg2ODI5 ZGE2NTZjMWNkMjA3OGJjN2FjMDQ2YmNmMWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTItMDgtMjAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjYwOTUu CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEyNjA5NQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ1NTUKKworICAgICAg ICBCcmVha3MgY29tcGlsYXRpb24gb2YgZG93bnN0cmVhbSBXZWJXaWRnZXQ6OnBhaW50CisgICAg ICAgIGltcGxlbWVudGF0aW9ucyAoUmVxdWVzdGVkIGJ5IGphbWVzciBvbiAjd2Via2l0KS4KKwor ICAgICAgICAqIHB1YmxpYy9XZWJXaWRnZXQuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViV2lkZ2V0 OjpwYWludCk6CisgICAgICAgICogc3JjL1dlYlBhZ2VQb3B1cEltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUG9wdXBJbXBsOjpwYWludCk6CisgICAgICAgICogc3JjL1dlYlBhZ2VQ b3B1cEltcGwuaDoKKyAgICAgICAgKFdlYlBhZ2VQb3B1cEltcGwpOgorICAgICAgICAqIHNyYy9X ZWJQb3B1cE1lbnVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUG9wdXBNZW51SW1wbDo6 cGFpbnQpOgorICAgICAgICAqIHNyYy9XZWJQb3B1cE1lbnVJbXBsLmg6CisgICAgICAgICogc3Jj L1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVmlld0ltcGw6OnBhaW50KToK KyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKyAgICAgICAgKFdlYlZpZXdJbXBsKToKKwog MjAxMi0wOC0yMCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW1Y4XSBNb3ZlIGluc3RydW1lbnRlZENhbGxGdW5jdGlvbigpIGZyb20gVjhQcm94eSB0byBT Y3JpcHRDb250cm9sbGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJXaWRnZXQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldC5o CmluZGV4IGIwM2JlZWI1MzBiZTZiMzk2NGFlYjhkMzFjZGZkYTdmMWM4ZTMyZTQuLjhlNGZlY2Fj N2U5OWEzZTMwMzNiZmM4MTcwNDIxZmMyYTlmNGVmM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYldpZGdldC5oCkBAIC05MCwyMSArOTAsNiBAQCBwdWJsaWM6CiAgICAgLy8g YW5kIGl0IG1heSByZXN1bHQgaW4gY2FsbHMgdG8gV2ViV2lkZ2V0Q2xpZW50OjpkaWRJbnZhbGlk YXRlUmVjdC4KICAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0KCkgeyB9CiAKLSAgICBlbnVtIFBhaW50 T3B0aW9ucyB7Ci0gICAgICAgIC8vIEF0dGVtcHQgdG8gZnVsZmlsbCB0aGUgcGFpbnRpbmcgcmVx dWVzdCBieSByZWFkaW5nIGJhY2sgZnJvbSB0aGUKLSAgICAgICAgLy8gY29tcG9zaXRvciwgYXNz dW1pbmcgd2UncmUgdXNpbmcgYSBjb21wb3NpdG9yIHRvIHJlbmRlci4KLSAgICAgICAgUmVhZGJh Y2tGcm9tQ29tcG9zaXRvcklmQXZhaWxhYmxlLAotCi0gICAgICAgIC8vIEZvcmNlIHRoZSB3aWRn ZXQgdG8gcmVyZW5kZXIgb250byB0aGUgY2FudmFzIHVzaW5nIHNvZnR3YXJlLiBUaGlzCi0gICAg ICAgIC8vIG1vZGUgaWdub3JlcyAzZCB0cmFuc2Zvcm1zIGFuZCBpZ25vcmVzIEdQVS1yZXNpZGVu dCBjb250ZW50LCBzdWNoCi0gICAgICAgIC8vIGFzIHZpZGVvLCBjYW52YXMsIGFuZCBXZWJHTC4K LSAgICAgICAgLy8KLSAgICAgICAgLy8gTm90ZTogVGhpcyBvcHRpb24gZXhpc3RzIG9uIE9TKEFO RFJPSUQpIGFuZCB3aWxsIGhvcGVmdWxseSBiZQotICAgICAgICAvLyAgICAgICByZW1vdmVkIG9u Y2UgdGhlIGxpbmsgZGlzYW1iaWd1YXRpb24gZmVhdHVyZSByZW5kZXJzIHVzaW5nCi0gICAgICAg IC8vICAgICAgIHRoZSBjb21wb3NpdG9yLgotICAgICAgICBGb3JjZVNvZnR3YXJlUmVuZGVyaW5n QW5kSWdub3JlR1BVUmVzaWRlbnRDb250ZW50LAotICAgIH07Ci0KICAgICAvLyBDYWxsZWQgdG8g cGFpbnQgdGhlIHJlY3Rhbmd1bGFyIHJlZ2lvbiB3aXRoaW4gdGhlIFdlYldpZGdldAogICAgIC8v IG9udG8gdGhlIHNwZWNpZmllZCBjYW52YXMgYXQgKHZpZXdQb3J0Lngsdmlld1BvcnQueSkuIFlv dSBNVVNUIGNhbGwKICAgICAvLyBMYXlvdXQgYmVmb3JlIGNhbGxpbmcgdGhpcyBtZXRob2QuIEl0 IGlzIG9rYXkgdG8gY2FsbCBwYWludApAQCAtMTEyLDcgKzk3LDcgQEAgcHVibGljOgogICAgIC8v IGNoYW5nZXMgYXJlIG1hZGUgdG8gdGhlIFdlYldpZGdldCAoZS5nLiwgb25jZSBldmVudHMgYXJl CiAgICAgLy8gcHJvY2Vzc2VkLCBpdCBzaG91bGQgYmUgYXNzdW1lZCB0aGF0IGFub3RoZXIgY2Fs bCB0byBsYXlvdXQgaXMKICAgICAvLyB3YXJyYW50ZWQgYmVmb3JlIHBhaW50aW5nIGFnYWluKS4K LSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2ViUmVjdCYgdmlld1Bv cnQsIFBhaW50T3B0aW9ucyA9IFJlYWRiYWNrRnJvbUNvbXBvc2l0b3JJZkF2YWlsYWJsZSkgeyB9 CisgICAgdmlydHVhbCB2b2lkIHBhaW50KFdlYkNhbnZhcyosIGNvbnN0IFdlYlJlY3QmIHZpZXdQ b3J0KSB7IH0KIAogICAgIC8vIEluIG5vbi10aHJlYWRlZCBjb21wb3NpdGluZyBtb2RlLCB0cmln Z2VycyBjb21wb3NpdGluZyBvZiB0aGUgY3VycmVudAogICAgIC8vIGxheWVycyBvbnRvIHRoZSBz Y3JlZW4uIFlvdSBNVVNUIGNhbGwgTGF5b3V0IGJlZm9yZSBjYWxsaW5nIHRoaXMgbWV0aG9kLApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVwSW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAppbmRl eCA5ODBmODFhOGFiMGVkYmUzNGU2NTcyZWY2ZjdlYjlhYjY0MDYyMzM4Li5mZTk0NWMwNjNkNTNi YTUzYjVmNTVmMWQyMWY0ZTAyNmY1MDg3YWIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJQYWdlUG9wdXBJbXBsLmNwcApAQCAtMjI1LDcgKzIyNSw3IEBAIHZvaWQgV2Vi UGFnZVBvcHVwSW1wbDo6bGF5b3V0KCkKICAgICBQYWdlV2lkZ2V0RGVsZWdhdGU6OmxheW91dCht X3BhZ2UuZ2V0KCkpOwogfQogCi12b2lkIFdlYlBhZ2VQb3B1cEltcGw6OnBhaW50KFdlYkNhbnZh cyogY2FudmFzLCBjb25zdCBXZWJSZWN0JiByZWN0LCBQYWludE9wdGlvbnMpCit2b2lkIFdlYlBh Z2VQb3B1cEltcGw6OnBhaW50KFdlYkNhbnZhcyogY2FudmFzLCBjb25zdCBXZWJSZWN0JiByZWN0 KQogewogICAgIFBhZ2VXaWRnZXREZWxlZ2F0ZTo6cGFpbnQobV9wYWdlLmdldCgpLCAwLCBjYW52 YXMsIHJlY3QsIFBhZ2VXaWRnZXREZWxlZ2F0ZTo6T3BhcXVlKTsKIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlBhZ2VQb3B1cEltcGwuaAppbmRleCBlNjg0NGJmZDA2YTQ5OGJk YjUwZGI4MTkwNmQ5NmU0YWUxNWRiNGE0Li43NjkzNmE0Y2Q2NWQzNGZmODkwMGE1MWI0ZWMwMzcw ZjI1ZGYxZWMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQYWdl UG9wdXBJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGFnZVBvcHVw SW1wbC5oCkBAIC03Miw3ICs3Miw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHNldENv bXBvc2l0b3JTdXJmYWNlUmVhZHkoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgY29tcG9z aXRlKGJvb2wpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKSBPVkVSUklERTsK LSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2ViUmVjdCYsIFBhaW50 T3B0aW9ucyA9IFJlYWRiYWNrRnJvbUNvbXBvc2l0b3JJZkF2YWlsYWJsZSkgT1ZFUlJJREU7Cisg ICAgdmlydHVhbCB2b2lkIHBhaW50KFdlYkNhbnZhcyosIGNvbnN0IFdlYlJlY3QmKSBPVkVSUklE RTsKICAgICB2aXJ0dWFsIHZvaWQgcmVzaXplKGNvbnN0IFdlYlNpemUmKSBPVkVSUklERTsKICAg ICB2aXJ0dWFsIHZvaWQgY2xvc2UoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIGJvb2wgaGFuZGxl SW5wdXRFdmVudChjb25zdCBXZWJJbnB1dEV2ZW50JikgT1ZFUlJJREU7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBvcHVwTWVudUltcGwuY3BwCmluZGV4IDE5NGRlZTU1MGNm MGRkNDk5NGQ2M2IwYTY5MTNkMTFkNDc0N2Y1NTcuLmVjODk5MzBmYjdkNmMzMmE3ODcxN2QxMDU2 MTE2ZDg1MzdkNzVjNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlBvcHVwTWVudUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBv cHVwTWVudUltcGwuY3BwCkBAIC0xOTMsNyArMTkzLDcgQEAgdm9pZCBXZWJQb3B1cE1lbnVJbXBs OjpsYXlvdXQoKQogewogfQogCi12b2lkIFdlYlBvcHVwTWVudUltcGw6OnBhaW50KFdlYkNhbnZh cyogY2FudmFzLCBjb25zdCBXZWJSZWN0JiByZWN0LCBQYWludE9wdGlvbnMpCit2b2lkIFdlYlBv cHVwTWVudUltcGw6OnBhaW50KFdlYkNhbnZhcyogY2FudmFzLCBjb25zdCBXZWJSZWN0JiByZWN0 KQogewogICAgIGlmICghbV93aWRnZXQpCiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBvcHVwTWVudUltcGwuaCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlBvcHVwTWVudUltcGwuaAppbmRleCA3ZjEzZTQzODUwZGZkYjUy ODdhZGY2ZGZkYjQxOWY0YzEwOGZmZjVkLi5jMjJhMGJiZWNlOTk1M2Q1ZDQ3MTI0ZWI0YTAwODNi ZjhiNjMzODg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1 cE1lbnVJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUG9wdXBNZW51 SW1wbC5oCkBAIC03Myw3ICs3Myw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgd2lsbEVu ZExpdmVSZXNpemUoKSBPVkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0ZShkb3VibGUg ZnJhbWVCZWdpblRpbWUpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKSBPVkVS UklERTsKLSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2ViUmVjdCYs IFBhaW50T3B0aW9ucyA9IFJlYWRiYWNrRnJvbUNvbXBvc2l0b3JJZkF2YWlsYWJsZSkgT1ZFUlJJ REU7CisgICAgdmlydHVhbCB2b2lkIHBhaW50KFdlYkNhbnZhcyosIGNvbnN0IFdlYlJlY3QmKSBP VkVSUklERTsKICAgICB2aXJ0dWFsIHZvaWQgdGhlbWVDaGFuZ2VkKCkgT1ZFUlJJREU7CiAgICAg dmlydHVhbCB2b2lkIHNldENvbXBvc2l0b3JTdXJmYWNlUmVhZHkoKSBPVkVSUklERTsKICAgICB2 aXJ0dWFsIHZvaWQgY29tcG9zaXRlKGJvb2wgZmluaXNoKSBPVkVSUklERTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCAyOTE5ZmI5ZjZlYWU1ZDE1ZmZl N2QyNTk4ODIxZDA4MmViZTkyMTY3Li45NzMzOWIzNDIzZjBjMTVjZjViNDc0ZThlZjQ3OWM0MTRj NjdhMmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCkBA IC0xNjg2LDE1ICsxNjg2LDkgQEAgdm9pZCBXZWJWaWV3SW1wbDo6ZG9QaXhlbFJlYWRiYWNrVG9D YW52YXMoV2ViQ2FudmFzKiBjYW52YXMsIGNvbnN0IEludFJlY3QmIHJlY3QKIH0KICNlbmRpZgog Ci12b2lkIFdlYlZpZXdJbXBsOjpwYWludChXZWJDYW52YXMqIGNhbnZhcywgY29uc3QgV2ViUmVj dCYgcmVjdCwgUGFpbnRPcHRpb25zIG9wdGlvbikKK3ZvaWQgV2ViVmlld0ltcGw6OnBhaW50KFdl YkNhbnZhcyogY2FudmFzLCBjb25zdCBXZWJSZWN0JiByZWN0KQogewotI2lmICFPUyhBTkRST0lE KQotICAgIC8vIFJlYWRiYWNrRnJvbUNvbXBvc2l0b3JJZkF2YWlsYWJsZSBpcyB0aGUgb25seSBv cHRpb24gYXZhaWxhYmxlIG9uIG5vbi1BbmRyb2lkLgotICAgIC8vIElkZWFsbHksIEFuZHJvaWQg d291bGQgYWx3YXlzIHVzZSBSZWFkYmFja0Zyb21Db21wb3NpdG9ySWZBdmFpbGFibGUgYXMgd2Vs bC4KLSAgICBBU1NFUlQob3B0aW9uID09IFJlYWRiYWNrRnJvbUNvbXBvc2l0b3JJZkF2YWlsYWJs ZSk7Ci0jZW5kaWYKLQotICAgIGlmIChvcHRpb24gPT0gUmVhZGJhY2tGcm9tQ29tcG9zaXRvcklm QXZhaWxhYmxlICYmIGlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKSB7CisgICAgaWYg KGlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKSB7CiAjaWYgVVNFKEFDQ0VMRVJBVEVE X0NPTVBPU0lUSU5HKQogICAgICAgICAvLyBJZiBhIGNhbnZhcyB3YXMgcGFzc2VkIGluLCB3ZSB1 c2UgaXQgdG8gZ3JhYiBhIGNvcHkgb2YgdGhlCiAgICAgICAgIC8vIGZyZXNobHktcmVuZGVyZWQg cGl4ZWxzLgpAQCAtMTcwNiwyNCArMTcwMCwxMiBAQCB2b2lkIFdlYlZpZXdJbXBsOjpwYWludChX ZWJDYW52YXMqIGNhbnZhcywgY29uc3QgV2ViUmVjdCYgcmVjdCwgUGFpbnRPcHRpb25zIG9wdAog ICAgICAgICB9CiAjZW5kaWYKICAgICB9IGVsc2UgewotICAgICAgICBGcmFtZVZpZXcqIHZpZXcg PSBwYWdlKCktPm1haW5GcmFtZSgpLT52aWV3KCk7Ci0gICAgICAgIFBhaW50QmVoYXZpb3Igb2xk UGFpbnRCZWhhdmlvciA9IHZpZXctPnBhaW50QmVoYXZpb3IoKTsKLSAgICAgICAgaWYgKGlzQWNj ZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKSB7Ci0gICAgICAgICAgICBBU1NFUlQob3B0aW9u ID09IEZvcmNlU29mdHdhcmVSZW5kZXJpbmdBbmRJZ25vcmVHUFVSZXNpZGVudENvbnRlbnQpOyAg ICAgICAgICAgIAotICAgICAgICAgICAgdmlldy0+c2V0UGFpbnRCZWhhdmlvcihvbGRQYWludEJl aGF2aW9yIHwgUGFpbnRCZWhhdmlvckZsYXR0ZW5Db21wb3NpdGluZ0xheWVycyk7Ci0gICAgICAg IH0KLQogICAgICAgICBkb3VibGUgcGFpbnRTdGFydCA9IGN1cnJlbnRUaW1lKCk7CiAgICAgICAg IFBhZ2VXaWRnZXREZWxlZ2F0ZTo6cGFpbnQobV9wYWdlLmdldCgpLCBwYWdlT3ZlcmxheXMoKSwg Y2FudmFzLCByZWN0LCBpc1RyYW5zcGFyZW50KCkgPyBQYWdlV2lkZ2V0RGVsZWdhdGU6OlRyYW5z bHVjZW50IDogUGFnZVdpZGdldERlbGVnYXRlOjpPcGFxdWUpOwogICAgICAgICBkb3VibGUgcGFp bnRFbmQgPSBjdXJyZW50VGltZSgpOwogICAgICAgICBkb3VibGUgcGl4ZWxzUGVyU2VjID0gKHJl Y3Qud2lkdGggKiByZWN0LmhlaWdodCkgLyAocGFpbnRFbmQgLSBwYWludFN0YXJ0KTsKICAgICAg ICAgV2ViS2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgpLT5oaXN0b2dyYW1DdXN0b21Db3VudHMoIlJl bmRlcmVyNC5Tb2Z0d2FyZVBhaW50RHVyYXRpb25NUyIsIChwYWludEVuZCAtIHBhaW50U3RhcnQp ICogMTAwMCwgMCwgMTIwLCAzMCk7CiAgICAgICAgIFdlYktpdDo6UGxhdGZvcm06OmN1cnJlbnQo KS0+aGlzdG9ncmFtQ3VzdG9tQ291bnRzKCJSZW5kZXJlcjQuU29mdHdhcmVQYWludE1lZ2FwaXhQ ZXJTZWNvbmQiLCBwaXhlbHNQZXJTZWMgLyAxMDAwMDAwLCAxMCwgMjEwLCAzMCk7Ci0KLSAgICAg ICAgaWYgKGlzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZSgpKSB7Ci0gICAgICAgICAgICBB U1NFUlQob3B0aW9uID09IEZvcmNlU29mdHdhcmVSZW5kZXJpbmdBbmRJZ25vcmVHUFVSZXNpZGVu dENvbnRlbnQpOyAgICAgICAgICAgIAotICAgICAgICAgICAgdmlldy0+c2V0UGFpbnRCZWhhdmlv cihvbGRQYWludEJlaGF2aW9yKTsKLSAgICAgICAgfQogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKaW5kZXggOGQ0OWYyZTEzZTM4ZjY3NDRmZTA0MGQx NDUxMjNhODdmZjA3Nzk1OC4uNDMxZGFkNDkwNjE0ZjVmZDMwNTljNDI4MzgzY2QwOGY0ZmQyNzcy ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCkBAIC0xNDMsNyAr MTQzLDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBzZXRDb21wb3NpdG9yU3VyZmFjZVJl YWR5KCk7CiAgICAgdmlydHVhbCB2b2lkIGFuaW1hdGUoZG91YmxlKTsKICAgICB2aXJ0dWFsIHZv aWQgbGF5b3V0KCk7IC8vIEFsc28gaW1wbGVtZW50cyBXZWJMYXllclRyZWVWaWV3Q2xpZW50Ojps YXlvdXQoKQotICAgIHZpcnR1YWwgdm9pZCBwYWludChXZWJDYW52YXMqLCBjb25zdCBXZWJSZWN0 JiwgUGFpbnRPcHRpb25zID0gUmVhZGJhY2tGcm9tQ29tcG9zaXRvcklmQXZhaWxhYmxlKTsKKyAg ICB2aXJ0dWFsIHZvaWQgcGFpbnQoV2ViQ2FudmFzKiwgY29uc3QgV2ViUmVjdCYpOwogICAgIHZp cnR1YWwgdm9pZCB0aGVtZUNoYW5nZWQoKTsKICAgICB2aXJ0dWFsIHZvaWQgY29tcG9zaXRlKGJv b2wgZmluaXNoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0TmVlZHNSZWRyYXcoKTsK