94550 2012-08-20 17:07:57 -0700 [chromium] Texture layer should not generate zero textureId quads 2012-08-20 19:35:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93677 1 aelias aelias aelias cc-bugs danakj enne jamesr piman webkit.review.bot oldest_to_newest 700208 0 aelias 2012-08-20 17:07:57 -0700 [chromium] Texture layer should not generate zero textureId quads 700216 1 159566 aelias 2012-08-20 17:12:54 -0700 Created attachment 159566 Patch 700224 2 159566 danakj 2012-08-20 17:17:14 -0700 Comment on attachment 159566 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159566&action=review > Source/WebCore/platform/graphics/chromium/cc/CCTextureLayerImpl.cpp:91 > + m_externalTextureResource = 0; I don't think you need this, m_externalTextureResource is cleared in didDraw. And we won't call didLoseContext in the middle of creating the quads for a frame right? 700229 3 159566 enne 2012-08-20 17:20:58 -0700 Comment on attachment 159566 Patch R=me. I think clearing m_externalTextureResources is fine. Thanks for fixing this bug. 700364 4 159566 webkit.review.bot 2012-08-20 19:35:49 -0700 Comment on attachment 159566 Patch Clearing flags on attachment: 159566 Committed r126122: <http://trac.webkit.org/changeset/126122> 700365 5 webkit.review.bot 2012-08-20 19:35:53 -0700 All reviewed patches have been landed. Closing bug. 159566 2012-08-20 17:12:54 -0700 2012-08-20 19:35:49 -0700 Patch bug-94550-20120820171215.patch text/plain 3994 aelias U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzcyYWJiMDc3YzcyYWQ3 YWU5NWQ2ODEwMmFkMTgwOWVkM2QwYTlhZS4uNTVkOGE2NDllY2I2NGJiZDEwN2RiMmY0MDIyZDE0 NGQyNTBjODE2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTIwICBBbGV4 YW5kcmUgRWxpYXMgIDxhZWxpYXNAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFRl eHR1cmUgbGF5ZXIgc2hvdWxkIG5vdCBnZW5lcmF0ZSB6ZXJvIHRleHR1cmVJZCBxdWFkcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ1NTAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBhIGNvbnRl eHQgbG9zcywgQ0NUZXh0dXJlTGF5ZXJJbXBsIHdvdWxkIGNsZWFyIGl0cyB0ZXh0dXJlSWQKKyAg ICAgICAgYnV0IGNvbnRpbnVlZCB0byBwcm9kdWNlIGV4dGVybmFsIHJlc291cmNlcyBhbmQgcXVh ZHMgd2l0aCB0aGUgemVybworICAgICAgICB0ZXh0dXJlaWQuICBBZGQgZWFybHkgcmV0dXJucyBz byB0aGF0IENDVGV4dHVyZUxheWVySW1wbCBiZWNvbWVzCisgICAgICAgIGluZXJ0IGFmdGVyIGEg Y29udGV4dCBsb3NzLgorCisgICAgICAgIEFkZGVkIGFzc2VydGlvbiBpbiByZWFkIGxvY2sgc28g dGhhdCBkb250VXNlT2xkUmVzb3VyY2VzQWZ0ZXJMb3N0Q29udGV4dAorICAgICAgICB0ZXN0IGNh dGNoZXMgdGhlIHByb2JsZW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ1Jlc291cmNlUHJvdmlkZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkNDU2NvcGVkTG9j a1Jlc291cmNlRm9yUmVhZDo6Q0NTY29wZWRMb2NrUmVzb3VyY2VGb3JSZWFkKToKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RleHR1cmVMYXllckltcGwuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q0NUZXh0dXJlTGF5ZXJJbXBsOjp3aWxsRHJhdyk6CisgICAgICAg IChXZWJDb3JlOjpDQ1RleHR1cmVMYXllckltcGw6OmFwcGVuZFF1YWRzKToKKyAgICAgICAgKFdl YkNvcmU6OkNDVGV4dHVyZUxheWVySW1wbDo6ZGlkRHJhdyk6CisgICAgICAgIChXZWJDb3JlOjpD Q1RleHR1cmVMYXllckltcGw6OmRpZExvc2VDb250ZXh0KToKKwogMjAxMi0wOC0yMCAgSGFucyBX ZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlc3BlY3QgcnVudGltZSBm bGFncyBmb3IgRGV2aWNlIE9yaWVudGF0aW9uIGFuZCBEZXZpY2UgTW90aW9uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Jlc291cmNl UHJvdmlkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDUmVzb3VyY2VQcm92aWRlci5oCmluZGV4IGI4NzMzYTE2MzhmZGFhN2I4YmFkNmJkNTQxYmI1 YWI3YjllNTljNzQuLmU5MjdkMjkyZmNkYzgzZWEwMWY3ZTI4MWQ1Y2ZjZjVjYzI4YmU2YzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND UmVzb3VyY2VQcm92aWRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDUmVzb3VyY2VQcm92aWRlci5oCkBAIC0yMjQsNyArMjI0LDEwIEBAIHB1 YmxpYzoKICAgICBDQ1Njb3BlZExvY2tSZXNvdXJjZUZvclJlYWQoQ0NSZXNvdXJjZVByb3ZpZGVy KiByZXNvdXJjZVByb3ZpZGVyLCBDQ1Jlc291cmNlUHJvdmlkZXI6OlJlc291cmNlSWQgcmVzb3Vy Y2VJZCkKICAgICAgICAgOiBtX3Jlc291cmNlUHJvdmlkZXIocmVzb3VyY2VQcm92aWRlcikKICAg ICAgICAgLCBtX3Jlc291cmNlSWQocmVzb3VyY2VJZCkKLSAgICAgICAgLCBtX3RleHR1cmVJZChy ZXNvdXJjZVByb3ZpZGVyLT5sb2NrRm9yUmVhZChyZXNvdXJjZUlkKSkgeyB9CisgICAgICAgICwg bV90ZXh0dXJlSWQocmVzb3VyY2VQcm92aWRlci0+bG9ja0ZvclJlYWQocmVzb3VyY2VJZCkpCisg ICAgeworICAgICAgICBBU1NFUlQobV90ZXh0dXJlSWQpOworICAgIH0KIAogICAgIH5DQ1Njb3Bl ZExvY2tSZXNvdXJjZUZvclJlYWQoKQogICAgIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGV4dHVyZUxheWVySW1wbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RleHR1cmVMYXll ckltcGwuY3BwCmluZGV4IDRhZDk2ZTE4OWIzMTdiNTFjNmY2MjljOGYyOThlM2U5YjRiYTc4Y2Eu LmI5ODFmNzEzZDFhZmZjZmExNWU5NTIxOWIxMjhkNmJhMDBiMGIwNWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGV4dHVyZUxheWVy SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Y2MvQ0NUZXh0dXJlTGF5ZXJJbXBsLmNwcApAQCAtNTIsMjAgKzUyLDI0IEBAIENDVGV4dHVyZUxh eWVySW1wbDo6fkNDVGV4dHVyZUxheWVySW1wbCgpCiAKIHZvaWQgQ0NUZXh0dXJlTGF5ZXJJbXBs Ojp3aWxsRHJhdyhDQ1Jlc291cmNlUHJvdmlkZXIqIHJlc291cmNlUHJvdmlkZXIpCiB7CisgICAg aWYgKCFtX3RleHR1cmVJZCkKKyAgICAgICAgcmV0dXJuOwogICAgIEFTU0VSVCghbV9leHRlcm5h bFRleHR1cmVSZXNvdXJjZSk7CiAgICAgbV9leHRlcm5hbFRleHR1cmVSZXNvdXJjZSA9IHJlc291 cmNlUHJvdmlkZXItPmNyZWF0ZVJlc291cmNlRnJvbUV4dGVybmFsVGV4dHVyZShtX3RleHR1cmVJ ZCk7CiB9CiAKIHZvaWQgQ0NUZXh0dXJlTGF5ZXJJbXBsOjphcHBlbmRRdWFkcyhDQ1F1YWRTaW5r JiBxdWFkTGlzdCwgY29uc3QgQ0NTaGFyZWRRdWFkU3RhdGUqIHNoYXJlZFF1YWRTdGF0ZSwgYm9v bCYpCiB7Ci0gICAgQVNTRVJUKG1fZXh0ZXJuYWxUZXh0dXJlUmVzb3VyY2UpOworICAgIGlmICgh bV9leHRlcm5hbFRleHR1cmVSZXNvdXJjZSkKKyAgICAgICAgcmV0dXJuOwogICAgIEludFJlY3Qg cXVhZFJlY3QoSW50UG9pbnQoKSwgY29udGVudEJvdW5kcygpKTsKICAgICBxdWFkTGlzdC5hcHBl bmQoQ0NUZXh0dXJlRHJhd1F1YWQ6OmNyZWF0ZShzaGFyZWRRdWFkU3RhdGUsIHF1YWRSZWN0LCBt X2V4dGVybmFsVGV4dHVyZVJlc291cmNlLCBtX3ByZW11bHRpcGxpZWRBbHBoYSwgbV91dlJlY3Qs IG1fZmxpcHBlZCkpOwogfQogCiB2b2lkIENDVGV4dHVyZUxheWVySW1wbDo6ZGlkRHJhdyhDQ1Jl c291cmNlUHJvdmlkZXIqIHJlc291cmNlUHJvdmlkZXIpCiB7Ci0gICAgQVNTRVJUKG1fZXh0ZXJu YWxUZXh0dXJlUmVzb3VyY2UpOworICAgIGlmICghbV9leHRlcm5hbFRleHR1cmVSZXNvdXJjZSkK KyAgICAgICAgcmV0dXJuOwogICAgIC8vIEZJWE1FOiB0aGUgZm9sbG93aW5nIGFzc2VydCB3aWxs IG5vdCBiZSB0cnVlIHdoZW4gc2VuZGluZyByZXNvdXJjZXMgdG8gYQogICAgIC8vIHBhcmVudCBj b21wb3NpdG9yLiBBIHN5bmNocm9uaXphdGlvbiBzY2hlbWUgKGRvdWJsZS1idWZmZXJpbmcgb3IK ICAgICAvLyBwaXBlbGluaW5nIG9mIHVwZGF0ZXMpIGZvciB0aGUgY2xpZW50IHdpbGwgbmVlZCB0 byBleGlzdCB0byBzb2x2ZSB0aGlzLgpAQCAtODQsNiArODgsNyBAQCB2b2lkIENDVGV4dHVyZUxh eWVySW1wbDo6ZHVtcExheWVyUHJvcGVydGllcyhUZXh0U3RyZWFtJiB0cywgaW50IGluZGVudCkg Y29uc3QKIHZvaWQgQ0NUZXh0dXJlTGF5ZXJJbXBsOjpkaWRMb3NlQ29udGV4dCgpCiB7CiAgICAg bV90ZXh0dXJlSWQgPSAwOworICAgIG1fZXh0ZXJuYWxUZXh0dXJlUmVzb3VyY2UgPSAwOwogfQog CiB9Cg==