94540 2012-08-20 16:03:40 -0700 re-enable image diff for the wk2 bots ASAP 2012-08-21 14:39:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91962 94396 1 dpranke dpranke beidson jhoneycutt kbalazs mark.lam ojan ossy simon.fraser thorton oldest_to_newest 700108 0 dpranke 2012-08-20 16:03:40 -0700 We temporarily disabled image diffs on the wk2 bots, which essentially skips all of the ref tests (we will still catch crashes and timeouts, at least). https://bugs.webkit.org/show_bug.cgi?id=94517 We should re-enable the check (and revert that change) as soon as we can. 700110 1 dpranke 2012-08-20 16:05:37 -0700 This should also re-enable treating ImageDiff failures as test failures for the wk2 bots (disabled in https://bugs.webkit.org/show_bug.cgi?id=94396 ). 701067 2 159757 dpranke 2012-08-21 13:30:08 -0700 Created attachment 159757 Patch 701122 3 159757 ojan 2012-08-21 14:22:23 -0700 Comment on attachment 159757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159757&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:-270 > - # https://bugs.webkit.org/show_bug.cgi?id=81962; ImageDiff doesn't Can we close this bug now? 701135 4 dpranke 2012-08-21 14:36:29 -0700 (In reply to comment #3) > (From update of attachment 159757 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159757&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:-270 > > - # https://bugs.webkit.org/show_bug.cgi?id=81962; ImageDiff doesn't > > Can we close this bug now? Not just yet; I'm still seeing the failures on my machine, but smfr hasn't been able to reproduce them, so we're going to land this and see if he sees them or if we see issues on the bots. 701139 5 dpranke 2012-08-21 14:39:15 -0700 Committed r126189: <http://trac.webkit.org/changeset/126189> 159757 2012-08-21 13:30:08 -0700 2012-08-21 14:22:22 -0700 Patch bug-94540-20120821133007.patch text/plain 6218 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDEyNzcxZjljZmM5NTEzOTRiMzczNjQ1NzUyZjVlNmVi Y2IxMzQ4ZS4uN2IyMWVlOGQyNzc5NmRhZmYxMDZiNGFjMTRmM2QxYTVjMjEzMGFhYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4 IEBACiAyMDEyLTA4LTIxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIFRleHQgQXV0b3NpemluZzogOjpmaXJzdC1sZXR0ZXIgcHNldWRvLWVsZW1lbnQgaXMg aW5jb3JyZWN0bHkgc2l6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk0NTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmV2ZXJ0IHRoZSBjaGFuZ2VzIGluIGJ1Z3MgOTQ1MTcgYW5kIDk0Mzk2IHNvIHRo YXQgd2UgYXJlCisgICAgICAgIGFjdHVhbGx5IGxvb2tpbmcgZm9yIHN0ZGVyciBvdXRwdXQgZnJv bSBJbWFnZURpZmYgYW5kIGRvaW5nCisgICAgICAgIGltYWdlIGNvbXBhcmVzIG9uIHJlZiB0ZXN0 cyBvbiB0aGUgd2syIHBvcnRzIGFnYWluLgorCisgICAgICAgIEFsc28sIGRvIGFuIGFjdHVhbCBk aWZmX2ltYWdlKCkgY2FsbCBpZiB0aGUgaGFzaCBjaGVja3MgZmFpbCBvbgorICAgICAgICByZWZ0 ZXN0cywgYW5kIG9ubHkgZmFpbCB0aGUgdGVzdCBpZiB3ZSBnZXQgcmVhbCBkaWZmcyAob3IgZG9u J3QsCisgICAgICAgIGZvciBtaXNtYXRjaGVzKS4KKworICAgICAgICBMYXN0bHksIGNsZWFuIHVw IHRoZSBsb2cgbWVzc2FnZXMgdG8gYmUgbW9yZSBoZWxwZnVsLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5 OgorICAgICAgICAoU2luZ2xlVGVzdFJ1bm5lci5fY29tcGFyZV9pbWFnZSk6CisgICAgICAgIChT aW5nbGVUZXN0UnVubmVyLl9jb21wYXJlX291dHB1dF93aXRoX3JlZmVyZW5jZSk6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvdGVzdF9yZXN1bHRf d3JpdGVyLnB5OgorICAgICAgICAod3JpdGVfdGVzdF9yZXN1bHQpOgorCisyMDEyLTA4LTIxICBE aXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIF9jb21wYXJlX2lt YWdlKCkgc3dhcHMgYWN0dWFsIGFuZCBleHBlY3RlZCBpbWFnZXMgYnkgbWlzdGFrZQogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ1NjcKIApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2lu Z2xlX3Rlc3RfcnVubmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv Y29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5CmluZGV4IDdiMTRlNmIwOWY4NGExOGY2 ZmZhOTJiYTg4NGIyNWI4M2EyOTQxNjkuLmFlMzQ3MGE1ZGFiN2NmM2IxMTVkNGE5ZDQwNWM2NWY2 YjVlOTliYWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkKQEAg LTI2NiwxMCArMjY2LDcgQEAgY2xhc3MgU2luZ2xlVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAg ICBlbGlmIGRyaXZlcl9vdXRwdXQuaW1hZ2VfaGFzaCAhPSBleHBlY3RlZF9kcml2ZXJfb3V0cHV0 LmltYWdlX2hhc2g6CiAgICAgICAgICAgICBkaWZmX3Jlc3VsdCA9IHNlbGYuX3BvcnQuZGlmZl9p bWFnZShleHBlY3RlZF9kcml2ZXJfb3V0cHV0LmltYWdlLCBkcml2ZXJfb3V0cHV0LmltYWdlKQog ICAgICAgICAgICAgZXJyX3N0ciA9IGRpZmZfcmVzdWx0WzJdCi0gICAgICAgICAgICAjIEZJWE1F OiBzZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0Mjc3IGFuZAot ICAgICAgICAgICAgIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE5 NjI7IEltYWdlRGlmZiBkb2Vzbid0Ci0gICAgICAgICAgICAjIHNlZW0gdG8gYmUgd29ya2luZyB3 aXRoIFdUUiBwcm9wZXJseSBhbmQgdG9ucyBvZiB0ZXN0cyBhcmUgZmFpbGluZy4KLSAgICAgICAg ICAgIGlmIGVycl9zdHIgYW5kIG5vdCBzZWxmLl9vcHRpb25zLndlYmtpdF90ZXN0X3J1bm5lcjoK KyAgICAgICAgICAgIGlmIGVycl9zdHI6CiAgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCcg ICVzIDogJXMnICUgKHNlbGYuX3Rlc3RfbmFtZSwgZXJyX3N0cikpCiAgICAgICAgICAgICAgICAg ZmFpbHVyZXMuYXBwZW5kKHRlc3RfZmFpbHVyZXMuRmFpbHVyZUltYWdlSGFzaE1pc21hdGNoKCkp CiAgICAgICAgICAgICAgICAgZHJpdmVyX291dHB1dC5lcnJvciA9IChkcml2ZXJfb3V0cHV0LmVy cm9yIG9yICcnKSArIGVycl9zdHIKQEAgLTI3OSw3ICsyNzYsNyBAQCBjbGFzcyBTaW5nbGVUZXN0 UnVubmVyKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgIGZhaWx1cmVzLmFwcGVuZCh0ZXN0 X2ZhaWx1cmVzLkZhaWx1cmVJbWFnZUhhc2hNaXNtYXRjaChkaWZmX3Jlc3VsdFsxXSkpCiAgICAg ICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICAgICAgIyBTZWUgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY5NDQ0IGZvciB3aHkgdGhpcyBpc24ndCBhIGZ1 bGwgZmFpbHVyZS4KLSAgICAgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCcgICVzIC0+IHBp eGVsIGhhc2ggZmFpbGVkIChidXQgcGl4ZWwgdGVzdCBzdGlsbCBwYXNzZXMpJyAlIHNlbGYuX3Rl c3RfbmFtZSkKKyAgICAgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCcgICVzIC0+IHBpeGVs IGhhc2ggZmFpbGVkIChidXQgZGlmZiBwYXNzZWQpJyAlIHNlbGYuX3Rlc3RfbmFtZSkKICAgICAg ICAgcmV0dXJuIGZhaWx1cmVzCiAKICAgICBkZWYgX3J1bl9yZWZ0ZXN0KHNlbGYpOgpAQCAtMzIw LDE5ICszMTcsMjEgQEAgY2xhc3MgU2luZ2xlVGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICBp ZiBmYWlsdXJlczoKICAgICAgICAgICAgIHJldHVybiBUZXN0UmVzdWx0KHNlbGYuX3Rlc3RfbmFt ZSwgZmFpbHVyZXMsIHRvdGFsX3Rlc3RfdGltZSwgaGFzX3N0ZGVycikKIAotICAgICAgICBpZiBz ZWxmLl9vcHRpb25zLndlYmtpdF90ZXN0X3J1bm5lciBhbmQgbm90IHNlbGYuX29wdGlvbnMucGl4 ZWxfdGVzdHM6Ci0gICAgICAgICAgICAjIGRvbid0IGNoZWNrIHBpeGVsIHJlc3VsdHMgZm9yIFdU Ui9XSzI7IHRoZXkncmUgYnJva2VuLgotICAgICAgICAgICAgcmV0dXJuIFRlc3RSZXN1bHQoc2Vs Zi5fdGVzdF9uYW1lLCBmYWlsdXJlcywgdG90YWxfdGVzdF90aW1lLCBoYXNfc3RkZXJyKQotCiAg ICAgICAgIGlmIG5vdCByZWZlcmVuY2VfZHJpdmVyX291dHB1dC5pbWFnZV9oYXNoIGFuZCBub3Qg YWN0dWFsX2RyaXZlcl9vdXRwdXQuaW1hZ2VfaGFzaDoKICAgICAgICAgICAgIGZhaWx1cmVzLmFw cGVuZCh0ZXN0X2ZhaWx1cmVzLkZhaWx1cmVSZWZ0ZXN0Tm9JbWFnZXNHZW5lcmF0ZWQocmVmZXJl bmNlX2ZpbGVuYW1lKSkKICAgICAgICAgZWxpZiBtaXNtYXRjaDoKICAgICAgICAgICAgIGlmIHJl ZmVyZW5jZV9kcml2ZXJfb3V0cHV0LmltYWdlX2hhc2ggPT0gYWN0dWFsX2RyaXZlcl9vdXRwdXQu aW1hZ2VfaGFzaDoKLSAgICAgICAgICAgICAgICBmYWlsdXJlcy5hcHBlbmQodGVzdF9mYWlsdXJl cy5GYWlsdXJlUmVmdGVzdE1pc21hdGNoRGlkTm90T2NjdXIocmVmZXJlbmNlX2ZpbGVuYW1lKSkK LSAgICAgICAgZWxpZiByZWZlcmVuY2VfZHJpdmVyX291dHB1dC5pbWFnZV9oYXNoICE9IGFjdHVh bF9kcml2ZXJfb3V0cHV0LmltYWdlX2hhc2g6Ci0gICAgICAgICAgICBmYWlsdXJlcy5hcHBlbmQo dGVzdF9mYWlsdXJlcy5GYWlsdXJlUmVmdGVzdE1pc21hdGNoKHJlZmVyZW5jZV9maWxlbmFtZSkp CisgICAgICAgICAgICAgICAgZGlmZl9yZXN1bHQgPSBzZWxmLl9wb3J0LmRpZmZfaW1hZ2UocmVm ZXJlbmNlX2RyaXZlcl9vdXRwdXQuaW1hZ2UsIGFjdHVhbF9kcml2ZXJfb3V0cHV0LmltYWdlKQor ICAgICAgICAgICAgICAgIGlmIG5vdCBkaWZmX3Jlc3VsdFswXToKKyAgICAgICAgICAgICAgICAg ICAgZmFpbHVyZXMuYXBwZW5kKHRlc3RfZmFpbHVyZXMuRmFpbHVyZVJlZnRlc3RNaXNtYXRjaERp ZE5vdE9jY3VyKHJlZmVyZW5jZV9maWxlbmFtZSkpCisgICAgICAgICAgICAgICAgZWxzZToKKyAg ICAgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCIgICVzIC0+IHJlZiB0ZXN0IGhhc2hlcyBt YXRjaGVkIGJ1dCBkaWZmIGZhaWxlZCIgJSBzZWxmLl90ZXN0X25hbWUpCiAKLSAgICAgICAgIyBy ZWNvbXB1dGUgaW4gY2FzZSB3ZSBhZGRlZCB0byBzdGRlcnIgZHVyaW5nIGRpZmZfaW1hZ2UKLSAg ICAgICAgaGFzX3N0ZGVyciA9IHJlZmVyZW5jZV9kcml2ZXJfb3V0cHV0Lmhhc19zdGRlcnIoKSBv ciBhY3R1YWxfZHJpdmVyX291dHB1dC5oYXNfc3RkZXJyKCkKKyAgICAgICAgZWxpZiByZWZlcmVu Y2VfZHJpdmVyX291dHB1dC5pbWFnZV9oYXNoICE9IGFjdHVhbF9kcml2ZXJfb3V0cHV0LmltYWdl X2hhc2g6CisgICAgICAgICAgICBkaWZmX3Jlc3VsdCA9IHNlbGYuX3BvcnQuZGlmZl9pbWFnZShy ZWZlcmVuY2VfZHJpdmVyX291dHB1dC5pbWFnZSwgYWN0dWFsX2RyaXZlcl9vdXRwdXQuaW1hZ2Up CisgICAgICAgICAgICBpZiBkaWZmX3Jlc3VsdFswXToKKyAgICAgICAgICAgICAgICBmYWlsdXJl cy5hcHBlbmQodGVzdF9mYWlsdXJlcy5GYWlsdXJlUmVmdGVzdE1pc21hdGNoKHJlZmVyZW5jZV9m aWxlbmFtZSkpCisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIF9sb2cud2Fybmlu ZygiICAlcyAtPiByZWYgdGVzdCBoYXNoZXMgZGlkbid0IG1hdGNoIGJ1dCBkaWZmIHBhc3NlZCIg JSBzZWxmLl90ZXN0X25hbWUpCiAKICAgICAgICAgcmV0dXJuIFRlc3RSZXN1bHQoc2VsZi5fdGVz dF9uYW1lLCBmYWlsdXJlcywgdG90YWxfdGVzdF90aW1lLCBoYXNfc3RkZXJyKQpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvdGVzdF9y ZXN1bHRfd3JpdGVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u dHJvbGxlcnMvdGVzdF9yZXN1bHRfd3JpdGVyLnB5CmluZGV4IDU0Y2RkYWZjYTU5YWJjYzM0MDA3 NTIwNzkyODBmM2ZiNjYxOTZhZTUuLmJlMTc4YWIzMjgyYTVjM2UyYjYwNmI1NDIyNGVmNzQxNDMx ZTUwMDEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2Nv bnRyb2xsZXJzL3Rlc3RfcmVzdWx0X3dyaXRlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy90ZXN0X3Jlc3VsdF93cml0ZXIucHkKQEAgLTc0 LDcgKzc0LDcgQEAgZGVmIHdyaXRlX3Rlc3RfcmVzdWx0KGZpbGVzeXN0ZW0sIHBvcnQsIHRlc3Rf bmFtZSwgZHJpdmVyX291dHB1dCwKICAgICAgICAgICAgICAgICAgICAgd3JpdGVyLndyaXRlX2lt YWdlX2RpZmZfZmlsZXMoZGlmZl9pbWFnZSkKICAgICAgICAgICAgICAgICAgICAgZmFpbHVyZS5k aWZmX3BlcmNlbnQgPSBkaWZmX3BlcmNlbnQKICAgICAgICAgICAgICAgICBlbHNlOgotICAgICAg ICAgICAgICAgICAgICBfbG9nLndhcm4oJ0NhbiBub3QgZ2V0IGltYWdlIGRpZmYuIEltYWdlRGlm ZiBwcm9ncmFtIG1pZ2h0IG5vdCB3b3JrIGNvcnJlY3RseS4nKQorICAgICAgICAgICAgICAgICAg ICBfbG9nLndhcm4oJ3JlZiB0ZXN0IG1pc21hdGNoIGRpZCBub3QgcHJvZHVjZSBhbiBpbWFnZSBk aWZmLicpCiAgICAgICAgICAgICB3cml0ZXIud3JpdGVfcmVmdGVzdChmYWlsdXJlLnJlZmVyZW5j ZV9maWxlbmFtZSkKICAgICAgICAgZWxpZiBpc2luc3RhbmNlKGZhaWx1cmUsIHRlc3RfZmFpbHVy ZXMuRmFpbHVyZVJlZnRlc3RNaXNtYXRjaERpZE5vdE9jY3VyKToKICAgICAgICAgICAgIHdyaXRl ci53cml0ZV9pbWFnZV9maWxlcyhkcml2ZXJfb3V0cHV0LmltYWdlLCBleHBlY3RlZF9pbWFnZT1O b25lKQo=