94535 2012-08-20 15:16:46 -0700 Never notify of insertedIntoTree during document destruction. 2012-08-21 11:50:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn eric inferno webkit.review.bot oldest_to_newest 700035 0 esprehn 2012-08-20 15:16:46 -0700 Never notify of insertedIntoTree since we wouldn't notify of removed causing bugs if you get multiple inserted notifications and no removed. 700037 1 159532 esprehn 2012-08-20 15:17:54 -0700 Created attachment 159532 Patch Never notify the renderer of insertedIntoTree during document destruction since we dont notify of willBeRemovedFromTree. 700070 2 159539 esprehn 2012-08-20 15:33:05 -0700 Created attachment 159539 Patch 700074 3 159539 eric 2012-08-20 15:35:03 -0700 Comment on attachment 159539 Patch Yup. 700085 4 inferno 2012-08-20 15:41:10 -0700 nice catch! 700259 5 159539 webkit.review.bot 2012-08-20 17:45:33 -0700 Comment on attachment 159539 Patch Clearing flags on attachment: 159539 Committed r126107: <http://trac.webkit.org/changeset/126107> 700260 6 webkit.review.bot 2012-08-20 17:45:36 -0700 All reviewed patches have been landed. Closing bug. 700970 7 159539 ap 2012-08-21 11:50:24 -0700 Comment on attachment 159539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159539&action=review > Source/WebCore/ChangeLog:12 > + No tests needed since this just closes holes related to future code. Will these tests be added together with future code? 159532 2012-08-20 15:17:54 -0700 2012-08-20 15:33:03 -0700 Patch bug-94535-20120820151715.patch text/plain 1981 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RmZmUzMDAyMzgyZGU3 NWFjODQyYjc5YTllMzZkNDBkNWU3YWExZS4uNzA3NWVmZmMzZDRlZWEzOWNhMDYwMjEzNjNiMGRl NjUxZmE1Mzk1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTIwICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIE5ldmVyIG5vdGlm eSBvZiBpbnNlcnRlZEludG9UcmVlIHNpbmNlIHdlIHdvdWxkbid0IG5vdGlmeSBvZiByZW1vdmVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ1MzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZXZlciBu b3RpZnkgb2YgaW5zZXJ0ZWRJbnRvVHJlZSBzaW5jZSB3ZSB3b3VsZG4ndCBub3RpZnkgb2YgcmVt b3ZlZCBjYXVzaW5nIGJ1Z3MgaWYgeW91IGdldCBtdWx0aXBsZSBpbnNlcnRlZCBub3RpZmljYXRp b25zIGFuZCBubyByZW1vdmVkLgorCisgICAgICAgIE5vIHRlc3RzIG5lZWRlZCBzaW5jZSB0aGlz IGp1c3QgY2xvc2VzIGhvbGVzIHJlbGF0ZWQgdG8gZnV0dXJlIGNvZGUuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyT2JqZWN0Q2hpbGRMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlck9iamVjdENoaWxkTGlzdDo6YXBwZW5kQ2hpbGROb2RlKToKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlck9iamVjdENoaWxkTGlzdDo6aW5zZXJ0Q2hpbGROb2RlKToKKwogMjAxMi0wOC0yMCAg Sm9obiBNZWxsb3IgIDxqb2hubWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRleHQgQXV0b3Np emluZzogT25seSB0YWtlIGludG8gYWNjb3VudCBibG9jayB3aWR0aCA8PSBkb2N1bWVudCBsYXlv dXQgd2lkdGguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2Jq ZWN0Q2hpbGRMaXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RD aGlsZExpc3QuY3BwCmluZGV4IDc4NjRhY2EzNDQ1YWUzN2MyMjA2OWM1MDhmMDYxYWI4MDYxZGE1 Y2QuLmJkYjU1MTZiNzhjNzdhMTJkNDU4ZTY4MzQ1NjJlY2M5Mjg3NmUwOWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwCkBAIC0x MzgsNyArMTM4LDcgQEAgdm9pZCBSZW5kZXJPYmplY3RDaGlsZExpc3Q6OmFwcGVuZENoaWxkTm9k ZShSZW5kZXJPYmplY3QqIG93bmVyLCBSZW5kZXJPYmplY3QqIG4KIAogICAgIHNldExhc3RDaGls ZChuZXdDaGlsZCk7CiAgICAgCi0gICAgaWYgKG5vdGlmeVJlbmRlcmVyKQorICAgIGlmICghb3du ZXItPmRvY3VtZW50QmVpbmdEZXN0cm95ZWQoKSAmJiBub3RpZnlSZW5kZXJlcikKICAgICAgICAg bmV3Q2hpbGQtPmluc2VydGVkSW50b1RyZWUoKTsKIAogICAgIGlmICghb3duZXItPmRvY3VtZW50 QmVpbmdEZXN0cm95ZWQoKSkgewpAQCAtMTc4LDcgKzE3OCw3IEBAIHZvaWQgUmVuZGVyT2JqZWN0 Q2hpbGRMaXN0OjppbnNlcnRDaGlsZE5vZGUoUmVuZGVyT2JqZWN0KiBvd25lciwgUmVuZGVyT2Jq ZWN0KiBjCiAKICAgICBjaGlsZC0+c2V0UGFyZW50KG93bmVyKTsKICAgICAKLSAgICBpZiAobm90 aWZ5UmVuZGVyZXIpCisgICAgaWYgKCFvd25lci0+ZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgpICYm IG5vdGlmeVJlbmRlcmVyKQogICAgICAgICBjaGlsZC0+aW5zZXJ0ZWRJbnRvVHJlZSgpOwogCiAg ICAgaWYgKCFvd25lci0+ZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgpKSB7Cg== 159539 2012-08-20 15:33:05 -0700 2012-08-21 11:50:24 -0700 Patch bug-94535-20120820153226.patch text/plain 2943 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2RmZmUzMDAyMzgyZGU3 NWFjODQyYjc5YTllMzZkNDBkNWU3YWExZS4uYTllMjJlMWJjMjg1NTRmYTAyMWNkNDc1N2JjZjEz ZDcxNGQzNWFkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTIwICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIE5ldmVyIG5vdGlm eSBvZiBpbnNlcnRlZEludG9UcmVlIGR1cmluZyBkb2N1bWVudCBkZXN0cnVjdGlvbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NTM1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV2ZXIgbm90aWZ5IG9m IGluc2VydGVkSW50b1RyZWUgZHVyaW5nIGRvY3VtZW50IGRlc3RydWN0aW9uLiBQcmV2aW91c2x5 IHNpbmNlIHdlCisgICAgICAgIGF2b2lkIG5vdGlmeWluZyBvZiB3aWxsQmVSZW1vdmVkRnJvbVRy ZWUgaXQncyBwb3NzaWJsZSB3ZSBjb3VsZCBoYXZlIGdvdHRlbiBzZXZlcmFsCisgICAgICAgIGlu c2VydGVkSW50b1RyZWUgbm90aWZpY2F0aW9ucyB3aXRob3V0IGV2ZXIgYmVpbmcgdG9sZCB3ZSB3 ZXJlIHJlbW92ZWQuCisKKyAgICAgICAgTm8gdGVzdHMgbmVlZGVkIHNpbmNlIHRoaXMganVzdCBj bG9zZXMgaG9sZXMgcmVsYXRlZCB0byBmdXR1cmUgY29kZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2Jq ZWN0Q2hpbGRMaXN0OjphcHBlbmRDaGlsZE5vZGUpOiBOZXZlciBjYWxsIGluc2VydGVkSW50b1Ry ZWUgZHVyaW5nIGRvY3VtZW50IGRlc3RydWN0aW9uLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy T2JqZWN0Q2hpbGRMaXN0OjppbnNlcnRDaGlsZE5vZGUpOiBTYW1lLgorICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJSZWdpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyUmVnaW9uOjph dHRhY2hSZWdpb24pOiBSZW1vdmVkIHVubmVlZGVkIGRvY3VtZW50IGRlc3RydWN0aW9uIGNoZWNr LgorCiAyMDEyLTA4LTIwICBKb2huIE1lbGxvciAgPGpvaG5tZUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgVGV4dCBBdXRvc2l6aW5nOiBPbmx5IHRha2UgaW50byBhY2NvdW50IGJsb2NrIHdpZHRo IDw9IGRvY3VtZW50IGxheW91dCB3aWR0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJPYmplY3RDaGlsZExpc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlck9iamVjdENoaWxkTGlzdC5jcHAKaW5kZXggNzg2NGFjYTM0NDVhZTM3YzIyMDY5 YzUwOGYwNjFhYjgwNjFkYTVjZC4uYmRiNTUxNmI3OGM3N2ExMmQ0NThlNjgzNDU2MmVjYzkyODc2 ZTA5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdENo aWxkTGlzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdENo aWxkTGlzdC5jcHAKQEAgLTEzOCw3ICsxMzgsNyBAQCB2b2lkIFJlbmRlck9iamVjdENoaWxkTGlz dDo6YXBwZW5kQ2hpbGROb2RlKFJlbmRlck9iamVjdCogb3duZXIsIFJlbmRlck9iamVjdCogbgog CiAgICAgc2V0TGFzdENoaWxkKG5ld0NoaWxkKTsKICAgICAKLSAgICBpZiAobm90aWZ5UmVuZGVy ZXIpCisgICAgaWYgKCFvd25lci0+ZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgpICYmIG5vdGlmeVJl bmRlcmVyKQogICAgICAgICBuZXdDaGlsZC0+aW5zZXJ0ZWRJbnRvVHJlZSgpOwogCiAgICAgaWYg KCFvd25lci0+ZG9jdW1lbnRCZWluZ0Rlc3Ryb3llZCgpKSB7CkBAIC0xNzgsNyArMTc4LDcgQEAg dm9pZCBSZW5kZXJPYmplY3RDaGlsZExpc3Q6Omluc2VydENoaWxkTm9kZShSZW5kZXJPYmplY3Qq IG93bmVyLCBSZW5kZXJPYmplY3QqIGMKIAogICAgIGNoaWxkLT5zZXRQYXJlbnQob3duZXIpOwog ICAgIAotICAgIGlmIChub3RpZnlSZW5kZXJlcikKKyAgICBpZiAoIW93bmVyLT5kb2N1bWVudEJl aW5nRGVzdHJveWVkKCkgJiYgbm90aWZ5UmVuZGVyZXIpCiAgICAgICAgIGNoaWxkLT5pbnNlcnRl ZEludG9UcmVlKCk7CiAKICAgICBpZiAoIW93bmVyLT5kb2N1bWVudEJlaW5nRGVzdHJveWVkKCkp IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJSZWdpb24uY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJlZ2lvbi5jcHAKaW5kZXggZjViNGIz NjdiODZkNDNlOTU5YzhlNGFmZDljYzYzODUwYjA0Mzc2Mi4uYjliMzNmMzk3ZjBiYjA3Yjg0NzYx YzFhYmQ2YjM0NjMyZjMxMjRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclJlZ2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclJl Z2lvbi5jcHAKQEAgLTE5Myw5ICsxOTMsNyBAQCB2b2lkIFJlbmRlclJlZ2lvbjo6bGF5b3V0KCkK IAogdm9pZCBSZW5kZXJSZWdpb246OmF0dGFjaFJlZ2lvbigpCiB7Ci0gICAgaWYgKGRvY3VtZW50 QmVpbmdEZXN0cm95ZWQoKSkKLSAgICAgICAgcmV0dXJuOwotCisgICAgQVNTRVJUKHZpZXcoKSk7 CiAgICAgQVNTRVJUKCFtX2Zsb3dUaHJlYWQpOwogICAgIC8vIEluaXRpYWxpemUgdGhlIGZsb3cg dGhyZWFkIHJlZmVyZW5jZSBhbmQgY3JlYXRlIHRoZSBmbG93IHRocmVhZCBvYmplY3QgaWYgbmVl ZGVkLgogICAgIC8vIFRoZSBmbG93IHRocmVhZCBsaWZldGltZSBpcyBpbmZsdWVuY2VkIGJ5IHRo ZSBudW1iZXIgb2YgcmVnaW9ucyBhdHRhY2hlZCB0byBpdCwK