94514 2012-08-20 12:39:46 -0700 [BlackBerry] Enabling DEBUG_LAYER_ANIMATION results in build break & warnings 2012-08-20 14:15:55 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 1 anlo anlo mifenton tonikitoo webkit.review.bot oldest_to_newest 699801 0 anlo 2012-08-20 12:39:46 -0700 DEBUG_LAYER_ANIMATION is for debug prints that are disabled by default. Enabling it results in an undefined wtf::CString build break & warnings. 699806 1 159493 anlo 2012-08-20 12:49:17 -0700 Created attachment 159493 Patch 699814 2 159493 rwlbuis 2012-08-20 12:52:39 -0700 Comment on attachment 159493 Patch LGTM. 699947 3 159493 webkit.review.bot 2012-08-20 14:15:51 -0700 Comment on attachment 159493 Patch Clearing flags on attachment: 159493 Committed r126068: <http://trac.webkit.org/changeset/126068> 699948 4 webkit.review.bot 2012-08-20 14:15:55 -0700 All reviewed patches have been landed. Closing bug. 159493 2012-08-20 12:49:17 -0700 2012-08-20 14:15:51 -0700 Patch bug-94514-20120820155159.patch text/plain 3356 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQyZWQzZDU0ZTQ0ZmY4 MjY4MDdjYWNiYjVjMDJkNjdlNjA2MmZmOC4uZDgwNjNkZGJjNzgwODk3NDE0MWFiZTg2NGY5YmFh ZTYyNTkxYzRiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTIwICBBbmRy ZXcgTG8gIDxhbmxvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEVuYWJsaW5nIERF QlVHX0xBWUVSX0FOSU1BVElPTiByZXN1bHRzIGluIGJ1aWxkIGJyZWFrICYgd2FybmluZ3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHd0Zjo6Q1N0 cmluZyBkZWZpbml0aW9uIHRvIGZpeCBidWlsZCBicmVhayB3aGVuIGVuYWJsaW5nIERFQlVHX0xB WUVSX0FOSU1BVElPTgorICAgICAgICBkZWJ1ZyBwcmludHMuIEZpeCBidWlsZCB3YXJuaW5ncyBm cm9tIHByaW50cy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vbi1mdW5jdGlvbmFsIGNoYW5n ZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvR3JhcGhpY3NMYXll ckJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckJsYWNrQmVy cnk6OmFkZEFuaW1hdGlvbik6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyQmxhY2tC ZXJyeTo6cGF1c2VBbmltYXRpb24pOgorCiAyMDEyLTA4LTE1ICBKb3NodWEgTmV0dGVyZmllbGQg IDxqbmV0dGVyZmllbGRAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVXBzdHJlYW0g QmxhY2tCZXJyeSBidWlsZCBmaXhlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9HcmFwaGljc0xheWVyQmxhY2tCZXJyeS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzTGF5ZXJCbGFj a0JlcnJ5LmNwcAppbmRleCBjYjlmZTFkNjdmODI0NzQ0YTM1MDdmZDBhMDY1MjlhYTUxNTgxNjQy Li41NDVmMzBmYTBjNTQ2OWMzNDAyZDhkMWU2NmM1MWNkOGI1MjM2ODNmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0dyYXBoaWNzTGF5ZXJC bGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFj a2JlcnJ5L0dyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5LmNwcApAQCAtNTMsNiArNTMsMTAgQEAKICNp bmNsdWRlICJMYXllcldlYktpdFRocmVhZC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgi CiAKKyNpZiBERUJVR19MQVlFUl9BTklNQVRJT04KKyNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5n Lmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0aWMgdm9pZCBzZXRMYXll ckJvcmRlckNvbG9yKExheWVyV2ViS2l0VGhyZWFkJiBsYXllciwgY29uc3QgQ29sb3ImIGNvbG9y KQpAQCAtNDQ2LDcgKzQ1MCw3IEBAIGJvb2wgR3JhcGhpY3NMYXllckJsYWNrQmVycnk6OmFkZEFu aW1hdGlvbihjb25zdCBLZXlmcmFtZVZhbHVlTGlzdCYgdmFsdWVzLCBjb25zCiAgICAgUmVmUHRy PExheWVyQW5pbWF0aW9uPiBsYXllckFuaW1hdGlvbiA9IExheWVyQW5pbWF0aW9uOjpjcmVhdGUo dmFsdWVzLCBib3hTaXplLCBhbmltYXRpb24sIGFuaW1hdGlvbk5hbWUsIHRpbWVPZmZzZXQpOwog CiAjaWYgREVCVUdfTEFZRVJfQU5JTUFUSU9OCi0gICAgZnByaW50ZihzdGRlcnIsICJMYXllckFu aW1hdGlvbiAweCUwOHg6IEFkZGluZyBhbmltYXRpb24gJXMgZm9yIHByb3BlcnR5ICVkXG4iLCBs YXllckFuaW1hdGlvbi5nZXQoKSwgYW5pbWF0aW9uTmFtZS5sYXRpbjEoKS5kYXRhKCksIHZhbHVl cy5wcm9wZXJ0eSgpKTsKKyAgICBmcHJpbnRmKHN0ZGVyciwgIkxheWVyQW5pbWF0aW9uIDB4JTA4 eDogQWRkaW5nIGFuaW1hdGlvbiAlcyBmb3IgcHJvcGVydHkgJWRcbiIsIChpbnQpbGF5ZXJBbmlt YXRpb24uZ2V0KCksIGFuaW1hdGlvbk5hbWUubGF0aW4xKCkuZGF0YSgpLCB2YWx1ZXMucHJvcGVy dHkoKSk7CiAjZW5kaWYKIAogICAgIG1fcnVubmluZ0FuaW1hdGlvbnMuYXBwZW5kKGxheWVyQW5p bWF0aW9uKTsKQEAgLTQ2Miw3ICs0NjYsNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5 OjpwYXVzZUFuaW1hdGlvbihjb25zdCBTdHJpbmcmIGFuaW1hdGlvbk5hbWUsIGRvdWJsZQogCiAg ICAgd2hpbGUgKFJlZlB0cjxMYXllckFuaW1hdGlvbj4gYW5pbWF0aW9uID0gcmVtb3ZlQW5pbWF0 aW9uQnlOYW1lKGFuaW1hdGlvbk5hbWUsIG1fcnVubmluZ0FuaW1hdGlvbnMpKSB7CiAjaWYgREVC VUdfTEFZRVJfQU5JTUFUSU9OCi0gICAgICAgIGZwcmludGYoc3RkZXJyLCAiTGF5ZXJBbmltYXRp b24gMHglMDh4OiBQYXVzaW5nIGFuaW1hdGlvbiAlc1xuIiwgYW5pbWF0aW9uLmdldCgpLCBhbmlt YXRpb24tPm5hbWUoKS5sYXRpbjEoKS5kYXRhKCkpOworICAgICAgICBmcHJpbnRmKHN0ZGVyciwg IkxheWVyQW5pbWF0aW9uIDB4JTA4eDogUGF1c2luZyBhbmltYXRpb24gJXNcbiIsIChpbnQpYW5p bWF0aW9uLmdldCgpLCBhbmltYXRpb24tPm5hbWUoKS5sYXRpbjEoKS5kYXRhKCkpOwogI2VuZGlm CiAKICAgICAgICAgLy8gTGF5ZXJBbmltYXRpb24gaXMgcmVhZG9ubHkuIENyZWF0ZSBhIG5ldyBh bmltYXRpb24gd2l0aCB0aGUgc2FtZSBkYXRhIGV4Y2VwdCBmb3IgdGltZU9mZnNldC4KQEAgLTQ3 NSw3ICs0NzksNyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJCbGFja0JlcnJ5OjpwYXVzZUFuaW1hdGlv bihjb25zdCBTdHJpbmcmIGFuaW1hdGlvbk5hbWUsIGRvdWJsZQogICAgICAgICBtX3N1c3BlbmRl ZEFuaW1hdGlvbnMuYXBwZW5kKGFuaW1hdGlvbik7CiAKICNpZiBERUJVR19MQVlFUl9BTklNQVRJ T04KLSAgICAgICAgZnByaW50ZihzdGRlcnIsICJMYXllckFuaW1hdGlvbiAweCUwOHg6IFBhdXNl ZCBhbmltYXRpb24gJXNcbiIsIGFuaW1hdGlvbi5nZXQoKSwgYW5pbWF0aW9uLT5uYW1lKCkubGF0 aW4xKCkuZGF0YSgpKTsKKyAgICAgICAgZnByaW50ZihzdGRlcnIsICJMYXllckFuaW1hdGlvbiAw eCUwOHg6IFBhdXNlZCBhbmltYXRpb24gJXNcbiIsIChpbnQpYW5pbWF0aW9uLmdldCgpLCBhbmlt YXRpb24tPm5hbWUoKS5sYXRpbjEoKS5kYXRhKCkpOwogI2VuZGlmCiAgICAgfTsKIAo=