94506 2012-08-20 11:04:44 -0700 Temporarily disable the 20+ crash and 500+ failure options on WK2 bots. 2012-08-20 11:20:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 beidson webkit-unassigned dpranke jberlin sam simon.fraser thorton oldest_to_newest 699691 0 beidson 2012-08-20 11:04:44 -0700 Temporarily disable the 20+ crash and 500+ failure options on WK2 bots. Seemingly randomly the WK2 bots are aborting due to 500+ failures. Figuring out why is covered by https://bugs.webkit.org/show_bug.cgi?id=94505 When you try to reproduce this locally you'll often see about ~700 flakey tests but they don't reproduce the flakiness on the retry. Therefore, even when you get the 500+ failures once, you still get actual information from the test run after they pass the retry. Therefore if we *didn't* bail early on the bots and instead re-ran the flaky tests then we'd actually be getting real information while we wait for 94505 to be resolved. 699695 1 159475 beidson 2012-08-20 11:08:23 -0700 Created attachment 159475 Proposed fix I don't actually know how to test changes to the buildbot infrastructure. I'll deferring to experts on whether or not that's possible and/or how to verify this change is sane. 699699 2 159475 dpranke 2012-08-20 11:10:53 -0700 Comment on attachment 159475 Proposed fix looks fine. I wouldn't worry about testing this, since it'll show up on the bot and presumably we can back this change out once things are fixed. 699717 3 beidson 2012-08-20 11:20:49 -0700 Landed in http://trac.webkit.org/changeset/126044 159475 2012-08-20 11:08:23 -0700 2012-08-20 11:10:52 -0700 Proposed fix patch.txt text/plain 2995 beidson ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGVjNzllZDQuLjM2M2U4OTIgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtMTA3LDYgKzEwNyw3IEBAIGNsYXNzIENvbmZpZ3VyZUJ1aWxkKGJ1aWxkc3Rl cC5CdWlsZFN0ZXApOgogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCJjb25maWd1cmF0aW9uIiwg c2VsZi5jb25maWd1cmF0aW9uKQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCJhcmNoaXRlY3R1 cmUiLCBzZWxmLmFyY2hpdGVjdHVyZSkKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgiYnVpbGRP bmx5Iiwgc2VsZi5idWlsZE9ubHkpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoInNob3VsZEFi b3J0RWFybHkiLCBUcnVlKQogICAgICAgICBzZWxmLmZpbmlzaGVkKFNVQ0NFU1MpCiAgICAgICAg IHJldHVybiBkZWZlci5zdWNjZWVkKE5vbmUpCiAKQEAgLTI5OCw5ICsyOTksNyBAQCBjbGFzcyBS dW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICAgICAgICAgICAgICItLWJ1aWxkLW51bWJl ciIsIFdpdGhQcm9wZXJ0aWVzKCIlKGJ1aWxkbnVtYmVyKXMiKSwKICAgICAgICAgICAgICAgICIt LW1hc3Rlci1uYW1lIiwgIndlYmtpdC5vcmciLAogICAgICAgICAgICAgICAgIi0tdGVzdC1yZXN1 bHRzLXNlcnZlciIsICJ0ZXN0LXJlc3VsdHMuYXBwc3BvdC5jb20iLAotICAgICAgICAgICAgICAg V2l0aFByb3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKSwKLSAgICAgICAgICAgICAgICIt LWV4aXQtYWZ0ZXItbi1jcmFzaGVzLW9yLXRpbWVvdXRzIiwgIjIwIiwKLSAgICAgICAgICAgICAg ICItLWV4aXQtYWZ0ZXItbi1mYWlsdXJlcyIsICI1MDAiXQorICAgICAgICAgICAgICAgV2l0aFBy b3BlcnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKV0KIAogICAgIGRlZiBfX2luaXRfXyhzZWxm LCBidWlsZEpTQ1Rvb2w9VHJ1ZSwgKmFyZ3MsICoqa3dhcmdzKToKICAgICAgICAgc2VsZi5idWls ZEpTQ1Rvb2wgPSBidWlsZEpTQ1Rvb2wKQEAgLTMwOSw5ICszMDgsMTMgQEAgY2xhc3MgUnVuV2Vi S2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAKICAgICBkZWYgc3RhcnQoc2VsZik6CiAgICAgICAgIHBs YXRmb3JtID0gc2VsZi5nZXRQcm9wZXJ0eSgncGxhdGZvcm0nKQorICAgICAgICBzaG91bGRBYm9y dEVhcmx5ID0gc2VsZi5nZXRQcm9wZXJ0eSgnc2hvdWxkQWJvcnRFYXJseScpCiAgICAgICAgIGFw cGVuZEN1c3RvbUJ1aWxkRmxhZ3Moc2VsZiwgcGxhdGZvcm0sIHNlbGYuZ2V0UHJvcGVydHkoJ2Z1 bGxQbGF0Zm9ybScpKQogICAgICAgICBpZiBwbGF0Zm9ybS5zdGFydHN3aXRoKCdtYWMnKToKICAg ICAgICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbJy0tbm8tYnVpbGQnXSkK KyAgICAgICAgaWYgc2hvdWxkQWJvcnRFYXJseToKKyAgICAgICAgICAgIHNlbGYuc2V0Q29tbWFu ZChzZWxmLmNvbW1hbmQgKyBbIi0tZXhpdC1hZnRlci1uLWNyYXNoZXMtb3ItdGltZW91dHMiLCAi MjAiLCAiLS1leGl0LWFmdGVyLW4tZmFpbHVyZXMiLCAiNTAwIl0pCisgICAgICAgICAgICAKICAg ICAgICAgaWYgcGxhdGZvcm0gPT0gIndpbiI6CiAgICAgICAgICAgICByb290QXJndW1lbnQgPSBb Jy0tcm9vdD0nICsgb3MucGF0aC5qb2luKCJXZWJLaXRCdWlsZCIsIHNlbGYuZ2V0UHJvcGVydHko J2NvbmZpZ3VyYXRpb24nKSwgImJpbiIpXQogICAgICAgICAgICAgc2VsZi5zZXRDb21tYW5kKHNl bGYuY29tbWFuZCArIFsnLS1uby1idWlsZCddKQpAQCAtNTk2LDYgKzU5OSw3IEBAIGNsYXNzIFJ1 bldlYktpdExlYWtUZXN0cyhSdW5XZWJLaXRUZXN0cyk6CiAKIGNsYXNzIFJ1bldlYktpdDJUZXN0 cyhSdW5XZWJLaXRUZXN0cyk6CiAgICAgZGVmIHN0YXJ0KHNlbGYpOgorICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCJzaG91bGRBYm9ydEVhcmx5IiwgRmFsc2UpCiAgICAgICAgIHNlbGYuc2V0Q29t bWFuZChzZWxmLmNvbW1hbmQgKyBbIi0td2Via2l0LXRlc3QtcnVubmVyIl0pCiAgICAgICAgIHJl dHVybiBSdW5XZWJLaXRUZXN0cy5zdGFydChzZWxmKQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjIwOTJmYy4uYmI3MmU4ZSAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA4LTIwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAg ICBUZW1wb3JhcmlseSBkaXNhYmxlIHRoZSAyMCsgY3Jhc2ggYW5kIDUwMCsgZmFpbHVyZSBvcHRp b25zIG9uIFdLMiBib3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQ1MDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIHJ1bm5pbmcgV0syIHRlc3RzLCBkb24ndCBhZGQgdGhlICJhYm9ydCBlYXJs eSIgY29tbWFuZCBsaW5lIG9wdGlvbnMuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoQ29uZmlndXJlQnVp bGQuc3RhcnQpOgorICAgICAgICAoUnVuV2ViS2l0VGVzdHMpOgorICAgICAgICAoUnVuV2ViS2l0 VGVzdHMuc3RhcnQpOgorICAgICAgICAoUnVuV2ViS2l0MlRlc3RzLnN0YXJ0KToKKwogMjAxMi0w OC0xOSAgU3RlcGhhbmllIExld2lzICA8c2xld2lzQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg bW91bnRhaW4gbGlvbiB0byBidWlsZCBjb25maWcuCg==