94502 2012-08-20 10:43:20 -0700 [Chromium] CCMathUtilTest.smallestAngleBetweenVectors unit test failing 2012-08-21 03:12:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 kbr shawnsingh cc-bugs jamesr skyostil webkit.review.bot oldest_to_newest 699665 0 kbr 2012-08-20 10:43:20 -0700 See for example: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/21410/steps/webkit_unit_tests Please fix ASAP in order to get the bots green. 699674 1 shawnsingh 2012-08-20 10:55:43 -0700 looks like this util function and the unit test were added with webkit rev 126018; +skyostil In the meantime, I'm trying to repro the failure locally if possible. 699752 2 kbr 2012-08-20 11:53:20 -0700 I'm going to disable this test for the moment until it's diagnosed. 699754 3 kbr 2012-08-20 11:55:34 -0700 Committed r126049: <http://trac.webkit.org/changeset/126049> 699796 4 shawnsingh 2012-08-20 12:33:19 -0700 (In reply to comment #3) > Committed r126049: <http://trac.webkit.org/changeset/126049> Just checking - was the additional TestExpectations stuff in this CL related to this unit test? 699825 5 159496 shawnsingh 2012-08-20 12:59:36 -0700 Created attachment 159496 Patch please note that the ".0" suffix seemed to be necessary here, other wise std::min could not be resolved correctly 699835 6 159496 kbr 2012-08-20 13:08:42 -0700 Comment on attachment 159496 Patch Per our offline discussion: are you sure that using higher precision for the intermediate results is really the right solution? No matter how many bits of precision are added, floating-point computations are inaccurate. Should the test be updated instead to allow for a small amount of inaccuracy? BTW, the TestExpectations updates in the other commit were unrelated to this test. 699844 7 159503 shawnsingh 2012-08-20 13:16:20 -0700 Created attachment 159503 Patch Thanks, good point =) new patch is even more trivial, and we should follow-up asking Sami whether it's OK that this edge case is tested with less precision. 699846 8 159503 kbr 2012-08-20 13:18:35 -0700 Comment on attachment 159503 Patch Looks good. r=me 700002 9 159503 webkit.review.bot 2012-08-20 14:50:36 -0700 Comment on attachment 159503 Patch Clearing flags on attachment: 159503 Committed r126075: <http://trac.webkit.org/changeset/126075> 700003 10 webkit.review.bot 2012-08-20 14:50:40 -0700 All reviewed patches have been landed. Closing bug. 700566 11 skyostil 2012-08-21 03:12:11 -0700 Thanks for fixing this guys. The landed patch looks fine. I didn't see the failure on my local machine or any Android phones, so I was wrongly assuming that EXPECT_EQ automatically uses an epsilon value for floats. 159496 2012-08-20 12:59:36 -0700 2012-08-20 13:16:17 -0700 Patch bug-94502-20120820125857.patch text/plain 3601 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODcxOWQ4MzAxNjIzOTA2 Zjc3OTc0OTc5NzdjOWU5ZGY1NWUzOTU0ZS4uMWRiNzQ1MmFjZTQ2ZDIwZDk5ZTEzMjU4Y2ZkZDdm NTMzYmZmZGQwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTIwICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g Q0NNYXRoVXRpbFRlc3Quc21hbGxlc3RBbmdsZUJldHdlZW5WZWN0b3JzIHVuaXQgdGVzdCBmYWls aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDUw MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg dGVzdCB3YXMgZmFpbGluZyBvbiBtYWMgT1MgWCBkdWUgdG8gcHJlY2lzaW9uIGVycm9yIGluCisg ICAgICAgIGRlZzJyYWQoKS4gIFRoZSBmaXgsIGF0IGxlYXN0IGZvciBub3csIGlzIHRvIHVwLWNv bnZlcnQgdG8gZG91YmxlCisgICAgICAgIHByZWNpc2lvbiBpbnNpZGUgb2YgdGhpcyBmdW5jdGlv biwgYW5kIGFmdGVyIGRlZzJyYWQoKSBpcworICAgICAgICBjb21wdXRlZCwgZG93bi1jb252ZXJ0 IGJhY2sgdG8gZmxvYXQgYmVmb3JlIHJldHVybmluZy4KKworICAgICAgICBUaGlzIHBhdGNoIGFs c28gcmUtZW5hYmxlcyB0aGUgdGVzdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDTWF0aFV0aWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NNYXRoVXRpbDo6 c21hbGxlc3RBbmdsZUJldHdlZW5WZWN0b3JzKToKKwogMjAxMi0wOC0yMCAgQnJ1bm8gZGUgT2xp dmVpcmEgQWJpbmFkZXIgIDxicnVuby5hYmluYWRlckBiYXN5c2tvbS5jb20+CiAKICAgICAgICAg W2NzczMtdGV4dF0gQWRkIHBhcnNpbmcgc3VwcG9ydCBmb3IgLXdlYmtpdC10ZXh0LWRlY29yYXRp b24tc3R5bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZDAyODI1M2RkZThkN2Q4MzEy YWEwYzYyZTUzYjY3NzZiZTNjYTdjZS4uZGE4MTVlMjY0N2U0NzJhNDljYTJhYjM5NmIxNzAxMzQ1 MGIxZmVlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAx Mi0wOC0yMCAgU2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4KKworICAgICAg ICBbY2hyb21pdW1dIENDTWF0aFV0aWxUZXN0LnNtYWxsZXN0QW5nbGVCZXR3ZWVuVmVjdG9ycyB1 bml0IHRlc3QgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQ1MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICByZS1lbmFibGUgdGhlIHRlc3QgdGhhdCB3YXMgcHJldmlvdXNseSBmYWlsaW5nLgor CisgICAgICAgICogdGVzdHMvQ0NNYXRoVXRpbFRlc3QuY3BwOgorCiAyMDEyLTA4LTIwICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIENocm9t aXVtIHJlYmFzZWxpbmluZyBhbmQgdGVzdCBmYWlsdXJlIHN1cHByZXNzaW9ucy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTWF0aFV0 aWwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NN YXRoVXRpbC5jcHAKaW5kZXggY2FkMGE1ZDYzYWU5MjAyZTg5MzVlYzYwMzQ3MmMyZmM3OWQ1NDli NC4uMjQ4ZmE5ZjA4YjRjZGJjM2EyZTc2OGEzZmYwNzBlZWI5NjhhMTA3ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NNYXRoVXRpbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NN YXRoVXRpbC5jcHAKQEAgLTM4MywxMCArMzgzLDEzIEBAIHZvaWQgQ0NNYXRoVXRpbDo6ZmxhdHRl blRyYW5zZm9ybVRvMmQoV2ViVHJhbnNmb3JtYXRpb25NYXRyaXgmIHRyYW5zZm9ybSkKIAogZmxv YXQgQ0NNYXRoVXRpbDo6c21hbGxlc3RBbmdsZUJldHdlZW5WZWN0b3JzKGNvbnN0IEZsb2F0U2l6 ZSYgdjEsIGNvbnN0IEZsb2F0U2l6ZSYgdjIpCiB7Ci0gICAgZmxvYXQgZG90UHJvZHVjdCA9ICh2 MS53aWR0aCgpICogdjIud2lkdGgoKSArIHYxLmhlaWdodCgpICogdjIuaGVpZ2h0KCkpIC8gKHYx LmRpYWdvbmFsTGVuZ3RoKCkgKiB2Mi5kaWFnb25hbExlbmd0aCgpKTsKKyAgICBkb3VibGUgZG90 UHJvZHVjdCA9ICh2MS53aWR0aCgpICogdjIud2lkdGgoKSArIHYxLmhlaWdodCgpICogdjIuaGVp Z2h0KCkpIC8gKHYxLmRpYWdvbmFsTGVuZ3RoKCkgKiB2Mi5kaWFnb25hbExlbmd0aCgpKTsKKwog ICAgIC8vIENsYW1wIHRvIGNvbXBlbnNhdGUgZm9yIHJvdW5kaW5nIGVycm9ycy4KLSAgICBkb3RQ cm9kdWN0ID0gc3RkOjptYXgoLTEuZiwgc3RkOjptaW4oMS5mLCBkb3RQcm9kdWN0KSk7Ci0gICAg cmV0dXJuIHJhZDJkZWcoYWNvc2YoZG90UHJvZHVjdCkpOworICAgIGRvdFByb2R1Y3QgPSBzdGQ6 Om1heCgtMS4wLCBzdGQ6Om1pbigxLjAsIGRvdFByb2R1Y3QpKTsKKyAgICBkb3VibGUgcmV0ID0g cmFkMmRlZyhhY29zKGRvdFByb2R1Y3QpKTsKKworICAgIHJldHVybiByZXQ7CiB9CiAKIEZsb2F0 U2l6ZSBDQ01hdGhVdGlsOjpwcm9qZWN0VmVjdG9yKGNvbnN0IEZsb2F0U2l6ZSYgc291cmNlLCBj b25zdCBGbG9hdFNpemUmIGRlc3RpbmF0aW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9DQ01hdGhVdGlsVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL0NDTWF0aFV0aWxUZXN0LmNwcAppbmRleCA5NTJkNjdlYzMwOTFhOWU4OTA3ZDM3MGM2 NmFkMzI1MzhhZThjYzA4Li45NDIxZDYwOTAzNDA1MmE2NmFlZWVmZTc2Zjk0NDlkOTMyYzBkN2I4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTWF0aFV0aWxUZXN0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTWF0aFV0aWxUZXN0LmNw cApAQCAtMTUzLDcgKzE1Myw3IEBAIFRFU1QoQ0NNYXRoVXRpbFRlc3QsIHZlcmlmeUVuY2xvc2lu Z1JlY3RPZlZlcnRpY2VzVXNlc0NvcnJlY3RJbml0aWFsQm91bmRzKQogfQogCiAvLyBodHRwOi8v d2Via2l0Lm9yZy9iLzk0NTAyCi1URVNUKENDTWF0aFV0aWxUZXN0LCBESVNBQkxFRF9zbWFsbGVz dEFuZ2xlQmV0d2VlblZlY3RvcnMpCitURVNUKENDTWF0aFV0aWxUZXN0LCBzbWFsbGVzdEFuZ2xl QmV0d2VlblZlY3RvcnMpCiB7CiAgICAgRmxvYXRTaXplIHgoMSwgMCk7CiAgICAgRmxvYXRTaXpl IHkoMCwgMSk7Cg== 159503 2012-08-20 13:16:20 -0700 2012-08-20 14:50:36 -0700 Patch bug-94502-20120820131540.patch text/plain 2643 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGQwMjgyNTNkZGU4ZDdkODMxMmFhMGM2MmU1M2I2Nzc2YmUzY2E3Y2UuLjdmZWUwNzQ2ZGFmN2Yx NmRiNTgxNjZmZjY2MGRhYmU1Zjk0MTI1ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMjAgIFNoYXduIFNpbmdoICA8c2hhd25zaW5naEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBDQ01hdGhVdGlsVGVzdC5zbWFsbGVzdEFu Z2xlQmV0d2VlblZlY3RvcnMgdW5pdCB0ZXN0IGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRlc3QgbmVlZGVkIHRvIHVzZSBFWFBFQ1Rf RkxPQVRfRVEgaW5zdGVhZCBvZiBFWFBFQ1RfRVEuIEluCisgICAgICAgIHRoaXMgcGF0Y2gsIHRo ZSB0ZXN0IGlzIGFsc28gcmUtZW5hYmxlZC4KKworICAgICAgICAqIHRlc3RzL0NDTWF0aFV0aWxU ZXN0LmNwcDoKKwogMjAxMi0wOC0yMCAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCBDaHJvbWl1bSByZWJhc2VsaW5pbmcgYW5kIHRlc3QgZmFp bHVyZSBzdXBwcmVzc2lvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL0NDTWF0aFV0aWxUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NN YXRoVXRpbFRlc3QuY3BwCmluZGV4IDk1MmQ2N2VjMzA5MWE5ZTg5MDdkMzcwYzY2YWQzMjUzOGFl OGNjMDguLjZlYmM1NWQzNGU0NDY1YjRhMGM4ZDI4NzE0ZGJkMDRiNmIwNTAzMjEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NNYXRoVXRpbFRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NNYXRoVXRpbFRlc3QuY3BwCkBAIC0xNTIs OCArMTUyLDcgQEAgVEVTVChDQ01hdGhVdGlsVGVzdCwgdmVyaWZ5RW5jbG9zaW5nUmVjdE9mVmVy dGljZXNVc2VzQ29ycmVjdEluaXRpYWxCb3VuZHMpCiAgICAgRVhQRUNUX0ZMT0FUX1JFQ1RfRVEo RmxvYXRSZWN0KEZsb2F0UG9pbnQoLTEwMCwgLTEwMCksIEZsb2F0U2l6ZSg5MCwgOTApKSwgcmVz dWx0KTsKIH0KIAotLy8gaHR0cDovL3dlYmtpdC5vcmcvYi85NDUwMgotVEVTVChDQ01hdGhVdGls VGVzdCwgRElTQUJMRURfc21hbGxlc3RBbmdsZUJldHdlZW5WZWN0b3JzKQorVEVTVChDQ01hdGhV dGlsVGVzdCwgc21hbGxlc3RBbmdsZUJldHdlZW5WZWN0b3JzKQogewogICAgIEZsb2F0U2l6ZSB4 KDEsIDApOwogICAgIEZsb2F0U2l6ZSB5KDAsIDEpOwpAQCAtMTY4LDEzICsxNjcsMTMgQEAgVEVT VChDQ01hdGhVdGlsVGVzdCwgRElTQUJMRURfc21hbGxlc3RBbmdsZUJldHdlZW5WZWN0b3JzKQog ICAgIEVYUEVDVF9FUSgwLCBDQ01hdGhVdGlsOjpzbWFsbGVzdEFuZ2xlQmV0d2VlblZlY3RvcnMo dGVzdFZlY3RvciwgdGVzdFZlY3RvcikpOwogCiAgICAgLy8gUGFyYWxsZWwgYnV0IHJldmVyc2Vk IHZlY3RvcnMgYXJlIGF0IDE4MCBkZWdyZWVzLgotICAgIEVYUEVDVF9FUSgxODAsIENDTWF0aFV0 aWw6OnNtYWxsZXN0QW5nbGVCZXR3ZWVuVmVjdG9ycyh4LCAteCkpOwotICAgIEVYUEVDVF9FUSgx ODAsIENDTWF0aFV0aWw6OnNtYWxsZXN0QW5nbGVCZXR3ZWVuVmVjdG9ycyh5LCAteSkpOwotICAg IEVYUEVDVF9FUSgxODAsIENDTWF0aFV0aWw6OnNtYWxsZXN0QW5nbGVCZXR3ZWVuVmVjdG9ycyh0 ZXN0VmVjdG9yLCAtdGVzdFZlY3RvcikpOworICAgIEVYUEVDVF9GTE9BVF9FUSgxODAsIENDTWF0 aFV0aWw6OnNtYWxsZXN0QW5nbGVCZXR3ZWVuVmVjdG9ycyh4LCAteCkpOworICAgIEVYUEVDVF9G TE9BVF9FUSgxODAsIENDTWF0aFV0aWw6OnNtYWxsZXN0QW5nbGVCZXR3ZWVuVmVjdG9ycyh5LCAt eSkpOworICAgIEVYUEVDVF9GTE9BVF9FUSgxODAsIENDTWF0aFV0aWw6OnNtYWxsZXN0QW5nbGVC ZXR3ZWVuVmVjdG9ycyh0ZXN0VmVjdG9yLCAtdGVzdFZlY3RvcikpOwogCiAgICAgLy8gVGhlIHRl c3QgdmVjdG9yIGlzIGF0IGEga25vd24gYW5nbGUuCi0gICAgRVhQRUNUX0VRKDQ1LCBmbG9vcihD Q01hdGhVdGlsOjpzbWFsbGVzdEFuZ2xlQmV0d2VlblZlY3RvcnModGVzdFZlY3RvciwgeCkpKTsK LSAgICBFWFBFQ1RfRVEoNDUsIGZsb29yKENDTWF0aFV0aWw6OnNtYWxsZXN0QW5nbGVCZXR3ZWVu VmVjdG9ycyh0ZXN0VmVjdG9yLCB5KSkpOworICAgIEVYUEVDVF9GTE9BVF9FUSg0NSwgZmxvb3Io Q0NNYXRoVXRpbDo6c21hbGxlc3RBbmdsZUJldHdlZW5WZWN0b3JzKHRlc3RWZWN0b3IsIHgpKSk7 CisgICAgRVhQRUNUX0ZMT0FUX0VRKDQ1LCBmbG9vcihDQ01hdGhVdGlsOjpzbWFsbGVzdEFuZ2xl QmV0d2VlblZlY3RvcnModGVzdFZlY3RvciwgeSkpKTsKIH0KIAogVEVTVChDQ01hdGhVdGlsVGVz dCwgdmVjdG9yUHJvamVjdGlvbikK