94489 2012-08-20 09:49:41 -0700 Web Inspector: NMI: wrong size was reported for immutable StylePropertySet 2012-08-21 06:48:21 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 87262 0 loislo loislo alph apavlov bweinstein cmarcelo joepeck keishi loislo macpherson menard pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 699608 0 loislo 2012-08-20 09:49:41 -0700 EOM 699621 1 159461 loislo 2012-08-20 09:59:33 -0700 Created attachment 159461 Patch 700526 2 159461 yurys 2012-08-21 00:06:41 -0700 Comment on attachment 159461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159461&action=review > Source/WebCore/ChangeLog:8 > + Immutable StylePropertySet is creating via placement new. creating -> created 700531 3 loislo 2012-08-21 00:18:13 -0700 Committed r126139: <http://trac.webkit.org/changeset/126139> 159461 2012-08-20 09:59:33 -0700 2012-08-21 00:06:40 -0700 Patch bug-94489-20120820205853.patch text/plain 4562 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ0YjI3Yjg2YmNjNzY3 YWNkNDExMmNmMzlmYmI0ODRmOGI3OTg0Yi4uZDcyYzkwNzcwOTAyNTJiMjZjZTljNDAyNzBlMmRl MzM1MTIwNDBmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTIwICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBOTUk6IHdyb25nIHNpemUgd2FzIHJlcG9ydGVkIGZvciBpbW11dGFibGUgU3R5bGVQcm9w ZXJ0eVNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTQ0ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ bW11dGFibGUgU3R5bGVQcm9wZXJ0eVNldCBpcyBjcmVhdGluZyB2aWEgcGxhY2VtZW50IG5ldy4K KyAgICAgICAgVGhlIHJlc3Qgb2YgdGhlIGFsbG9jYXRlZCBidWZmZXIgaXMgdXNlZCBhcyBhbiBh cnJheSBvZiBDU1NQcm9wZXJ0eS4KKyAgICAgICAgVGhpcyBtZWFucyB0aGF0IHdlIGRvbid0IG5l ZWQgdG8gcmVwb3J0IG1fcHJvcGVydGllcyBtZW1iZXIgYnV0IGhhdmUgdG8gcmVwb3J0IGFjdHVh bCBzaXplIG9mIHRoZSBidWZmZXIKKyAgICAgICAgdXNlZCBmb3IgdGhlIG9iamVjdCBhbmQgQ1NT UHJvcGVydHkgYXJyYXkuCisKKyAgICAgICAgKiBjc3MvU3R5bGVQcm9wZXJ0eVNldC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjppbW11dGFibGVTdHlsZVByb3BlcnR5U2V0U2l6ZSk6CisgICAgICAg IChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUHJvcGVydHlTZXQ6OmNyZWF0ZUlt bXV0YWJsZSk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVByb3BlcnR5U2V0OjpyZXBvcnRNZW1v cnlVc2FnZSk6CisgICAgICAgICogZG9tL01lbW9yeUluc3RydW1lbnRhdGlvbi5oOgorICAgICAg ICAoV2ViQ29yZTo6TWVtb3J5T2JqZWN0SW5mbzo6cmVwb3J0T2JqZWN0SW5mbyk6CisgICAgICAg IChXZWJDb3JlOjpNZW1vcnlDbGFzc0luZm86Ok1lbW9yeUNsYXNzSW5mbyk6CisKIDIwMTItMDgt MjAgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0g TW92ZSBWOFByb3h5OjptX2V4dGVuc2lvbnMgdG8gU2NyaXB0Q29udHJvbGxlcgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwIGIvU291cmNlL1dlYkNv cmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwCmluZGV4IGE0ODcyOGFlNjU1NGY4NDUzMDVjMWE2 YWU1MmI0NTZhNTY5OWQzMzkuLmFkYzdmYzg1YzUwYjBkMzA5MmRmMmM0MDcwZTE4YzQ5YTUwNDJl ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNldC5jcHAKQEAgLTUwLDkgKzUw LDE0IEBAIHN0YXRpYyBQcm9wZXJ0eVNldENTU09NV3JhcHBlck1hcCYgcHJvcGVydHlTZXRDU1NP TVdyYXBwZXJNYXAoKQogICAgIHJldHVybiBwcm9wZXJ0eVNldENTU09NV3JhcHBlck1hcEluc3Rh bmNlOwogfQogCitzdGF0aWMgc2l6ZV90IGltbXV0YWJsZVN0eWxlUHJvcGVydHlTZXRTaXplKHVu c2lnbmVkIGNvdW50KQoreworICAgIHJldHVybiBzaXplb2YoU3R5bGVQcm9wZXJ0eVNldCkgLSBz aXplb2Yodm9pZCopICsgc2l6ZW9mKENTU1Byb3BlcnR5KSAqIGNvdW50OworfQorCiBQYXNzUmVm UHRyPFN0eWxlUHJvcGVydHlTZXQ+IFN0eWxlUHJvcGVydHlTZXQ6OmNyZWF0ZUltbXV0YWJsZShj b25zdCBDU1NQcm9wZXJ0eSogcHJvcGVydGllcywgdW5zaWduZWQgY291bnQsIENTU1BhcnNlck1v ZGUgY3NzUGFyc2VyTW9kZSkKIHsKLSAgICB2b2lkKiBzbG90ID0gV1RGOjpmYXN0TWFsbG9jKHNp emVvZihTdHlsZVByb3BlcnR5U2V0KSAtIHNpemVvZih2b2lkKikgKyBzaXplb2YoQ1NTUHJvcGVy dHkpICogY291bnQpOworICAgIHZvaWQqIHNsb3QgPSBXVEY6OmZhc3RNYWxsb2MoaW1tdXRhYmxl U3R5bGVQcm9wZXJ0eVNldFNpemUoY291bnQpKTsKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IChz bG90KSBTdHlsZVByb3BlcnR5U2V0KHByb3BlcnRpZXMsIGNvdW50LCBjc3NQYXJzZXJNb2RlLCAv KiBtYWtlTXV0YWJsZSAqLyBmYWxzZSkpOwogfQogCkBAIC0xMDkxLDExICsxMDk2LDExIEBAIHVu c2lnbmVkIFN0eWxlUHJvcGVydHlTZXQ6OmF2ZXJhZ2VTaXplSW5CeXRlcygpCiAKIHZvaWQgU3R5 bGVQcm9wZXJ0eVNldDo6cmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5 T2JqZWN0SW5mbykgY29uc3QKIHsKLSAgICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmpl Y3RJbmZvLCB0aGlzLCBNZW1vcnlJbnN0cnVtZW50YXRpb246OkNTUyk7CisgICAgc2l6ZV90IGFj dHVhbFNpemUgPSBtX2lzTXV0YWJsZSA/IHNpemVvZihTdHlsZVByb3BlcnR5U2V0KSA6IGltbXV0 YWJsZVN0eWxlUHJvcGVydHlTZXRTaXplKG1fYXJyYXlTaXplKTsKKyAgICBNZW1vcnlDbGFzc0lu Zm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBNZW1vcnlJbnN0cnVtZW50YXRpb246OkNT UywgYWN0dWFsU2l6ZSk7CiAgICAgaWYgKG1faXNNdXRhYmxlKQogICAgICAgICBpbmZvLmFkZFZl Y3RvclB0cihtX211dGFibGVQcm9wZXJ0eVZlY3Rvcik7Ci0gICAgZWxzZQotICAgICAgICBpbmZv LmFkZFJhd0J1ZmZlcihtX3Byb3BlcnRpZXMsIG1fYXJyYXlTaXplICogc2l6ZW9mKENTU1Byb3Bl cnR5KSk7CisKICAgICB1bnNpZ25lZCBjb3VudCA9IHByb3BlcnR5Q291bnQoKTsKICAgICBmb3Ig KHVuc2lnbmVkIGkgPSAwOyBpIDwgY291bnQ7ICsraSkKICAgICAgICAgaW5mby5hZGRJbnN0cnVt ZW50ZWRNZW1iZXIocHJvcGVydHlBdChpKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vTWVtb3J5SW5z dHJ1bWVudGF0aW9uLmgKaW5kZXggZWJiMzZjZWFjOGY0Nzg1MDUyYmNhYWY0MmFkOGQ5NWExZmM3 YTY1MC4uYzBjMmQzNzVhYThjZmFmZWEyMmUzZDkzZWYwM2U0ODI4OTE5NzMxMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL01lbW9yeUluc3RydW1lbnRhdGlvbi5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9NZW1vcnlJbnN0cnVtZW50YXRpb24uaApAQCAtMTY4LDEwICsxNjgsMTAg QEAgcHVibGljOgogcHJpdmF0ZToKICAgICBmcmllbmQgY2xhc3MgTWVtb3J5Q2xhc3NJbmZvOwog Ci0gICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IHZvaWQgcmVwb3J0T2JqZWN0SW5mbyhNZW1vcnlJ bnN0cnVtZW50YXRpb246Ok9iamVjdFR5cGUgb2JqZWN0VHlwZSkKKyAgICB0ZW1wbGF0ZSA8dHlw ZW5hbWUgVD4gdm9pZCByZXBvcnRPYmplY3RJbmZvKE1lbW9yeUluc3RydW1lbnRhdGlvbjo6T2Jq ZWN0VHlwZSBvYmplY3RUeXBlLCBzaXplX3QgYWN0dWFsU2l6ZSkKICAgICB7CiAgICAgICAgIGlm ICghbV9vYmplY3RTaXplKSB7Ci0gICAgICAgICAgICBtX29iamVjdFNpemUgPSBzaXplb2YoVCk7 CisgICAgICAgICAgICBtX29iamVjdFNpemUgPSBhY3R1YWxTaXplID8gYWN0dWFsU2l6ZSA6IHNp emVvZihUKTsKICAgICAgICAgICAgIGlmIChvYmplY3RUeXBlICE9IE1lbW9yeUluc3RydW1lbnRh dGlvbjo6T3RoZXIpCiAgICAgICAgICAgICAgICAgbV9vYmplY3RUeXBlID0gb2JqZWN0VHlwZTsK ICAgICAgICAgfQpAQCAtMTg1LDExICsxODUsMTEgQEAgcHJpdmF0ZToKIGNsYXNzIE1lbW9yeUNs YXNzSW5mbyB7CiBwdWJsaWM6CiAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+Ci0gICAgTWVtb3J5 Q2xhc3NJbmZvKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8sIGNvbnN0IFQqLCBN ZW1vcnlJbnN0cnVtZW50YXRpb246Ok9iamVjdFR5cGUgb2JqZWN0VHlwZSkKKyAgICBNZW1vcnlD bGFzc0luZm8oTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbywgY29uc3QgVCosIE1l bW9yeUluc3RydW1lbnRhdGlvbjo6T2JqZWN0VHlwZSBvYmplY3RUeXBlLCBzaXplX3QgYWN0dWFs U2l6ZSA9IDApCiAgICAgICAgIDogbV9tZW1vcnlPYmplY3RJbmZvKG1lbW9yeU9iamVjdEluZm8p CiAgICAgICAgICwgbV9tZW1vcnlJbnN0cnVtZW50YXRpb24obWVtb3J5T2JqZWN0SW5mby0+bWVt b3J5SW5zdHJ1bWVudGF0aW9uKCkpCiAgICAgewotICAgICAgICBtX21lbW9yeU9iamVjdEluZm8t PnJlcG9ydE9iamVjdEluZm88VD4ob2JqZWN0VHlwZSk7CisgICAgICAgIG1fbWVtb3J5T2JqZWN0 SW5mby0+cmVwb3J0T2JqZWN0SW5mbzxUPihvYmplY3RUeXBlLCBhY3R1YWxTaXplKTsKICAgICAg ICAgbV9vYmplY3RUeXBlID0gbWVtb3J5T2JqZWN0SW5mby0+b2JqZWN0VHlwZSgpOwogICAgIH0K IAo=