94486 2012-08-20 09:30:44 -0700 REGRESSION (r121482, Lion-only): Closing a popover containing a WKView can crash 2012-08-20 09:54:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac (Intel) OS X 10.7 RESOLVED FIXED InRadar P1 Major --- 1 sullivan sullivan oldest_to_newest 699592 0 sullivan 2012-08-20 09:30:44 -0700 <http://trac.webkit.org/changeset/121482> fixed a class of undo-related bugs where undo entries were left on the stack after their target was dealloc’ed. This triggered a Lion-only crash closing an NSPopover that contains a WKView, due to an object lifetime bug in AppKit. This AppKit bug was fixed in OS X 10.8. This bug represents working around that AppKit bug in OS X 10.7. This is in Radar as <rdar://problem/12128557>. 699597 1 159453 sullivan 2012-08-20 09:38:22 -0700 Created attachment 159453 Patch to avoid a line of recently-added code in the problematic case, only on OS X 10.7 699613 2 sullivan 2012-08-20 09:54:54 -0700 Fixed in http://trac.webkit.org/changeset/126041 159453 2012-08-20 09:38:22 -0700 2012-08-20 09:49:29 -0700 Patch to avoid a line of recently-added code in the problematic case, only on OS X 10.7 undo_popover_patch.txt text/plain 2599 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTk3MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTE4ICBKb2huIFN1 bGxpdmFuICA8c3VsbGl2YW5AYXBwbGUuY29tPgorCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ0ODY+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x MjEyODU1Nz4KKyAgICAgICAgUkVHUkVTU0lPTiAocjEyMTQ4MiwgTGlvbi1vbmx5KTogQ2xvc2lu ZyBhIHBvcG92ZXIgY29udGFpbmluZyBhIFdLVmlldyBjYW4gY3Jhc2gKKyAgICAgICAgCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAoLVtXS1ZpZXcgdmlld1dpbGxNb3ZlVG9XaW5kb3c6 XSk6CisgICAgICAgIEF2b2lkIGNhbGxpbmcgdGhlIGNvZGUgYWRkZWQgaW4gMTIxNDgyIHRoYXQg ZW5zdXJlcyB0aGF0IHRoZSB1bmRvIHN0YWNrIGlzIGNsZWFuZWQgdXAKKyAgICAgICAgYmVmb3Jl IHRoZSBXS1ZpZXcgaXMgbW92ZWQgZnJvbSBvbmUgd2luZG93IHRvIGFub3RoZXIgd2hlbiB0aGUg V0tWaWV3IGlzIGJlaW5nIG1vdmVkCisgICAgICAgIG91dCBvZiBhIHBvcG92ZXIgd2luZG93LiBU aGlzIGF2b2lkcyBhIGJ1ZyBpbiBPUyBYIDEwLjcgdGhhdCB3YXMgZml4ZWQgaW4gMTAuOC4KKyAg ICAgICAgV2hpbGUgdGhpcyB0ZWNobmljYWxseSByZW9wZW5zIGEgcG90ZW50aWFsbHkgY3Jhc2hp bmcgY29kZSBwYXRoIHRoYXQgMTIxNDgyIGNsb3NlZCwKKyAgICAgICAgaXQgb25seSByZW9wZW5z IGl0IGZvciBXS1ZpZXdzIHRoYXQgYXJlIHVzZWQgZm9yIHRleHQgZWRpdGluZyBhbmQgdGhhdCBh cmUgcmVtb3ZlZAorICAgICAgICBmcm9tIGFuIE5TUG9wb3ZlciBhdCBzb21lIHRpbWUgZWFybGll ciB0aGFuIHRlYXItZG93biBvZiB0aGUgTlNQb3BvdmVyLgorCiAyMDEyLTA4LTE4ICBNaWtoYWls IFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFtF RkxdW1dLMl0gZXdrX2JhY2tfZm9yd2FyZF9saXN0X2l0ZW0gcHJvcGVydGllcyBzaG91bGQgYmUg aW4gc3luYyB3aXRoIFdlYlByb2Nlc3NQcm94eTo6bV9iYWNrRm9yd2FyZExpc3RJdGVtTWFwCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lv biAxMjU3MzkpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0J KHdvcmtpbmcgY29weSkKQEAgLTE4OTUsOCArMTg5NSwxNyBAQCAtICh2b2lkKXZpZXdXaWxsTW92 ZVRvV2luZG93OihOU1dpbmRvdyAqCiAgICAgTlNXaW5kb3cgKmN1cnJlbnRXaW5kb3cgPSBbc2Vs ZiB3aW5kb3ddOwogICAgIGlmICh3aW5kb3cgPT0gY3VycmVudFdpbmRvdykKICAgICAgICAgcmV0 dXJuOwotICAgIAotICAgIF9kYXRhLT5fcGFnZUNsaWVudC0+dmlld1dpbGxNb3ZlVG9Bbm90aGVy V2luZG93KCk7CisKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID09IDEwNzAK KyAgICAvLyBBdm9pZCBjYWxsaW5nIHRoZSBjb2RlIGFkZGVkIGluIDEyMTQ4MiB0aGF0IGVuc3Vy ZXMgdGhhdCB0aGUgdW5kbyBzdGFjayBpcyBjbGVhbmVkIHVwCisgICAgLy8gYmVmb3JlIHRoZSBX S1ZpZXcgaXMgbW92ZWQgZnJvbSBvbmUgd2luZG93IHRvIGFub3RoZXIgd2hlbiB0aGUgV0tWaWV3 IGlzIGJlaW5nIG1vdmVkCisgICAgLy8gb3V0IG9mIGEgcG9wb3ZlciB3aW5kb3cuIFRoaXMgYXZv aWRzIGEgYnVnIGluIE9TIFggMTAuNyB0aGF0IHdhcyBmaXhlZCBpbiAxMC44LgorICAgIC8vIFdo aWxlIHRoaXMgdGVjaG5pY2FsbHkgcmVvcGVucyBhIHBvdGVudGlhbGx5IGNyYXNoaW5nIGNvZGUg cGF0aCB0aGF0IDEyMTQ4MiBjbG9zZWQsCisgICAgLy8gaXQgb25seSByZW9wZW5zIGl0IGZvciBX S1ZpZXdzIHRoYXQgYXJlIHVzZWQgZm9yIHRleHQgZWRpdGluZyBhbmQgdGhhdCBhcmUgcmVtb3Zl ZAorICAgIC8vIGZyb20gYW4gTlNQb3BvdmVyIGF0IHNvbWUgdGltZSBlYXJsaWVyIHRoYW4gdGVh ci1kb3duIG9mIHRoZSBOU1BvcG92ZXIuCisgICAgaWYgKCFbY3VycmVudFdpbmRvdyBpc0tpbmRP ZkNsYXNzOk5TQ2xhc3NGcm9tU3RyaW5nKEAiX05TUG9wb3ZlcldpbmRvdyIpXSkKKyNlbmRpZgor ICAgICAgICBfZGF0YS0+X3BhZ2VDbGllbnQtPnZpZXdXaWxsTW92ZVRvQW5vdGhlcldpbmRvdygp OwogICAgIAogICAgIFtzZWxmIHJlbW92ZVdpbmRvd09ic2VydmVyc107CiAgICAgW3NlbGYgYWRk V2luZG93T2JzZXJ2ZXJzRm9yV2luZG93OndpbmRvd107Cg==