94477 2012-08-20 07:04:35 -0700 Update postMessage declaration in MessagePort.idl 2012-08-20 09:56:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.w3.org/TR/html5/comms.html#messageport P2 Normal --- 1 cdumez cdumez abarth darin eric haraken levin ojan webkit.review.bot oldest_to_newest 699474 0 cdumez 2012-08-20 07:04:35 -0700 postMessage() / webkitPostMessage() are defined as follows in MessagePort.idl: [Custom] void postMessage(in DOMString message, in [Optional] Array messagePorts) [Custom] void webkitPostMessage(in DOMString message, in [Optional] Array transfer) According to the spec (http://www.w3.org/TR/html5/comms.html#messageport), the first argument should be of type 'any', not 'DOMString'. We currently don't notice the issue cause we provide custom implementation for those methods and the custom implementation handles the first argument as being of type 'any'. We should however update MessagePort.idl to avoid confusion. 699477 1 159419 cdumez 2012-08-20 07:07:54 -0700 Created attachment 159419 Patch 699552 2 159419 haraken 2012-08-20 08:49:21 -0700 Comment on attachment 159419 Patch The change looks reasonable. DedicatedWorkerContext.idl already uses 'any' for postMessage() and webkitPostMessage(). > We currently don't notice the issue cause we provide custom implementation for those methods and the custom implementation handles the first argument as being of type 'any'. Note: Code generators do not yet support 'any', so we can use 'any' only for custom implementations. We want to fix it. 699598 3 159419 webkit.review.bot 2012-08-20 09:39:26 -0700 Comment on attachment 159419 Patch Clearing flags on attachment: 159419 Committed r126040: <http://trac.webkit.org/changeset/126040> 699599 4 webkit.review.bot 2012-08-20 09:39:32 -0700 All reviewed patches have been landed. Closing bug. 159419 2012-08-20 07:07:54 -0700 2012-08-20 09:39:26 -0700 Patch 94477_messageport_idl.patch text/plain 1802 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNGY4NzU5Li41NjAxMjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDgtMjAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBwb3N0TWVzc2FnZSgpIGluIE1lc3NhZ2VQb3J0LmlkbCBkb2VzIG5v dCBtYXRjaCBzcGVjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NDQ3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFVwZGF0ZSBkZWZpbml0aW9uIG9mIHBvc3RNZXNzYWdlKCkgaW4gTWVzc2FnZVBvcnQuaWRs CisgICAgICAgIHRvIG1hdGNoIHRoZSBzcGVjaWZpY2F0aW9uIGF0OgorICAgICAgICBodHRwOi8v d3d3LnczLm9yZy9UUi9odG1sNS9jb21tcy5odG1sI21lc3NhZ2Vwb3J0CisKKyAgICAgICAgVGhl IGZpcnN0IGFyZ3VtZW50IHNob3VsZCBiZSBvZiB0eXBlICdhbnknLCBub3QKKyAgICAgICAgJ0RP TVN0cmluZycuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgKiBkb20vTWVzc2FnZVBvcnQuaWRsOgorCiAyMDEyLTA4LTIwICBYYW4gTG9wZXog IDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBQcm92aWRlIGJhY2t3YXJkcyBj b21wYXRpYmxlIG1ldGhvZCBmb3IgV2ViS2l0RE9NV2ViS2l0TmFtZWRGbG93OjpvdmVyZmxvdwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL01lc3NhZ2VQb3J0LmlkbCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9NZXNzYWdlUG9ydC5pZGwKaW5kZXggZjMxOGY3OS4uOWYzOTNiNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL01lc3NhZ2VQb3J0LmlkbAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9kb20vTWVzc2FnZVBvcnQuaWRsCkBAIC0zNyw5ICszNyw5IEBAIG1vZHVsZSBldmVudHMg ewogLy8gV2UgbmVlZCB0byBoYXZlIHNvbWV0aGluZyBhcyBhbiBPYmpDIGJpbmRpbmcsIGJlY2F1 c2UgTWVzc2FnZVBvcnQgaXMgdXNlZCBpbiBNZXNzYWdlRXZlbnQsIHdoaWNoIGFscmVhZHkgaGFz IG9uZSwKIC8vIGJ1dCB3ZSBkb24ndCB3YW50IHRvIGFjdHVhbGx5IGV4cG9zZSB0aGUgQVBJIHdo aWxlIGl0IGlzIGluIGZsdXguCiAjaWYgZGVmaW5lZChMQU5HVUFHRV9KQVZBU0NSSVBUKSAmJiBM QU5HVUFHRV9KQVZBU0NSSVBUCi0gICAgICAgIFtDdXN0b21dIHZvaWQgcG9zdE1lc3NhZ2UoaW4g RE9NU3RyaW5nIG1lc3NhZ2UsIGluIFtPcHRpb25hbF0gQXJyYXkgbWVzc2FnZVBvcnRzKQorICAg ICAgICBbQ3VzdG9tXSB2b2lkIHBvc3RNZXNzYWdlKGluIGFueSBtZXNzYWdlLCBpbiBbT3B0aW9u YWxdIEFycmF5IG1lc3NhZ2VQb3J0cykKICAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24p OwotICAgICAgICBbQ3VzdG9tXSB2b2lkIHdlYmtpdFBvc3RNZXNzYWdlKGluIERPTVN0cmluZyBt ZXNzYWdlLCBpbiBbT3B0aW9uYWxdIEFycmF5IHRyYW5zZmVyKQorICAgICAgICBbQ3VzdG9tXSB2 b2lkIHdlYmtpdFBvc3RNZXNzYWdlKGluIGFueSBtZXNzYWdlLCBpbiBbT3B0aW9uYWxdIEFycmF5 IHRyYW5zZmVyKQogICAgICAgICAgICAgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAgICAgICAgIHZv aWQgc3RhcnQoKTsKICAgICAgICAgdm9pZCBjbG9zZSgpOwo=