94468 2012-08-20 05:13:38 -0700 [Qt] Custom tap-highlight-color renders fully opaque 2012-08-20 08:18:37 -0700 1 1 1 Unclassified WebKit WebKit2 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen eric kenneth webkit.review.bot oldest_to_newest 699413 0 allan.jensen 2012-08-20 05:13:38 -0700 Observed on the webpage http://heltnormalt.dk/striben, when tap clicking any link, the link will be obscured by pink opaque overlay. The tap highlight color has been configured as: a:link { -webkit-tap-highlight-color: #FF5E99; } Which means it has been declared fully opaque, unfortunately that is not how Android, N9 or iPhone renders it as far as I can tell. I am not sure what the right solution is, but I am leaning towards redefining defaultTapHighlightColor in RenderTheme.h from 0x33000000 to 0x66000000, and always start with the tap-highlight being at most 50% transparent. Apparently N9 defines the defaultTapHighlightColor to 0x7F000000, Android to 0x6633b5e5 and iPhone to 0x4D1A1A1A, so an alpha value of 0x66 would also fit in better with actually used defaults. 699444 1 kenneth 2012-08-20 06:06:03 -0700 Ah sounds good. Probably good to leave a comment next to the value 699455 2 159410 allan.jensen 2012-08-20 06:25:51 -0700 Created attachment 159410 Patch 699530 3 159410 webkit.review.bot 2012-08-20 08:18:33 -0700 Comment on attachment 159410 Patch Clearing flags on attachment: 159410 Committed r126031: <http://trac.webkit.org/changeset/126031> 699531 4 webkit.review.bot 2012-08-20 08:18:37 -0700 All reviewed patches have been landed. Closing bug. 159410 2012-08-20 06:25:51 -0700 2012-08-20 08:18:33 -0700 Patch bug-94468-20120820152506.patch text/plain 3377 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRmODc1OTY2ZGU1ZTFh OGYzOWVlOWQ0ZTAxZTRjODAwYTJkNTk2Zi4uYTU1ZDBiMjNiYjRhMzViZjM5MjU4Nzc5YTlhMmY0 YTI4MGNlOWViYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTIwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gQ3VzdG9tIHRhcC1oaWdobGlnaHQtY29sb3IgcmVuZGVycyBmdWxseSBvcGFxdWUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDY4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRqdXN0IHRoZSBkZWZh dWx0IHRhcC1oaWdobGlnaHQtY29sb3IgdG8gZmlndXJlIGluIHRoYXQgaXMgd2lsbCBiZQorICAg ICAgICBkcmF3biBzZW1pLXRyYW5zcGFyZW50LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clRoZW1lLmg6CisgICAgICAgIChSZW5kZXJUaGVtZSk6CisKIDIwMTItMDgtMjAgIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFByb3ZpZGUgYmFja3dhcmRz IGNvbXBhdGlibGUgbWV0aG9kIGZvciBXZWJLaXRET01XZWJLaXROYW1lZEZsb3c6Om92ZXJmbG93 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cKaW5kZXggNDg0YWRjYWFmYzA2NDhlNGY1ODE1NGU1ZjBkZmUzZmQ5ZTQxMjM1OC4u OTBiNjhlNjBmMWEyYTcwNGQyODNhNzAyY2ZlZGI0ODBlZjQ4MDIzNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDEyLTA4LTIwICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5q ZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtRdF0gQ3VzdG9tIHRhcC1oaWdobGlnaHQtY29s b3IgcmVuZGVycyBmdWxseSBvcGFxdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk0NDY4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRHJhdyB0YXAtaGlnaGxpZ2h0LWNvbG9yIGF0IDUwJSB0cmFuc3BhcmVu Y3ksIHRvIGJldHRlciBtYXRjaCBob3cKKyAgICAgICAgZXhpc3RpbmcgV2ViS2l0IGJyb3dzZXJz IGFjdCBvbiBjdXN0b20gdGFwLWhpZ2hsaWdodCBjb2xvcnMuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1dlYlBhZ2UvVGFwSGlnaGxpZ2h0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJLaXQ6 OlRhcEhpZ2hsaWdodENvbnRyb2xsZXI6OmRyYXdSZWN0KToKKwogMjAxMi0wOC0yMCAgTWlraGFp bCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAgICBb RUZMXVtXSzJdIEFkZCB1bml0IHRlc3RzIGZvciBXS0VpbmFTaGFyZWRTdHJpbmcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgKaW5kZXggNmZhY2Y1MjgwMTdmOTA0MjM5YTc5MjNk OTk5NGU2MTlhNGU5MGU2NC4uNjAyNmI2MDE3MDVlNzhkNTZhZGQ5MWNlMTQ0YTkzMTgwZWEwNDA2 ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmgKQEAgLTM2NSw3ICszNjUs OSBAQCBwcml2YXRlOgogICAgIG11dGFibGUgQ29sb3IgbV9pbmFjdGl2ZUxpc3RCb3hTZWxlY3Rp b25Gb3JlZ3JvdW5kQ29sb3I7CiAKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQotICAgIHN0YXRp YyBjb25zdCBSR0JBMzIgZGVmYXVsdFRhcEhpZ2hsaWdodENvbG9yID0gMHgzMzAwMDAwMDsKKyAg ICAvLyBUaGlzIGNvbG9yIGlzIGV4cGVjdGVkIHRvIGJlIGRyYXduIG9uIGEgc2VtaS10cmFuc3Bh cmVudCBvdmVybGF5LAorICAgIC8vIG1ha2luZyBpdCBtb3JlIHRyYW5zcGFyZW50IHRoYW4gaXRz IGFscGhhIHZhbHVlIGluZGljYXRlcy4KKyAgICBzdGF0aWMgY29uc3QgUkdCQTMyIGRlZmF1bHRU YXBIaWdobGlnaHRDb2xvciA9IDB4NjYwMDAwMDA7CiAjZW5kaWYKIAogI2lmIFVTRShORVdfVEhF TUUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvVGFwSGln aGxpZ2h0Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv VGFwSGlnaGxpZ2h0Q29udHJvbGxlci5jcHAKaW5kZXggODJhZjAxZDczZDg0OGVlMzM5YWQzMDJm M2E0Yjg0MTNmODJjMDhlMi4uNjBiOWM5NzQ0YWE4ZDc4YTFiMzNhNzdkYmNjMDM4MzI3NzM2YTdi NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1RhcEhpZ2hs aWdodENvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9UYXBIaWdobGlnaHRDb250cm9sbGVyLmNwcApAQCAtMTA1LDkgKzEwNSw5IEBAIHZvaWQgVGFw SGlnaGxpZ2h0Q29udHJvbGxlcjo6ZHJhd1JlY3QoUGFnZU92ZXJsYXkqIHBhZ2VPdmVybGF5LCBH cmFwaGljc0NvbnRleHQmCiAgICAgewogICAgICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZVNhdmVy IHN0YXRlU2F2ZXIoY29udGV4dCk7CiAgICAgICAgIGlmIChtX3dlYlBhZ2UtPmRyYXdpbmdBcmVh KCktPnBhZ2VPdmVybGF5U2hvdWxkQXBwbHlGYWRlV2hlblBhaW50aW5nKCkpCi0gICAgICAgICAg ICBjb250ZXh0LnNldEZpbGxDb2xvcihoaWdobGlnaHRDb2xvcihtX2NvbG9yLCBwYWdlT3Zlcmxh eS0+ZnJhY3Rpb25GYWRlZEluKCkpLCBDb2xvclNwYWNlU1JHQik7CisgICAgICAgICAgICBjb250 ZXh0LnNldEZpbGxDb2xvcihoaWdobGlnaHRDb2xvcihtX2NvbG9yLCBwYWdlT3ZlcmxheS0+ZnJh Y3Rpb25GYWRlZEluKCkgKiAwLjVmKSwgQ29sb3JTcGFjZVNSR0IpOwogICAgICAgICBlbHNlCi0g ICAgICAgICAgICBjb250ZXh0LnNldEZpbGxDb2xvcihtX2NvbG9yLCBDb2xvclNwYWNlU1JHQik7 CisgICAgICAgICAgICBjb250ZXh0LnNldEZpbGxDb2xvcihoaWdobGlnaHRDb2xvcihtX2NvbG9y LCAwLjVmKSwgQ29sb3JTcGFjZVNSR0IpOwogICAgICAgICBjb250ZXh0LmZpbGxQYXRoKG1fcGF0 aCk7CiAgICAgfQogfQo=