94464 2012-08-20 04:42:25 -0700 [GTK] Provide backwards compatible method for WebKitDOMWebKitNamedFlow::overflow 2012-08-20 05:26:15 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned webkit.review.bot oldest_to_newest 699398 0 xan.lopez 2012-08-20 04:42:25 -0700 This was removed from upstream, but we need to keep compatibility to some extent. See https://bugs.webkit.org/show_bug.cgi?id=93477#c2 for more details. 699400 1 159394 xan.lopez 2012-08-20 04:45:25 -0700 Created attachment 159394 Patch 699405 2 webkit.review.bot 2012-08-20 04:48:38 -0700 Attachment 159394 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/gobject/WebKitDOMCustom.h:38: The parameter name "flow" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 699416 3 159394 cgarcia 2012-08-20 05:21:41 -0700 Comment on attachment 159394 Patch Thanks! 699420 4 159394 webkit.review.bot 2012-08-20 05:26:12 -0700 Comment on attachment 159394 Patch Clearing flags on attachment: 159394 Committed r126021: <http://trac.webkit.org/changeset/126021> 699421 5 webkit.review.bot 2012-08-20 05:26:15 -0700 All reviewed patches have been landed. Closing bug. 159394 2012-08-20 04:45:25 -0700 2012-08-20 05:26:12 -0700 Patch namedflow.diff text/plain 4149 xan.lopez RnJvbSAyMjg5ZTI4ZDFkOGQ1YjczMDJkN2Q1NDUzZWNiODljNjZiY2EwZjc4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBpZ2FsaWEuY29tPgpEYXRlOiBNb24s IDIwIEF1ZyAyMDEyIDEzOjQzOjU0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0wOC0yMCAg WGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFtHVEtdIFByb3ZpZGUgYmFj a3dhcmRzIGNvbXBhdGlibGUgbWV0aG9kIGZvciBXZWJLaXRET01XZWJLaXROYW1lZEZsb3c6Om92 ZXJmbG93CiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0 NDY0CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBQcm92aWRl IGEgY29tcGF0aWJpbGl0eSBtZXRob2QgdG8gYWNjZXNzIHRoZSBuZXcgJ292ZXJzZXQnCiAgICAg ICAgcHJvcGVydHkgdGhyb3VnaCB0aGUgb2xkICdvdmVyZmxvdycgbmFtZSBpbgogICAgICAgIFdl YktpdERPTVdlYktpdE5hbWVkRmxvdy4gTm90ZSB0aGF0IHRyeWluZyB0byBhY2Nlc3MgaXQgdGhy b3VnaAogICAgICAgIGdfb2JqZWN0X2dldCBkaXJlY3RseSB3aWxsIGdpdmUgYSBydW50aW1lIHdh cm5pbmcsIHNpbmNlIHRoZQogICAgICAgIHByb3BlcnR5IGRvZXMgbm90IGFjdHVhbGx5IGV4aXN0 IGFueW1vcmU7IHRoaXMgaXMgZG9uZSBwdXJlbHkgdG8KICAgICAgICBtYWludGFpbiBBUEkgY29t cGF0aWJpbGl0eS4KCiAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5j cHA6CiAgICAgICAgKHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X292ZXJmbG93KTog YWRkIG1ldGhvZC4KICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmg6 Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDE4ICsrKysrKysrKysrKysrKysrKwogLi4uL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9X ZWJLaXRET01DdXN0b20uY3BwICAgfCAgICA4ICsrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oICB8ICAgIDEgKwogMyBmaWxlcyBjaGFuZ2Vk LCAyNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlNDRkMWMx Li5lM2RmODhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTItMDgtMjAgIFhhbiBM b3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFByb3ZpZGUgYmFja3dh cmRzIGNvbXBhdGlibGUgbWV0aG9kIGZvciBXZWJLaXRET01XZWJLaXROYW1lZEZsb3c6Om92ZXJm bG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDQ2 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb3Zp ZGUgYSBjb21wYXRpYmlsaXR5IG1ldGhvZCB0byBhY2Nlc3MgdGhlIG5ldyAnb3ZlcnNldCcKKyAg ICAgICAgcHJvcGVydHkgdGhyb3VnaCB0aGUgb2xkICdvdmVyZmxvdycgbmFtZSBpbgorICAgICAg ICBXZWJLaXRET01XZWJLaXROYW1lZEZsb3cuIE5vdGUgdGhhdCB0cnlpbmcgdG8gYWNjZXNzIGl0 IHRocm91Z2gKKyAgICAgICAgZ19vYmplY3RfZ2V0IGRpcmVjdGx5IHdpbGwgZ2l2ZSBhIHJ1bnRp bWUgd2FybmluZywgc2luY2UgdGhlCisgICAgICAgIHByb3BlcnR5IGRvZXMgbm90IGFjdHVhbGx5 IGV4aXN0IGFueW1vcmU7IHRoaXMgaXMgZG9uZSBwdXJlbHkgdG8KKyAgICAgICAgbWFpbnRhaW4g QVBJIGNvbXBhdGliaWxpdHkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L1dlYktpdERP TUN1c3RvbS5jcHA6CisgICAgICAgICh3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9v dmVyZmxvdyk6IGFkZCBtZXRob2QuCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRE T01DdXN0b20uaDoKKwogMjAxMi0wOC0yMCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbXByb3ZlIHN0YW5kYWxvbmUgdGVz dCBoYXJuZXNzIHRvIGFsbG93IGF0dGFjaGluZyB0byBpbnNwZWN0b3IgYmVmb3JlIHRlc3QuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3Rv bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5j cHAKaW5kZXggYjdkOWM1Ni4uNjhhYTlmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcApAQCAtMjUsNiArMjUsNyBAQAogI2lu Y2x1ZGUgIldlYktpdERPTUhUTUxJbnB1dEVsZW1lbnRQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2Vi S2l0RE9NSFRNTFRleHRBcmVhRWxlbWVudC5oIgogI2luY2x1ZGUgIldlYktpdERPTUhUTUxUZXh0 QXJlYUVsZW1lbnRQcml2YXRlLmgiCisjaW5jbHVkZSAiV2ViS2l0RE9NV2ViS2l0TmFtZWRGbG93 LmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKQEAgLTYxLDYgKzYyLDEzIEBAIHdlYmtp dF9kb21faHRtbF9lbGVtZW50X3NldF9jbGFzc19uYW1lKFdlYktpdERPTUhUTUxFbGVtZW50KiBl bGVtZW50LCBjb25zdCBnY2hhCiAgICAgd2Via2l0X2RvbV9lbGVtZW50X3NldF9jbGFzc19uYW1l KFdFQktJVF9ET01fRUxFTUVOVChlbGVtZW50KSwgdmFsdWUpOwogfQogCitnYm9vbGVhbgord2Vi a2l0X2RvbV93ZWJraXRfbmFtZWRfZmxvd19nZXRfb3ZlcmZsb3coV2ViS2l0RE9NV2ViS2l0TmFt ZWRGbG93KiBmbG93KQoreworICAgIGdfd2FybmluZygiVGhlIFdlYktpdERPTVdlYktpdE5hbWVk Rmxvdzo6b3ZlcmZsb3cgcHJvcGVydHkgaGFzIGJlZW4gcmVuYW1lZCB0byBXZWJLaXRET01XZWJL aXROYW1lZEZsb3c6Om92ZXJzZXQuIFBsZWFzZSB1cGRhdGUgeW91ciBjb2RlIHRvIHVzZSB0aGUg bmV3IG5hbWUuIik7CisgICAgcmV0dXJuIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0 X292ZXJzZXQoZmxvdyk7Cit9CisKIHZvaWQKIHdlYmtpdF9kb21faHRtbF9mb3JtX2VsZW1lbnRf ZGlzcGF0Y2hfZm9ybV9jaGFuZ2UoV2ViS2l0RE9NSFRNTEZvcm1FbGVtZW50KiBzZWxmKQogewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0 b20uaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmgK aW5kZXggOGZiNTA4My4uYzgxYmUzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oCkBAIC0zNSw2ICszNSw3IEBAIFdFQktJVF9BUEkg dm9pZCB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9zZXRfY2xhc3NfbmFtZShXZWJLaXRET01IVE1M RWxlbWVudCogZWxlCiBXRUJLSVRfQVBJIFdlYktpdERPTURPTVRva2VuTGlzdCogd2Via2l0X2Rv bV9odG1sX2VsZW1lbnRfZ2V0X2NsYXNzX2xpc3QoV2ViS2l0RE9NSFRNTEVsZW1lbnQqIGVsZW1l bnQpOwogV0VCS0lUX0FQSSB2b2lkIHdlYmtpdF9kb21faHRtbF9mb3JtX2VsZW1lbnRfZGlzcGF0 Y2hfZm9ybV9jaGFuZ2UoV2ViS2l0RE9NSFRNTEZvcm1FbGVtZW50KiBzZWxmKTsKIFdFQktJVF9B UEkgdm9pZCB3ZWJraXRfZG9tX2h0bWxfZm9ybV9lbGVtZW50X2Rpc3BhdGNoX2Zvcm1faW5wdXQo V2ViS2l0RE9NSFRNTEZvcm1FbGVtZW50KiBzZWxmKTsKK1dFQktJVF9BUEkgZ2Jvb2xlYW4gd2Vi a2l0X2RvbV93ZWJraXRfbmFtZWRfZmxvd19nZXRfb3ZlcmZsb3coV2ViS2l0RE9NV2ViS2l0TmFt ZWRGbG93KiBmbG93KTsKIAogR19FTkRfREVDTFMKIAotLSAKMS43LjcuNgoK