94457 2012-08-20 02:06:19 -0700 Web Inspector: Drop dimmed crumb handling 2012-11-07 22:50:01 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 tzik tzik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik vsevik webkit.review.bot yurys oldest_to_newest 699333 0 tzik 2012-08-20 02:06:19 -0700 In Breadcrumbs of ElementsPanel, we skip DOCUMENT_NODE crumb and mark rootDOMNode as "dimmed". But I think, rootDOMNode is always document node and is skipped. So, "dimmed" node handling looks dead code. Can we drop it as a cleanup? 699334 1 159371 tzik 2012-08-20 02:07:54 -0700 Created attachment 159371 Patch 701165 2 159371 webkit.review.bot 2012-08-21 15:06:14 -0700 Comment on attachment 159371 Patch Rejecting attachment 159371 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ceeded at 680 (offset 1 line). Hunk #4 succeeded at 897 (offset 1 line). Hunk #5 succeeded at 908 (offset 1 line). patching file Source/WebCore/inspector/front-end/elementsPanel.css Hunk #1 FAILED at 97. Hunk #2 FAILED at 130. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/inspector/front-end/elementsPanel.css.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Vsevolod V..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13559035 761360 3 vsevik 2012-11-07 22:50:01 -0800 Landed: http://trac.webkit.org/changeset/133852 159371 2012-08-20 02:07:54 -0700 2012-08-21 15:06:14 -0700 Patch bug-94457-20120820180714.patch text/plain 4671 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM0YzA5YjczOWNkMjY2 NGVjNjBhNDQzZTc1MTgyOGVjYTUyMmI0My4uMjQ0ZmZjYjliM2U0MDEzM2NmMTg4OGQ3YmZmYTQw MzE2ZWFhOTU4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTIwICBUYWlq dSBUc3Vpa2kgIDx0emlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE cm9wIGRpbW1lZCBjcnVtYiBoYW5kbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTQ0NTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIEV4aXN0aW5nIGluc3BlY3RvciB0ZXN0IHNo b3VsZCB3b3JrLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVs LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlLnVwZGF0 ZUJyZWFkY3J1bWIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90 eXBlLnVwZGF0ZUJyZWFkY3J1bWJTaXplcyk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9lbGVtZW50c1BhbmVsLmNzczoKKwogMjAxMi0wOC0xOSAgS2VudGFybyBIYXJhICA8aGFyYWtl bkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIFJlZlB0ciBmcm9tIEhUTUxQcm9ncmVz c0VsZW1lbnQ6Om1fdmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvRWxlbWVudHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRWxlbWVudHNQYW5lbC5qcwppbmRleCA5NzQ2Yjk4NWE1OGFhMWQyZTA1NTFjYzI1ZjU3 NDY4MjU3NTIzZjA3Li4zNWRlY2NmZjljMmQ0Y2YxNDEyY2IxOTA0OGU2NmJmZTJiZjVhOWRiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFu ZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1Bh bmVsLmpzCkBAIC01OTIsMTcgKzU5Miw4IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnBy b3RvdHlwZSA9IHsKICAgICAgICAgdmFyIGNydW1icyA9IHRoaXMuY3J1bWJzRWxlbWVudDsKIAog ICAgICAgICB2YXIgaGFuZGxlZCA9IGZhbHNlOwotICAgICAgICB2YXIgZm91bmRSb290ID0gZmFs c2U7CiAgICAgICAgIHZhciBjcnVtYiA9IGNydW1icy5maXJzdENoaWxkOwogICAgICAgICB3aGls ZSAoY3J1bWIpIHsKLSAgICAgICAgICAgIGlmIChjcnVtYi5yZXByZXNlbnRlZE9iamVjdCA9PT0g dGhpcy50cmVlT3V0bGluZS5yb290RE9NTm9kZSkKLSAgICAgICAgICAgICAgICBmb3VuZFJvb3Qg PSB0cnVlOwotCi0gICAgICAgICAgICBpZiAoZm91bmRSb290KQotICAgICAgICAgICAgICAgIGNy dW1iLmFkZFN0eWxlQ2xhc3MoImRpbW1lZCIpOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAg ICAgICAgIGNydW1iLnJlbW92ZVN0eWxlQ2xhc3MoImRpbW1lZCIpOwotCiAgICAgICAgICAgICBp ZiAoY3J1bWIucmVwcmVzZW50ZWRPYmplY3QgPT09IHRoaXMuc2VsZWN0ZWRET01Ob2RlKCkpIHsK ICAgICAgICAgICAgICAgICBjcnVtYi5hZGRTdHlsZUNsYXNzKCJzZWxlY3RlZCIpOwogICAgICAg ICAgICAgICAgIGhhbmRsZWQgPSB0cnVlOwpAQCAtNjUwLDE0ICs2NDEsMTAgQEAgV2ViSW5zcGVj dG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgZXZlbnQucHJldmVu dERlZmF1bHQoKTsKICAgICAgICAgfQogCi0gICAgICAgIGZvdW5kUm9vdCA9IGZhbHNlOwogICAg ICAgICBmb3IgKHZhciBjdXJyZW50ID0gdGhpcy5zZWxlY3RlZERPTU5vZGUoKTsgY3VycmVudDsg Y3VycmVudCA9IGN1cnJlbnQucGFyZW50Tm9kZSkgewogICAgICAgICAgICAgaWYgKGN1cnJlbnQu bm9kZVR5cGUoKSA9PT0gTm9kZS5ET0NVTUVOVF9OT0RFKQogICAgICAgICAgICAgICAgIGNvbnRp bnVlOwogCi0gICAgICAgICAgICBpZiAoY3VycmVudCA9PT0gdGhpcy50cmVlT3V0bGluZS5yb290 RE9NTm9kZSkKLSAgICAgICAgICAgICAgICBmb3VuZFJvb3QgPSB0cnVlOwotCiAgICAgICAgICAg ICBjcnVtYiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKICAgICAgICAgICAgIGNy dW1iLmNsYXNzTmFtZSA9ICJjcnVtYiI7CiAgICAgICAgICAgICBjcnVtYi5yZXByZXNlbnRlZE9i amVjdCA9IGN1cnJlbnQ7CkBAIC02OTIsOCArNjc5LDYgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRz UGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGNydW1iLnRpdGxlID0gY3J1bWJU aXRsZTsKICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgaWYgKGZvdW5kUm9vdCkKLSAgICAg ICAgICAgICAgICBjcnVtYi5hZGRTdHlsZUNsYXNzKCJkaW1tZWQiKTsKICAgICAgICAgICAgIGlm IChjdXJyZW50ID09PSB0aGlzLnNlbGVjdGVkRE9NTm9kZSgpKQogICAgICAgICAgICAgICAgIGNy dW1iLmFkZFN0eWxlQ2xhc3MoInNlbGVjdGVkIik7CiAgICAgICAgICAgICBpZiAoIWNydW1icy5j aGlsZE5vZGVzLmxlbmd0aCkKQEAgLTkxMSwxOCArODk2LDYgQEAgV2ViSW5zcGVjdG9yLkVsZW1l bnRzUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgIGNvYWxlc2NlQ29sbGFwc2Vk Q3J1bWJzKCk7CiAgICAgICAgIH0KIAotICAgICAgICBmdW5jdGlvbiBjb21wYWN0RGltbWVkKGNy dW1iKQotICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoY3J1bWIuaGFzU3R5bGVDbGFzcygiZGlt bWVkIikpCi0gICAgICAgICAgICAgICAgY29tcGFjdChjcnVtYik7Ci0gICAgICAgIH0KLQotICAg ICAgICBmdW5jdGlvbiBjb2xsYXBzZURpbW1lZChjcnVtYikKLSAgICAgICAgewotICAgICAgICAg ICAgaWYgKGNydW1iLmhhc1N0eWxlQ2xhc3MoImRpbW1lZCIpKQotICAgICAgICAgICAgICAgIGNv bGxhcHNlKGNydW1iLCBmYWxzZSk7Ci0gICAgICAgIH0KLQogICAgICAgICBpZiAoIWZvY3VzZWRD cnVtYikgewogICAgICAgICAgICAgLy8gV2hlbiBub3QgZm9jdXNlZCBvbiBhIGNydW1iIHdlIGNh biBiZSBiaWFzZWQgYW5kIGNvbGxhcHNlIGxlc3MgaW1wb3J0YW50CiAgICAgICAgICAgICAvLyBj cnVtYnMgdGhhdCB0aGUgdXNlciBtaWdodCBub3QgY2FyZSBtdWNoIGFib3V0LgpAQCAtOTM0LDE0 ICs5MDcsNiBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAg ICAgICAgICAvLyBDb2xsYXBzZSBjaGlsZCBjcnVtYnMuCiAgICAgICAgICAgICBpZiAobWFrZUNy dW1ic1NtYWxsZXIoY29sbGFwc2UsIENoaWxkU2lkZSkpCiAgICAgICAgICAgICAgICAgcmV0dXJu OwotCi0gICAgICAgICAgICAvLyBDb21wYWN0IGRpbW1lZCBhbmNlc3RvciBjcnVtYnMuCi0gICAg ICAgICAgICBpZiAobWFrZUNydW1ic1NtYWxsZXIoY29tcGFjdERpbW1lZCwgQW5jZXN0b3JTaWRl KSkKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgICAgIC8vIENvbGxhcHNlIGRp bW1lZCBhbmNlc3RvciBjcnVtYnMuCi0gICAgICAgICAgICBpZiAobWFrZUNydW1ic1NtYWxsZXIo Y29sbGFwc2VEaW1tZWQsIEFuY2VzdG9yU2lkZSkpCi0gICAgICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICB9CiAKICAgICAgICAgLy8gQ29tcGFjdCBhbmNlc3RvciBjcnVtYnMsIG9yIGZyb20g Ym90aCBzaWRlcyBpZiBmb2N1c2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9lbGVtZW50c1BhbmVsLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvZWxlbWVudHNQYW5lbC5jc3MKaW5kZXggNzM4OWE4ZGFiZTI5MGQ4M2Y3ZDY2 ZGJmNGZiMjkyNzYyNWVlODM4ZS4uNWU1ODNkNjRjYjMyZDc5YzlhOWRkZmEwYmJiNGVhYTc0YTMy MGQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9lbGVt ZW50c1BhbmVsLmNzcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2Vs ZW1lbnRzUGFuZWwuY3NzCkBAIC05NywxMCArOTcsNiBAQAogICAgIGRpc3BsYXk6IG5vbmU7CiB9 CiAKLS5jcnVtYnMgLmNydW1iLmRpbW1lZCB7Ci0gICAgY29sb3I6IHJnYmEoMCwgMCwgMCwgMC40 NSk7Ci19Ci0KIC5jcnVtYnMgLmNydW1iLnN0YXJ0IHsKICAgICBwYWRkaW5nLWxlZnQ6IDdweDsK IH0KQEAgLTEzMCwxMSArMTI2LDYgQEAKICAgICBjb2xvcjogYmxhY2s7CiB9CiAKLS5jcnVtYnMg LmNydW1iLmRpbW1lZDpob3ZlciB7Ci0gICAgLXdlYmtpdC1ib3JkZXItaW1hZ2U6IHVybChJbWFn ZXMvc2VnbWVudEhvdmVyLnBuZykgMCAxMiAwIDI7Ci0gICAgY29sb3I6IHJnYmEoMCwgMCwgMCwg MC43NSk7Ci19Ci0KIC5jcnVtYnMgLmNydW1iLmVuZDpob3ZlciB7CiAgICAgLXdlYmtpdC1ib3Jk ZXItaW1hZ2U6IHVybChJbWFnZXMvc2VnbWVudEhvdmVyRW5kLnBuZykgMCAyIDAgMjsKIH0K