94455 2012-08-20 01:47:17 -0700 [V8] Move collectGarbage() from ScriptController to V8GCController 2012-08-20 19:47:41 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 699320 0 haraken 2012-08-20 01:47:17 -0700 We can move collectGarbage() from ScriptController to V8GCController. Also we can remove ScriptController::lowMemoryNotification() since it is not used at all. 699324 1 159368 haraken 2012-08-20 01:51:19 -0700 Created attachment 159368 Patch 699715 2 159368 abarth 2012-08-20 11:20:21 -0700 Comment on attachment 159368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159368&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:534 > +void V8GCController::collectGarbage() It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage. > Source/WebCore/bindings/v8/V8GCController.cpp:538 > + v8::Persistent<v8::Context> v8Context = v8::Context::New(); v8Context -> context 700201 3 haraken 2012-08-20 17:02:47 -0700 Committed r126098: <http://trac.webkit.org/changeset/126098> 700207 4 haraken 2012-08-20 17:06:51 -0700 (In reply to comment #2) > > Source/WebCore/bindings/v8/V8GCController.cpp:534 > > +void V8GCController::collectGarbage() > > It's a bit strange that collectGarbageIfNecessary is so different from collectGarbage. collectGarbage() always collects garbage. collectGarbageIfNecessary() just sends an idle notification to V8, which is just a hint for V8 to trigger GC. Maybe can we rename collectGarbageIfNecessary() to hintForCollectGarbage()? > > Source/WebCore/bindings/v8/V8GCController.cpp:538 > > + v8::Persistent<v8::Context> v8Context = v8::Context::New(); > > v8Context -> context Done. 700213 5 abarth 2012-08-20 17:09:38 -0700 > hintForCollectGarbage Ok. I think that's the name you had before I asked you to change it. :) 700220 6 haraken 2012-08-20 17:15:22 -0700 Reopening to attach new patch. 700221 7 159568 haraken 2012-08-20 17:15:26 -0700 Created attachment 159568 Patch 700373 8 159568 webkit.review.bot 2012-08-20 19:47:37 -0700 Comment on attachment 159568 Patch Clearing flags on attachment: 159568 Committed r126123: <http://trac.webkit.org/changeset/126123> 700374 9 webkit.review.bot 2012-08-20 19:47:41 -0700 All reviewed patches have been landed. Closing bug. 159368 2012-08-20 01:51:19 -0700 2012-08-20 17:15:17 -0700 Patch bug-94455-20120820175039.patch text/plain 6874 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg3OTdiMWE5MjJkM2M3 M2ZhN2M0OGI2NGE0Mjg0MDU0OGQ5YzM2MC4uMzQxMmQwODgyZjc2ZGQwNzNiNDcxNzY5NzBiMGI2 NWY1ZjJiMzczMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA4LTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgY29s bGVjdEdhcmJhZ2UoKSBmcm9tIFNjcmlwdENvbnRyb2xsZXIgdG8gVjhHQ0NvbnRyb2xsZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDU1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBUaGlzIHBhdGNo IG1vdmVzIGNvbGxlY3RHYXJiYWdlKCkgZnJvbSBTY3JpcHRDb250cm9sbGVyIHRvIFY4R0NDb250 cm9sbGVyLgorICAgICAgICAtIFRoaXMgcGF0Y2ggbWFrZXMgY29sbGVjdEdhcmJhZ2UoKSBhIHN0 YXRpYyBtZXRob2QuCisgICAgICAgIC0gVGhpcyBwYXRjaCByZW1vdmVzIFNjcmlwdENvbnRyb2xs ZXI6Omxvd01lbW9yeU5vdGlmaWNhdGlvbigpCisgICAgICAgIHNpbmNlIGl0IGlzIG5vdCB1c2Vk IGF0IGFsbC4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisg ICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgICogYmlu ZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0ND b250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpjb2xsZWN0 R2FyYmFnZSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEdD Q29udHJvbGxlci5oOgorICAgICAgICAoVjhHQ0NvbnRyb2xsZXIpOgorCiAyMDEyLTA4LTE5ICBL ZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIE1vdmUg Y29udGV4dERlYnVnSWQoKSBhbmQgc2V0Q29udGV4dERlYnVnSWQoKSBmcm9tIFY4UHJveHkgdG8g U2NyaXB0Q29udHJvbGxlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA3ZDM2ZDk4NGUz NmZlOWNkOTlmZTljZDFkYmQ4NTdkNjM3ZmQ1MjNiLi5mMTI0NmJlZGZkMGQyMzJjNTU2ZWZhMDIz ZDQ0YTAzNTVkMjllODEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA4LTIwICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbVjhdIE1vdmUgY29sbGVjdEdhcmJhZ2UoKSBmcm9tIFNjcmlwdENvbnRyb2xsZXIg dG8gVjhHQ0NvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk0NDU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBUaGlzIHBhdGNoIG1vdmVzIGNvbGxlY3RHYXJiYWdlKCkgZnJvbSBTY3JpcHRD b250cm9sbGVyIHRvIFY4R0NDb250cm9sbGVyLgorICAgICAgICAtIFRoaXMgcGF0Y2ggbWFrZXMg Y29sbGVjdEdhcmJhZ2UoKSBhIHN0YXRpYyBtZXRob2QuCisgICAgICAgIC0gVGhpcyBwYXRjaCBy ZW1vdmVzIFNjcmlwdENvbnRyb2xsZXI6Omxvd01lbW9yeU5vdGlmaWNhdGlvbigpCisgICAgICAg IHNpbmNlIGl0IGlzIG5vdCB1c2VkIGF0IGFsbC4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hh bmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6Y29sbGVjdEdhcmJhZ2UpOgorCiAyMDEyLTA4LTE5 ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIE1v dmUgY29udGV4dERlYnVnSWQoKSBhbmQgc2V0Q29udGV4dERlYnVnSWQoKSBmcm9tIFY4UHJveHkg dG8gU2NyaXB0Q29udHJvbGxlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3Jp cHRDb250cm9sbGVyLmNwcAppbmRleCA2MDZjZGMzYTk3NDc4ZTY1MDA4OTdhZWNhZDFjYWExNDkw NTQxYjkwLi44NmQ4OWI5NWRiZTBiMDAyY2I1MmJkMmJhYjE1NmY2ZGYzMjE5ZDEwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcApAQCAtMzA1 LDMxICszMDUsNiBAQCB2b2lkIFNjcmlwdENvbnRyb2xsZXI6OmJpbmRUb1dpbmRvd09iamVjdChG cmFtZSogZnJhbWUsIGNvbnN0IFN0cmluZyYga2V5LCBOUE9iagogICAgIGdsb2JhbC0+U2V0KHY4 U3RyaW5nKGtleSksIHZhbHVlKTsKIH0KIAotdm9pZCBTY3JpcHRDb250cm9sbGVyOjpjb2xsZWN0 R2FyYmFnZSgpCi17Ci0gICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOwotCi0gICAgdjg6 OlBlcnNpc3RlbnQ8djg6OkNvbnRleHQ+IHY4Q29udGV4dCA9IHY4OjpDb250ZXh0OjpOZXcoKTsK LSAgICBpZiAodjhDb250ZXh0LklzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuOwotICAgIHsKLSAg ICAgICAgdjg6OkNvbnRleHQ6OlNjb3BlIHNjb3BlKHY4Q29udGV4dCk7Ci0gICAgICAgIHY4OjpM b2NhbDx2ODo6U3RyaW5nPiBzb3VyY2UgPSB2ODo6U3RyaW5nOjpOZXcoImlmIChnYykgZ2MoKTsi KTsKLSAgICAgICAgdjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbWUgPSB2ODo6U3RyaW5nOjpOZXco ImdjIik7Ci0gICAgICAgIHY4OjpIYW5kbGU8djg6OlNjcmlwdD4gc2NyaXB0ID0gdjg6OlNjcmlw dDo6Q29tcGlsZShzb3VyY2UsIG5hbWUpOwotICAgICAgICBpZiAoIXNjcmlwdC5Jc0VtcHR5KCkp IHsKLSAgICAgICAgICAgIFY4UmVjdXJzaW9uU2NvcGU6Ok1pY3JvdGFza1N1cHByZXNzaW9uIHNj b3BlOwotICAgICAgICAgICAgc2NyaXB0LT5SdW4oKTsKLSAgICAgICAgfQotICAgIH0KLSAgICB2 OENvbnRleHQuRGlzcG9zZSgpOwotfQotCi12b2lkIFNjcmlwdENvbnRyb2xsZXI6Omxvd01lbW9y eU5vdGlmaWNhdGlvbigpCi17Ci0gICAgdjg6OlY4OjpMb3dNZW1vcnlOb3RpZmljYXRpb24oKTsK LX0KLQogYm9vbCBTY3JpcHRDb250cm9sbGVyOjpoYXZlSW50ZXJwcmV0ZXIoKSBjb25zdAogewog ICAgIHJldHVybiB3aW5kb3dTaGVsbCgpLT5pc0NvbnRleHRJbml0aWFsaXplZCgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCmluZGV4IGZlN2I3NjMx ZWRhNWU1ODJiNmE0NDAzZGZjZDZkN2Q2YTZlMzA5ZDcuLjc1ODE3MzE3NGY5MDIyNzYwODY2MWZj ZDMyNDRmODZhZjFmMWM0ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdENvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3Jp cHRDb250cm9sbGVyLmgKQEAgLTExOSwxMSArMTE5LDYgQEAgcHVibGljOgogICAgIFNjcmlwdENv bnRyb2xsZXIqIHdpbmRvd1NoZWxsKERPTVdyYXBwZXJXb3JsZCopIHsgcmV0dXJuIHRoaXM7IH0K ICAgICBTY3JpcHRDb250cm9sbGVyKiBleGlzdGluZ1dpbmRvd1NoZWxsKERPTVdyYXBwZXJXb3Js ZCopIHsgcmV0dXJuIHRoaXM7IH0KIAotICAgIHZvaWQgY29sbGVjdEdhcmJhZ2UoKTsKLQotICAg IC8vIE5vdGlmeSBWOCB0aGF0IHRoZSBzeXN0ZW0gaXMgcnVubmluZyBsb3cgb24gbWVtb3J5Lgot ICAgIHZvaWQgbG93TWVtb3J5Tm90aWZpY2F0aW9uKCk7Ci0KICAgICAvLyBDcmVhdGVzIGEgcHJv cGVydHkgb2YgdGhlIGdsb2JhbCBvYmplY3Qgb2YgYSBmcmFtZS4KICAgICB2b2lkIGJpbmRUb1dp bmRvd09iamVjdChGcmFtZSosIGNvbnN0IFN0cmluZyYga2V5LCBOUE9iamVjdCopOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKaW5kZXggMDgyZDgx MDBkOTA4N2I3YTczZTM2ZGExY2RhNjBjZmRmOTk1YTkxMS4uNjUxNTBmYTNhNDY1MmZmNGFlN2Y4 OThhOGQxNzE2NTZkYTNjMDM3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhHQ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 R0NDb250cm9sbGVyLmNwcApAQCAtNDgsNiArNDgsNyBAQAogI2luY2x1ZGUgIlY4Q1NTU3R5bGVE ZWNsYXJhdGlvbi5oIgogI2luY2x1ZGUgIlY4RE9NSW1wbGVtZW50YXRpb24uaCIKICNpbmNsdWRl ICJWOE1lc3NhZ2VQb3J0LmgiCisjaW5jbHVkZSAiVjhSZWN1cnNpb25TY29wZS5oIgogI2luY2x1 ZGUgIlY4U3R5bGVTaGVldC5oIgogI2luY2x1ZGUgIlY4U3R5bGVTaGVldExpc3QuaCIKICNpbmNs dWRlICJXcmFwcGVyVHlwZUluZm8uaCIKQEAgLTUzMCw0ICs1MzEsMjQgQEAgdm9pZCBWOEdDQ29u dHJvbGxlcjo6Y29sbGVjdEdhcmJhZ2VJZk5lY2Vzc2FyeSgpCiAgICAgdjg6OlY4OjpJZGxlTm90 aWZpY2F0aW9uKGxvbmdJZGxlUGF1c2VJbk1TKTsKIH0KIAordm9pZCBWOEdDQ29udHJvbGxlcjo6 Y29sbGVjdEdhcmJhZ2UoKQoreworICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsKKwor ICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0PiB2OENvbnRleHQgPSB2ODo6Q29udGV4dDo6 TmV3KCk7CisgICAgaWYgKHY4Q29udGV4dC5Jc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKyAg ICB7CisgICAgICAgIHY4OjpDb250ZXh0OjpTY29wZSBzY29wZSh2OENvbnRleHQpOworICAgICAg ICB2ODo6TG9jYWw8djg6OlN0cmluZz4gc291cmNlID0gdjg6OlN0cmluZzo6TmV3KCJpZiAoZ2Mp IGdjKCk7Iik7CisgICAgICAgIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBuYW1lID0gdjg6OlN0cmlu Zzo6TmV3KCJnYyIpOworICAgICAgICB2ODo6SGFuZGxlPHY4OjpTY3JpcHQ+IHNjcmlwdCA9IHY4 OjpTY3JpcHQ6OkNvbXBpbGUoc291cmNlLCBuYW1lKTsKKyAgICAgICAgaWYgKCFzY3JpcHQuSXNF bXB0eSgpKSB7CisgICAgICAgICAgICBWOFJlY3Vyc2lvblNjb3BlOjpNaWNyb3Rhc2tTdXBwcmVz c2lvbiBzY29wZTsKKyAgICAgICAgICAgIHNjcmlwdC0+UnVuKCk7CisgICAgICAgIH0KKyAgICB9 CisgICAgdjhDb250ZXh0LkRpc3Bvc2UoKTsKK30KKwogfSAgLy8gbmFtZXNwYWNlIFdlYkNvcmUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5oCmluZGV4IGVhMjcy ZWI5MDgwZWFmMWQ4ZmE3MDk2OTViMzY4YzhhMDVmZTRmZTcuLjk3MmFkYjZiMDk2ODg1OTg3NzEx OTU4ZGY1YzdlNGVjMzQ5MzcyNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4R0NDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhH Q0NvbnRyb2xsZXIuaApAQCAtNzcsNiArNzcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAg ICAgICAgc3RhdGljIHZvaWQgY2hlY2tNZW1vcnlVc2FnZSgpOwogICAgICAgICBzdGF0aWMgdm9p ZCBjb2xsZWN0R2FyYmFnZUlmTmVjZXNzYXJ5KCk7CisgICAgICAgIHN0YXRpYyB2b2lkIGNvbGxl Y3RHYXJiYWdlKCk7CiAKICAgICBwcml2YXRlOgogICAgICAgICAvLyBFc3RpbWF0ZSBvZiBjdXJy ZW50IHdvcmtpbmcgc2V0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViRnJhbWVJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5jcHAKaW5kZXggYTk4YTMzM2MxMzdmY2I1ZWVmM2FjZDRkODZlNzllZDZmMjI0YjdhNy4uOTY3 N2RhNjRkZTU1NWZhMmFkNWJlZWU2NzVlMGExODE2NDNmNThiZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCkBAIC0xOTQsNiArMTk0LDcgQEAKICNpbmNs dWRlICJWOERpcmVjdG9yeUVudHJ5LmgiCiAjaW5jbHVkZSAiVjhET01GaWxlU3lzdGVtLmgiCiAj aW5jbHVkZSAiVjhGaWxlRW50cnkuaCIKKyNpbmNsdWRlICJWOEdDQ29udHJvbGxlci5oIgogI2lu Y2x1ZGUgPHB1YmxpYy9XZWJGaWxlU3lzdGVtLmg+CiAjZW5kaWYKIApAQCAtODk4LDcgKzg5OSw3 IEBAIHZvaWQgV2ViRnJhbWVJbXBsOjpjb2xsZWN0R2FyYmFnZSgpCiAgICAgICAgIHJldHVybjsK ICAgICAvLyBGSVhNRTogTW92ZSB0aGlzIHRvIHRoZSBTY3JpcHRDb250cm9sbGVyIGFuZCBtYWtl IGl0IEpTIG5ldXRyYWwuCiAjaWYgVVNFKFY4KQotICAgIG1fZnJhbWUtPnNjcmlwdCgpLT5jb2xs ZWN0R2FyYmFnZSgpOworICAgIFY4R0NDb250cm9sbGVyOjpjb2xsZWN0R2FyYmFnZSgpOwogI2Vs c2UKICAgICBub3RJbXBsZW1lbnRlZCgpOwogI2VuZGlmCg== 159568 2012-08-20 17:15:26 -0700 2012-08-20 19:47:37 -0700 Patch bug-94455-20120821091446.patch text/plain 3263 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmUwZWFjZjNhMWQ0YTE1 OGI2YjgyZWUwYWRhNzI0MTg4OWFjYTUzNS4uOTA3YTE2YjdmYzQwNTQ1NTk5MDRjZjVkMTAwNDFh ODI2MzQyNDJhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA4LTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW5hbWUgY29sbGVj dEdhcmJhZ2VJZk5lY2Vzc2FyeSgpIHRvIGhpbnRGb3JDb2xsZWN0R2FyYmFnZSgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDQ1NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSBmb2xsb3ct dXAgcGF0Y2ggZm9yIHIxMjYwOTguCisKKyAgICAgICAgY29sbGVjdEdhcmJhZ2UoKSBhbHdheXMg Y29sbGVjdHMgZ2FyYmFnZS4gY29sbGVjdEdhcmJhZ2VJZk5lY2Vzc2FyeSgpIGp1c3Qgc2VuZHMK KyAgICAgICAgYW4gaWRsZSBub3RpZmljYXRpb24gdG8gVjgsIHdoaWNoIGlzIGp1c3QgYSBoaW50 IGZvciBWOCB0byB0cmlnZ2VyIEdDLgorICAgICAgICBUbyBjbGFyaWZ5IHRoZSBkaWZmZXJlbmNl LCB0aGlzIHBhdGNoIHJlbmFtZXMgY29sbGVjdEdhcmJhZ2VJZk5lY2Vzc2FyeSgpCisgICAgICAg IHRvIGhpbnRGb3JDb2xsZWN0R2FyYmFnZSgpLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFu Z2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmNsZWFyRm9yQ2xvc2Up OgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0Q29udHJvbGxlcjo6Y2xlYXJGb3JOYXZpZ2F0aW9u KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpWOEdDQ29udHJvbGxlcjo6aGludEZvckNvbGxlY3RHYXJiYWdlKToKKyAgICAgICAg KiBiaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5oOgorICAgICAgICAoVjhHQ0NvbnRyb2xsZXIp OgorCiAyMDEyLTA4LTIwICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgWWFuayBhbiB1bm5lY2Nlc3NhcnkgaWYgYWRkZWQgaW4gcjEyNTgxMC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggMWM4 ZmNiNjkxODAyODhjMTA1ZTQwNDFjOWFhMTMzYWYyYzVlZGFiZC4uYjc2MWJkNDVmMGU1MGI1OGU0 OGRlYTk3MmQ5NDI5ZmVkYWU1N2VmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTE1OSwxNCArMTU5LDE0IEBAIHZvaWQgU2NyaXB0 Q29udHJvbGxlcjo6cmVzZXRJc29sYXRlZFdvcmxkcygpCiB2b2lkIFNjcmlwdENvbnRyb2xsZXI6 OmNsZWFyRm9yQ2xvc2UoKQogewogICAgIHJlc2V0SXNvbGF0ZWRXb3JsZHMoKTsKLSAgICBWOEdD Q29udHJvbGxlcjo6Y29sbGVjdEdhcmJhZ2VJZk5lY2Vzc2FyeSgpOworICAgIFY4R0NDb250cm9s bGVyOjpoaW50Rm9yQ29sbGVjdEdhcmJhZ2UoKTsKICAgICB3aW5kb3dTaGVsbCgpLT5jbGVhckZv ckNsb3NlKCk7CiB9CiAKIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6Y2xlYXJGb3JOYXZpZ2F0aW9u KCkKIHsKICAgICByZXNldElzb2xhdGVkV29ybGRzKCk7Ci0gICAgVjhHQ0NvbnRyb2xsZXI6OmNv bGxlY3RHYXJiYWdlSWZOZWNlc3NhcnkoKTsKKyAgICBWOEdDQ29udHJvbGxlcjo6aGludEZvckNv bGxlY3RHYXJiYWdlKCk7CiAgICAgd2luZG93U2hlbGwoKS0+Y2xlYXJGb3JOYXZpZ2F0aW9uKCk7 CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9s bGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcApp bmRleCAxZDA3NDFkMjRlMjJmODNiMTE5MWJlYjc1MTQ2NjQ2NzExMTc3MDE5Li40MjM4MGNhMmFh NmVmZjRmZTlkNDkxMTcwMWQ2NWYxZDM5ODM4Yzk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEdDQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuY3BwCkBAIC01MjAsNyArNTIwLDcgQEAgdm9pZCBWOEdD Q29udHJvbGxlcjo6Y2hlY2tNZW1vcnlVc2FnZSgpCiAjZW5kaWYKIH0KIAotdm9pZCBWOEdDQ29u dHJvbGxlcjo6Y29sbGVjdEdhcmJhZ2VJZk5lY2Vzc2FyeSgpCit2b2lkIFY4R0NDb250cm9sbGVy OjpoaW50Rm9yQ29sbGVjdEdhcmJhZ2UoKQogewogICAgIFY4UGVySXNvbGF0ZURhdGEqIGRhdGEg PSBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCk7CiAgICAgaWYgKCFkYXRhLT5zaG91bGRDb2xs ZWN0R2FyYmFnZVNvb24oKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4R0NDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdDQ29udHJv bGxlci5oCmluZGV4IDk3MmFkYjZiMDk2ODg1OTg3NzExOTU4ZGY1YzdlNGVjMzQ5MzcyNmYuLmY1 ZjljM2EzYTQ5MjZlN2MzYTk4OGI3NTljYzY2OWRkMjlmYTg5ZjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIuaApAQCAtNzYsNyArNzYsNyBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgICAgIHN0YXRpYyB2b2lkIGdjRXBpbG9ndWUoKTsKIAogICAgICAg ICBzdGF0aWMgdm9pZCBjaGVja01lbW9yeVVzYWdlKCk7Ci0gICAgICAgIHN0YXRpYyB2b2lkIGNv bGxlY3RHYXJiYWdlSWZOZWNlc3NhcnkoKTsKKyAgICAgICAgc3RhdGljIHZvaWQgaGludEZvckNv bGxlY3RHYXJiYWdlKCk7CiAgICAgICAgIHN0YXRpYyB2b2lkIGNvbGxlY3RHYXJiYWdlKCk7CiAK ICAgICBwcml2YXRlOgo=