94454 2012-08-20 01:32:43 -0700 media/media-document-audio-repaint.html is racy 2012-08-21 08:15:22 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned eric.carlson feature-media-reviews fischman webkit.review.bot oldest_to_newest 699316 0 pnormand 2012-08-20 01:32:43 -0700 In the GTK port, sometimes the play event is not catched by the test, playback continues until EOS instead of pausing, doing a seek near the end and ending the test. This triggers a small text diff on the controls: text run at (0,0) width 55: "00:01 / 00:01" instead of text run at (0,0) width 55: "00:00 / 00:01" I think we can safely directly pause the media element from the beginning instead of attempting to play the already playing media. What do you think Ami? 699323 1 159367 pnormand 2012-08-20 01:50:50 -0700 Created attachment 159367 Patch 699466 2 eric.carlson 2012-08-20 06:52:49 -0700 Seems reasonable to me, but lets wait for Ami to have a look. 700432 3 159367 fischman 2012-08-20 21:15:53 -0700 Comment on attachment 159367 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159367&action=review LGTM % nit > LayoutTests/ChangeLog:9 > + event. Trigger the display and seek upon reception of the pause event. s/reception/receipt/ 700503 4 pnormand 2012-08-20 23:31:45 -0700 Thank you Ami! I can fix this mistake when landing. 700775 5 pnormand 2012-08-21 08:15:22 -0700 Committed r126158: <http://trac.webkit.org/changeset/126158> 159367 2012-08-20 01:50:50 -0700 2012-08-21 08:06:37 -0700 Patch Patch.patch text/plain 2272 pnormand RnJvbSA3NzY4NzgzYjUzYjgzOTFjMzRiY2ZiZjNlNDRlODc5MTI3N2E2OTQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDIwIEF1ZyAyMDEyIDEwOjQ5OjIyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g UGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxMCArKysrKysrKysrCiBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1kb2N1bWVu dC1hdWRpby1yZXBhaW50Lmh0bWwgfCAgIDEyICsrLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2Vk LCAxMiBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGNlZDVhYy4uMTAx ZjYyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTIwICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBtZWRpYS9tZWRpYS1kb2N1bWVudC1h dWRpby1yZXBhaW50Lmh0bWwgaXMgcmFjeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTQ0NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIG1lZGlhL21lZGlhLWRvY3VtZW50LWF1ZGlvLXJlcGFpbnQuaHRt bDogRG9uJ3QgcmVseSBvbiB0aGUgcGxheQorICAgICAgICBldmVudC4gVHJpZ2dlciB0aGUgZGlz cGxheSBhbmQgc2VlayB1cG9uIHJlY2VwdGlvbiBvZiB0aGUgcGF1c2UgZXZlbnQuCisKIDIwMTIt MDgtMjAgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb VGVzdHNdIHRpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVhcmFuY2UtYmFzaWMuaHRtbCBhbmQgdGlt ZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS1wc2V1ZG8tZWxlbWVudHMuaHRtbCBhcmUgZmFp bGVkIG9uIENocm9taXVtIE1hYwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEt ZG9jdW1lbnQtYXVkaW8tcmVwYWludC5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtZG9j dW1lbnQtYXVkaW8tcmVwYWludC5odG1sCmluZGV4IGRmMzE4OWUuLmFjYTgxYTMgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL21lZGlhL21lZGlhLWRvY3VtZW50LWF1ZGlvLXJlcGFpbnQuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1kb2N1bWVudC1hdWRpby1yZXBhaW50Lmh0bWwK QEAgLTE2LDIxICsxNiwxMyBAQAogICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7 CiAgICAgfQogCi0gICAgZnVuY3Rpb24gb25QbGF5KCkKLSAgICB7Ci0gICAgICAgIHZhciB2aWRl b0VsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZnIiKS5jb250ZW50RG9jdW1lbnQu cXVlcnlTZWxlY3RvcigidmlkZW8iKTsKLSAgICAgICAgdmlkZW9FbGVtZW50LnBhdXNlKCk7Ci0g ICAgfQotCiAgICAgZnVuY3Rpb24gZnJhbWVMb2FkZWQoKQogICAgIHsKICAgICAgICAgdmFyIHZp ZGVvRWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJmciIpLmNvbnRlbnREb2N1bWVu dC5xdWVyeVNlbGVjdG9yKCJ2aWRlbyIpOwotICAgICAgICB2aWRlb0VsZW1lbnQuYWRkRXZlbnRM aXN0ZW5lcigicGxheSIsIG9uUGxheSwgZmFsc2UpOwogICAgICAgICB2aWRlb0VsZW1lbnQuYWRk RXZlbnRMaXN0ZW5lcigicGF1c2UiLCBvblBhdXNlLCBmYWxzZSk7CiAgICAgICAgIHZpZGVvRWxl bWVudC5hZGRFdmVudExpc3RlbmVyKCJzZWVrZWQiLCBvblNlZWtlZCwgZmFsc2UpOwotICAgICAg ICAvLyBNYWtlIHN1cmUgd2UncmUgcGxheWluZywgZXZlbiB0aG91Z2ggdGhlIE1lZGlhRG9jdW1l bnQgaGFzIEFVVE9QTEFZIHNldCwKLSAgICAgICAgLy8gdG8gYXZvaWQgcmFjZXMgYmV0d2VlbiB0 aGUgZnJhbWUncyBsb2FkZWQgZXZlbnQgYW5kIHRoZSB2aWRlbydzIHBsYXkgZXZlbnQuCi0gICAg ICAgIHZpZGVvRWxlbWVudC5wbGF5KCk7CisgICAgICAgIC8vIFRoZSBNZWRpYURvY3VtZW50IGhh cyBBVVRPUExBWSBzZXQsIG1ha2Ugc3VyZSB3ZSdyZSBwYXVzZWQuCisgICAgICAgIHZpZGVvRWxl bWVudC5wYXVzZSgpOwogICAgIH0KIDwvc2NyaXB0PgogPHA+Ci0tIAoxLjcuMTAuNA==