94450 2012-08-20 01:06:14 -0700 [V8] Remove V8Proxy from V8IsolatedContext 2012-08-20 17:07:26 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 699292 0 haraken 2012-08-20 01:06:14 -0700 We can remove dependency on V8Proxy from V8IsolatedContext. 699295 1 159352 haraken 2012-08-20 01:07:32 -0700 Created attachment 159352 Patch 699299 2 159352 haraken 2012-08-20 01:10:30 -0700 Comment on attachment 159352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159352&action=review > Source/WebCore/bindings/v8/ScriptController.cpp:198 > + isolatedContext = new V8IsolatedContext(m_frame, extensionGroup, worldID); Should V8IsolatedContext be a RefPtr? If so, I'll write a follow-up fix to make it reference-countable. 699706 3 159352 abarth 2012-08-20 11:12:54 -0700 Comment on attachment 159352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159352&action=review >> Source/WebCore/bindings/v8/ScriptController.cpp:198 >> - isolatedContext = new V8IsolatedContext(proxy(), extensionGroup, worldID); >> + isolatedContext = new V8IsolatedContext(m_frame, extensionGroup, worldID); > > Should V8IsolatedContext be a RefPtr? If so, I'll write a follow-up fix to make it reference-countable. Its lifetime is managed by the V8 garbage collector. If you see a clean way to do that with RefPtr, go for it. 700014 4 159352 webkit.review.bot 2012-08-20 14:59:10 -0700 Comment on attachment 159352 Patch Rejecting attachment 159352 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: eeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/ScriptController.cpp patching file Source/WebCore/bindings/v8/V8IsolatedContext.cpp Hunk #2 FAILED at 64. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8IsolatedContext.cpp.rej patching file Source/WebCore/bindings/v8/V8IsolatedContext.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13543490 700190 5 haraken 2012-08-20 16:57:55 -0700 Committed r126096: <http://trac.webkit.org/changeset/126096> 159352 2012-08-20 01:07:32 -0700 2012-08-20 17:07:26 -0700 Patch bug-94450-20120820170653.patch text/plain 5587 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjg3OTdiMWE5MjJkM2M3 M2ZhN2M0OGI2NGE0Mjg0MDU0OGQ5YzM2MC4uZmU5Y2NiYmQ2YjMwNmQ4ZmNhYzk1ZjFmNDkyZTM3 OTQwZmI3NThmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTIwICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBW OFByb3h5IGZyb20gVjhJc29sYXRlZENvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIGRlcGVuZGVuY3kgb24gVjhQ cm94eSBmcm9tIFY4SXNvbGF0ZWRDb250ZXh0LgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFu Z2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlSW5Jc29s YXRlZFdvcmxkKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOElzb2xhdGVkQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpWOElzb2xhdGVkQ29udGV4dDo6VjhJc29sYXRlZENvbnRleHQp OgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4SXNvbGF0ZWRDb250ZXh0Lmg6CisgICAgICAgIChX ZWJDb3JlKToKKyAgICAgICAgKFY4SXNvbGF0ZWRDb250ZXh0KToKKwogMjAxMi0wOC0xOSAgS2Vu dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBNb3ZlIGNv bnRleHREZWJ1Z0lkKCkgYW5kIHNldENvbnRleHREZWJ1Z0lkKCkgZnJvbSBWOFByb3h5IHRvIFNj cmlwdENvbnRyb2xsZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nj cmlwdENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29u dHJvbGxlci5jcHAKaW5kZXggNjA2Y2RjM2E5NzQ3OGU2NTAwODk3YWVjYWQxY2FhMTQ5MDU0MWI5 MC4uNWNhNDY5ZTQ0NTc4MWY3YmNkZDhmMmM1ZmY2YTFmNjQ4MGRiZjg3MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTE5NSw3ICsx OTUsNyBAQCB2b2lkIFNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlSW5Jc29sYXRlZFdvcmxkKHVu c2lnbmVkIHdvcmxkSUQsIGNvbnN0IFZlY3RvcjxTYwogICAgICAgICAgICAgaWYgKGl0ZXIgIT0g bV9wcm94eS0+aXNvbGF0ZWRXb3JsZHMoKS5lbmQoKSkKICAgICAgICAgICAgICAgICBpc29sYXRl ZENvbnRleHQgPSBpdGVyLT5zZWNvbmQ7CiAgICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAg ICAgICBpc29sYXRlZENvbnRleHQgPSBuZXcgVjhJc29sYXRlZENvbnRleHQocHJveHkoKSwgZXh0 ZW5zaW9uR3JvdXAsIHdvcmxkSUQpOworICAgICAgICAgICAgICAgIGlzb2xhdGVkQ29udGV4dCA9 IG5ldyBWOElzb2xhdGVkQ29udGV4dChtX2ZyYW1lLCBleHRlbnNpb25Hcm91cCwgd29ybGRJRCk7 CiAgICAgICAgICAgICAgICAgaWYgKGlzb2xhdGVkQ29udGV4dC0+Y29udGV4dCgpLklzRW1wdHko KSkgewogICAgICAgICAgICAgICAgICAgICBkZWxldGUgaXNvbGF0ZWRDb250ZXh0OwogICAgICAg ICAgICAgICAgICAgICByZXR1cm47CkBAIC0yMDksNyArMjA5LDcgQEAgdm9pZCBTY3JpcHRDb250 cm9sbGVyOjpldmFsdWF0ZUluSXNvbGF0ZWRXb3JsZCh1bnNpZ25lZCB3b3JsZElELCBjb25zdCBW ZWN0b3I8U2MKICAgICAgICAgICAgIGlmIChzZWN1cml0eU9yaWdpbkl0ZXIgIT0gbV9wcm94eS0+ aXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2lucygpLmVuZCgpKQogICAgICAgICAgICAgICAgIGlz b2xhdGVkQ29udGV4dC0+c2V0U2VjdXJpdHlPcmlnaW4oc2VjdXJpdHlPcmlnaW5JdGVyLT5zZWNv bmQpOwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgaXNvbGF0ZWRDb250ZXh0ID0gbmV3 IFY4SXNvbGF0ZWRDb250ZXh0KHByb3h5KCksIGV4dGVuc2lvbkdyb3VwLCB3b3JsZElEKTsKKyAg ICAgICAgICAgIGlzb2xhdGVkQ29udGV4dCA9IG5ldyBWOElzb2xhdGVkQ29udGV4dChtX2ZyYW1l LCBleHRlbnNpb25Hcm91cCwgd29ybGRJRCk7CiAgICAgICAgICAgICBpZiAoaXNvbGF0ZWRDb250 ZXh0LT5jb250ZXh0KCkuSXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAgICAgZGVsZXRlIGlzb2xh dGVkQ29udGV4dDsKICAgICAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOElzb2xhdGVkQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOElzb2xhdGVkQ29udGV4dC5jcHAKaW5kZXggNWRlOGRlM2I1MGQ0MTc0 NjAyMGM5NGYwYzExZjJiZTAzYmU1MWEyZC4uNThmZTI0YTIxZjc1NGQ0MTRkNDRiYjYxZGY3MDBk YmFhYzQ5OTVkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJc29s YXRlZENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SXNvbGF0 ZWRDb250ZXh0LmNwcApAQCAtMzgsNyArMzgsNiBAQAogI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2lu LmgiCiAjaW5jbHVkZSAiVjhET01XaW5kb3cuaCIKICNpbmNsdWRlICJWOFBlckNvbnRleHREYXRh LmgiCi0jaW5jbHVkZSAiVjhQcm94eS5oIgogI2luY2x1ZGUgPHd0Zi9TdHJpbmdFeHRyYXMuaD4K IAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNjUsMTcgKzY0LDE3IEBAIHN0YXRpYyB2b2lkIHNl dEluamVjdGVkU2NyaXB0Q29udGV4dERlYnVnSWQodjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gdGFy Z2V0Q29udGV4CiAgICAgdGFyZ2V0Q29udGV4dC0+U2V0RGF0YSh2ODo6U3RyaW5nOjpOZXcoYnVm ZmVyKSk7CiB9CiAKLVY4SXNvbGF0ZWRDb250ZXh0OjpWOElzb2xhdGVkQ29udGV4dChWOFByb3h5 KiBwcm94eSwgaW50IGV4dGVuc2lvbkdyb3VwLCBpbnQgd29ybGRJZCkKK1Y4SXNvbGF0ZWRDb250 ZXh0OjpWOElzb2xhdGVkQ29udGV4dChGcmFtZSogZnJhbWUsIGludCBleHRlbnNpb25Hcm91cCwg aW50IHdvcmxkSWQpCiAgICAgOiBtX3dvcmxkKERPTVdyYXBwZXJXb3JsZDo6Y3JlYXRlKHdvcmxk SWQpKSwKLSAgICAgIG1fZnJhbWUocHJveHktPmZyYW1lKCkpCisgICAgICBtX2ZyYW1lKGZyYW1l KQogewogICAgIHY4OjpIYW5kbGVTY29wZSBzY29wZTsKLSAgICB2ODo6SGFuZGxlPHY4OjpDb250 ZXh0PiBtYWluV29ybGRDb250ZXh0ID0gcHJveHktPndpbmRvd1NoZWxsKCktPmNvbnRleHQoKTsK KyAgICB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBtYWluV29ybGRDb250ZXh0ID0gZnJhbWUtPnNj cmlwdCgpLT53aW5kb3dTaGVsbCgpLT5jb250ZXh0KCk7CiAgICAgaWYgKG1haW5Xb3JsZENvbnRl eHQuSXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBGSVhNRTogV2Ugc2hvdWxk IGJlIGNyZWF0aW5nIGEgbmV3IFY4RE9NV2luZG93U2hlbGwgaGVyZSBpbnN0ZWFkIG9mIHJpcGlu ZyBvdXQgdGhlIGNvbnRleHQuCi0gICAgbV9jb250ZXh0ID0gU2hhcmVkUGVyc2lzdGVudDx2ODo6 Q29udGV4dD46OmNyZWF0ZShwcm94eS0+d2luZG93U2hlbGwoKS0+Y3JlYXRlTmV3Q29udGV4dCh2 ODo6SGFuZGxlPHY4OjpPYmplY3Q+KCksIGV4dGVuc2lvbkdyb3VwLCBtX3dvcmxkLT53b3JsZElk KCkpKTsKKyAgICBtX2NvbnRleHQgPSBTaGFyZWRQZXJzaXN0ZW50PHY4OjpDb250ZXh0Pjo6Y3Jl YXRlKGZyYW1lLT5zY3JpcHQoKS0+d2luZG93U2hlbGwoKS0+Y3JlYXRlTmV3Q29udGV4dCh2ODo6 SGFuZGxlPHY4OjpPYmplY3Q+KCksIGV4dGVuc2lvbkdyb3VwLCBtX3dvcmxkLT53b3JsZElkKCkp KTsKICAgICBpZiAobV9jb250ZXh0LT5nZXQoKS5Jc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsK IApAQCAtOTAsNyArODksNyBAQCBWOElzb2xhdGVkQ29udGV4dDo6VjhJc29sYXRlZENvbnRleHQo VjhQcm94eSogcHJveHksIGludCBleHRlbnNpb25Hcm91cCwgaW50IHdvcgogICAgIG1fcGVyQ29u dGV4dERhdGEtPmluaXQoKTsKIAogICAgIC8vIEZJWE1FOiBUaGlzIHdpbGwgZ28gYXdheSBvbmNl IHdlIGhhdmUgYSB3aW5kb3dTaGVsbCBmb3IgdGhlIGlzb2xhdGVkIHdvcmxkLgotICAgIHByb3h5 LT53aW5kb3dTaGVsbCgpLT5pbnN0YWxsRE9NV2luZG93KG1fY29udGV4dC0+Z2V0KCksIG1fZnJh bWUtPmRvY3VtZW50KCktPmRvbVdpbmRvdygpKTsKKyAgICBmcmFtZS0+c2NyaXB0KCktPndpbmRv d1NoZWxsKCktPmluc3RhbGxET01XaW5kb3cobV9jb250ZXh0LT5nZXQoKSwgbV9mcmFtZS0+ZG9j dW1lbnQoKS0+ZG9tV2luZG93KCkpOwogCiAgICAgLy8gVXNpbmcgdGhlIGRlZmF1bHQgc2VjdXJp dHkgdG9rZW4gbWVhbnMgdGhhdCB0aGUgY2FuQWNjZXNzIGlzIGFsd2F5cwogICAgIC8vIGNhbGxl ZCwgd2hpY2ggaXMgc2xvdy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4SXNvbGF0ZWRDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOElzb2xh dGVkQ29udGV4dC5oCmluZGV4IDU5MWUwNWJmNDI1MGY0NDFiNjQyZjM4MGExZDk0ZDM1Zjc1Y2Rh ZDIuLjk4Y2FlNDU0OWNlNDY2ZDdkN2YyZjViZTI1ODZlZDlmZmM4MWU1MjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SXNvbGF0ZWRDb250ZXh0LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhJc29sYXRlZENvbnRleHQuaApAQCAtMzksOSArMzks OSBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIEZyYW1lOwogY2xhc3MgU2VjdXJp dHlPcmlnaW47CiBjbGFzcyBWOFBlckNvbnRleHREYXRhOwotY2xhc3MgVjhQcm94eTsKIAogLy8g VjhJc29sYXRlZENvbnRleHQKIC8vCkBAIC01OSw3ICs1OSw3IEBAIGNsYXNzIFY4SXNvbGF0ZWRD b250ZXh0IHsKIHB1YmxpYzoKICAgICAvLyBDcmVhdGVzIGFuIGlzb2xhdGVkIHdvcmxkLiBUbyBk ZXN0cm95IGl0LCBjYWxsIGRlc3Ryb3koKS4KICAgICAvLyBUaGlzIHdpbGwgZGVsZXRlIHRoZSBp c29sYXRlZCB3b3JsZCB3aGVuIHRoZSBjb250ZXh0IGl0IG93bnMgaXMgR0MnZC4KLSAgICBWOElz b2xhdGVkQ29udGV4dChWOFByb3h5KiwgaW50IGV4dGVuc2lvbkdyb3VwLCBpbnQgd29ybGRJZCk7 CisgICAgVjhJc29sYXRlZENvbnRleHQoRnJhbWUqLCBpbnQgZXh0ZW5zaW9uR3JvdXAsIGludCB3 b3JsZElkKTsKICAgICB+VjhJc29sYXRlZENvbnRleHQoKTsKIAogICAgIC8vIENhbGwgdGhpcyB0 byBkZXN0cm95IHRoZSBpc29sYXRlZCB3b3JsZC4gSXQgd2lsbCBiZSBkZWxldGVkIHNvbWV0aW1l Cg==