9445 2006-06-14 17:02:03 -0700 Netscape Plugin (Flash) NSURLRequests have no MainDocumentURL set 2010-03-08 14:28:07 -0800 1 1 1 Unclassified WebKit Plug-ins 420+ Mac OS X 10.4 RESOLVED DUPLICATE 26391 InRadar P2 Normal --- 1 rachael rachael ap beidson ggaren mitz opendarwin oldest_to_newest 45707 0 rachael 2006-06-14 17:02:03 -0700 Problem seen with Flash plugin requests specifically 43812 1 ap 2006-11-29 12:02:38 -0800 From IRC: Omni is using mainDocumentURL to block specific requests, to "do things like add ".swf" to your blacklist and have flash just not-load, and then click to load it if you want it." 43762 2 11676 rachael 2006-11-29 20:23:42 -0800 Created attachment 11676 Omni's Fix for this bug ap: here's the change Omni made, to ensure that requests that originate from WebPlugins have their MainDocumentURL set. We use this to decide whether or not to block content. 43338 3 ap 2006-12-04 22:46:17 -0800 Something that surprises me is that this code doesn't seem to be reachable from Netscape-style plugins - the modified method is a WebPluginController API, and the only place in WebKit where it is called is from an SPI of same class ("For compatibility only"). 42561 4 11676 mjs 2006-12-09 14:47:32 -0800 Comment on attachment 11676 Omni's Fix for this bug This may not cover all the right places to get plugins to set a main document URL, but seems like an improvement in any case. r=me 42571 5 ap 2006-12-10 02:46:46 -0800 I'll land this, but would like to clarify something over IRC first. 42615 6 ap 2006-12-11 11:55:06 -0800 Looks like my concerns may be not entirely nonsense - reassigning back to Rachael to look into them some more. Besides this patch being for another issue, I'm not sure if it's even correct to set mainDocumentURL rather than referer here. 39160 7 11676 ddkilzer 2006-12-28 15:32:19 -0800 Comment on attachment 11676 Omni's Fix for this bug Clearing mjs r+ on Attachment 11676 per Comment #6. 173002 8 mitz 2009-12-17 17:35:47 -0800 <rdar://problem/7338359> 197315 9 beidson 2010-03-08 14:28:07 -0800 Reverse duping to https://bugs.webkit.org/show_bug.cgi?id=26391 *** This bug has been marked as a duplicate of bug 26391 *** 11676 2006-11-29 20:23:42 -0800 2006-12-28 15:32:19 -0800 Omni's Fix for this bug webkitPatch.txt text/plain 1111 rachael SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTc5MzcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTAgQEAKKzIwMDYtMTEtMjkgIFJhY2hhZWwgU3RhbnRvbiAgPHJhY2hhZWxAb21uaWdy b3VwLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFBsdWdpbnMvV2ViUGx1Z2luQ29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV2ViUGx1Z2lu Q29udHJvbGxlciB3ZWJQbHVnSW5Db250YWluZXJMb2FkUmVxdWVzdDppbkZyYW1lOl0pOgorCiAy MDA2LTExLTI5ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBPbGl2ZXIuCkluZGV4OiBXZWJLaXQvUGx1Z2lucy9XZWJQbHVnaW5Db250 cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9QbHVnaW5zL1dlYlBsdWdpbkNvbnRyb2xs ZXIubW0JKHJldmlzaW9uIDE3OTM1KQorKysgV2ViS2l0L1BsdWdpbnMvV2ViUGx1Z2luQ29udHJv bGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMjk5LDYgKzI5OSw4IEBAIHN0YXRpYyB2b2lkIGNh bmNlbE91dHN0YW5kaW5nQ2hlY2soY29uc3QKICAgICAgICAgICAgIExPR19FUlJPUigiY291bGQg bm90IGxvYWQgVVJMICVAIiwgW3JlcXVlc3QgVVJMXSk7CiAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgIH0KKyAgICAgICAgcmVxdWVzdCA9IFtbcmVxdWVzdCBtdXRhYmxlQ29weV0gYXV0b3Jl bGVhc2VdOworICAgICAgICBbKE5TTXV0YWJsZVVSTFJlcXVlc3QgKilyZXF1ZXN0IHNldE1haW5E b2N1bWVudFVSTDpbW1tbW2ZyYW1lIHdlYlZpZXddIG1haW5GcmFtZV0gZGF0YVNvdXJjZV0gcmVx dWVzdF0gVVJMXV07ICAgICAgICAKICAgICAgICAgW2ZyYW1lIF9mcmFtZUxvYWRlcl0tPmxvYWQo cmVxdWVzdCwgdGFyZ2V0KTsKICAgICB9CiB9Cg==