94445 2012-08-19 22:51:48 -0700 [V8] Replace proxy()->windowShell() in ScriptController with windowShell() 2012-08-19 23:52:18 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 699236 0 haraken 2012-08-19 22:51:48 -0700 Now ScriptController owns windowShell. So ScriptController doesn't need to get windowShell through V8Proxy. 699237 1 159336 haraken 2012-08-19 22:52:57 -0700 Created attachment 159336 Patch 699264 2 159336 webkit.review.bot 2012-08-19 23:52:15 -0700 Comment on attachment 159336 Patch Clearing flags on attachment: 159336 Committed r126000: <http://trac.webkit.org/changeset/126000> 699265 3 webkit.review.bot 2012-08-19 23:52:18 -0700 All reviewed patches have been landed. Closing bug. 159336 2012-08-19 22:52:57 -0700 2012-08-19 23:52:15 -0700 Patch bug-94445-20120820145218.patch text/plain 3308 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGNiZGIxNjhkNjEzYWE3 NGI4MWVmOWE2YWM0YmU1YmJlODJjMzU2OC4uMTk3OWMwNjIwOTMwZTQ0NGY5OTczYzcxOTQ0Yzc3 MjE2ZDgwMjRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTA4LTE5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFJlcGxhY2Ug cHJveHkoKS0+d2luZG93U2hlbGwoKSBpbiBTY3JpcHRDb250cm9sbGVyIHdpdGggd2luZG93U2hl bGwoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ0 NDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cg U2NyaXB0Q29udHJvbGxlciBvd25zIHdpbmRvd1NoZWxsLiBTbyBTY3JpcHRDb250cm9sbGVyIGRv ZXNuJ3QKKyAgICAgICAgbmVlZCB0byBnZXQgd2luZG93U2hlbGwgdGhyb3VnaCBWOFByb3h5Lgor CisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBi aW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dENvbnRyb2xsZXI6OnVwZGF0ZVNlY3VyaXR5T3JpZ2luKToKKyAgICAgICAgKFdlYkNvcmU6OlNj cmlwdENvbnRyb2xsZXI6OmhhdmVJbnRlcnByZXRlcik6CisgICAgICAgIChXZWJDb3JlOjpTY3Jp cHRDb250cm9sbGVyOjplbmFibGVFdmFsKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRy b2xsZXI6OmRpc2FibGVFdmFsKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6 OnVwZGF0ZURvY3VtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6Om5h bWVkSXRlbUFkZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6Om5hbWVk SXRlbVJlbW92ZWQpOgorCisyMDEyLTA4LTE5ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9t aXVtLm9yZz4KKwogICAgICAgICBbVjhdIE1vdmUgVjhQcm94eTo6Y2FsbEZ1bmN0aW9uKCkgdG8g U2NyaXB0Q29udHJvbGxlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTQ0MzcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv U2NyaXB0Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRD b250cm9sbGVyLmNwcAppbmRleCBiNTU4YmU2OTI3ZmQ1NWZhMjAyYjk4MmIzOTk4ZjNhOTQ4YWQ1 MmM1Li4xYTk2MTNlOWQwY2YzNjNkNmY3YmM4MWExMzFjMWExNTg1ZTIwYThkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmNwcApAQCAtMTQ2LDcg KzE0Niw3IEBAIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6Y2xlYXJTY3JpcHRPYmplY3RzKCkKIAog dm9pZCBTY3JpcHRDb250cm9sbGVyOjp1cGRhdGVTZWN1cml0eU9yaWdpbigpCiB7Ci0gICAgbV9w cm94eS0+d2luZG93U2hlbGwoKS0+dXBkYXRlU2VjdXJpdHlPcmlnaW4oKTsKKyAgICB3aW5kb3dT aGVsbCgpLT51cGRhdGVTZWN1cml0eU9yaWdpbigpOwogfQogCiB2b2lkIFNjcmlwdENvbnRyb2xs ZXI6OnVwZGF0ZVBsYXRmb3JtU2NyaXB0T2JqZWN0cygpCkBAIC0zMzEsMTMgKzMzMSwxMyBAQCB2 b2lkIFNjcmlwdENvbnRyb2xsZXI6Omxvd01lbW9yeU5vdGlmaWNhdGlvbigpCiAKIGJvb2wgU2Ny aXB0Q29udHJvbGxlcjo6aGF2ZUludGVycHJldGVyKCkgY29uc3QKIHsKLSAgICByZXR1cm4gbV9w cm94eS0+d2luZG93U2hlbGwoKS0+aXNDb250ZXh0SW5pdGlhbGl6ZWQoKTsKKyAgICByZXR1cm4g d2luZG93U2hlbGwoKS0+aXNDb250ZXh0SW5pdGlhbGl6ZWQoKTsKIH0KIAogdm9pZCBTY3JpcHRD b250cm9sbGVyOjplbmFibGVFdmFsKCkKIHsKICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2Nv cGU7Ci0gICAgdjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gdjhDb250ZXh0ID0gcHJveHkoKS0+d2lu ZG93U2hlbGwoKS0+Y29udGV4dCgpOworICAgIHY4OjpIYW5kbGU8djg6OkNvbnRleHQ+IHY4Q29u dGV4dCA9IHdpbmRvd1NoZWxsKCktPmNvbnRleHQoKTsKICAgICBpZiAodjhDb250ZXh0LklzRW1w dHkoKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC0zNDcsNyArMzQ3LDcgQEAgdm9pZCBTY3JpcHRD b250cm9sbGVyOjplbmFibGVFdmFsKCkKIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6ZGlzYWJsZUV2 YWwoKQogewogICAgIHY4OjpIYW5kbGVTY29wZSBoYW5kbGVTY29wZTsKLSAgICB2ODo6SGFuZGxl PHY4OjpDb250ZXh0PiB2OENvbnRleHQgPSBwcm94eSgpLT53aW5kb3dTaGVsbCgpLT5jb250ZXh0 KCk7CisgICAgdjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gdjhDb250ZXh0ID0gd2luZG93U2hlbGwo KS0+Y29udGV4dCgpOwogICAgIGlmICh2OENvbnRleHQuSXNFbXB0eSgpKQogICAgICAgICByZXR1 cm47CiAKQEAgLTUyMiwxNyArNTIyLDE3IEBAIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6YXR0YWNo RGVidWdnZXIodm9pZCopCiAKIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6dXBkYXRlRG9jdW1lbnQo KQogewotICAgIG1fcHJveHktPndpbmRvd1NoZWxsKCktPnVwZGF0ZURvY3VtZW50KCk7CisgICAg d2luZG93U2hlbGwoKS0+dXBkYXRlRG9jdW1lbnQoKTsKIH0KIAogdm9pZCBTY3JpcHRDb250cm9s bGVyOjpuYW1lZEl0ZW1BZGRlZChIVE1MRG9jdW1lbnQqIGRvYywgY29uc3QgQXRvbWljU3RyaW5n JiBuYW1lKQogewotICAgIG1fcHJveHktPndpbmRvd1NoZWxsKCktPm5hbWVkSXRlbUFkZGVkKGRv YywgbmFtZSk7CisgICAgd2luZG93U2hlbGwoKS0+bmFtZWRJdGVtQWRkZWQoZG9jLCBuYW1lKTsK IH0KIAogdm9pZCBTY3JpcHRDb250cm9sbGVyOjpuYW1lZEl0ZW1SZW1vdmVkKEhUTUxEb2N1bWVu dCogZG9jLCBjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUpCiB7Ci0gICAgbV9wcm94eS0+d2luZG93 U2hlbGwoKS0+bmFtZWRJdGVtUmVtb3ZlZChkb2MsIG5hbWUpOworICAgIHdpbmRvd1NoZWxsKCkt Pm5hbWVkSXRlbVJlbW92ZWQoZG9jLCBuYW1lKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQo=