94438 2012-08-19 18:15:05 -0700 [V8] Move m_windowShell from V8Proxy to ScriptController 2012-08-19 21:32:34 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth dcarney japhet webkit.review.bot oldest_to_newest 699130 0 haraken 2012-08-19 18:15:05 -0700 m_windowShell should be owned by ScriptController. After this change, I can move a bunch of V8Proxy methods that access windowShell() from V8Proxy to ScriptController. 699147 1 159316 haraken 2012-08-19 18:44:55 -0700 Created attachment 159316 Patch 699183 2 159316 abarth 2012-08-19 20:46:09 -0700 Comment on attachment 159316 Patch I thought I tried this before and there was some complication, but perhaps that complication has been removed. This patch certainly look straightforward and correct. Note: We eventually want ScriptController to hold a map from DOMWrapperWorld to V8WindowShell, but that's a separate effort. 699184 3 abarth 2012-08-19 20:48:32 -0700 @dcarney: Related to your work with making a WindowShell per DOMWrapperWorld. 699203 4 159316 webkit.review.bot 2012-08-19 21:32:30 -0700 Comment on attachment 159316 Patch Clearing flags on attachment: 159316 Committed r125993: <http://trac.webkit.org/changeset/125993> 699205 5 webkit.review.bot 2012-08-19 21:32:34 -0700 All reviewed patches have been landed. Closing bug. 159316 2012-08-19 18:44:55 -0700 2012-08-19 21:32:30 -0700 Patch bug-94438-20120820104416.patch text/plain 6616 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI4MTJjYzU3ZDQ4OWE1 MDI1YmIwNDU2OWUxNjMyNzU5YjI1ZTk1OC4uZDEwZTdhNWUyMTAzMjBiNDRiNDU1NjcwNDIxMzFl NTkyYzZjM2FhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA4LTE5ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgbV93 aW5kb3dTaGVsbCBmcm9tIFY4UHJveHkgdG8gU2NyaXB0Q29udHJvbGxlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ0MzgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX3dpbmRvd1NoZWxsIHNob3VsZCBi ZSBvd25lZCBieSBTY3JpcHRDb250cm9sbGVyLgorICAgICAgICBBZnRlciB0aGlzIGNoYW5nZSwg SSBjYW4gbW92ZSBhIGJ1bmNoIG9mIFY4UHJveHkgbWV0aG9kcworICAgICAgICB0aGF0IGFjY2Vz cyB3aW5kb3dTaGVsbCgpIGZyb20gVjhQcm94eSB0byBTY3JpcHRDb250cm9sbGVyLgorCisgICAg ICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5n cy92OC9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRy b2xsZXI6OlNjcmlwdENvbnRyb2xsZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdENv bnRyb2xsZXIuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0 Q29udHJvbGxlcjo6d2luZG93U2hlbGwpOgorICAgICAgICAoU2NyaXB0Q29udHJvbGxlcik6Cisg ICAgICAgICogYmluZGluZ3MvdjgvVjhCaW5kaW5nLmg6CisgICAgICAgICogYmluZGluZ3Mvdjgv VjhQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5OjpWOFByb3h5KToKKyAgICAg ICAgKFdlYkNvcmU6OlY4UHJveHk6OndpbmRvd1NoZWxsKToKKyAgICAgICAgKFdlYkNvcmUpOgor ICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAg ICAgICAoV2ViQ29yZTo6VjhQcm94eTo6ZnJhbWUpOgorICAgICAgICAoVjhQcm94eSk6CisKIDIw MTItMDgtMTkgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBDU1Ag MS4xOiBBZGQgJ3BsdWdpbi10eXBlcycgYW5kICdmb3JtLWFjdGlvbicgRE9NIEFQSS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggMDY5 MmUzZDJiOWI4MmQzODk2Yzk1OTI2MjlmMzUyNzQ5YTczYzBlZi4uNDU3NDQ2NmJkN2UyZGIxNGI2 N2RkZDNmMmI4MGZmZjcwNjhhMWI4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTEwMiw2ICsxMDIsNyBAQCBib29sIFNjcmlwdENv bnRyb2xsZXI6OmNhbkFjY2Vzc0Zyb21DdXJyZW50T3JpZ2luKEZyYW1lICpmcmFtZSkKIFNjcmlw dENvbnRyb2xsZXI6OlNjcmlwdENvbnRyb2xsZXIoRnJhbWUqIGZyYW1lKQogICAgIDogbV9mcmFt ZShmcmFtZSkKICAgICAsIG1fc291cmNlVVJMKDApCisgICAgLCBtX3dpbmRvd1NoZWxsKFY4RE9N V2luZG93U2hlbGw6OmNyZWF0ZShmcmFtZSkpCiAgICAgLCBtX3BhdXNlZChmYWxzZSkKICAgICAs IG1fcHJveHkoYWRvcHRQdHIobmV3IFY4UHJveHkoZnJhbWUpKSkKICNpZiBFTkFCTEUoTkVUU0NB UEVfUExVR0lOX0FQSSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Nj cmlwdENvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRy b2xsZXIuaAppbmRleCBkMTg5ZGMxYzQ3ZjkxOGUzOTRmNThkNmQ4NTFmMDYxODJhNjI2NDc2Li4w NjliYTZlMzVkMTU1ZDE2MWIzNDMyOTE5ZDNlOTBkZGM0ZWFhZGY3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCkBAIC01MSwxMCArNTEsMTIgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgRE9NV3JhcHBlcldvcmxkOwogY2xhc3MgRXZlbnQ7 CiBjbGFzcyBGcmFtZTsKK2NsYXNzIEhUTUxEb2N1bWVudDsKIGNsYXNzIEhUTUxQbHVnSW5FbGVt ZW50OwogY2xhc3MgUGFnZVBvcHVwQ2xpZW50OwogY2xhc3MgU2NyaXB0U291cmNlQ29kZTsKIGNs YXNzIFNjcmlwdFN0YXRlOworY2xhc3MgVjhET01XaW5kb3dTaGVsbDsKIGNsYXNzIFdpZGdldDsK IAogY2xhc3MgU2NyaXB0Q29udHJvbGxlciB7CkBAIC02NSw3ICs2Nyw3IEBAIHB1YmxpYzoKICAg ICAvLyBGSVhNRTogVjhQcm94eSBzaG91bGQgZWl0aGVyIGJlIGZvbGRlZCBpbnRvIFNjcmlwdENv bnRyb2xsZXIKICAgICAvLyBvciB0aGlzIGFjY2Vzc29yIHNob3VsZCBiZSBtYWRlIEpTUHJveHkq CiAgICAgVjhQcm94eSogcHJveHkoKSB7IHJldHVybiBtX3Byb3h5LmdldCgpOyB9Ci0gICAgVjhE T01XaW5kb3dTaGVsbCogd2luZG93U2hlbGwoKSB7IHJldHVybiBtX3Byb3h5LT53aW5kb3dTaGVs bCgpOyB9CisgICAgVjhET01XaW5kb3dTaGVsbCogd2luZG93U2hlbGwoKSBjb25zdCB7IHJldHVy biBtX3dpbmRvd1NoZWxsLmdldCgpOyB9CiAKICAgICBTY3JpcHRWYWx1ZSBleGVjdXRlU2NyaXB0 KGNvbnN0IFNjcmlwdFNvdXJjZUNvZGUmKTsKICAgICBTY3JpcHRWYWx1ZSBleGVjdXRlU2NyaXB0 KGNvbnN0IFN0cmluZyYgc2NyaXB0LCBib29sIGZvcmNlVXNlckdlc3R1cmUgPSBmYWxzZSk7CkBA IC0xODYsNiArMTg4LDkgQEAgcHJpdmF0ZToKICAgICBGcmFtZSogbV9mcmFtZTsKICAgICBjb25z dCBTdHJpbmcqIG1fc291cmNlVVJMOwogCisgICAgLy8gRm9yIHRoZSBtb21lbnQsIHdlIGhhdmUg b25lIG9mIHRoZXNlLiBTb29uIHdlIHdpbGwgaGF2ZSBvbmUgcGVyIERPTVdyYXBwZXJXb3JsZC4K KyAgICBSZWZQdHI8VjhET01XaW5kb3dTaGVsbD4gbV93aW5kb3dTaGVsbDsKKwogICAgIGJvb2wg bV9wYXVzZWQ7CiAKICAgICBPd25QdHI8VjhQcm94eT4gbV9wcm94eTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhCaW5kaW5nLmgKaW5kZXggMmJiZTU0ZDcxNzU5YjU3ZjIyZjE4YjQ5ZWZjNjA5 N2E4NTA3MDc0NC4uNzEyOGI4ZDVjNjhjNDQzZTZmZWNmNmZhMDcyMDZiNTcwMWU4MjRmOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTM2LDYgKzM2LDcgQEAKICNp bmNsdWRlICJTYWZlQWxsb2NhdGlvbi5oIgogI2luY2x1ZGUgIlY4QmluZGluZ01hY3Jvcy5oIgog I2luY2x1ZGUgIlY4RE9NQ29uZmlndXJhdGlvbi5oIgorI2luY2x1ZGUgIlY4RE9NV2luZG93U2hl bGwuaCIKICNpbmNsdWRlICJWOERPTVdyYXBwZXIuaCIKICNpbmNsdWRlICJWOEhpZGRlblByb3Bl cnR5TmFtZS5oIgogI2luY2x1ZGUgIlY4UGVySXNvbGF0ZURhdGEuaCIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhQcm94eS5jcHAKaW5kZXggMjVhMzYwNmE5MjhlNzhhZWU2ZGIwZTQ3OTRlMWUz ZTJmODU5ZjU4Mi4uYWIyNzNhZWQwZjU3ODUxYjFhMjMxZTk4NmQzZmMyMDU1MjAwZDgzOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAKQEAgLTEyMCw3ICsxMjAsNiBAQCBz dGF0aWMgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gaGFuZGxlTWF4UmVjdXJzaW9uRGVwdGhFeGNlZWRl ZCgpCiAKIFY4UHJveHk6OlY4UHJveHkoRnJhbWUqIGZyYW1lKQogICAgIDogbV9mcmFtZShmcmFt ZSkKLSAgICAsIG1fd2luZG93U2hlbGwoVjhET01XaW5kb3dTaGVsbDo6Y3JlYXRlKGZyYW1lKSkK IHsKIH0KIApAQCAtMzU1LDYgKzM1NCwxMSBAQCB2ODo6TG9jYWw8djg6OlZhbHVlPiBWOFByb3h5 OjpuZXdJbnN0YW5jZSh2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4gY29uc3RydWN0b3IsCiAgICAg cmV0dXJuIHJlc3VsdDsKIH0KIAorVjhET01XaW5kb3dTaGVsbCogVjhQcm94eTo6d2luZG93U2hl bGwoKSBjb25zdAoreworICAgIHJldHVybiBmcmFtZSgpLT5zY3JpcHQoKS0+d2luZG93U2hlbGwo KTsKK30KKwogRE9NV2luZG93KiBWOFByb3h5OjpyZXRyaWV2ZVdpbmRvdyh2ODo6SGFuZGxlPHY4 OjpDb250ZXh0PiBjb250ZXh0KQogewogICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gZ2xvYmFs ID0gY29udGV4dC0+R2xvYmFsKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFByb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKaW5k ZXggYjgyMDg5MjJhY2YzZDUwOGVmM2Y1Nzg5Y2QzOTcwNTkyNzFhNGU2NC4uY2ZjZmIwODlmOTU0 YmFmM2UzZTEwZGM1ZWVjZWY4ZjFiNDJiYzk1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 UHJveHkuaApAQCAtMzUsNyArMzUsNiBAQAogI2luY2x1ZGUgIlNoYXJlZFBlcnNpc3RlbnQuaCIK ICNpbmNsdWRlICJTdGF0c0NvdW50ZXIuaCIKICNpbmNsdWRlICJWOEFic3RyYWN0RXZlbnRMaXN0 ZW5lci5oIgotI2luY2x1ZGUgIlY4RE9NV2luZG93U2hlbGwuaCIKICNpbmNsdWRlICJWOERPTVdy YXBwZXIuaCIKICNpbmNsdWRlICJWOEdDQ29udHJvbGxlci5oIgogI2luY2x1ZGUgIlY4VXRpbGl0 aWVzLmgiCkBAIC02Miw5ICs2MSwxMCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xhc3Mg U2NyaXB0RXhlY3V0aW9uQ29udGV4dDsKICAgICBjbGFzcyBTY3JpcHRTb3VyY2VDb2RlOwogICAg IGNsYXNzIFNlY3VyaXR5T3JpZ2luOwotICAgIGNsYXNzIFY4UGVyQ29udGV4dERhdGE7CisgICAg Y2xhc3MgVjhET01XaW5kb3dTaGVsbDsKICAgICBjbGFzcyBWOEV2ZW50TGlzdGVuZXI7CiAgICAg Y2xhc3MgVjhJc29sYXRlZENvbnRleHQ7CisgICAgY2xhc3MgVjhQZXJDb250ZXh0RGF0YTsKICAg ICBjbGFzcyBXb3JsZENvbnRleHRIYW5kbGU7CiAKICAgICBjb25zdCBpbnQga01heFJlY3Vyc2lv bkRlcHRoID0gMjI7CkBAIC04OCw3ICs4OCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAg ICAgICB+VjhQcm94eSgpOwogCi0gICAgICAgIEZyYW1lKiBmcmFtZSgpIHsgcmV0dXJuIG1fZnJh bWU7IH0KKyAgICAgICAgRnJhbWUqIGZyYW1lKCkgY29uc3QgeyByZXR1cm4gbV9mcmFtZTsgfQog CiAgICAgICAgIHZvaWQgY2xlYXJGb3JOYXZpZ2F0aW9uKCk7CiAgICAgICAgIHZvaWQgY2xlYXJG b3JDbG9zZSgpOwpAQCAtMTM4LDcgKzEzOCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgYm9vbCBtYXRjaGVzQ3VycmVudENvbnRleHQoKTsKIAogICAgICAgICAvLyBGSVhNRTogVGhp cyBzaG91bGQgZXZlbnR1YWxseSB0YWtlIERPTVdyYXBwZXJXb3JsZCBhcmd1bWVudCEKLSAgICAg ICAgVjhET01XaW5kb3dTaGVsbCogd2luZG93U2hlbGwoKSBjb25zdCB7IHJldHVybiBtX3dpbmRv d1NoZWxsLmdldCgpOyB9CisgICAgICAgIC8vIEZJWE1FOiBUaGlzIG1ldGhvZCB3aWxsIGJlIHNv b24gcmVtb3ZlZCwgYXMgYWxsIG1ldGhvZHMgdGhhdCBhY2Nlc3Mgd2luZG93U2hlbGwoKQorICAg ICAgICAvLyB3aWxsIGJlIG1vdmVkIHRvIFNjcmlwdENvbnRyb2xsZXIuCisgICAgICAgIFY4RE9N V2luZG93U2hlbGwqIHdpbmRvd1NoZWxsKCkgY29uc3Q7CiAKICAgICAgICAgYm9vbCBzZXRDb250 ZXh0RGVidWdJZChpbnQgaWQpOwogICAgICAgICBzdGF0aWMgaW50IGNvbnRleHREZWJ1Z0lkKHY4 OjpIYW5kbGU8djg6OkNvbnRleHQ+KTsKQEAgLTE2NCw5ICsxNjYsNiBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKICAgICAgICAgRnJhbWUqIG1fZnJhbWU7CiAKLSAgICAgICAgLy8gRm9yIHRoZSBt b21lbnQsIHdlIGhhdmUgb25lIG9mIHRoZXNlLiAgU29vbiB3ZSB3aWxsIGhhdmUgb25lIHBlciBE T01XcmFwcGVyV29ybGQuCi0gICAgICAgIFJlZlB0cjxWOERPTVdpbmRvd1NoZWxsPiBtX3dpbmRv d1NoZWxsOwotCiAgICAgICAgIC8vIEFsbCBvZiB0aGUgZXh0ZW5zaW9ucyByZWdpc3RlcmVkIHdp dGggdGhlIGNvbnRleHQuCiAgICAgICAgIHN0YXRpYyBWOEV4dGVuc2lvbnMgbV9leHRlbnNpb25z OwogCg==