94426 2012-08-19 08:18:51 -0700 Web Inspector: improve standalone test harness to allow attaching to inspector before test. 2012-08-20 03:06:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 699033 0 pfeldman 2012-08-19 08:18:51 -0700 Patch to follow. 699034 1 159295 pfeldman 2012-08-19 08:21:48 -0700 Created attachment 159295 Patch 699362 2 159295 vsevik 2012-08-20 02:59:42 -0700 Comment on attachment 159295 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159295&action=review > Source/WebCore/ChangeLog:8 > + - User can not "Debug", attach inspector to the front-end and "Continue" test execution. Please fix typo. 699363 3 159295 webkit.review.bot 2012-08-20 03:06:12 -0700 Comment on attachment 159295 Patch Clearing flags on attachment: 159295 Committed r126016: <http://trac.webkit.org/changeset/126016> 699364 4 webkit.review.bot 2012-08-20 03:06:16 -0700 All reviewed patches have been landed. Closing bug. 159295 2012-08-19 08:21:48 -0700 2012-08-20 03:06:11 -0700 Patch bug-94426-20120819192107.patch text/plain 4489 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI1ZDJjYzVlZTEzZTRj NTI2NmUyMzNkMzVhOTQ5ODA4NTcyOWRhOS4uMjk3ZmE4ZDAzNzQ4N2EwMmJmZDU0Njk2MjgwNWM2 ZGIzZDgwNjFhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTE5ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGltcHJvdmUgc3RhbmRhbG9uZSB0ZXN0IGhhcm5lc3MgdG8gYWxsb3cgYXR0YWNoaW5nIHRv IGluc3BlY3RvciBiZWZvcmUgdGVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk0NDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgLSBVc2VyIGNhbiBub3QgIkRlYnVnIiwgYXR0YWNoIGluc3BlY3RvciB0 byB0aGUgZnJvbnQtZW5kIGFuZCAiQ29udGludWUiIHRlc3QgZXhlY3V0aW9uLgorICAgICAgICAt IFlvdSBjYW4gYWxzbyBhc3NpZ24gZmlsdGVyIGZyb20gdGhlIHF1ZXJ5IHBhcmFtZXRlci4KKwor ICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdGVzdC1ydW5uZXIuaHRtbDoKKwogMjAxMi0w OC0xOCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBtYWtlIHByb2ZpbGVzIHBhbmVsIGEgbGF6aWx5IGxvYWRlZCBtb2R1bGUu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3Rlc3QtcnVu bmVyLmh0bWwgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3Rlc3QtcnVubmVy Lmh0bWwKaW5kZXggNGYwNWY4NzdlZTY2NTRhZWE3MjlmM2VkOTdmYjI3Y2MxYzBjNWQ3Yy4uM2Vk ZjJjNTgwZWEzMDAyZDVkYTZjZTA0OTEwN2ZkMjc4NTZmMDQ1MyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90ZXN0LXJ1bm5lci5odG1sCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdGVzdC1ydW5uZXIuaHRtbApAQCAtNjksNiAr NjksMTEgQEAgdmFyIHRyZWVPdXRsaW5lID0gbnVsbDsKIAogZnVuY3Rpb24gcnVuKGRlYnVnKQog eworICAgIGlmICh3aW5kb3cucnVubmVyICYmIGRlYnVnKSB7CisgICAgICAgIHdpbmRvdy5ydW5u ZXIuY29udGludWVEZWJ1Z2dpbmcoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIGlm ICh3aW5kb3cudGVzdFNjYW5uZXJJZnJhbWUpIAogICAgICAgICBkb2N1bWVudC5ib2R5LnJlbW92 ZUNoaWxkKHdpbmRvdy50ZXN0U2Nhbm5lcklmcmFtZSk7CiAKQEAgLTEwOCw4ICsxMTMsMTAgQEAg ZnVuY3Rpb24gcnVuTmV4dFRlc3QobGFzdFJlc3VsdCkKIAogICAgICAgICBlbGVtZW50ID0gZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlbWFpbmluZyIpOwogICAgICAgICBlbGVtZW50LnRleHRD b250ZW50ID0gcGFyc2VJbnQoZWxlbWVudC50ZXh0Q29udGVudCkgLSAxOwotICAgICAgICBpZiAo d2luZG93LmRlYnVnKQorICAgICAgICBpZiAod2luZG93LmRlYnVnKSB7CisgICAgICAgICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZGVidWciKS50ZXh0Q29udGVudCA9ICJEZWJ1ZyI7CiAg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KICAgICB9CiAKICAgICB2YXIgdGVzdDsKQEAg LTE3MSwxMiArMTc4LDI3IEBAIFN0YW5kYWxvbmVUZXN0UnVubmVyLnByb3RvdHlwZSA9IHsKICAg ICAgICAgdGhpcy5faW5zcGVjdG9yV2luZG93TG9hZGluZyA9IHdpbmRvdy5vcGVuKFN0YW5kYWxv bmVUZXN0UnVubmVyLkZyb250ZW5kTG9jYXRpb24gKyAiPyIgKyB0aGlzLl9kZWJ1Z2dlclVSTCwg Imluc3BlY3RvciIsIGZlYXR1cmVzKTsKICAgICAgICAgCiAgICAgICAgIHdpbmRvdy5hZGRFdmVu dExpc3RlbmVyKCd1bmxvYWQnLCB0aGlzLmNsZWFudXAuYmluZCh0aGlzKSk7Ci0gICAgICAgIAot ICAgICAgICB0aGlzLl93YXRjaERvZyA9IHNldFRpbWVvdXQodGhpcy5fdGltZW91dC5iaW5kKHRo aXMpLCAxMDAwMCk7CisKKyAgICAgICAgaWYgKCF3aW5kb3cuZGVidWcpCisgICAgICAgICAgICB0 aGlzLl93YXRjaERvZyA9IHNldFRpbWVvdXQodGhpcy5fdGltZW91dC5iaW5kKHRoaXMpLCAxMDAw MCk7CiAgICAgfSwKIAogICAgIGxvYWRDb21wbGV0ZWQ6IGZ1bmN0aW9uKCkKICAgICB7CisgICAg ICAgIGlmICghd2luZG93LmRlYnVnKSB7CisgICAgICAgICAgICB0aGlzLl9sb2FkQ29tcGxldGVk KHRoaXMpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJkZWJ1ZyIpLnRleHRDb250ZW50ID0gIkNvbnRpbnVlIjsKKyAgICB9 LAorCisgICAgY29udGludWVEZWJ1Z2dpbmc6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHRo aXMuX2xvYWRDb21wbGV0ZWQoKTsKKyAgICB9LAorCisgICAgX2xvYWRDb21wbGV0ZWQ6IGZ1bmN0 aW9uKCkKKyAgICB7CiAgICAgICAgIHRoaXMuX2luc3BlY3RvcldpbmRvdyA9IHRoaXMuX2luc3Bl Y3RvcldpbmRvd0xvYWRpbmc7CiAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5fcGVu ZGluZ01lc3NhZ2VzLmxlbmd0aDsgKytpKQogICAgICAgICAgICAgdGhpcy5faW5zcGVjdG9yV2lu ZG93LnBvc3RNZXNzYWdlKHRoaXMuX3BlbmRpbmdNZXNzYWdlc1tpXSwgIioiKTsKQEAgLTI2Miw5 ICsyODQsNyBAQCBTdGFuZGFsb25lVGVzdFJ1bm5lci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRo aXMuX3RyZWVFbGVtZW50LnRpdGxlID0gdGhpcy5fdGVzdFBhdGggKyAiOiBUSU1FT1VUIjsKICAg ICAgICAgdGhpcy5fdHJlZUVsZW1lbnQubGlzdEl0ZW1FbGVtZW50LmFkZFN0eWxlQ2xhc3MoInRp bWVvdXQiKTsKICAgICAgICAgdGhpcy5fZG9uZSA9IHRydWU7Ci0gICAgICAgIGlmICghd2luZG93 LmRlYnVnKSAKLSAgICAgICAgICAgIHRoaXMuY2xlYW51cCgpOwotCisgICAgICAgIHRoaXMuY2xl YW51cCgpOwogICAgICAgICB0aGlzLl9uZXh0KCJ0aW1lb3V0Iik7CiAgICAgfSwKIApAQCAtMzAy LDEwICszMjIsMjUgQEAgZnVuY3Rpb24gb25NZXNzYWdlRnJvbVRlc3RQYWdlKGV2ZW50KQogICAg ICAgICB3aW5kb3cucnVubmVyW21ldGhvZF0uYXBwbHkod2luZG93LnJ1bm5lciwgc2lnbmF0dXJl KTsKIH0KIAorZnVuY3Rpb24gb25sb2FkKCkKK3sKKyAgICB2YXIgcXVlcnlQYXJhbXNPYmplY3Qg PSB7fTsKKyAgICB2YXIgcXVlcnlQYXJhbXMgPSB3aW5kb3cubG9jYXRpb24uc2VhcmNoOworICAg IGlmICghcXVlcnlQYXJhbXMpCisgICAgICAgIHJldHVybjsKKyAgICB2YXIgcGFyYW1zID0gcXVl cnlQYXJhbXMuc3Vic3RyaW5nKDEpLnNwbGl0KCImIik7CisgICAgZm9yICh2YXIgaSA9IDA7IGkg PCBwYXJhbXMubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgdmFyIHBhaXIgPSBwYXJhbXNbaV0uc3Bs aXQoIj0iKTsKKyAgICAgICAgcXVlcnlQYXJhbXNPYmplY3RbcGFpclswXV0gPSBwYWlyWzFdOwor ICAgIH0KKyAgICBpZiAoImZpbHRlciIgaW4gcXVlcnlQYXJhbXNPYmplY3QpCisgICAgICAgIGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJmaWx0ZXIiKS52YWx1ZSA9IHF1ZXJ5UGFyYW1zT2JqZWN0 WyJmaWx0ZXIiXTsKK30KKwogd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoIm1lc3NhZ2UiLCBvbk1l c3NhZ2VGcm9tVGVzdFBhZ2UsIHRydWUpOwogCiA8L3NjcmlwdD4KLTxib2R5PgorPGJvZHkgb25s b2FkPSJvbmxvYWQoKSI+CiBUaGlzIGlzIGEgc3RhbmRhbG9uZSB0ZXN0IHN1aXRlIGZvciBpbnNw ZWN0b3IgZnJvbnQtZW5kLiBIZXJlIGlzIGhvdyB5b3UgcnVuIGl0OgogPHVsPgogPGxpPkNoZWNr IG91dCBXZWJLaXQgc291cmNlIHRyZWU6IGdpdCBjbG9uZSBodHRwOi8vZ2l0LmNocm9taXVtLm9y Zy9leHRlcm5hbC9XZWJraXQuZ2l0PC9saT4KQEAgLTMxNCw3ICszNDksNyBAQCBUaGlzIGlzIGEg c3RhbmRhbG9uZSB0ZXN0IHN1aXRlIGZvciBpbnNwZWN0b3IgZnJvbnQtZW5kLiBIZXJlIGlzIGhv dyB5b3UgcnVuIGl0OgogPC91bD4KIAogPGJ1dHRvbiBvbmNsaWNrPSJydW4oKSI+UnVuPC9idXR0 b24+Ci08YnV0dG9uIG9uY2xpY2s9InJ1bih0cnVlKSI+RGVidWc8L2J1dHRvbj4KKzxidXR0b24g aWQ9ImRlYnVnIiBvbmNsaWNrPSJydW4odHJ1ZSkiPkRlYnVnPC9idXR0b24+CiA8YnV0dG9uIG9u Y2xpY2s9ImludGVycnVwdCgpIj5JbnRlcnJ1cHQ8L2J1dHRvbj4KIEZpbHRlcjogPGlucHV0IGlk PSJmaWx0ZXIiIHR5cGU9InRleHQiIHNpemU9IjQwIj48L2lucHV0PjxzbWFsbD48aT5DbGljayBv biByZXN1bHRzIHRvIGxvYWQgZmlsdGVyPC9pPjwvc21hbGw+PGJyPgogCg==