94420 2012-08-18 17:49:46 -0700 Remove the static Strings used for outputting values of CSS_ATTR, CSS_COUNTER, CSS_RECT 2012-08-19 20:40:07 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo haraken macpherson menard webkit.review.bot oldest_to_newest 698976 0 benjamin 2012-08-18 17:49:46 -0700 Keeping literal constant as local static WTF::String is a bad idea. 698980 1 159278 benjamin 2012-08-18 18:00:00 -0700 Created attachment 159278 Patch 698986 2 159278 haraken 2012-08-18 21:55:18 -0700 Comment on attachment 159278 Patch Looks reasonable. 699177 3 159278 benjamin 2012-08-19 20:40:05 -0700 Comment on attachment 159278 Patch Clearing flags on attachment: 159278 Committed r125990: <http://trac.webkit.org/changeset/125990> 699178 4 benjamin 2012-08-19 20:40:07 -0700 All reviewed patches have been landed. Closing bug. 159278 2012-08-18 18:00:00 -0700 2012-08-19 20:40:04 -0700 Patch bug-94420-20120818175923.patch text/plain 4085 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRjMDMyOGUyYTI0NGZk OTI4ZWY1MWFhN2M0YzRlZDYwOGYwZTI0ZC4uMGU3YTcxMzczNDZhOTQ2NThhOGJhNjE2YzRmOTFm MjkwZGQ3YzdiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTE4ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZW1vdmUgdGhl IHN0YXRpYyBTdHJpbmdzIHVzZWQgZm9yIG91dHB1dHRpbmcgdmFsdWVzIG9mIENTU19BVFRSLCBD U1NfQ09VTlRFUiwgQ1NTX1JFQ1QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk0NDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIHRoZSBuZXcgU3RyaW5nQnVpbGRlcjo6YXBwZW5kTGl0ZXJhbCgpIGlu c3RlYWQgb2Yga2VlcGluZyBzb21lIFdURjo6U3RyaW5nIGluCisgICAgICAgIG1lbW9yeS4KKwor ICAgICAgICBUaGUgcGF0Y2ggcmVkdWNlcyBtZW1vcnkgdXNhZ2UuCisgICAgICAgIEl0IGFsc28g cmVkdWNlcyB0aGUgYmluYXJ5IHNpemUgKC0xNjcyIGJ5dGVzIG9uIHg4Nl82NCkuCisgICAgICAg IEkgZGlkIG5vdCBtZWFzdXJlIGFueSBkaWZmZXJlbmNlIGluIHBlcmZvcm1hbmNlLgorCisgICAg ICAgICogY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1By aW1pdGl2ZVZhbHVlOjpjdXN0b21Dc3NUZXh0KToKKwogMjAxMi0wOC0xOCAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ1NTVmFsdWVMaXN0OiBSZXNlcnZlIHRo ZSBleGFjdCBhbW91bnQgb2Ygc3BhY2UgbmVlZGVkIHdoZW4gY29uc3RydWN0aW5nIGZyb20gQ1NT IHBhcnNlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1 ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWUuY3BwCmluZGV4IGEx ZWZhODE2OWZhNDY2YjdlN2I4YWExZTY4MTdjZWY3ZDRkODUyNmUuLmJiZDY3MDBkMzc3Y2Q1Y2Q5 YzQyNDlkMjZkMzlmYWQ1YjgyNTU4MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NQcmltaXRpdmVWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlLmNwcApAQCAtOTM3LDEyICs5MzcsOSBAQCBTdHJpbmcgQ1NTUHJpbWl0aXZlVmFsdWU6 OmN1c3RvbUNzc1RleHQoKSBjb25zdAogICAgICAgICAgICAgdGV4dCA9IHZhbHVlT3JQcm9wZXJ0 eU5hbWUobV92YWx1ZS5pZGVudCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBD U1NfQVRUUjogewotICAgICAgICAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcs IGF0dHJQYXJlbiwgKCJhdHRyKCIpKTsKLQogICAgICAgICAgICAgU3RyaW5nQnVpbGRlciByZXN1 bHQ7CiAgICAgICAgICAgICByZXN1bHQucmVzZXJ2ZUNhcGFjaXR5KDYgKyBtX3ZhbHVlLnN0cmlu Zy0+bGVuZ3RoKCkpOwotCi0gICAgICAgICAgICByZXN1bHQuYXBwZW5kKGF0dHJQYXJlbik7Cisg ICAgICAgICAgICByZXN1bHQuYXBwZW5kTGl0ZXJhbCgiYXR0cigiKTsKICAgICAgICAgICAgIHJl c3VsdC5hcHBlbmQobV92YWx1ZS5zdHJpbmcpOwogICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgn KScpOwogCkBAIC05NTUsMjIgKzk1MiwyMSBAQCBTdHJpbmcgQ1NTUHJpbWl0aXZlVmFsdWU6OmN1 c3RvbUNzc1RleHQoKSBjb25zdAogICAgICAgICAgICAgdGV4dCArPSAiKSI7CiAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgY2FzZSBDU1NfQ09VTlRFUjogewotICAgICAgICAgICAgREVGSU5F X1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIGNvdW50ZXJQYXJlbiwgKCJjb3VudGVyKCIpKTsK LSAgICAgICAgICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBjb3VudGVyc1Bh cmVuLCAoImNvdW50ZXJzKCIpKTsKLSAgICAgICAgICAgIERFRklORV9TVEFUSUNfTE9DQUwoY29u c3QgU3RyaW5nLCBjb21tYVNwYWNlLCAoIiwgIikpOwotCiAgICAgICAgICAgICBTdHJpbmdCdWls ZGVyIHJlc3VsdDsKICAgICAgICAgICAgIFN0cmluZyBzZXBhcmF0b3IgPSBtX3ZhbHVlLmNvdW50 ZXItPnNlcGFyYXRvcigpOwotICAgICAgICAgICAgcmVzdWx0LmFwcGVuZChzZXBhcmF0b3IuaXNF bXB0eSgpID8gY291bnRlclBhcmVuIDogY291bnRlcnNQYXJlbik7CisgICAgICAgICAgICBpZiAo c2VwYXJhdG9yLmlzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kTGl0ZXJh bCgiY291bnRlcigiKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICByZXN1bHQu YXBwZW5kTGl0ZXJhbCgiY291bnRlcnMoIik7CiAKICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQo bV92YWx1ZS5jb3VudGVyLT5pZGVudGlmaWVyKCkpOwogICAgICAgICAgICAgaWYgKCFzZXBhcmF0 b3IuaXNFbXB0eSgpKSB7Ci0gICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZChjb21tYVNwYWNl KTsKKyAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kTGl0ZXJhbCgiLCAiKTsKICAgICAgICAg ICAgICAgICByZXN1bHQuYXBwZW5kKHF1b3RlQ1NTU3RyaW5nSWZOZWVkZWQoc2VwYXJhdG9yKSk7 CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBTdHJpbmcgbGlzdFN0eWxlID0gbV92YWx1ZS5j b3VudGVyLT5saXN0U3R5bGUoKTsKICAgICAgICAgICAgIGlmICghbGlzdFN0eWxlLmlzRW1wdHko KSkgewotICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoY29tbWFTcGFjZSk7CisgICAgICAg ICAgICAgICAgcmVzdWx0LmFwcGVuZExpdGVyYWwoIiwgIik7CiAgICAgICAgICAgICAgICAgcmVz dWx0LmFwcGVuZChsaXN0U3R5bGUpOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgcmVzdWx0 LmFwcGVuZCgnKScpOwpAQCAtOTc5LDI2ICs5NzUsOCBAQCBTdHJpbmcgQ1NTUHJpbWl0aXZlVmFs dWU6OmN1c3RvbUNzc1RleHQoKSBjb25zdAogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K ICAgICAgICAgY2FzZSBDU1NfUkVDVDogewotICAgICAgICAgICAgREVGSU5FX1NUQVRJQ19MT0NB TChjb25zdCBTdHJpbmcsIHJlY3RQYXJlbiwgKCJyZWN0KCIpKTsKLQogICAgICAgICAgICAgUmVj dCogcmVjdFZhbCA9IGdldFJlY3RWYWx1ZSgpOwotICAgICAgICAgICAgU3RyaW5nQnVpbGRlciBy ZXN1bHQ7Ci0gICAgICAgICAgICByZXN1bHQucmVzZXJ2ZUNhcGFjaXR5KDMyKTsKLSAgICAgICAg ICAgIHJlc3VsdC5hcHBlbmQocmVjdFBhcmVuKTsKLQotICAgICAgICAgICAgcmVzdWx0LmFwcGVu ZChyZWN0VmFsLT50b3AoKS0+Y3NzVGV4dCgpKTsKLSAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQo JyAnKTsKLQotICAgICAgICAgICAgcmVzdWx0LmFwcGVuZChyZWN0VmFsLT5yaWdodCgpLT5jc3NU ZXh0KCkpOwotICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICcpOwotCi0gICAgICAgICAgICBy ZXN1bHQuYXBwZW5kKHJlY3RWYWwtPmJvdHRvbSgpLT5jc3NUZXh0KCkpOwotICAgICAgICAgICAg cmVzdWx0LmFwcGVuZCgnICcpOwotCi0gICAgICAgICAgICByZXN1bHQuYXBwZW5kKHJlY3RWYWwt PmxlZnQoKS0+Y3NzVGV4dCgpKTsKLSAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJyknKTsKLQot ICAgICAgICAgICAgdGV4dCA9IHJlc3VsdC50b1N0cmluZygpOworICAgICAgICAgICAgdGV4dCA9 ICJyZWN0KCIgKyByZWN0VmFsLT50b3AoKS0+Y3NzVGV4dCgpICsgJyAnICsgcmVjdFZhbC0+cmln aHQoKS0+Y3NzVGV4dCgpICsgJyAnICsgcmVjdFZhbC0+Ym90dG9tKCktPmNzc1RleHQoKSArICcg JyArIHJlY3RWYWwtPmxlZnQoKS0+Y3NzVGV4dCgpICsgJyknOwogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIH0KICAgICAgICAgY2FzZSBDU1NfUVVBRDogewo=