94418 2012-08-18 15:08:27 -0700 Refactor SVGMaskElement to inherit from StyledElement 2012-08-18 17:57:57 -0700 1 1 1 Unclassified WebKit SVG 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr krit webkit.review.bot zimmermann oldest_to_newest 698951 0 pdr 2012-08-18 15:08:27 -0700 SVGMaskElement is a subclass of SVGStyledLocatableElement but it should be a subclass of SVGStyledElement. Spec: http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement 698952 1 159271 pdr 2012-08-18 15:12:56 -0700 Created attachment 159271 Refactor SVGMaskElement to inherit from StyledElement 698968 2 krit 2012-08-18 17:06:49 -0700 Don't spend to much Time in refactoring. The structure will change with SVG2 completely. 698977 3 159271 webkit.review.bot 2012-08-18 17:57:54 -0700 Comment on attachment 159271 Refactor SVGMaskElement to inherit from StyledElement Clearing flags on attachment: 159271 Committed r125971: <http://trac.webkit.org/changeset/125971> 698979 4 webkit.review.bot 2012-08-18 17:57:57 -0700 All reviewed patches have been landed. Closing bug. 159271 2012-08-18 15:12:56 -0700 2012-08-18 17:57:54 -0700 Refactor SVGMaskElement to inherit from StyledElement 94418.1.patch text/plain 2860 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTk2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTE4ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVmYWN0b3IgU1ZHTWFza0VsZW1l bnQgdG8gaW5oZXJpdCBmcm9tIFN0eWxlZEVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUHJldmlvdXNseSwgU1ZHTWFza0VsZW1lbnQgaW5oZXJp dGVkIGZyb20gU1ZHU3R5bGVkTG9jYXRhYmxlRWxlbWVudCB3aGljaCBpbmNsdWRlcworICAgICAg ICBzZXZlcmFsIHVubmVjZXNzYXJ5IGZ1bmN0aW9ucyAoZS5nLiwgZ2V0QkJveCgpKS4gVGhpcyBw YXRjaCByZWZhY3RvcnMgU1ZHTWFza0VsZW1lbnQKKyAgICAgICAgdG8gaW5oZXJpdCBmcm9tIFNW R1N0eWxlZEVsZW1lbnQgd2hpY2ggbWF0Y2hlcyB0aGUgc3BlYzoKKyAgICAgICAgaHR0cDovL3d3 dy53My5vcmcvVFIvU1ZHL3NpbmdsZS1wYWdlLmh0bWwjbWFza2luZy1JbnRlcmZhY2VTVkdNYXNr RWxlbWVudAorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGlzIGp1c3QgYSByZWZhY3Rv cmluZy4KKworICAgICAgICAqIHN2Zy9TVkdNYXNrRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlNWR01hc2tFbGVtZW50OjpTVkdNYXNrRWxlbWVudCk6 CisgICAgICAgICogc3ZnL1NWR01hc2tFbGVtZW50Lmg6CisKIDIwMTItMDgtMTggIEFuZHJlYXMg S2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIENTU1ZhbHVlTGlzdDogUmVzZXJ2 ZSB0aGUgZXhhY3QgYW1vdW50IG9mIHNwYWNlIG5lZWRlZCB3aGVuIGNvbnN0cnVjdGluZyBmcm9t IENTUyBwYXJzZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHTWFza0VsZW1lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdNYXNrRWxlbWVudC5jcHAJKHJl dmlzaW9uIDEyNTg3MikKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdNYXNrRWxlbWVudC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUzLDEyICs1MywxMiBAQCBCRUdJTl9SRUdJU1RFUl9BTklNQVRF RF9QUk9QRVJUSUVTKFNWR01hCiAgICAgUkVHSVNURVJfTE9DQUxfQU5JTUFURURfUFJPUEVSVFko d2lkdGgpCiAgICAgUkVHSVNURVJfTE9DQUxfQU5JTUFURURfUFJPUEVSVFkoaGVpZ2h0KQogICAg IFJFR0lTVEVSX0xPQ0FMX0FOSU1BVEVEX1BST1BFUlRZKGV4dGVybmFsUmVzb3VyY2VzUmVxdWly ZWQpCi0gICAgUkVHSVNURVJfUEFSRU5UX0FOSU1BVEVEX1BST1BFUlRJRVMoU1ZHU3R5bGVkTG9j YXRhYmxlRWxlbWVudCkKKyAgICBSRUdJU1RFUl9QQVJFTlRfQU5JTUFURURfUFJPUEVSVElFUyhT VkdTdHlsZWRFbGVtZW50KQogICAgIFJFR0lTVEVSX1BBUkVOVF9BTklNQVRFRF9QUk9QRVJUSUVT KFNWR1Rlc3RzKQogRU5EX1JFR0lTVEVSX0FOSU1BVEVEX1BST1BFUlRJRVMKIAogaW5saW5lIFNW R01hc2tFbGVtZW50OjpTVkdNYXNrRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1l LCBEb2N1bWVudCogZG9jdW1lbnQpCi0gICAgOiBTVkdTdHlsZWRMb2NhdGFibGVFbGVtZW50KHRh Z05hbWUsIGRvY3VtZW50KQorICAgIDogU1ZHU3R5bGVkRWxlbWVudCh0YWdOYW1lLCBkb2N1bWVu dCkKICAgICAsIG1fbWFza1VuaXRzKFNWR1VuaXRUeXBlczo6U1ZHX1VOSVRfVFlQRV9PQkpFQ1RC T1VORElOR0JPWCkKICAgICAsIG1fbWFza0NvbnRlbnRVbml0cyhTVkdVbml0VHlwZXM6OlNWR19V TklUX1RZUEVfVVNFUlNQQUNFT05VU0UpCiAgICAgLCBtX3goTGVuZ3RoTW9kZVdpZHRoLCAiLTEw JSIpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHTWFza0VsZW1lbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHTWFza0VsZW1lbnQuaAkocmV2aXNpb24gMTI1ODcy KQorKysgU291cmNlL1dlYkNvcmUvc3ZnL1NWR01hc2tFbGVtZW50LmgJKHdvcmtpbmcgY29weSkK QEAgLTI2LDEzICsyNiwxMyBAQAogI2luY2x1ZGUgIlNWR0FuaW1hdGVkTGVuZ3RoLmgiCiAjaW5j bHVkZSAiU1ZHRXh0ZXJuYWxSZXNvdXJjZXNSZXF1aXJlZC5oIgogI2luY2x1ZGUgIlNWR0xhbmdT cGFjZS5oIgotI2luY2x1ZGUgIlNWR1N0eWxlZExvY2F0YWJsZUVsZW1lbnQuaCIKKyNpbmNsdWRl ICJTVkdTdHlsZWRFbGVtZW50LmgiCiAjaW5jbHVkZSAiU1ZHVGVzdHMuaCIKICNpbmNsdWRlICJT VkdVbml0VHlwZXMuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1jbGFzcyBTVkdNYXNrRWxl bWVudCA6IHB1YmxpYyBTVkdTdHlsZWRMb2NhdGFibGVFbGVtZW50LAorY2xhc3MgU1ZHTWFza0Vs ZW1lbnQgOiBwdWJsaWMgU1ZHU3R5bGVkRWxlbWVudCwKICAgICAgICAgICAgICAgICAgICAgICAg cHVibGljIFNWR1Rlc3RzLAogICAgICAgICAgICAgICAgICAgICAgICBwdWJsaWMgU1ZHTGFuZ1Nw YWNlLAogICAgICAgICAgICAgICAgICAgICAgICBwdWJsaWMgU1ZHRXh0ZXJuYWxSZXNvdXJjZXNS ZXF1aXJlZCB7Cg==