94400 2012-08-17 17:17:00 -0700 [chromium] Random noise around text in FPS HUD 2023-03-09 12:22:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vangelis vangelis cc-bugs jamesr kbr waleedsattar5 webkit.review.bot oldest_to_newest 698818 0 vangelis 2012-08-17 17:17:00 -0700 This is the result of an missing clear operation in the canvas used to store the text atlas. 698834 1 159240 vangelis 2012-08-17 17:26:41 -0700 Created attachment 159240 Patch 698844 2 159240 jamesr 2012-08-17 17:38:12 -0700 Comment on attachment 159240 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159240&action=review > Source/WebCore/platform/graphics/chromium/CompositorHUDFontAtlas.cpp:68 > atlasContext.setFillColor(Color(0, 0, 0, 0), ColorSpaceDeviceRGB); > - atlasContext.fillRect(FloatRect(0, 0, ATLAS_SIZE, ATLAS_SIZE)); > + atlasContext.clearRect(FloatRect(0, 0, ATLAS_SIZE, ATLAS_SIZE)); how is clearRect() different from fillRect() with color(0, 0, 0, 0) ? do you still want to set the fill color when calling clearRect()? 698866 3 vangelis 2012-08-17 18:07:22 -0700 (In reply to comment #2) > (From update of attachment 159240 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159240&action=review > > > Source/WebCore/platform/graphics/chromium/CompositorHUDFontAtlas.cpp:68 > > atlasContext.setFillColor(Color(0, 0, 0, 0), ColorSpaceDeviceRGB); > > - atlasContext.fillRect(FloatRect(0, 0, ATLAS_SIZE, ATLAS_SIZE)); > > + atlasContext.clearRect(FloatRect(0, 0, ATLAS_SIZE, ATLAS_SIZE)); > > how is clearRect() different from fillRect() with color(0, 0, 0, 0) ? The default transfer mode for GC is "source-over" (essentially a blend with whatever was in the background) which means with fillRect we're drawing a transparent rect over whatever was already there, which has no effect. clearRect sets the transfer mode to clear which does the job. > > do you still want to set the fill color when calling clearRect()? It's used by the Skia code when setting the paint, so I assume that yes, it's needed. Presumably you could clear to any color. 698891 4 159240 webkit.review.bot 2012-08-17 19:07:14 -0700 Comment on attachment 159240 Patch Clearing flags on attachment: 159240 Committed r125961: <http://trac.webkit.org/changeset/125961> 698892 5 webkit.review.bot 2012-08-17 19:07:17 -0700 All reviewed patches have been landed. Closing bug. 159240 2012-08-17 17:26:41 -0700 2012-08-17 19:07:14 -0700 Patch bug-94400-20120817172604.patch text/plain 1554 vangelis SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTk1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTE3ICBWYW5nZWxp cyBLb2trZXZpcyAgPHZhbmdlbGlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1d IEZpeCByYW5kb20gbm9pc2UgYXJvdW5kIHRleHQgaW4gRlBTIEhVRC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NDAwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3YXMgdGhlIHJlc3VsdCBvZiBh biBpbmNvcnJlY3QgY2xlYXIgb3BlcmF0aW9uIG9uIHRoZSBjYW52YXMKKyAgICAgICAgdGhhdCBz dG9yZXMgdGhlIGZvbnQgYXRsYXMgdXNlZCBieSB0aGUgSFVELgorCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db21wb3NpdG9ySFVERm9udEF0bGFzLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNvbXBvc2l0b3JIVURGb250QXRsYXM6OmdlbmVyYXRlRm9udEF0bGFzKToK KwogMjAxMi0wOC0xNyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyNTk0MC4KSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NvbXBvc2l0b3JIVURGb250QXRs YXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0NvbXBvc2l0b3JIVURGb250QXRsYXMuY3BwCShyZXZpc2lvbiAxMjU3MzMpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Db21wb3NpdG9ySFVERm9u dEF0bGFzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjUsNyArNjUsNyBAQCBTa0JpdG1hcCBDb21w b3NpdG9ySFVERm9udEF0bGFzOjpnZW5lcmF0CiAKICAgICAvLyBDbGVhciB0aGUgZW50aXJlIHRl eHR1cmUgYXRsYXMgdG8gdHJhbnNwYXJlbnQgYmVmb3JlIGRyYXdpbmcgZm9udHMuCiAgICAgYXRs YXNDb250ZXh0LnNldEZpbGxDb2xvcihDb2xvcigwLCAwLCAwLCAwKSwgQ29sb3JTcGFjZURldmlj ZVJHQik7Ci0gICAgYXRsYXNDb250ZXh0LmZpbGxSZWN0KEZsb2F0UmVjdCgwLCAwLCBBVExBU19T SVpFLCBBVExBU19TSVpFKSk7CisgICAgYXRsYXNDb250ZXh0LmNsZWFyUmVjdChGbG9hdFJlY3Qo MCwgMCwgQVRMQVNfU0laRSwgQVRMQVNfU0laRSkpOwogCiAgICAgLy8gRklYTUU6IG1vbm9zcGFj ZSBmb250IGRvZXMgbm90IHdvcmsgYXMgZXhwZWN0ZWQuCiAgICAgRm9udERlc2NyaXB0aW9uIGZv bnREZXNjcmlwdGlvbjsK