94396 2012-08-17 16:57:23 -0700 nrwt: don't fail tests if ImageDiff fails on the wk2 ports 2012-08-20 16:04:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94540 1 dpranke dpranke abarth beidson ojan rniwa simon.fraser thorton webkit.review.bot oldest_to_newest 698793 0 dpranke 2012-08-17 16:57:23 -0700 nrwt: don't fail tests if ImageDiff fails on the wk2 ports 698796 1 159229 dpranke 2012-08-17 17:00:31 -0700 Created attachment 159229 Patch 698809 2 159229 beidson 2012-08-17 17:12:46 -0700 Comment on attachment 159229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159229&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:270 > + # https://bugs.webkit.org/show_bug.cgi?id=819262; ImageDiff doesn't Wrong bug id here. 698826 3 159238 dpranke 2012-08-17 17:21:18 -0700 Created attachment 159238 fix typoed bug # in comment 698833 4 dpranke 2012-08-17 17:26:02 -0700 Committed r125954: <http://trac.webkit.org/changeset/125954> 699716 5 simon.fraser 2012-08-20 11:20:35 -0700 But why are we running ImageDiff at all on the Mac ports, other than for ref tests? 699728 6 dpranke 2012-08-20 11:25:33 -0700 (In reply to comment #5) > But why are we running ImageDiff at all on the Mac ports, other than for ref tests? You're not; these are ref tests that are failing. 159229 2012-08-17 17:00:31 -0700 2012-08-17 17:21:18 -0700 Patch bug-94396-20120817170007.patch text/plain 2357 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2MxN2Q5ZWM0NmQzMTVjNGMxZjA3Nzg3ZWNiZDFmY2Vm YTMyYWU2MS4uMTE0MDRmYzcxNWQ0OWRhOTRlNDc2YjM3ZjkzMTZiZDBlMWY5NDI0YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA4LTE3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIG5yd3Q6IGRvbid0IGZhaWwgdGVzdHMgaWYgSW1hZ2VEaWZmIGZhaWxzIG9uIHRoZSB3 azIgcG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk0Mzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SXQgYXBwZWFycyB0aGF0IFdUUiBpcyBnZW5lcmF0aW5nIFBOR3MgdGhhdCBJbWFnZURpZmYgZG9l c24ndAorICAgICAgICBsaWtlLCBhbmQgc28gd2UncmUgZ2V0dGluZyBsb3RzIG9mICJjYW4gbm90 IGdldCBJbWFnZURpZmYiCisgICAgICAgIGVycm9ycyAoc2VlIGJ1ZyA4MTk2MikuIFRoZSBjaGFu Z2UgaW4gcjEyNDU4MSBtYWRlIHRoaXMgYSB0ZXN0CisgICAgICAgIGZhaWx1cmUsIGFuZCB0aGlz IGlzIGNhdXNpbmcgdGhlIFdLMiBib3RzIHRvIGZyZXF1ZW50bHkgYWJvcnQKKyAgICAgICAgd2l0 aCA1MDArIGZhaWx1cmVzLiAKKworICAgICAgICBUaGlzIGNoYW5nZSBtYWtlcyBJbWFnZURpZmYg ZXJyb3JzIG5vdCBiZSB0ZXN0IGZhaWx1cmVzIGp1c3QgZm9yCisgICAgICAgIFdLMiBmb3Igbm93 IHVudGlsIHdlIGNhbiBiZXR0ZXIgdHJpYWdlIHdoYXQncyBnb2luZyBvbi4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1 bm5lci5weToKKyAgICAgICAgKFNpbmdsZVRlc3RSdW5uZXIuX2NvbXBhcmVfaW1hZ2UpOgorCiAy MDEyLTA4LTE3ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRGVs ZXRlIHNvbWUgZGVhZCBjb2RlIGZyb20gdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3Npbmds ZV90ZXN0X3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2Nv bnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQppbmRleCBhNTVlZmQ0OGVmYmJmMmE2N2Zl ZmE2Y2U0Yzc0NTkzOTMzMTYzMjliLi5hOGEwM2ZlMWEyNDY5ZDlkNWU5MzhlNzczZTViNGQ1MzMy MzBlYjNkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9j b250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5CkBAIC0y NjYsNyArMjY2LDEwIEBAIGNsYXNzIFNpbmdsZVRlc3RSdW5uZXIob2JqZWN0KToKICAgICAgICAg ZWxpZiBkcml2ZXJfb3V0cHV0LmltYWdlX2hhc2ggIT0gZXhwZWN0ZWRfZHJpdmVyX291dHB1dC5p bWFnZV9oYXNoOgogICAgICAgICAgICAgZGlmZl9yZXN1bHQgPSBzZWxmLl9wb3J0LmRpZmZfaW1h Z2UoZHJpdmVyX291dHB1dC5pbWFnZSwgZXhwZWN0ZWRfZHJpdmVyX291dHB1dC5pbWFnZSkKICAg ICAgICAgICAgIGVycl9zdHIgPSBkaWZmX3Jlc3VsdFsyXQotICAgICAgICAgICAgaWYgZXJyX3N0 cjoKKyAgICAgICAgICAgICMgRklYTUU6IHNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTQyNzcgYW5kCisgICAgICAgICAgICAjIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04MTkyNjI7IEltYWdlRGlmZiBkb2Vzbid0CisgICAgICAgICAg ICAjIHNlZW0gdG8gYmUgd29ya2luZyB3aXRoIFdUUiBwcm9wZXJseSBhbmQgdG9ucyBvZiB0ZXN0 cyBhcmUgZmFpbGluZy4KKyAgICAgICAgICAgIGlmIGVycl9zdHIgYW5kIG5vdCBzZWxmLl9vcHRp b25zLndlYmtpdF90ZXN0X3J1bm5lcjoKICAgICAgICAgICAgICAgICBfbG9nLndhcm5pbmcoJyAg JXMgOiAlcycgJSAoc2VsZi5fdGVzdF9uYW1lLCBlcnJfc3RyKSkKICAgICAgICAgICAgICAgICBm YWlsdXJlcy5hcHBlbmQodGVzdF9mYWlsdXJlcy5GYWlsdXJlSW1hZ2VIYXNoTWlzbWF0Y2goKSkK ICAgICAgICAgICAgICAgICBkcml2ZXJfb3V0cHV0LmVycm9yID0gKGRyaXZlcl9vdXRwdXQuZXJy b3Igb3IgJycpICsgZXJyX3N0cgo= 159238 2012-08-17 17:21:18 -0700 2012-08-17 17:22:16 -0700 fix typoed bug # in comment patch text/plain 2196 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3YzE3 ZDllLi4xMTQwNGZjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTItMDgtMTcgIERpcmsgUHJhbmtlICA8ZHByYW5r ZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgbnJ3dDogZG9uJ3QgZmFpbCB0ZXN0cyBpZiBJbWFn ZURpZmYgZmFpbHMgb24gdGhlIHdrMiBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJdCBhcHBlYXJzIHRoYXQgV1RSIGlzIGdlbmVyYXRpbmcgUE5H cyB0aGF0IEltYWdlRGlmZiBkb2Vzbid0CisgICAgICAgIGxpa2UsIGFuZCBzbyB3ZSdyZSBnZXR0 aW5nIGxvdHMgb2YgImNhbiBub3QgZ2V0IEltYWdlRGlmZiIKKyAgICAgICAgZXJyb3JzIChzZWUg YnVnIDgxOTYyKS4gVGhlIGNoYW5nZSBpbiByMTI0NTgxIG1hZGUgdGhpcyBhIHRlc3QKKyAgICAg ICAgZmFpbHVyZSwgYW5kIHRoaXMgaXMgY2F1c2luZyB0aGUgV0syIGJvdHMgdG8gZnJlcXVlbnRs eSBhYm9ydAorICAgICAgICB3aXRoIDUwMCsgZmFpbHVyZXMuIAorCisgICAgICAgIFRoaXMgY2hh bmdlIG1ha2VzIEltYWdlRGlmZiBlcnJvcnMgbm90IGJlIHRlc3QgZmFpbHVyZXMganVzdCBmb3IK KyAgICAgICAgV0syIGZvciBub3cgdW50aWwgd2UgY2FuIGJldHRlciB0cmlhZ2Ugd2hhdCdzIGdv aW5nIG9uLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJv bGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5OgorICAgICAgICAoU2luZ2xlVGVzdFJ1bm5lci5f Y29tcGFyZV9pbWFnZSk6CisKIDIwMTItMDgtMTcgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBEZWxldGUgc29tZSBkZWFkIGNvZGUgZnJvbSB0aGUgZmxha2luZXNz IGRhc2hib2FyZApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5CmluZGV4 IGE1NWVmZDQuLmRlNjA0YjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3NpbmdsZV90ZXN0X3J1bm5lci5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5u ZXIucHkKQEAgLTI2Niw3ICsyNjYsMTAgQEAgY2xhc3MgU2luZ2xlVGVzdFJ1bm5lcihvYmplY3Qp OgogICAgICAgICBlbGlmIGRyaXZlcl9vdXRwdXQuaW1hZ2VfaGFzaCAhPSBleHBlY3RlZF9kcml2 ZXJfb3V0cHV0LmltYWdlX2hhc2g6CiAgICAgICAgICAgICBkaWZmX3Jlc3VsdCA9IHNlbGYuX3Bv cnQuZGlmZl9pbWFnZShkcml2ZXJfb3V0cHV0LmltYWdlLCBleHBlY3RlZF9kcml2ZXJfb3V0cHV0 LmltYWdlKQogICAgICAgICAgICAgZXJyX3N0ciA9IGRpZmZfcmVzdWx0WzJdCi0gICAgICAgICAg ICBpZiBlcnJfc3RyOgorICAgICAgICAgICAgIyBGSVhNRTogc2VlIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDI3NyBhbmQKKyAgICAgICAgICAgICMgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxOTYyOyBJbWFnZURpZmYgZG9lc24ndAor ICAgICAgICAgICAgIyBzZWVtIHRvIGJlIHdvcmtpbmcgd2l0aCBXVFIgcHJvcGVybHkgYW5kIHRv bnMgb2YgdGVzdHMgYXJlIGZhaWxpbmcuCisgICAgICAgICAgICBpZiBlcnJfc3RyIGFuZCBub3Qg c2VsZi5fb3B0aW9ucy53ZWJraXRfdGVzdF9ydW5uZXI6CiAgICAgICAgICAgICAgICAgX2xvZy53 YXJuaW5nKCcgICVzIDogJXMnICUgKHNlbGYuX3Rlc3RfbmFtZSwgZXJyX3N0cikpCiAgICAgICAg ICAgICAgICAgZmFpbHVyZXMuYXBwZW5kKHRlc3RfZmFpbHVyZXMuRmFpbHVyZUltYWdlSGFzaE1p c21hdGNoKCkpCiAgICAgICAgICAgICAgICAgZHJpdmVyX291dHB1dC5lcnJvciA9IChkcml2ZXJf b3V0cHV0LmVycm9yIG9yICcnKSArIGVycl9zdHIK