94390 2012-08-17 16:06:17 -0700 REGRESSION (r125912): Crashes in worker tests 2012-08-17 16:28:12 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94220 1 ap ap abarth beidson oldest_to_newest 698735 0 ap 2012-08-17 16:06:17 -0700 Not every global object is a window. 698740 1 159220 ap 2012-08-17 16:08:54 -0700 Created attachment 159220 proposed fix 698753 2 159220 sam 2012-08-17 16:15:44 -0700 Comment on attachment 159220 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=159220&action=review > Source/WebCore/bindings/js/JSDOMBinding.cpp:167 > + ScriptExecutionContext* scriptExecutionContext = globalObject->scriptExecutionContext(); > + scriptExecutionContext->reportException(ustringToString(errorMessage), lineNumber, ustringToString(exceptionSourceURL), 0); I think this can go on one line. 698767 3 ap 2012-08-17 16:28:12 -0700 Committed <http://trac.webkit.org/changeset/125946>. 159220 2012-08-17 16:08:54 -0700 2012-08-17 16:15:44 -0700 proposed fix ReportException.txt text/plain 2022 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNTk0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTE3ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMjU5 MTIpOiBDcmFzaGVzIGluIHdvcmtlciB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzOTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5jcHA6IChXZWJD b3JlOjpyZXBvcnRFeGNlcHRpb24pOiBJdCdzIGFsd2F5cyBmaW5lCisgICAgICAgIHRvIHJlcG9y dCBhbiBleGNlcHRpb24gb24gYSB3b3JrZXIgY29udGV4dCwgYnV0IGl0J3Mgbm90IGZpbmUgdG8g dHJlYXQgdGhvc2UgYXMgd2luZG93cy4KKwogMjAxMi0wOC0xNyAgSnVsaWVuIENoYWZmcmFpeCAg PGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBJbnRyb2R1Y2UgYSB3aWxsLWJlLXJl bW92ZWQtZnJvbS10cmVlIG5vdGlmaWNhdGlvbiBpbiBSZW5kZXJPYmplY3QKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcAkocmV2aXNpb24gMTI1OTQx KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTU4LDEwICsxNTgsMTMgQEAgdm9pZCByZXBvcnRFeGNlcHRpb24oRXhlY1N0 YXRlKiBleGVjLCBKUwogICAgIGlmIChFeGNlcHRpb25CYXNlKiBleGNlcHRpb25CYXNlID0gdG9F eGNlcHRpb25CYXNlKGV4Y2VwdGlvbikpCiAgICAgICAgIGVycm9yTWVzc2FnZSA9IHN0cmluZ1Rv VVN0cmluZyhleGNlcHRpb25CYXNlLT5tZXNzYWdlKCkgKyAiOiAiICArIGV4Y2VwdGlvbkJhc2Ut PmRlc2NyaXB0aW9uKCkpOwogCi0gICAgRE9NV2luZG93KiBhY3RpdmVXaW5kb3cgPSBhY3RpdmVE T01XaW5kb3coZXhlYyk7Ci0gICAgaWYgKCFhY3RpdmVXaW5kb3ctPmlzQ3VycmVudGx5RGlzcGxh eWVkSW5GcmFtZSgpKQotICAgICAgICByZXR1cm47Ci0gICAgYWN0aXZlV2luZG93LT5zY3JpcHRF eGVjdXRpb25Db250ZXh0KCktPnJlcG9ydEV4Y2VwdGlvbih1c3RyaW5nVG9TdHJpbmcoZXJyb3JN ZXNzYWdlKSwgbGluZU51bWJlciwgdXN0cmluZ1RvU3RyaW5nKGV4Y2VwdGlvblNvdXJjZVVSTCks IDApOworICAgIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QgPSBqc0Nhc3Q8SlNET01H bG9iYWxPYmplY3QqPihleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCkpOworICAgIGlmIChKU0RP TVdpbmRvdyogd2luZG93ID0ganNEeW5hbWljQ2FzdDxKU0RPTVdpbmRvdyo+KGdsb2JhbE9iamVj dCkpIHsKKyAgICAgICAgaWYgKCF3aW5kb3ctPmltcGwoKS0+aXNDdXJyZW50bHlEaXNwbGF5ZWRJ bkZyYW1lKCkpCisgICAgICAgICAgICByZXR1cm47CisgICAgfQorICAgIFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgPSBnbG9iYWxPYmplY3QtPnNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoKTsKKyAgICBzY3JpcHRFeGVjdXRpb25Db250ZXh0LT5yZXBvcnRFeGNl cHRpb24odXN0cmluZ1RvU3RyaW5nKGVycm9yTWVzc2FnZSksIGxpbmVOdW1iZXIsIHVzdHJpbmdU b1N0cmluZyhleGNlcHRpb25Tb3VyY2VVUkwpLCAwKTsKIH0KIAogdm9pZCByZXBvcnRDdXJyZW50 RXhjZXB0aW9uKEV4ZWNTdGF0ZSogZXhlYykK