94385 2012-08-17 14:49:39 -0700 AudioParam must support k-rate processing with audio-rate connections 2012-08-17 17:42:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson feature-media-reviews kbr webkit.review.bot oldest_to_newest 698685 0 crogers 2012-08-17 14:49:39 -0700 AudioParam must support k-rate processing with audio-rate connections 698693 1 159212 crogers 2012-08-17 14:57:14 -0700 Created attachment 159212 Patch 698773 2 159212 kbr 2012-08-17 16:32:28 -0700 Comment on attachment 159212 Patch The code structure looks fine, though I don't understand the terminology or the math behind it. r=me 698847 3 159212 webkit.review.bot 2012-08-17 17:42:41 -0700 Comment on attachment 159212 Patch Clearing flags on attachment: 159212 Committed r125957: <http://trac.webkit.org/changeset/125957> 698848 4 webkit.review.bot 2012-08-17 17:42:45 -0700 All reviewed patches have been landed. Closing bug. 159212 2012-08-17 14:57:14 -0700 2012-08-17 17:42:41 -0700 Patch bug-94385-20120817145637.patch text/plain 6308 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk0MDY1OTkxZWY0MWQ3 MDk5MWNlMzFlMjliNTFiNWI3ZjBlNzIwYi4uM2NiMjZhMmJkOTA2MjA1ODBhNDkzZmMxY2FhMGRi Yjc2NjFmZTcxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTE3ICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgQXVkaW9QYXJhbSBtdXN0 IHN1cHBvcnQgay1yYXRlIHByb2Nlc3Npbmcgd2l0aCBhdWRpby1yYXRlIGNvbm5lY3Rpb25zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDM4NQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZ1bGx5IGltcGxl bWVudCBBdWRpb1BhcmFtICpmaW5hbCogdmFsdWUgY2FsY3VsYXRpb24gYWNjb3JkaW5nIHRvIHNw ZWM6CisgICAgICAgIGh0dHBzOi8vZHZjcy53My5vcmcvaGcvYXVkaW8vcmF3LWZpbGUvdGlwL3dl YmF1ZGlvL3NwZWNpZmljYXRpb24uaHRtbCNBdWRpb1BhcmFtCisKKyAgICAgICAgSW4gcGFydGlj dWxhciwgdGhpcyBjb3ZlcnMgdGhlIGNhc2Ugd2hlcmUgdGhlIHBhcmFtZXRlciBpcyBrLXJhdGUs IGFuZCB3ZSBhbHNvCisgICAgICAgIGhhdmUgYXVkaW8tcmF0ZSBjb25uZWN0aW9ucyB0byB0aGUg QXVkaW9QYXJhbS4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBdWRpb1BhcmFtOjpmaW5hbFZhbHVlKToKKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9QYXJhbTo6Y2FsY3VsYXRlU2FtcGxlQWNj dXJhdGVWYWx1ZXMpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9QYXJhbTo6Y2FsY3VsYXRlRmlu YWxWYWx1ZXMpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5oOgorICAg ICAgICAoQXVkaW9QYXJhbSk6CisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9EZWxheURTUEtl cm5lbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEZWxheURTUEtlcm5lbDo6cHJvY2Vzcyk6CisK IDIwMTItMDgtMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBE ZWxldGUgRnJhbWU6OmRvbVdpbmRvdygpIGFuZCBGcmFtZTo6ZXhpc3RpbmdET01XaW5kb3coKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtLmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9QYXJhbS5jcHAKaW5kZXgg MTVjNjc0MzFkMTg4ODAyOWEwNWVhODA2ZWJmY2QzZWY4YzE1ZmU4ZS4uYzUyNWIyZTZjYjU1OGIz YjQyYThkNGI3NDBhYWQ1MzM5MWIwMTdjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9BdWRpb1BhcmFtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL0F1ZGlvUGFyYW0uY3BwCkBAIC05NCw2ICs5NCwxMyBAQCBib29sIEF1ZGlvUGFy YW06OnNtb290aCgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitmbG9hdCBBdWRpb1BhcmFtOjpm aW5hbFZhbHVlKCkKK3sKKyAgICBmbG9hdCB2YWx1ZTsKKyAgICBjYWxjdWxhdGVGaW5hbFZhbHVl cygmdmFsdWUsIDEsIGZhbHNlKTsKKyAgICByZXR1cm4gdmFsdWU7Cit9CisKIHZvaWQgQXVkaW9Q YXJhbTo6Y2FsY3VsYXRlU2FtcGxlQWNjdXJhdGVWYWx1ZXMoZmxvYXQqIHZhbHVlcywgdW5zaWdu ZWQgbnVtYmVyT2ZWYWx1ZXMpCiB7CiAgICAgYm9vbCBpc1NhZmUgPSBjb250ZXh0KCkgJiYgY29u dGV4dCgpLT5pc0F1ZGlvVGhyZWFkKCkgJiYgdmFsdWVzICYmIG51bWJlck9mVmFsdWVzOwpAQCAt MTAxLDMxICsxMDgsMzAgQEAgdm9pZCBBdWRpb1BhcmFtOjpjYWxjdWxhdGVTYW1wbGVBY2N1cmF0 ZVZhbHVlcyhmbG9hdCogdmFsdWVzLCB1bnNpZ25lZCBudW1iZXJPZlYKICAgICBpZiAoIWlzU2Fm ZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG51bWJlck9mUmVuZGVyaW5nQ29ubmVjdGlv bnMoKSkKLSAgICAgICAgY2FsY3VsYXRlQXVkaW9SYXRlU2lnbmFsVmFsdWVzKHZhbHVlcywgbnVt YmVyT2ZWYWx1ZXMpOwotICAgIGVsc2UKLSAgICAgICAgY2FsY3VsYXRlVGltZWxpbmVWYWx1ZXMo dmFsdWVzLCBudW1iZXJPZlZhbHVlcyk7CisgICAgY2FsY3VsYXRlRmluYWxWYWx1ZXModmFsdWVz LCBudW1iZXJPZlZhbHVlcywgdHJ1ZSk7CiB9CiAKLXZvaWQgQXVkaW9QYXJhbTo6Y2FsY3VsYXRl QXVkaW9SYXRlU2lnbmFsVmFsdWVzKGZsb2F0KiB2YWx1ZXMsIHVuc2lnbmVkIG51bWJlck9mVmFs dWVzKQordm9pZCBBdWRpb1BhcmFtOjpjYWxjdWxhdGVGaW5hbFZhbHVlcyhmbG9hdCogdmFsdWVz LCB1bnNpZ25lZCBudW1iZXJPZlZhbHVlcywgYm9vbCBzYW1wbGVBY2N1cmF0ZSkKIHsKLSAgICBi b29sIGlzR29vZCA9IG51bWJlck9mUmVuZGVyaW5nQ29ubmVjdGlvbnMoKSAmJiBudW1iZXJPZlZh bHVlczsKKyAgICBib29sIGlzR29vZCA9IGNvbnRleHQoKSAmJiBjb250ZXh0KCktPmlzQXVkaW9U aHJlYWQoKSAmJiB2YWx1ZXMgJiYgbnVtYmVyT2ZWYWx1ZXM7CiAgICAgQVNTRVJUKGlzR29vZCk7 CiAgICAgaWYgKCFpc0dvb2QpCiAgICAgICAgIHJldHVybjsKIAogICAgIC8vIFRoZSBjYWxjdWxh dGVkIHJlc3VsdCB3aWxsIGJlIHRoZSAiaW50cmluc2ljIiB2YWx1ZSBzdW1tZWQgd2l0aCBhbGwg YXVkaW8tcmF0ZSBjb25uZWN0aW9ucy4KIAotICAgIGlmIChtX3RpbWVsaW5lLmhhc1ZhbHVlcygp KSB7Ci0gICAgICAgIC8vIENhbGN1bGF0ZSByZWd1bGFyIHRpbWVsaW5lIHZhbHVlcywgaWYgd2Ug aGF2ZSBhbnkuCisgICAgaWYgKHNhbXBsZUFjY3VyYXRlKSB7CisgICAgICAgIC8vIENhbGN1bGF0 ZSBzYW1wbGUtYWNjdXJhdGUgKGEtcmF0ZSkgaW50cmluc2ljIHZhbHVlcy4KICAgICAgICAgY2Fs Y3VsYXRlVGltZWxpbmVWYWx1ZXModmFsdWVzLCBudW1iZXJPZlZhbHVlcyk7CiAgICAgfSBlbHNl IHsKLSAgICAgICAgLy8gT3RoZXJ3aXNlIHNldCB2YWx1ZXMgYXJyYXkgdG8gb3VyIGNvbnN0YW50 IHZhbHVlLgotICAgICAgICBmbG9hdCB2YWx1ZSA9IG1fdmFsdWU7IC8vIENhY2hlIGluIGxvY2Fs LgorICAgICAgICAvLyBDYWxjdWxhdGUgY29udHJvbC1yYXRlIChrLXJhdGUpIGludHJpbnNpYyB2 YWx1ZS4KKyAgICAgICAgYm9vbCBoYXNWYWx1ZTsKKyAgICAgICAgZmxvYXQgdGltZWxpbmVWYWx1 ZSA9IG1fdGltZWxpbmUudmFsdWVGb3JDb250ZXh0VGltZShjb250ZXh0KCksIG5hcnJvd1ByZWNp c2lvblRvRmxvYXQobV92YWx1ZSksIGhhc1ZhbHVlKTsKKworICAgICAgICBpZiAoaGFzVmFsdWUp CisgICAgICAgICAgICBtX3ZhbHVlID0gdGltZWxpbmVWYWx1ZTsKIAotICAgICAgICAvLyBGSVhN RTogY2FuIGJlIG9wdGltaXplZCBpZiB3ZSBjcmVhdGUgYSBuZXcgVmVjdG9yTWF0aCBmdW5jdGlv bi4KLSAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG51bWJlck9mVmFsdWVzOyArK2kp Ci0gICAgICAgICAgICB2YWx1ZXNbaV0gPSB2YWx1ZTsKKyAgICAgICAgdmFsdWVzWzBdID0gbmFy cm93UHJlY2lzaW9uVG9GbG9hdChtX3ZhbHVlKTsKICAgICB9CiAKICAgICAvLyBOb3cgc3VtIGFs bCBvZiB0aGUgYXVkaW8tcmF0ZSBjb25uZWN0aW9ucyB0b2dldGhlciAodW5pdHktZ2FpbiBzdW1t aW5nIGp1bmN0aW9uKS4KQEAgLTEzOCw3ICsxNDQsNyBAQCB2b2lkIEF1ZGlvUGFyYW06OmNhbGN1 bGF0ZUF1ZGlvUmF0ZVNpZ25hbFZhbHVlcyhmbG9hdCogdmFsdWVzLCB1bnNpZ25lZCBudW1iZXJP ZgogICAgICAgICBBU1NFUlQob3V0cHV0KTsKIAogICAgICAgICAvLyBSZW5kZXIgYXVkaW8gZnJv bSB0aGlzIG91dHB1dC4KLSAgICAgICAgQXVkaW9CdXMqIGNvbm5lY3Rpb25CdXMgPSBvdXRwdXQt PnB1bGwoMCwgbnVtYmVyT2ZWYWx1ZXMpOworICAgICAgICBBdWRpb0J1cyogY29ubmVjdGlvbkJ1 cyA9IG91dHB1dC0+cHVsbCgwLCBBdWRpb05vZGU6OlByb2Nlc3NpbmdTaXplSW5GcmFtZXMpOwog CiAgICAgICAgIC8vIFN1bSwgd2l0aCB1bml0eS1nYWluLgogICAgICAgICBzdW1taW5nQnVzLnN1 bUZyb20oKmNvbm5lY3Rpb25CdXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJhdWRpby9BdWRpb1BhcmFtLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvUGFyYW0uaAppbmRleCA5MGZkZTNiNTIwNTJhOWY1MzFhM2VjMzUxZWViZGExYTk5YzQ4 MDZhLi43MTYwYjgyOTcxMGE1MTgxYmVkMGRiNDg0MjI4YzE5NmJmYmIxYmM3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvUGFyYW0uaApAQCAtNTYsOSArNTYsMTQg QEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBjYW5VcGRhdGVTdGF0ZSgpIE9WRVJSSURFIHsg cmV0dXJuIHRydWU7IH0KICAgICB2aXJ0dWFsIHZvaWQgZGlkVXBkYXRlKCkgT1ZFUlJJREUgeyB9 CiAKKyAgICAvLyBJbnRyaW5zaWMgdmFsdWUuCiAgICAgZmxvYXQgdmFsdWUoKTsKICAgICB2b2lk IHNldFZhbHVlKGZsb2F0KTsKIAorICAgIC8vIEZpbmFsIHZhbHVlIGZvciBrLXJhdGUgcGFyYW1l dGVycywgb3RoZXJ3aXNlIHVzZSBjYWxjdWxhdGVTYW1wbGVBY2N1cmF0ZVZhbHVlcygpIGZvciBh LXJhdGUuCisgICAgLy8gTXVzdCBiZSBjYWxsZWQgaW4gdGhlIGF1ZGlvIHRocmVhZC4KKyAgICBm bG9hdCBmaW5hbFZhbHVlKCk7CisKICAgICBTdHJpbmcgbmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1f bmFtZTsgfQogCiAgICAgZmxvYXQgbWluVmFsdWUoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2Fz dDxmbG9hdD4obV9taW5WYWx1ZSk7IH0KQEAgLTExMiw3ICsxMTcsOCBAQCBwcm90ZWN0ZWQ6CiAg ICAgfQogCiBwcml2YXRlOgotICAgIHZvaWQgY2FsY3VsYXRlQXVkaW9SYXRlU2lnbmFsVmFsdWVz KGZsb2F0KiB2YWx1ZXMsIHVuc2lnbmVkIG51bWJlck9mVmFsdWVzKTsKKyAgICAvLyBzYW1wbGVB Y2N1cmF0ZSBjb3JyZXNwb25kcyB0byBhLXJhdGUgKGF1ZGlvIHJhdGUpIHZzLiBrLXJhdGUgaW4g dGhlIFdlYiBBdWRpbyBzcGVjaWZpY2F0aW9uLgorICAgIHZvaWQgY2FsY3VsYXRlRmluYWxWYWx1 ZXMoZmxvYXQqIHZhbHVlcywgdW5zaWduZWQgbnVtYmVyT2ZWYWx1ZXMsIGJvb2wgc2FtcGxlQWNj dXJhdGUpOwogICAgIHZvaWQgY2FsY3VsYXRlVGltZWxpbmVWYWx1ZXMoZmxvYXQqIHZhbHVlcywg dW5zaWduZWQgbnVtYmVyT2ZWYWx1ZXMpOwogCiAgICAgU3RyaW5nIG1fbmFtZTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vRGVsYXlEU1BLZXJuZWwuY3BwIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9EZWxheURTUEtlcm5lbC5jcHAKaW5kZXgg MWYzNWU1NWEyOTZiY2QyNGEwODQ5Nzc2ODI4YTExYjRjNDc2Zjk3ZS4uNzgzODI1NmE4YWUwZGU0 MjdlMGMwZTg1Njk3ZDA1Y2JlYjVkYjkyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9EZWxheURTUEtlcm5lbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9EZWxheURTUEtlcm5lbC5jcHAKQEAgLTk5LDcgKzk5LDcgQEAgdm9pZCBE ZWxheURTUEtlcm5lbDo6cHJvY2Vzcyhjb25zdCBmbG9hdCogc291cmNlLCBmbG9hdCogZGVzdGlu YXRpb24sIHNpemVfdCBmcmEKICAgICAgICAgcmV0dXJuOwogICAgICAgICAKICAgICBmbG9hdCBz YW1wbGVSYXRlID0gdGhpcy0+c2FtcGxlUmF0ZSgpOwotICAgIGRvdWJsZSBkZWxheVRpbWUgPSBk ZWxheVByb2Nlc3NvcigpID8gZGVsYXlQcm9jZXNzb3IoKS0+ZGVsYXlUaW1lKCktPnZhbHVlKCkg OiBtX2Rlc2lyZWREZWxheUZyYW1lcyAvIHNhbXBsZVJhdGU7CisgICAgZG91YmxlIGRlbGF5VGlt ZSA9IGRlbGF5UHJvY2Vzc29yKCkgPyBkZWxheVByb2Nlc3NvcigpLT5kZWxheVRpbWUoKS0+Zmlu YWxWYWx1ZSgpIDogbV9kZXNpcmVkRGVsYXlGcmFtZXMgLyBzYW1wbGVSYXRlOwogCiAgICAgLy8g TWFrZSBzdXJlIHRoZSBkZWxheSB0aW1lIGlzIGluIGEgdmFsaWQgcmFuZ2UuCiAgICAgZGVsYXlU aW1lID0gbWluKG1heERlbGF5VGltZSgpLCBkZWxheVRpbWUpOwo=