94382 2012-08-17 14:17:08 -0700 [chromium] Add a style check for #include "cc/..." in chromium files 2012-08-17 17:08:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dpranke enne eric levin ojan webkit.review.bot oldest_to_newest 698646 0 jamesr 2012-08-17 14:17:08 -0700 [chromium] Add a style check for #include "cc/..." in chromium files 698649 1 159202 jamesr 2012-08-17 14:18:23 -0700 Created attachment 159202 Patch 698650 2 jamesr 2012-08-17 14:19:04 -0700 This is to prevent regressing http://trac.webkit.org/changeset/125932. It'll probably only need to be in the repo for a few weeks. 698690 3 159202 jamesr 2012-08-17 14:53:08 -0700 Comment on attachment 159202 Patch Thanks! 698805 4 159202 webkit.review.bot 2012-08-17 17:08:37 -0700 Comment on attachment 159202 Patch Clearing flags on attachment: 159202 Committed r125952: <http://trac.webkit.org/changeset/125952> 698806 5 webkit.review.bot 2012-08-17 17:08:41 -0700 All reviewed patches have been landed. Closing bug. 159202 2012-08-17 14:18:23 -0700 2012-08-17 17:08:36 -0700 Patch bug-94382-20120817141750.patch text/plain 3005 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDFhODVkMmM2NDcwMGEyYWY3Yzc4MjI3ZDBlZWNhODlm OTYyYTQwOC4uM2IyNGY5YTUzYmU5ZDE1NzA1NDM5NzUyZGMxYmVhNWRiZWZlZTA0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA4LTE3ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgW2Nocm9taXVtXSBBZGQgYSBzdHlsZSBjaGVjayBmb3IgI2luY2x1ZGUgImNjLy4u LiIgaW4gY2hyb21pdW0gZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk0MzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkcyBhIHN0eWxlIGNoZWNrIHRvIG1ha2Ugc3VyZSBuZXcgY2hyb21pdW0g Y29kZSBmb2xsb3dzIHRoZSBjb3JyZWN0IGNvbnZlbnRpb24gZm9yIGluY2x1ZGluZyBjYyBmaWxl cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Ogor ICAgICAgICAoY2hlY2tfaW5jbHVkZV9saW5lKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKE9yZGVyT2ZJbmNsdWRl c1Rlc3QudGVzdF9jaGVja19jY19pbmNsdWRlcyk6CisKIDIwMTItMDgtMTcgIEpvY2hlbiBFaXNp bmdlciAgPGpvY2hlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBBZGQgY29u dGVudCBzaGVsbCBib3RzIHRvIHRoZSBmbGFraW5lc3MgZGFzaGJvYXJkCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CmluZGV4IDc4Y2Q4ODI1MDMwYjkxNjkz ODczMWVhN2Q1MDg0ZjJlM2E3MTZjZDIuLjQ1YzQ5YWFiNDM2YjE2Yzk0NDM1NDQ5MDhlNTIxNzZi MGMzZDBjOTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw LnB5CkBAIC0yNzQ3LDYgKzI3NDcsMTAgQEAgZGVmIGNoZWNrX2luY2x1ZGVfbGluZShmaWxlbmFt ZSwgZmlsZV9leHRlbnNpb24sIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgaW5jbHUKICAgICAg ICAgZXJyb3IobGluZV9udW1iZXIsICdidWlsZC9pbmNsdWRlJywgNCwKICAgICAgICAgICAgICAg J3d0ZiBpbmNsdWRlcyBzaG91bGQgYmUgPHd0Zi9maWxlLmg+IGluc3RlYWQgb2YgInd0Zi9maWxl LmgiLicpCiAKKyAgICBpZiBmaWxlbmFtZS5maW5kKCcvY2hyb21pdW0vJykgIT0gLTEgYW5kIGlu Y2x1ZGUuc3RhcnRzd2l0aCgnY2MvQ0MnKToKKyAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdi dWlsZC9pbmNsdWRlJywgNCwKKyAgICAgICAgICAgICAgJ2NjIGluY2x1ZGVzIHNob3VsZCBiZSAi Q0NGb28uaCIgaW5zdGVhZCBvZiAiY2MvQ0NGb28uaCIuJykKKwogICAgIGR1cGxpY2F0ZV9oZWFk ZXIgPSBpbmNsdWRlIGluIGluY2x1ZGVfc3RhdGUKICAgICBpZiBkdXBsaWNhdGVfaGVhZGVyOgog ICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ2J1aWxkL2luY2x1ZGUnLCA0LApkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpp bmRleCAzMzk4OTdmZTg1YzkwNzc0NTI4MTNkMDQ3MWY4ZDFmZjhiMTk2Yzk5Li5hNWE5NGI3OTNh OTNkOGI1YTI3MGFjMjcyZWFhOWQyMDk4YmM1MTM3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtMjczNiw2ICsy NzM2LDE1IEBAIGNsYXNzIE9yZGVyT2ZJbmNsdWRlc1Rlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd3dGYgaW5jbHVkZXMgc2hv dWxkIGJlIDx3dGYvZmlsZS5oPiBpbnN0ZWFkIG9mICJ3dGYvZmlsZS5oIi4nCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgIFtidWlsZC9pbmNsdWRlXSBbNF0nKQog CisgICAgZGVmIHRlc3RfY2hlY2tfY2NfaW5jbHVkZXMoc2VsZik6CisgICAgICAgIHNlbGYuYXNz ZXJ0X2xhbmd1YWdlX3J1bGVzX2NoZWNrKCdiYXIvY2hyb21pdW0vZm9vLmNwcCcsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiY29uZmlnLmgiXG4n CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcjaW5jbHVkZSAiZm9v LmgiXG4nCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdcbicKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyNpbmNsdWRlICJjYy9DQ1By b3h5LmgiXG4nLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnY2Mg aW5jbHVkZXMgc2hvdWxkIGJlICJDQ0Zvby5oIiBpbnN0ZWFkIG9mICJjYy9DQ0Zvby5oIi4nCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICcgIFtidWlsZC9pbmNsdWRl XSBbNF0nKQorCiAgICAgZGVmIHRlc3RfY2xhc3NpZnlfaW5jbHVkZShzZWxmKToKICAgICAgICAg Y2xhc3NpZnlfaW5jbHVkZSA9IGNwcF9zdHlsZS5fY2xhc3NpZnlfaW5jbHVkZQogICAgICAgICBp bmNsdWRlX3N0YXRlID0gY3BwX3N0eWxlLl9JbmNsdWRlU3RhdGUoKQo=