94381 2012-08-17 14:04:24 -0700 Add ability to create AtomicString using LChar* buffer and length 2012-08-17 17:43:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 698637 0 msaboff 2012-08-17 14:04:24 -0700 Add an AtomicString::add() method that takes an LChar* and length. This would allow many Atomic string creation sites to use a native 8 bit string instead of up converting to 16 bits before creating. 698647 1 159201 msaboff 2012-08-17 14:17:28 -0700 Created attachment 159201 Patch 698651 2 159201 ggaren 2012-08-17 14:19:25 -0700 Comment on attachment 159201 Patch r=me Would be nice to explain what this improves. 698652 3 msaboff 2012-08-17 14:23:46 -0700 (In reply to comment #2) > (From update of attachment 159201 [details]) > r=me > > Would be nice to explain what this improves. This will be used initially in the 8 bit CSS parser path, but other places as well. 698849 4 msaboff 2012-08-17 17:43:48 -0700 Committed r125958: <http://trac.webkit.org/changeset/125958> 159201 2012-08-17 14:17:28 -0700 2012-08-17 14:19:19 -0700 Patch 94381.patch text/plain 5032 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjU5MzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhYmlsaXR5IHRvIGNyZWF0ZSBBdG9taWNT dHJpbmcgdXNpbmcgTENoYXIqIGJ1ZmZlciBhbmQgbGVuZ3RoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDM4MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93cyB0aGUgdXNlIG9mIDggYml0IHN0cmlu ZyBkYXRhIGRpcmVjdGx5IHdpdGhvdXQgY29udmVydGluZyB0byAxNiBiaXRzIGZpcnN0LgorCisg ICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6TENoYXJC dWZmZXJUcmFuc2xhdG9yOjpoYXNoKToKKyAgICAgICAgKExDaGFyQnVmZmVyVHJhbnNsYXRvcik6 CisgICAgICAgIChXVEY6OkxDaGFyQnVmZmVyVHJhbnNsYXRvcjo6ZXF1YWwpOgorICAgICAgICAo V1RGOjpMQ2hhckJ1ZmZlclRyYW5zbGF0b3I6OnRyYW5zbGF0ZSk6CisgICAgICAgIChXVEY6OkF0 b21pY1N0cmluZzo6YWRkKToKKyAgICAgICAgKiB3dGYvdGV4dC9BdG9taWNTdHJpbmcuaDoKKyAg ICAgICAgKFdURjo6QXRvbWljU3RyaW5nOjpBdG9taWNTdHJpbmcpOgorICAgICAgICAoQXRvbWlj U3RyaW5nKToKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisgICAgICAgIChTdHJp bmdJbXBsKToKKwogMjAxMi0wOC0xNyAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAogICAgICAg ICBbQmxhY2tCZXJyeV0gVHVybiBvbiBhIGZldyBtYWNyb3MgZm9yIGpwZWcgZGVjb2RpbmcgYW5k IGltYWdlIGludGVycG9sYXRpb24KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3Ry aW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5j cHAJKHJldmlzaW9uIDEyNTkwNykKKysrIFNvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5n LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk4LDYgKzI5OCwyNiBAQCBQYXNzUmVmUHRyPFN0cmlu Z0ltcGw+IEF0b21pY1N0cmluZzo6YWRkCiAgICAgU3Vic3RyaW5nTG9jYXRpb24gYnVmZmVyID0g eyBiYXNlU3RyaW5nLCBzdGFydCwgbGVuZ3RoIH07CiAgICAgcmV0dXJuIGFkZFRvU3RyaW5nVGFi bGU8U3Vic3RyaW5nTG9jYXRpb24sIFN1YnN0cmluZ1RyYW5zbGF0b3I+KGJ1ZmZlcik7CiB9Cisg ICAgCit0eXBlZGVmIEhhc2hUcmFuc2xhdG9yQ2hhckJ1ZmZlcjxMQ2hhcj4gTENoYXJCdWZmZXI7 CitzdHJ1Y3QgTENoYXJCdWZmZXJUcmFuc2xhdG9yIHsKKyAgICBzdGF0aWMgdW5zaWduZWQgaGFz aChjb25zdCBMQ2hhckJ1ZmZlciYgYnVmKQorICAgIHsKKyAgICAgICAgcmV0dXJuIFN0cmluZ0hh c2hlcjo6Y29tcHV0ZUhhc2hBbmRNYXNrVG9wOEJpdHMoYnVmLnMsIGJ1Zi5sZW5ndGgpOworICAg IH0KKworICAgIHN0YXRpYyBib29sIGVxdWFsKFN0cmluZ0ltcGwqIGNvbnN0JiBzdHIsIGNvbnN0 IExDaGFyQnVmZmVyJiBidWYpCisgICAgeworICAgICAgICByZXR1cm4gV1RGOjplcXVhbChzdHIs IGJ1Zi5zLCBidWYubGVuZ3RoKTsKKyAgICB9CisKKyAgICBzdGF0aWMgdm9pZCB0cmFuc2xhdGUo U3RyaW5nSW1wbComIGxvY2F0aW9uLCBjb25zdCBMQ2hhckJ1ZmZlciYgYnVmLCB1bnNpZ25lZCBo YXNoKQorICAgIHsKKyAgICAgICAgbG9jYXRpb24gPSBTdHJpbmdJbXBsOjpjcmVhdGUoYnVmLnMs IGJ1Zi5sZW5ndGgpLmxlYWtSZWYoKTsKKyAgICAgICAgbG9jYXRpb24tPnNldEhhc2goaGFzaCk7 CisgICAgICAgIGxvY2F0aW9uLT5zZXRJc0F0b21pYyh0cnVlKTsKKyAgICB9Cit9OwogCiB0eXBl ZGVmIEhhc2hUcmFuc2xhdG9yQ2hhckJ1ZmZlcjxjaGFyPiBDaGFyQnVmZmVyOwogc3RydWN0IENo YXJCdWZmZXJGcm9tTGl0ZXJhbERhdGFUcmFuc2xhdG9yIHsKQEAgLTMxOSw2ICszMzksMTggQEAg c3RydWN0IENoYXJCdWZmZXJGcm9tTGl0ZXJhbERhdGFUcmFuc2xhdAogICAgIH0KIH07CiAKK1Bh c3NSZWZQdHI8U3RyaW5nSW1wbD4gQXRvbWljU3RyaW5nOjphZGQoY29uc3QgTENoYXIqIHMsIHVu c2lnbmVkIGxlbmd0aCkKK3sKKyAgICBpZiAoIXMpCisgICAgICAgIHJldHVybiAwOworCisgICAg aWYgKCFsZW5ndGgpCisgICAgICAgIHJldHVybiBTdHJpbmdJbXBsOjplbXB0eSgpOworCisgICAg TENoYXJCdWZmZXIgYnVmZmVyID0geyBzLCBsZW5ndGggfTsKKyAgICByZXR1cm4gYWRkVG9TdHJp bmdUYWJsZTxMQ2hhckJ1ZmZlciwgTENoYXJCdWZmZXJUcmFuc2xhdG9yPihidWZmZXIpOworfQor CiBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IEF0b21pY1N0cmluZzo6YWRkRnJvbUxpdGVyYWxEYXRh KGNvbnN0IGNoYXIqIGNoYXJhY3RlcnMsIHVuc2lnbmVkIGxlbmd0aCkKIHsKICAgICBBU1NFUlQo Y2hhcmFjdGVycyk7CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90ZXh0L0F0b21pY1N0cmluZy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgJKHJldmlzaW9u IDEyNTkwNykKKysrIFNvdXJjZS9XVEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQzLDYgKzQzLDcgQEAgcHVibGljOgogICAgIEF0b21pY1N0cmluZygpIHsgfQog ICAgIEF0b21pY1N0cmluZyhjb25zdCBMQ2hhciogcykgOiBtX3N0cmluZyhhZGQocykpIHsgfQog ICAgIEF0b21pY1N0cmluZyhjb25zdCBjaGFyKiBzKSA6IG1fc3RyaW5nKGFkZChzKSkgeyB9Cisg ICAgQXRvbWljU3RyaW5nKGNvbnN0IExDaGFyKiBzLCB1bnNpZ25lZCBsZW5ndGgpIDogbV9zdHJp bmcoYWRkKHMsIGxlbmd0aCkpIHsgfQogICAgIEF0b21pY1N0cmluZyhjb25zdCBVQ2hhciogcywg dW5zaWduZWQgbGVuZ3RoKSA6IG1fc3RyaW5nKGFkZChzLCBsZW5ndGgpKSB7IH0KICAgICBBdG9t aWNTdHJpbmcoY29uc3QgVUNoYXIqIHMsIHVuc2lnbmVkIGxlbmd0aCwgdW5zaWduZWQgZXhpc3Rp bmdIYXNoKSA6IG1fc3RyaW5nKGFkZChzLCBsZW5ndGgsIGV4aXN0aW5nSGFzaCkpIHsgfQogICAg IEF0b21pY1N0cmluZyhjb25zdCBVQ2hhciogcykgOiBtX3N0cmluZyhhZGQocykpIHsgfQpAQCAt MTU4LDYgKzE1OSw3IEBAIHByaXZhdGU6CiAgICAgCiAgICAgV1RGX0VYUE9SVF9TVFJJTkdfQVBJ IHN0YXRpYyBQYXNzUmVmUHRyPFN0cmluZ0ltcGw+IGFkZChjb25zdCBMQ2hhciopOwogICAgIEFM V0FZU19JTkxJTkUgc3RhdGljIFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4gYWRkKGNvbnN0IGNoYXIq IHMpIHsgcmV0dXJuIGFkZChyZWludGVycHJldF9jYXN0PGNvbnN0IExDaGFyKj4ocykpOyB9Owor ICAgIFdURl9FWFBPUlRfU1RSSU5HX0FQSSBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBh ZGQoY29uc3QgTENoYXIqLCB1bnNpZ25lZCBsZW5ndGgpOwogICAgIFdURl9FWFBPUlRfU1RSSU5H X0FQSSBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBhZGQoY29uc3QgVUNoYXIqLCB1bnNp Z25lZCBsZW5ndGgpOwogICAgIEFMV0FZU19JTkxJTkUgc3RhdGljIFBhc3NSZWZQdHI8U3RyaW5n SW1wbD4gYWRkKGNvbnN0IGNoYXIqIHMsIHVuc2lnbmVkIGxlbmd0aCkgeyByZXR1cm4gYWRkKHJl aW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KHMpLCBsZW5ndGgpOyB9OwogICAgIFdURl9FWFBP UlRfU1RSSU5HX0FQSSBzdGF0aWMgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBhZGQoY29uc3QgVUNo YXIqLCB1bnNpZ25lZCBsZW5ndGgsIHVuc2lnbmVkIGV4aXN0aW5nSGFzaCk7CkluZGV4OiBTb3Vy Y2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0 Zi90ZXh0L1N0cmluZ0ltcGwuaAkocmV2aXNpb24gMTI1OTA3KQorKysgU291cmNlL1dURi93dGYv dGV4dC9TdHJpbmdJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDcgQEAgbmFtZXNw YWNlIFdURiB7CiBzdHJ1Y3QgQ1N0cmluZ1RyYW5zbGF0b3I7CiB0ZW1wbGF0ZTx0eXBlbmFtZSBD aGFyYWN0ZXJUeXBlPiBzdHJ1Y3QgSGFzaEFuZENoYXJhY3RlcnNUcmFuc2xhdG9yOwogc3RydWN0 IEhhc2hBbmRVVEY4Q2hhcmFjdGVyc1RyYW5zbGF0b3I7CitzdHJ1Y3QgTENoYXJCdWZmZXJUcmFu c2xhdG9yOwogc3RydWN0IENoYXJCdWZmZXJGcm9tTGl0ZXJhbERhdGFUcmFuc2xhdG9yOwogc3Ry dWN0IFN1YnN0cmluZ1RyYW5zbGF0b3I7CiBzdHJ1Y3QgVUNoYXJCdWZmZXJUcmFuc2xhdG9yOwpA QCAtNzcsNiArNzgsNyBAQCBjbGFzcyBTdHJpbmdJbXBsIHsKICAgICB0ZW1wbGF0ZTx0eXBlbmFt ZSBDaGFyYWN0ZXJUeXBlPiBmcmllbmQgc3RydWN0IFdURjo6SGFzaEFuZENoYXJhY3RlcnNUcmFu c2xhdG9yOwogICAgIGZyaWVuZCBzdHJ1Y3QgV1RGOjpIYXNoQW5kVVRGOENoYXJhY3RlcnNUcmFu c2xhdG9yOwogICAgIGZyaWVuZCBzdHJ1Y3QgV1RGOjpDaGFyQnVmZmVyRnJvbUxpdGVyYWxEYXRh VHJhbnNsYXRvcjsKKyAgICBmcmllbmQgc3RydWN0IFdURjo6TENoYXJCdWZmZXJUcmFuc2xhdG9y OwogICAgIGZyaWVuZCBzdHJ1Y3QgV1RGOjpTdWJzdHJpbmdUcmFuc2xhdG9yOwogICAgIGZyaWVu ZCBzdHJ1Y3QgV1RGOjpVQ2hhckJ1ZmZlclRyYW5zbGF0b3I7CiAgICAgZnJpZW5kIGNsYXNzIEF0 b21pY1N0cmluZ0ltcGw7Cg==