94369 2012-08-17 11:24:52 -0700 [chromium] Add content shell bots to the flakiness dashboard 2012-08-17 12:57:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen ojan webkit.review.bot oldest_to_newest 698510 0 jochen 2012-08-17 11:24:52 -0700 [chromium] Add content shell bots to the flakiness dashboard 698512 1 159166 jochen 2012-08-17 11:26:16 -0700 Created attachment 159166 Patch 698514 2 jochen 2012-08-17 11:27:35 -0700 For reference, the builder is here: http://build.chromium.org/p/chromium.webkit/builders/Linux%20%28Content%20Shell%29 I'm going to add windoes and mac builders soon 698519 3 159166 ojan 2012-08-17 11:31:45 -0700 Comment on attachment 159166 Patch Just to be clear, you'll only be adding "Content Shell" builders that run the layout tests, right? Otherwise, we'll start showing bots that don't have content and the dashboard will show big red error messages. Not the end of the world. :) 698522 4 159166 ojan 2012-08-17 11:32:35 -0700 Comment on attachment 159166 Patch If you feel moved, there is a unittest for this in flakiness_dashboard_unittests.js that you could add a couple cases too. Not a big deal since you're not really changing logic. 698553 5 159175 jochen 2012-08-17 12:10:18 -0700 Created attachment 159175 Patch for landing 698555 6 jochen 2012-08-17 12:11:43 -0700 (In reply to comment #3) > (From update of attachment 159166 [details]) > Just to be clear, you'll only be adding "Content Shell" builders that run the layout tests, right? Otherwise, we'll start showing bots that don't have content and the dashboard will show big red error messages. Not the end of the world. :) Right, they will all run layout tests 698582 7 159175 webkit.review.bot 2012-08-17 12:57:35 -0700 Comment on attachment 159175 Patch for landing Clearing flags on attachment: 159175 Committed r125926: <http://trac.webkit.org/changeset/125926> 698583 8 webkit.review.bot 2012-08-17 12:57:38 -0700 All reviewed patches have been landed. Closing bug. 159166 2012-08-17 11:26:16 -0700 2012-08-17 12:10:15 -0700 Patch bug-94369-20120817202539.patch text/plain 1580 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDljN2IxZWJkODIwMzBjNzgyNTc4ZjQ5MDQ4NTI0NGRj NDYyZjUyMC4uY2QwNTY0ZThlNzQ2YzMzMjUxZjIyY2RmYTM0ZDBjNmNkNGExNjU5NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTE3ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGNvbnRlbnQgc2hlbGwgYm90cyB0byB0aGUgZmxha2lu ZXNzIGRhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTQzNjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgYm90cyBhcmUgbmFtZWQgJE9TIChDb250ZW50IFNoZWxsKS4KKworICAgICAgICAq IFRlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanM6CisgICAgICAg IChpc0Nocm9taXVtV2Via2l0VGlwT2ZUcmVlVGVzdFJ1bm5lcik6CisKIDIwMTItMDgtMTYgIEd1 c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAgW2poYnVpbGRd IEVGTCBub3cgcnVucyBqaGJ1aWxkIHVwZGF0ZSBmb3IgZXZlcnkgYnVpbGQKZGlmZiAtLWdpdCBh L1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMgYi9U b29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCmluZGV4 IGY2ZGJkZjU2NDEzZjE1MDE1MjE4ZGY1NDE3YTY4MmIzYTY0NGU5M2QuLjA5ZmJmZDFlMTZiMzhk Mjk3NTNiMTIwMmE3MGIzM2FlNzNhNzgwOGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRT ZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMKKysrIGIvVG9vbHMvVGVzdFJlc3Vs dFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qcwpAQCAtMTY3LDcgKzE2Nyw3IEBA IGZ1bmN0aW9uIGlzV2Via2l0VGVzdFJ1bm5lcihidWlsZGVyKQogCiBmdW5jdGlvbiBpc0Nocm9t aXVtV2Via2l0VGlwT2ZUcmVlVGVzdFJ1bm5lcihidWlsZGVyKQogewotICAgIHJldHVybiBidWls ZGVyLmluZGV4T2YoJ1dlYmtpdCcpICE9IC0xICYmIGJ1aWxkZXIuaW5kZXhPZignQnVpbGRlcicp ID09IC0xICYmIGJ1aWxkZXIuaW5kZXhPZignKGRlcHMpJykgPT0gLTEgJiYgYnVpbGRlci5pbmRl eE9mKCdBU0FOJykgPT0gLTE7CisgICAgcmV0dXJuIChidWlsZGVyLmluZGV4T2YoJ1dlYmtpdCcp ICE9IC0xICYmIGJ1aWxkZXIuaW5kZXhPZignQnVpbGRlcicpID09IC0xICYmIGJ1aWxkZXIuaW5k ZXhPZignKGRlcHMpJykgPT0gLTEgJiYgYnVpbGRlci5pbmRleE9mKCdBU0FOJykgPT0gLTEpIHx8 IGJ1aWxkZXIuaW5kZXhPZignKENvbnRlbnQgU2hlbGwpJykgIT0gLTE7CiB9CiAKIGZ1bmN0aW9u IGlzQ2hyb21pdW1XZWJraXREZXBzVGVzdFJ1bm5lcihidWlsZGVyKQo= 159175 2012-08-17 12:10:18 -0700 2012-08-17 12:57:35 -0700 Patch for landing bug-94369-20120817210942.patch text/plain 3442 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDljN2IxZWJkODIwMzBjNzgyNTc4ZjQ5MDQ4NTI0NGRj NDYyZjUyMC4uYjM1MTI2NDk0MmQ2ODZmMzMxN2UyMDM4YjU0ZWExODZjY2VlYzE3ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA4LTE3ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gQWRkIGNvbnRlbnQgc2hlbGwgYm90cyB0byB0aGUgZmxha2lu ZXNzIGRhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTQzNjkKKworICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgorCisgICAgICAg IFRoZSBib3RzIGFyZSBuYW1lZCAkT1MgKENvbnRlbnQgU2hlbGwpLgorCisgICAgICAgICogVGVz dFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9idWlsZGVycy5qczoKKyAgICAgICAgKGlz Q2hyb21pdW1XZWJraXRUaXBPZlRyZWVUZXN0UnVubmVyKToKKyAgICAgICAgKiBUZXN0UmVzdWx0 U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5pdHRlc3RzLmpz OgorCiAyMDEyLTA4LTE2ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgog CiAgICAgICAgIFtqaGJ1aWxkXSBFRkwgbm93IHJ1bnMgamhidWlsZCB1cGRhdGUgZm9yIGV2ZXJ5 IGJ1aWxkCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9h cmRzL2J1aWxkZXJzLmpzIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJk cy9idWlsZGVycy5qcwppbmRleCBmNmRiZGY1NjQxM2YxNTAxNTIxOGRmNTQxN2E2ODJiM2E2NDRl OTNkLi4wOWZiZmQxZTE2YjM4ZDI5NzUzYjEyMDJhNzBiMzNhZTczYTc4MDhmIDEwMDY0NAotLS0g YS9Ub29scy9UZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2J1aWxkZXJzLmpzCisr KyBiL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvYnVpbGRlcnMuanMK QEAgLTE2Nyw3ICsxNjcsNyBAQCBmdW5jdGlvbiBpc1dlYmtpdFRlc3RSdW5uZXIoYnVpbGRlcikK IAogZnVuY3Rpb24gaXNDaHJvbWl1bVdlYmtpdFRpcE9mVHJlZVRlc3RSdW5uZXIoYnVpbGRlcikK IHsKLSAgICByZXR1cm4gYnVpbGRlci5pbmRleE9mKCdXZWJraXQnKSAhPSAtMSAmJiBidWlsZGVy LmluZGV4T2YoJ0J1aWxkZXInKSA9PSAtMSAmJiBidWlsZGVyLmluZGV4T2YoJyhkZXBzKScpID09 IC0xICYmIGJ1aWxkZXIuaW5kZXhPZignQVNBTicpID09IC0xOworICAgIHJldHVybiAoYnVpbGRl ci5pbmRleE9mKCdXZWJraXQnKSAhPSAtMSAmJiBidWlsZGVyLmluZGV4T2YoJ0J1aWxkZXInKSA9 PSAtMSAmJiBidWlsZGVyLmluZGV4T2YoJyhkZXBzKScpID09IC0xICYmIGJ1aWxkZXIuaW5kZXhP ZignQVNBTicpID09IC0xKSB8fCBidWlsZGVyLmluZGV4T2YoJyhDb250ZW50IFNoZWxsKScpICE9 IC0xOwogfQogCiBmdW5jdGlvbiBpc0Nocm9taXVtV2Via2l0RGVwc1Rlc3RSdW5uZXIoYnVpbGRl cikKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMv Zmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanMgYi9Ub29scy9UZXN0UmVzdWx0U2VydmVy L3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmRfdW5pdHRlc3RzLmpzCmluZGV4 IGZlYzRjNGQyYzM5YzM0MjFjZmI4YWQyMzJhY2RiYzhlNjQzODgzNzIuLjMyZDJhZjIyNTEwNzYx ZTIwZWZkZTVhMWJhMWNmYTU0OTJkYTRiOTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRT ZXJ2ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZF91bml0dGVzdHMuanMK KysrIGIvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3Nf ZGFzaGJvYXJkX3VuaXR0ZXN0cy5qcwpAQCAtNTIzLDkgKzUyMywxMCBAQCB0ZXN0KCdnZW5lcmF0 ZUNocm9taXVtV2Via2l0VGlwT2ZUcmVlQnVpbGRlcnNGcm9tQnVpbGRlckxpc3QnLCAxLCBmdW5j dGlvbigpIHsKICAgICAgICAgIkxpbnV4IFZhbGdyaW5kIiwgIk1hYyBCdWlsZGVyIChkYmcpIiwg Ik1hYzEwLjYgUGVyZiIsICJNYWMxMC42IFRlc3RzIiwgIlZpc3RhIFBlcmYiLCAiVmlzdGEgVGVz dHMiLCAiV2Via2l0IExpbnV4IiwgIldlYmtpdCBMaW51eCBBU0FOIiwgICJXZWJraXQgTGludXgg KGRiZykiLCAiV2Via2l0IExpbnV4IChkZXBzKSIsICJXZWJraXQgTGludXggMzIiLAogICAgICAg ICAiV2Via2l0IE1hYyBCdWlsZGVyIiwgIldlYmtpdCBNYWMgQnVpbGRlciAoZGJnKSIsICJXZWJr aXQgTWFjIEJ1aWxkZXIgKGRlcHMpIiwgIldlYmtpdCBNYWMxMC42IiwgIldlYmtpdCBNYWMxMC42 IChkYmcpIiwKICAgICAgICAgIldlYmtpdCBNYWMxMC42IChkZXBzKSIsICJXZWJraXQgTWFjMTAu NyIsICJXZWJraXQgV2luIiwgIldlYmtpdCBXaW4gKGRiZykoMSkiLCAiV2Via2l0IFdpbiAoZGJn KSgyKSIsICJXZWJraXQgV2luIChkZXBzKSIsICJXZWJraXQgV2luIEJ1aWxkZXIiLCAiV2Via2l0 IFdpbiBCdWlsZGVyIChkYmcpIiwKLSAgICAgICAgIldlYmtpdCBXaW4gQnVpbGRlciAoZGVwcyki LCAiV2Via2l0IFdpbjciLCAiV2luIChkYmcpIiwgIldpbiBCdWlsZGVyIl07CisgICAgICAgICJX ZWJraXQgV2luIEJ1aWxkZXIgKGRlcHMpIiwgIldlYmtpdCBXaW43IiwgIldpbiAoZGJnKSIsICJX aW4gQnVpbGRlciIsCisgICAgICAgICJMaW51eCAoQ29udGVudCBTaGVsbCkiXTsKICAgICB2YXIg ZXhwZWN0ZWRCdWlsZGVycyA9IFtbIldlYmtpdCBMaW51eCIsIDJdLCBbIldlYmtpdCBMaW51eCAo ZGJnKSJdLCBbIldlYmtpdCBMaW51eCAzMiJdLCBbIldlYmtpdCBNYWMxMC42Il0sCi0gICAgICAg IFsiV2Via2l0IE1hYzEwLjYgKGRiZykiXSwgWyJXZWJraXQgTWFjMTAuNyJdLCBbIldlYmtpdCBX aW4iXSwgWyJXZWJraXQgV2luIChkYmcpKDEpIl0sIFsiV2Via2l0IFdpbiAoZGJnKSgyKSJdLCBb IldlYmtpdCBXaW43Il1dOworICAgICAgICBbIldlYmtpdCBNYWMxMC42IChkYmcpIl0sIFsiV2Vi a2l0IE1hYzEwLjciXSwgWyJXZWJraXQgV2luIl0sIFsiV2Via2l0IFdpbiAoZGJnKSgxKSJdLCBb IldlYmtpdCBXaW4gKGRiZykoMikiXSwgWyJXZWJraXQgV2luNyJdLCBbIkxpbnV4IChDb250ZW50 IFNoZWxsKSJdXTsKICAgICBkZWVwRXF1YWwoZ2VuZXJhdGVCdWlsZGVyc0Zyb21CdWlsZGVyTGlz dChidWlsZGVyTGlzdCwgaXNDaHJvbWl1bVdlYmtpdFRpcE9mVHJlZVRlc3RSdW5uZXIpLCBleHBl Y3RlZEJ1aWxkZXJzKTsKIH0pOwogCg==