94336 2012-08-17 05:08:57 -0700 Remove RefPtr from HTMLProgressElement::m_value 2012-08-19 18:31:42 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94324 1 haraken haraken morrita tkent webkit.review.bot oldest_to_newest 698220 0 haraken 2012-08-17 05:08:57 -0700 To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324. HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement node, which is guaranteed to exist in the subtree of the HTMLProgressElement node. 698222 1 159093 haraken 2012-08-17 05:10:36 -0700 Created attachment 159093 Patch 699121 2 159093 tkent 2012-08-19 17:50:30 -0700 Comment on attachment 159093 Patch ok 699141 3 159093 webkit.review.bot 2012-08-19 18:31:39 -0700 Comment on attachment 159093 Patch Clearing flags on attachment: 159093 Committed r125985: <http://trac.webkit.org/changeset/125985> 699142 4 webkit.review.bot 2012-08-19 18:31:42 -0700 All reviewed patches have been landed. Closing bug. 159093 2012-08-17 05:10:36 -0700 2012-08-19 18:31:39 -0700 Patch bug-94336-20120817211000.patch text/plain 3138 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1ODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDkyYWYxODdhM2ZiZjA1 NGRjMmU2NTdiODQwNjIxNmUwMmZhNDdkOS4uZDkxMGIxNzk4YmM4M2Q1ZGVjYjY0ZTc4NWJmODc4 NmQ2NzJmMjFlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgUmVmUHRy IGZyb20gSFRNTFByb2dyZXNzRWxlbWVudDo6bV92YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQzMzYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBhdm9pZCByZWZlcmVuY2UgY3ljbGVzIG9mIFJl ZlB0cjxOb2RlPnMsIHdlIHdhbnQgdG8gcmVtb3ZlCisgICAgICAgIHVubmVjZXNzYXJ5IFJlZlB0 cjxOb2RlPnMuIFRoZSByYXRpb25hbGUgaXMgZGVzY3JpYmVkIGluIGJ1ZyA5NDMyNC4KKworICAg ICAgICBIVE1MUHJvZ3Jlc3NFbGVtZW50OjptX3ZhbHVlIGRvZXMgbm90IG5lZWQgdG8gYmUgYSBS ZWZQdHI8Tm9kZT4sIGJlY2F1c2UKKyAgICAgICAgaXQgaXMgZ3VhcmFudGVlZCB0byBwb2ludCB0 byBhIHNoYWRvdyBET00gdHJlZSBvZiB0aGUgSFRNTFByb2dyZXNzRWxlbWVudAorICAgICAgICBu b2RlLCB3aGljaCBpcyBndWFyYW50ZWVkIHRvIGV4aXN0IGluIHRoZSBzdWJ0cmVlIG9mIHRoZSBI VE1MUHJvZ3Jlc3NFbGVtZW50IG5vZGUuCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBp biBiZWhhdmlvci4KKworICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MUHJvZ3Jlc3NFbGVtZW50OjpIVE1MUHJvZ3Jlc3NFbGVtZW50 KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQcm9ncmVzc0VsZW1lbnQ6OmNyZWF0ZVNoYWRvd1N1 YnRyZWUpOgorICAgICAgICAqIGh0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oOgorCiAyMDEyLTA4 LTE3ICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Zv cm1zXSBSZW5hbWUgU3BpbkJ1dHRvbkVsZW1lbnQ6OlN0ZXBBY3Rpb25IYW5kbGVyIHRvIFNwaW5C dXR0b25Pd25lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUHJvZ3Jlc3NF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5jcHAK aW5kZXggNDhiNWI4ODZlMWJiMjk0ODgzOTY1MzZmNTg4N2MxOWYwNWU1NDQ5OC4uMTg0MDJmYzQy MGZhNGRmMmVkODVlZmU3ODIyNTExYjM4ZGViZDdmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MUHJvZ3Jlc3NFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxQcm9ncmVzc0VsZW1lbnQuY3BwCkBAIC00Myw2ICs0Myw3IEBAIGNvbnN0IGRvdWJsZSBI VE1MUHJvZ3Jlc3NFbGVtZW50OjpJbnZhbGlkUG9zaXRpb24gPSAtMjsKIAogSFRNTFByb2dyZXNz RWxlbWVudDo6SFRNTFByb2dyZXNzRWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiB0YWdOYW1l LCBEb2N1bWVudCogZG9jdW1lbnQpCiAgICAgOiBMYWJlbGFibGVFbGVtZW50KHRhZ05hbWUsIGRv Y3VtZW50KQorICAgICwgbV92YWx1ZSgwKQogICAgICwgbV9oYXNBdXRob3JTaGFkb3dSb290KGZh bHNlKQogewogICAgIEFTU0VSVChoYXNUYWdOYW1lKHByb2dyZXNzVGFnKSk7CkBAIC0xNjQsNiAr MTY1LDcgQEAgdm9pZCBIVE1MUHJvZ3Jlc3NFbGVtZW50OjpkaWRFbGVtZW50U3RhdGVDaGFuZ2Uo KQogdm9pZCBIVE1MUHJvZ3Jlc3NFbGVtZW50OjpjcmVhdGVTaGFkb3dTdWJ0cmVlKCkKIHsKICAg ICBBU1NFUlQoIXVzZXJBZ2VudFNoYWRvd1Jvb3QoKSk7CisgICAgQVNTRVJUKCFtX3ZhbHVlKTsK ICAgICAgICAgICAgCiAgICAgUmVmUHRyPFNoYWRvd1Jvb3Q+IHJvb3QgPSBTaGFkb3dSb290Ojpj cmVhdGUodGhpcywgU2hhZG93Um9vdDo6VXNlckFnZW50U2hhZG93Um9vdCwgQVNTRVJUX05PX0VY Q0VQVElPTik7CiAKQEAgLTE3MSw3ICsxNzMsOCBAQCB2b2lkIEhUTUxQcm9ncmVzc0VsZW1lbnQ6 OmNyZWF0ZVNoYWRvd1N1YnRyZWUoKQogICAgIHJvb3QtPmFwcGVuZENoaWxkKGlubmVyKTsKIAog ICAgIFJlZlB0cjxQcm9ncmVzc0JhckVsZW1lbnQ+IGJhciA9IFByb2dyZXNzQmFyRWxlbWVudDo6 Y3JlYXRlKGRvY3VtZW50KCkpOwotICAgIG1fdmFsdWUgPSBQcm9ncmVzc1ZhbHVlRWxlbWVudDo6 Y3JlYXRlKGRvY3VtZW50KCkpOworICAgIFJlZlB0cjxQcm9ncmVzc1ZhbHVlRWxlbWVudD4gdmFs dWUgPSBQcm9ncmVzc1ZhbHVlRWxlbWVudDo6Y3JlYXRlKGRvY3VtZW50KCkpOworICAgIG1fdmFs dWUgPSB2YWx1ZS5nZXQoKTsKICAgICBiYXItPmFwcGVuZENoaWxkKG1fdmFsdWUsIEFTU0VSVF9O T19FWENFUFRJT04pOwogCiAgICAgaW5uZXItPmFwcGVuZENoaWxkKGJhciwgQVNTRVJUX05PX0VY Q0VQVElPTik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQcm9ncmVzc0Vs ZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCmluZGV4 IDY2NjBkOWQ4NWE5OWI2ZWJjZjc4MmQ5ZTc3YjA4OGM1NWJhYjRiNzUuLjQ2MjA0ZmFhMTYyMDNh YjVmYWIzZjgyNWEwN2VkZGZiODI4MmFjMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFByb2dyZXNzRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBy b2dyZXNzRWxlbWVudC5oCkBAIC03MSw3ICs3MSw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaWRF bGVtZW50U3RhdGVDaGFuZ2UoKTsKICAgICB2b2lkIGNyZWF0ZVNoYWRvd1N1YnRyZWUoKTsKIAot ICAgIFJlZlB0cjxQcm9ncmVzc1ZhbHVlRWxlbWVudD4gbV92YWx1ZTsKKyAgICBQcm9ncmVzc1Zh bHVlRWxlbWVudCogbV92YWx1ZTsKICAgICBib29sIG1faGFzQXV0aG9yU2hhZG93Um9vdDsKIH07 CiAK